RE: [PATCH v3] eventdev/timer: add API to get remaining ticks

["Carrillo, Erik G" <erik.g.carrillo@intel.com>]

Hi Jerin,

Thanks for the review.  One response in-line:

<...snipped...>

> > +static int
> > +swtim_get_remaining_ticks(const struct rte_event_timer_adapter
> *adapter,
> > +                         const struct rte_event_timer *evtim,
> > +                         uint64_t *ticks_remaining) {
> > +       uint64_t nsecs_per_adapter_tick, opaque, cycles_remaining;
> > +       enum rte_event_timer_state n_state;
> > +       double nsecs_per_cycle;
> > +       struct rte_timer *tim;
> > +       uint64_t cur_cycles;
> > +
> > +       /* Check that timer is armed */
> > +       n_state = __atomic_load_n(&evtim->state, __ATOMIC_ACQUIRE);
> > +       if (n_state != RTE_EVENT_TIMER_ARMED)
> > +               return -EINVAL;
> > +
> > +       opaque = evtim->impl_opaque[0];
> > +       tim = (struct rte_timer *)(uintptr_t)opaque;
> > +
> > +       cur_cycles = rte_get_timer_cycles();
> > +       if (cur_cycles > tim->expire) {
> > +               *ticks_remaining = 0;
> > +               return 0;
> > +       }
> > +
> > +       cycles_remaining = tim->expire - cur_cycles;
> > +       nsecs_per_cycle = (double)NSECPERSEC / rte_get_timer_hz();
> > +       nsecs_per_adapter_tick = adapter->data->conf.timer_tick_ns;
> > +
> > +       *ticks_remaining = (uint64_t)ceil((cycles_remaining *
> nsecs_per_cycle) /
> > +                                         nsecs_per_adapter_tick);
> 
> Can RTE_*CEIL* in eal/include/rte_common.h" API helps here? Also, it will
> remove the need for math.h, and it will be more optimized.
>
It looks like the RTE_*CEIL* macros are related to alignment, so they don't seem to apply here.

I'll make the suggested changes for the remainder of the comments in the next version of the patch. 
 
Thanks,
Erik

<...snipped...>