From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73021A00C5; Mon, 19 Dec 2022 22:16:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D7DA40685; Mon, 19 Dec 2022 22:16:26 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6E16440395 for ; Mon, 19 Dec 2022 22:16:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671484584; x=1703020584; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0q0JhF08jLPRNwDH/Vbs4ltCAgHF7Pl3gYFnA6NbZVE=; b=Jx1P3z8FHdbArKkulXI8H7YUIuYDSH6N51IlqbuglbORtkCMDPyRgq60 Gp/SRdETW7lsO1gOlP7TkH909NodnGrkCVWCgVUmRnoCIHkoaSpx5KOMI 2a3MfHIXKCIhSYrsLJyxzGQNzqUF9EC78ep5zlyYCsAgNUcehLXc8dk+D 8ZBokLQxgSSRVFBrr7F8INTN6LX6arACNOLAF/PE9ZKiy1BGSCOo+I3iF JdN906e6R7NZOsbSJLurNkLkwxnCqffPScuKETDuvo4YhPyRlMnYbQdBU h42UwojGj6dyh5Sc/1zqnIrBRlStbgfZBR31rFeIJs4tmcZDZWej+OuV1 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="302877876" X-IronPort-AV: E=Sophos;i="5.96,257,1665471600"; d="scan'208";a="302877876" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 13:16:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="793037054" X-IronPort-AV: E=Sophos;i="5.96,257,1665471600"; d="scan'208";a="793037054" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 19 Dec 2022 13:15:58 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 19 Dec 2022 13:15:58 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 19 Dec 2022 13:15:58 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 19 Dec 2022 13:15:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3ITuchdeP7o/xFArd0SCq1vpyqjF34kZS8B3w/J/Pi/8zoLpz09Voqnhh3dIXrSJGnuRXSzEFtih3WtDNya3xaApCxgU4RbniNlSDUyRMwJSWQ1rqXouoa1oDSHBbxT0CRWZwYX+sNhZqvjg0z0On0Zjw+hVeoSkfTkFOq5dprSIeKvrCWsBE2oFxSq+nkkVZZpiIgMhOWY9Mfd6y95GLJ7wSXBGuEUVep815TC3fUpPpIHGwfti5Ix9hTc8AnmJO6Zv+ZUo6vJ1wKOQJcsgBui0cpPOc2S3YI39dac37cM7fT9PHUHBIpDa0AI/fbZ9j4TNZKaz61xxiwH7vNiqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KpMXzngErpn6NN9krH67JrLHS26pOJS9SPy3PBiz1jE=; b=SLARTEAChLESUFCO5Jtf4L74pK7MMdm4F2v33CK2gEpNZYQWRdvUtaXD8IGI0vDj8F/P8VEGRBGT9BZx75eRb7lDo0XwbBxTtW0vgZhJMRhdSrglo871AjWrom1SIcAPeHeiifmaaWcPin85YhgqZfnIsJY1YbokTxClv2KcS7nBIkVFDMKwvIWzPsGcPBD1NJRSPAzug2iCWybCDVNP2S9qcKl476A4IlWvRf+4FOycQbGMJvTsE/Vu/XxB3TyBVbRDUCx60CC2fwxCYVylhPOjYv9+46b24uu8GWoB2D+gdYCvkqIxFOK+lL7gxHjHagQ0Yv7qE3BfoiHH1glb/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6418.namprd11.prod.outlook.com (2603:10b6:208:3aa::18) by CH0PR11MB8167.namprd11.prod.outlook.com (2603:10b6:610:192::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 21:15:56 +0000 Received: from IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::e4f7:a82d:dd09:a55d]) by IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::e4f7:a82d:dd09:a55d%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 21:15:56 +0000 From: "Carrillo, Erik G" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" CC: "hofors@lysator.liu.se" , "Naga Harish K, S V" , "Jayatheerthan, Jay" , Shijith Thotton , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v2] eventdev/timer: add API to get remaining ticks Thread-Topic: [EXT] [PATCH v2] eventdev/timer: add API to get remaining ticks Thread-Index: AQHZE+SBa3KMkyWzmUiNSJkso5HYp651p9AAgAAOEwA= Date: Mon, 19 Dec 2022 21:15:55 +0000 Message-ID: References: <20221219195900.2389529-1-erik.g.carrillo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6418:EE_|CH0PR11MB8167:EE_ x-ms-office365-filtering-correlation-id: b5277cff-7b5d-4bc3-bec3-08dae20637c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sdf//+Pc0Ibaxpmd0mQUYQnYV770iHLITSeOrAB/iW1RbSa758PcDJj5VRwcHU6ZMSA0BqbIyOiIrMMw15NfWad9pgJFhHvCYehXefElNmeUbhro4KN+YzZGehgYUCbPF39XsQe6O6+jiy/eHTEZjwu/MKekP4VT00gMPFgEWRs7NhOY/KsA6IFDc0/Tv0XWqNr4fCZ2HC1jebLeBa1HFe60uBKTHQdxqFzYitI1knBi+uMhtuaaRyZXtPipHtGA1/rbeWf25JPfIAmAOW5Fdm2Ih7nGQB6zWilkssP7rIruvYQ/SNECQ4hSIVED3k6bIDeCuddxjfDg/6YBPAPHxtzNL1uVdWKpz1+rRXKLGsQLs3N1AA8fDieyfZDsYvPsERQmvshSwfWp+ypc47uBH2mrAhaUMmvo01EZvPNNcjw0kmWt8deyvHTZ9kyFENjtwAwxEE5lpDZDawRf44a18qdwtWkuyl1Qu68xE6cMZnV3K1agGXb39Fk6rVPzMwVDB2aNVGmX/AOf97hqmYRGouiN6Jmh+YK91Nc1rV/7rpFPuOWKi0fO9uULZx7R4b2BV/RUWgtXsCSOZdVT4bZGjTqx1n0bDX29CGI1URRWkMGU+KL2y38YAyLdkfbjzZ+kGd/qB+zgE8F1DDM6Wbv2YpJ/nlmTzuAxCmQyu1u3F4IV8ag+RVTir9Vxb8ulT8CmZKmQejBQGtKqnvUnk+vw3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6418.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(366004)(376002)(39860400002)(346002)(451199015)(8936002)(33656002)(52536014)(83380400001)(186003)(55016003)(26005)(5660300002)(9686003)(2906002)(41300700001)(478600001)(110136005)(316002)(71200400001)(82960400001)(76116006)(64756008)(54906003)(38070700005)(8676002)(66946007)(4326008)(7696005)(66556008)(66476007)(66446008)(38100700002)(86362001)(122000001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UsJVccL3efyHhLtkg1UK67zpormSbJRc0kXWuIld3TUc1pKYqEX5nleAaAFR?= =?us-ascii?Q?aS7EJx0femaSuNoWVsi+eUQ+f3zIfkGiokOQzCTNtRPWrN8Sgn4X9fup97rn?= =?us-ascii?Q?MNhaRZfu37wE4bJc/Z9wDEImmwDGwpv0zm1QC3qf85bgfos01w/iL51GgE6Y?= =?us-ascii?Q?ULe6FCAnRixL59Mz6nxiXvGQl/Ons4S8EPsQ7np4fUx/R1/YvfgQ9RNdIB1U?= =?us-ascii?Q?wXungmcyMkZaPqWwYBE1GDreCSgi9XAw4JTB3Q3CJ8xHiUrj6XTnJDn8fLa+?= =?us-ascii?Q?o7A+bB/3FtRhY9Y8JlwnBR32Z/Q0LKUxugFDEDO9nzXrKiaHqIq+mnI3qTiN?= =?us-ascii?Q?SRE2IsHiBYh0hiaVygCa1DNQZL/fJTO2vTJNkbtbm+Lj/AqyNZ08TA5wsXVt?= =?us-ascii?Q?7Ln++dzJ+GuPaJ5pUJvJKkbxsWoQrd96eyebeeJs6sqF9VZ2Lw4vlgxluezJ?= =?us-ascii?Q?nwe1d8NZFDNeNItdudIoROkrDjkWRSGuBZxMAm6ScRA/Fw4AX7FjNmhDtIIs?= =?us-ascii?Q?QWOQ17nPodwHNfePe6yl5ZbDOPCx8WHAQ6EJCzWPmoNmyvb3z/hx6Q8CmQQJ?= =?us-ascii?Q?uxsRH2cm7M2AlDPtF8q1sAoUV+JSMSbQXmzePSPrYZXGzxNGbcYrtT3tqQtc?= =?us-ascii?Q?1Kcp4tNzi3aELhhi7k61NV/BuQIsmEnUuknyTGntdjUNKmeZB9b46YlLXn+b?= =?us-ascii?Q?1nIRaHPOgnPHTkG3h7xlC0DTL+GJmK0QsKz4bn/zNqB4QafWVV+yS2HXdc5B?= =?us-ascii?Q?bVKfYDuprd4idhbGUslDYSlv8voU4S3hX4cPsJvaQfnRmcfBz1XAKbyZOgAb?= =?us-ascii?Q?7rlcOfxHktUsLLxZgw9tn6X0Kge99SP5kyQJhVbgb5LSjff4kEVqYoOslFvp?= =?us-ascii?Q?nKwCLbdA6BMQU3WGLHNcM6RhbSMmxi/psu7tp8OUpT/Pz5frRZTLnF10CgTu?= =?us-ascii?Q?enFAo+U5A2NF6ad3NTR3igsVP6oI9w6C1xmY3zWutiY9rvdl4Wj5p7e8ZYWh?= =?us-ascii?Q?tkPxeoPtAnnU7UJdnplz00kjBtTrZAQ+pF5Y8vc7cbT0kwhKDVxUNgrfTMM6?= =?us-ascii?Q?6GV+acrPXciomBivIgOFYtABFK8rp7r2IKjZKOtj2+iObtievqOJK0lVZMQP?= =?us-ascii?Q?ydkHbYUCXWCTJFGvXT2KYcdPFr9uTcYUJ+md8UGNWMp4xWauTPN3Ehb2RcPO?= =?us-ascii?Q?3qlJiIh8/XWuueiPG/bB6TKaCMleuWgvJDjWmQMjjhGDyZtt+oHwZdMClWZl?= =?us-ascii?Q?84kdG0fFGTjCka+jE+78Cw9iUh0tvCdwVMhmqajolZUhwAe+tAghNym6l2WX?= =?us-ascii?Q?kPwX3DYGNtQkLXkhiFNs81z9ftK3UtHIscfvV61cQLV4aVuGUuFpoCqrOKO3?= =?us-ascii?Q?gd7YBAyfghFyJpcTiaDJqcwTJkzpbKgZ9BLdcIiNL4nQIMCtIVMEokt0QpBz?= =?us-ascii?Q?E+f5Sxm8cS+k+1ASM4loXlysKy+RWkBT6dhIkyKuvK1iajGS0H5F8u0HG69m?= =?us-ascii?Q?O2lJOfahVRhKhP8kYQ2nOR+m9bH2uo+wWSPE+4FQVMSgBnu9+6W0h4ITQ1CZ?= =?us-ascii?Q?OIU+ouOTEgNm53MZ04dcJ3IbV4kZPB03OVW6AtqXmr6hebQJvsyexgVgo3T9?= =?us-ascii?Q?AA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6418.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5277cff-7b5d-4bc3-bec3-08dae20637c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 21:15:55.9043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O2rrjMqKMMMOTfsVlsemwyb1cJoDFB8bJsRkW1bMPytGXJmCxa5BAFYnGcA2eL4l/zhisnVw+KrAVNDOdEyRqsOUSsIeCbRtUZ4TfbUi4/g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8167 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org <... snipped ...> > > diff --git a/app/test/test_event_timer_adapter.c > > b/app/test/test_event_timer_adapter.c > > index 1a440dfd10..1a1fb48b24 100644 > > --- a/app/test/test_event_timer_adapter.c > > +++ b/app/test/test_event_timer_adapter.c > > @@ -1920,6 +1920,72 @@ adapter_create_max(void) > > return TEST_SUCCESS; > > } > > > > +static inline int > > +test_timer_ticks_remaining(void) > > +{ > > + uint64_t ticks_remaining =3D UINT64_MAX; > > + struct rte_event_timer *ev_tim; > > + struct rte_event ev; > > + int ret, i; > > + const struct rte_event_timer tim =3D { > > + .ev.op =3D RTE_EVENT_OP_NEW, > > + .ev.queue_id =3D 0, > > + .ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC, > > + .ev.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL, > > + .ev.event_type =3D RTE_EVENT_TYPE_TIMER, > > + .state =3D RTE_EVENT_TIMER_NOT_ARMED, > > + }; > > + > > + rte_mempool_get(eventdev_test_mempool, (void **)&ev_tim); > > + *ev_tim =3D tim; > > + ev_tim->ev.event_ptr =3D ev_tim; > > +#define TEST_TICKS 5 > > + ev_tim->timeout_ticks =3D CALC_TICKS(TEST_TICKS); > > + > > + /* Test that unarmed timer returns error */ > > + TEST_ASSERT_FAIL(rte_event_timer_get_remaining_ticks(timdev, > > ev_tim, > > + &ticks_remaining), > > + "Didn't fail to get ticks for unarmed event timer"); >=20 > Please handle ENOSUP case. >=20 Good catch - updated in v3. Thanks, Erik <... snipped ...>