From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v4 3/4] timer: fix function to stop all timers
Date: Thu, 18 Aug 2022 13:12:52 +0000 [thread overview]
Message-ID: <IA1PR11MB64189068C7C02D401CB453F8B96D9@IA1PR11MB6418.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220812160748.287176-1-s.v.naga.harish.k@intel.com>
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Friday, August 12, 2022 11:08 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH v4 3/4] timer: fix function to stop all timers
>
> There is a possibility of deadlock in this API, as same spinlock is tried to be
> acquired in nested manner.
>
> If the lcore that is stopping the timer is different from the lcore that owns the
> timer, the timer list lock is acquired in timer_del(), even if local_is_locked is
> true. Because the same lock was already acquired in rte_timer_stop_all(),
> the thread will hang.
>
> This patch removes the acquisition of nested lock.
>
> Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a list")
> Cc: stable@dpdk.org
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
prev parent reply other threads:[~2022-08-18 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 16:26 [PATCH 3/4] timer: fix rte_timer_stop_all Naga Harish K S V
2022-08-03 17:49 ` Stephen Hemminger
2022-08-10 7:20 ` Naga Harish K, S V
2022-08-10 7:09 ` [PATCH v2 3/4] timer: fix function to stop all timers Naga Harish K S V
2022-08-10 19:29 ` Carrillo, Erik G
2022-08-10 19:38 ` Stephen Hemminger
2022-08-11 15:42 ` Naga Harish K, S V
2022-08-11 15:37 ` [PATCH v3 " Naga Harish K S V
2022-08-12 16:07 ` [PATCH v4 " Naga Harish K S V
2022-08-18 13:12 ` Carrillo, Erik G [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR11MB64189068C7C02D401CB453F8B96D9@IA1PR11MB6418.namprd11.prod.outlook.com \
--to=erik.g.carrillo@intel.com \
--cc=dev@dpdk.org \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).