From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BDA6A034C; Thu, 18 Aug 2022 15:13:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 991D940694; Thu, 18 Aug 2022 15:13:01 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 57E8C40156; Thu, 18 Aug 2022 15:13:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660828380; x=1692364380; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xnHNWgyHYWaOPpJd4gU8sO0+thMfENkvFlQ9eaId78g=; b=GPlO8g1Dfyp23P48xdDx8HxNuLnCqr2HC74xRM4I3nHAt2XOpZNYgWji d5MY7hNNU1SzpWq+Cgf9klIR601Bw8+w5ydD4WBtmOr01BlCUehzwZnPe 4nhOUV7c5sz0U2NAQ5qgirObCAFkJdGOn6umfIvleEE7R/O6V18gAYl7V vP1sDUND2lFBLkVDqPJF71O/9j8IU3IZl53H5CGWCn8/JxyV46Ry59CmF giRKpgrHxPpU5XAmpEE12up58EGnf4ZnG9GhL27SVcPuJPDVVANaaxE1r DEotiM12mNLCcg/B4IdXtsEJAxvfR+36vOhGljNj81bZMjhQp+mtnR8no A==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="290318450" X-IronPort-AV: E=Sophos;i="5.93,246,1654585200"; d="scan'208";a="290318450" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2022 06:12:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,246,1654585200"; d="scan'208";a="750107148" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 18 Aug 2022 06:12:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 18 Aug 2022 06:12:58 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 18 Aug 2022 06:12:56 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 18 Aug 2022 06:12:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 18 Aug 2022 06:12:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WE8tHS4OFaq1mCdLG3fg6sWUUrUC3QiC6OOu1JWDhEaibsLNtuX2Ku+wouG/QlUf2Lly51lFn9t7Zbo0COV1RhQZ3/BKO7cV5MmgxagZfOcD2zPmieZZKDUfISvdIu84jcYfSAaCr3vCyOp0OffqG5BjKbuSkHyZrMP4i2XN5g/lOsa++Amt8tECtBpxQRxY+QUqLZb3hftCjKumHbE4K45ygJqaE4E81oXg8Lfq5kQfLvUHrjeu9xCPWH30UwJrbGPUI1HhAjkceA/tYb5jwhE2Mb0mBUxQ5sZPmKUQ28b4llMNBw3+gOwXKiAAtGrf2HtPoPtt3zTp4o/BOpuD6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnHNWgyHYWaOPpJd4gU8sO0+thMfENkvFlQ9eaId78g=; b=RvOrSaUHIfUfnZ7vghv5bFOZ5Hb6vcd0Szp+LbgVd7G/AmX3y8D4ZNacBvQZNBjD+QSz1+WrUyrjRnDW1BXAGAH2t4TeOjsqv7Vp64I+D4vWB+sKfSq1OMi6t+9+n0wEbbiKbiOLFC1oxl966gUOoTlp8LJzjvw4BJbv7rb1WhRCJkNOX2b8T3EtLrX7HRdvjfVvlPJ/2S0iRvpHKSe6fymK7SAeF/8/G7is0u0QBYlOFT/Q+kNXYYdlZKArgDvVTZrkVTXkvxiBXPNur8iEs8YR1xGv+LaqRerZQnAvYYOnMAAWC42OVMqvalhlzCoEKTegUmfyWfYuc1JYda0XTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6418.namprd11.prod.outlook.com (2603:10b6:208:3aa::18) by BN6PR11MB1921.namprd11.prod.outlook.com (2603:10b6:404:104::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Thu, 18 Aug 2022 13:12:52 +0000 Received: from IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::186b:95ac:d246:161e]) by IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::186b:95ac:d246:161e%8]) with mapi id 15.20.5546.016; Thu, 18 Aug 2022 13:12:52 +0000 From: "Carrillo, Erik G" To: "Naga Harish K, S V" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v4 3/4] timer: fix function to stop all timers Thread-Topic: [PATCH v4 3/4] timer: fix function to stop all timers Thread-Index: AQHYrmWxthM9Of3DY0SfWD4Y7qoqna20q5Ag Date: Thu, 18 Aug 2022 13:12:52 +0000 Message-ID: References: <20220811153717.3992516-1-s.v.naga.harish.k@intel.com> <20220812160748.287176-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20220812160748.287176-1-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c212e4e-c5df-4eb2-585a-08da811b5b9b x-ms-traffictypediagnostic: BN6PR11MB1921:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c42OZWGai5xOszv6YUW/jRBe0yR76ejnYfr63vvNUsOt//bS2mJutsLPBUT9mslLmTfF6Ob6CEWkZcgDKN1xIdsKiFjHoVWaGcOiMVFppipzCxo+a+emAZovp8agCPkW5glV28lkmfZ1NoCInZ04F553tJ/+eXAbjpTnTPcNhfjD4ywhOcrpTonjapjvQ7aQEceygmOSGovLDA5KDUYyO0iqLDc03LgS6L5acOx9JuH3M4jWSRFEf75/u/TnZA6zEfuF4B6YA/OAacYiPc+qh+uB0oKoPIjjx6XPFC+Jq16BYUBivKg5n622uYafK7btZeC3Q+NISViKA9V4y1RH/LHAzAbqjIWfGmgQxPdXkOSiawzBYB3stjYafR8sZTy1n5S5cq8eIj7/G0zcZqAZ2YdbztvTnmD7qGaaPPaRZVKLwzNf1HGrQFxUFTFsC34xOPtEGfXcBG6zGzO9q+V7+I3FPP5GV2eUFrkV0uC+x1ad9XwQ81BAeLFP8109pnq6Kr8MnM6sbZxBYdau54noVeoe8wEeLSR4ghy1ap9zCfXrjCG05cMF2wk52X/fA1GLFeuBl4BhWrz2ixfTJ75eLzCDzPJJEfiym378ggHfrluEgjOBpcpuBmUAjRfmbnY8QCnEPnh1NV1P1VcDHc7hGesJg+QmC4XJThkTO+avmVg3WII3q25IkJjK1JYzxzfM0WcHwLo8+pUF+U9eS0/JJEhQDcKrfUxCYHTGCj/hQ2zAcucWIGcqIKfe7H9b78Y18iUB6oyD00zBExYD0VhCKQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6418.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(366004)(396003)(136003)(346002)(39860400002)(7696005)(6506007)(41300700001)(86362001)(186003)(38070700005)(33656002)(53546011)(83380400001)(71200400001)(9686003)(478600001)(26005)(2906002)(6636002)(66946007)(450100002)(55016003)(316002)(66476007)(76116006)(8676002)(54906003)(64756008)(4744005)(4326008)(66556008)(5660300002)(122000001)(82960400001)(8936002)(38100700002)(66446008)(6862004)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vu2MWH/azKeDnLiFnOlTFveuhehxffxL8/QvvG9FVTGe6WpiEWAJKZqq31vd?= =?us-ascii?Q?aDYse7PN1Zn/8olnefHTApI+r1qPGzH6bC+ohi1x55dLnKMr0hdJlxvttf3K?= =?us-ascii?Q?/9zT4bWD0DClfBnDAAAltoIbONk705++WhHH++JDxrrzs3cZxWEwSyO8fcP+?= =?us-ascii?Q?uKsuRddGNMdKpZ/BTv5TsGcp2OHvQw8DQplPa6riXrmG458s1sP2geOEW0MF?= =?us-ascii?Q?Z8vX5XMYAbcCeFZUXX1VgtKDPQMih+ceOa3x8yfYb8of8bjbIXJvpfMVo6s4?= =?us-ascii?Q?bMt6c7DXowwcVx3CQ7F+9rvgUcIzB/1O5qF4AviJg3gnpA1tzT5Scrmq/mY6?= =?us-ascii?Q?kCAMS1rgXBum+XJgjmcRym55qgkF71vQ5UR//5BpQOhDNewrfSUaEc3r5ebp?= =?us-ascii?Q?P5v/Kv9dHQ0f/cTJ+eDI8EdJH1ENGyAkwLvhps4LnKxDOl7sO2H1Fd0XcCgF?= =?us-ascii?Q?Lj4MC2gG+C+syX8IfyAzn5hrdH8HjbaH35+PG3dMlHMvkyW50og27JSuwElR?= =?us-ascii?Q?kbprxYa5uz/+neerW3AF8JRD4eh0BgPaVDqn+EF587N/aoggkR7u5If0gA/a?= =?us-ascii?Q?8S0V70XSZoJm78iqef0WmLvsU+8x9ECMT+KkkQ4cHhZdOuA60E4T+e2+DxIR?= =?us-ascii?Q?Tob0evn+/d+tE3U+mX8WTN7kALZfJ8aN/YI9sc0xxfE/32pbGa26UbwOyNxk?= =?us-ascii?Q?mWYTRIAy40myvLzMVkFCmzzmWnOiV3Z1SdZXLttzqnJC/OHNB+gj/qOTEJIi?= =?us-ascii?Q?ZRx04ZX5+XIaZcsDPt9LfhbXougPKp75xXg1ckj4ixqiPTccrch23p8Ujta6?= =?us-ascii?Q?hG5MFmXh4RV7LxlyqpZewLAJIKWhbZQx2Z5JU1romBE5gwl7pZJKEZgPtYjZ?= =?us-ascii?Q?ZpHV+3L+IYmK8IipZ9pc7Un6bukoEGlam7tPEoAkcSDn+4/9jrXsE5+0srbI?= =?us-ascii?Q?ugSYj1C5sl99mLk5e5YMFCTkuwwq4ahb/2aGOLpTpf42Tw83qUR5fMtp0KFJ?= =?us-ascii?Q?sfPT+AUoa5h4uloEDGAVKUdzlg9Sh+iEC7I+vwG5zfEGEPE8iQbp924M+8sD?= =?us-ascii?Q?uHpC3/TdExDWUdOndsD4iWtHmDpTUr3gFXO3gf2xMqdtz2A1eSpUHBQGiVGB?= =?us-ascii?Q?1msjUs7HC/qOC4xbRUVfBMnpcAFOPOYRBQoR7j6rYgdVFFfpLhuk4Xb3msaR?= =?us-ascii?Q?RT8RuZKCHvcAosx3gNALXntO0oljANp1nv2s2kyWVPLPaECwYVKcmOVOIMwK?= =?us-ascii?Q?uePODAQ7a2zeWL4ZV6XpSo654XYZQKYUQ23XoUUf4MEFZ68ZAKFQ+xFX17tZ?= =?us-ascii?Q?I4cGganY3HzSWjOF/uNXFIHTMM2MWK6Lg0JOA4Pv7pkwORgqj6w5uA3JJhXo?= =?us-ascii?Q?Lut9/RUOZ6TneJioUJIs6Z38BhAi9iBjfD2xior73sePrNhExn/cqIhqHnvi?= =?us-ascii?Q?rcZvNUgAwjT1cUCwmkpzzXqCbvLYwaD8pdM1CjPwGTH2Czc9daw0uUwgFZ/d?= =?us-ascii?Q?wq+pjJbZdh4kmeHFwPA7b1eHXtWPN7giJk5HUnXO0cY9UQyh2ktRwNHypPAp?= =?us-ascii?Q?e1fKcDRJXuLadDph54KzQXGQXEZajpMrOFoO3wZ8MSPkABKysenDO6KbHQ97?= =?us-ascii?Q?rg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6418.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c212e4e-c5df-4eb2-585a-08da811b5b9b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 13:12:52.7041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZFbzlFQt+QD9bSmADL9r0uflyuqgq/gbFtABk7O1tuCHdd2oSPOcvajMkgaY7mndAyc7ELtAmOkh6qi9VtwEz9VKmz7Hsm0Hw6+dnlJsbBY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1921 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:08 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH v4 3/4] timer: fix function to stop all timers >=20 > There is a possibility of deadlock in this API, as same spinlock is tried= to be > acquired in nested manner. >=20 > If the lcore that is stopping the timer is different from the lcore that = owns the > timer, the timer list lock is acquired in timer_del(), even if local_is_l= ocked is > true. Because the same lock was already acquired in rte_timer_stop_all(), > the thread will hang. >=20 > This patch removes the acquisition of nested lock. >=20 > Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a list= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Naga Harish K S V Acked-by: Erik Gabriel Carrillo