From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C104A0548; Thu, 11 Aug 2022 21:22:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 456F8410FC; Thu, 11 Aug 2022 21:22:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id F35C340697 for ; Thu, 11 Aug 2022 21:22:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660245749; x=1691781749; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2cEIbJ5w4g01yYkHbPg6i0xNjiUBDTTqwd/Pc7AwNDU=; b=GZdfb2xwCCDJ6YBvK4NCCeryRMddw9dp+naAT2LDCGSjt+guNhV4mYVL bc1O6DY5Vj115FbP/CZTZsbJ0dqe9A3pqNxfcRQUvdmxzO80YWOjZPI8w ujIsE8M+lQZDSUxA0Fid3U9bCem2R4lFbqwFBBt48D3LsmBAIo1UmOakK k67SZOWMoAnKwGhEBAZ60rV07yazOhhVe2PmzYYL5YKnOde62M+v6ptqb unvXJXEg6BeTkv1qi2H4Kqh+s40RoLvEiFkaoGc++wQagu/VTq2DhM6OW 67B+Ir9VNJMYshRX2Gq0DLk4lm+cvKcHwL5/myhc9pzJCK5onkkQbKY+9 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10436"; a="278391615" X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="278391615" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 12:22:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="747938250" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 11 Aug 2022 12:22:27 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 12:22:27 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 12:22:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 12:22:26 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 12:22:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JiGtKEzB1oWCJ2zLPKNFk2m3bzsnB4ZeRRWIs6jWCHYV2Lmo4RbLxogqdX/sp5LtqVpUzdM5IHBTW4S/z+WIAnysuw3GsOb4bsI3YBde72ZSpsXr2JDugDScBcvFysSUqt435YpKH1i6XR1UEhClgBdluH4i5agiLYcR99bIKkTxJ7A5TksasEwROYI1HoURaOh5kPDxjswUBq4j+Z1+03dsSR4/I7ayMC/8SyNJLneiZ/nvPlO2EYxqV+e3GUSbwT2EOFwS+efOeP2k28p7rbMY8NSx/gR+XDOcCtKH8G2vGVgrS9biFrriNgdROn1K4jl+cpyLu1NqQ/QG6CnYsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c0uGPlD024lttw+NKWjlC1C0i4uDZHkH9oZfKB6wj1A=; b=oTZoy356W4cc//xNG8Z1tufDUuD/Vc/c3NNHxvgWi2uCrIQsmTbk1CzAY6usdYITlrp9Ig4ivsfv6j3Dot4xefZV1LpM5Z3mfjmn+l1fjTxjeDEaZMCUzDv7Jhi1dXOJwFOjfx+GpqJxGkyOaBwjM4dJb4nLXSKFmla0Rtr1aLC8Gnh279hHcQW9ZcccsQMAiyNFhzfTrgCmszcqWRp5TAqD7RIRvrBbZdUSOf0FWpm4H3n5hqohCdEKCsZek5pkVMfsC1B2nzWY2tGwKLCOutOFr5EcOEpjwBiEUJfwUXl7Zr4a623kgSt3BkqvMC8pCpl8pVV4NfcJ5R/26H05CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6418.namprd11.prod.outlook.com (2603:10b6:208:3aa::18) by CH2PR11MB4200.namprd11.prod.outlook.com (2603:10b6:610:3d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 11 Aug 2022 19:22:24 +0000 Received: from IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::186b:95ac:d246:161e]) by IA1PR11MB6418.namprd11.prod.outlook.com ([fe80::186b:95ac:d246:161e%7]) with mapi id 15.20.5504.020; Thu, 11 Aug 2022 19:22:24 +0000 From: "Carrillo, Erik G" To: "Naga Harish K, S V" , "jerinj@marvell.com" CC: "pbhagavatula@marvell.com" , "sthotton@marvell.com" , "dev@dpdk.org" Subject: RE: [PATCH v3 1/4] eventdev/timer: add periodic event timer support Thread-Topic: [PATCH v3 1/4] eventdev/timer: add periodic event timer support Thread-Index: AQHYrZgvdaek2OLQmE2RVW4+JcG8h62qEurQ Date: Thu, 11 Aug 2022 19:22:24 +0000 Message-ID: References: <20220810070722.3110873-1-s.v.naga.harish.k@intel.com> <20220811153638.3992403-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20220811153638.3992403-1-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: efca75b4-9467-4a19-71a3-08da7bced21c x-ms-traffictypediagnostic: CH2PR11MB4200:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8D/zN7OhZ7j/NezbWGtmhc1f5FavCWGbz9iNjob1XXf94MGI9yKJvMMfXqxMQ9ZQwZDADeTa81VrVhbePKpXMdAehhOG5ZpdbzESLF0mor1Vw80/LLwWLh6C1JNHtqNj4K8196KVEPMalWdGM1YX0gKFW00svfQOTJ5hrSxdd05SJ03iBFlsRj//LrX4tptuGqp992W34RtEkmoc/9ZTPznugB5c5daNnl1mF6uWhUq+hK9bbd+GnVfwVvxsP2uPxY+MCQmFA07z+TkUC5s8Om7mHdcWdRVT3/KmGT72yNbQt9ntTP6+uqm+M4Maq+ZKvTHORfvGPJuWIQ9uYAT6riRI+sv4RatLZbMRcVU9DZMWZa/ylzSidKfftQTSS2b6Mw5hJ859DBFAL8qRarT9GmNw5BQefkPsQPz/0kPjZrKzjX7FZq/IXEbmVpQhz4elbGHZX1TUMDkxm7t7OAw4lyXd3TwexKpe0YH5fMUfEqYiKJStlRMersf7FYnc9k8Q9TvaBv8awqMZzdvpAFhxwI1a3/RrxGqlcKciPeMdxfRG39qWOSF2VwLUMpinz3WD0a1NH4vDaL0MQEXoryqULYL5GNz8DIdQSltQ43HLpQnz949qHpfIrr7PKx7U+pZY9wmijTnfNZsPVTcE+YfKBG4qrXuQji37YaaDPIUTGnz2qZ07u3qbmXXjWjzB2Rj+YkIkspGbWgx7yfpErzkmTZ30vm3Ex7r0BxTjYSvL5CAYxgzZBKHRmAxvh4LgU4EYR5lh1t5vnYuBGyPipAM+htHiiiHrqD25RgWA7kvKn/0iyCRverGC135yrWjOsmdW x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR11MB6418.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(136003)(39860400002)(376002)(346002)(71200400001)(54906003)(186003)(55016003)(66476007)(66446008)(110136005)(8676002)(41300700001)(4326008)(66556008)(64756008)(76116006)(83380400001)(66946007)(122000001)(38100700002)(316002)(9686003)(82960400001)(26005)(8936002)(33656002)(53546011)(478600001)(38070700005)(7696005)(2906002)(6506007)(5660300002)(52536014)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IsyHvo86xl4vr0ELPtfM+WTWc+8FgvuhPHCDvrZmW8gdSrAs7BZ9J/RsD12s?= =?us-ascii?Q?v0XypkFcgNRYsVyUv8iP/2mRyQfzGAPChMtot0Cjq9CKhzy5390dsXaRboDr?= =?us-ascii?Q?nxthOhqozAGmMrZ/5IZLSNNRz65glCthapVd/QfcK7eak7+XtoipSdwvf7dI?= =?us-ascii?Q?mD8Sp/h+sZsdk6+eCXMwWrDFBnyr7q0DKpEAs9UI16nPtF3qGHZCTkTXbGOD?= =?us-ascii?Q?W6S10j+NEAlWaytf7T10VyyLma3oEIx0z1OfK1Fuy2OxghoaZ2XeGbT6XSf6?= =?us-ascii?Q?IOUuoIqyvQQ9/fCYRu8m/+Kuc352a4mP2sG4cYXJcW9ghBFxQIGgo8eJDrIa?= =?us-ascii?Q?8qbyGqJvhyF6sXc3eS2SQa2teEvjBfj4AAC2bSFb+6tGNzWxPIWCggcG5uKc?= =?us-ascii?Q?GKGcNpTNUDrtcbvyl/qo5j2TXTAAYV5qleBJ5wGtTeNYPIngj6/vUJFk0iin?= =?us-ascii?Q?9vM5PEHxbr2UA7LoYS+F+sGCt3dyZzf5ZYzFd3YU2UQOOntK3aHyveZYkCLG?= =?us-ascii?Q?FAV28UKBtG0fbbHCVa9DUTS6O1/WBSLkMhw6uJsectklPFoqBpLvQ1qDn0Cl?= =?us-ascii?Q?6rPTagka+7Y/VUn60X8JeftjTRODRKagZ994XbKutSU8pmOoAuJDztDXhfTB?= =?us-ascii?Q?ujUyvVI9ShbrYRx12qJOKQ99FNUez5Vc2MxB4vYqEPEzYhSgd/U1uIdG5lh0?= =?us-ascii?Q?df6Asdo+VNxKbJz3NrfsP4it5U6YIucFFCFvgfxe4pJkaj7zmNVqn2c+UQ2B?= =?us-ascii?Q?4iUUaeTtQlk2L0Dr/6Ac185gS+ugrra9qFfgQgk7ub0dqw5LUiFO/e73Wd53?= =?us-ascii?Q?RTrFWihaAqNuB44I66UPMMZlWidr0CAV2pooMdK+3WtIr9xkA5gLg/JOjR7K?= =?us-ascii?Q?xCApjQcsZkTuWvNVUlYCPWd4MDjliNqrYag9rjBoa4T3pVNp6Vr3dMxLMv4j?= =?us-ascii?Q?uAiH9a1Q0w0HlcUs2NBSu3Oqo4xG+haf0zo5Gzl2Nb7ZQEuZ0Db+SfUeKnHk?= =?us-ascii?Q?cJDrCHiw8vB6UBdYIVYDjVY3x7vDFr3aC40JghGErUcOcAqmAF0sZHxIDVEB?= =?us-ascii?Q?8UDtFzh7MB8tSecCTrCMV++WaqEnDje0Q/+v9sWf6Nr388Um6n1OdzLWEBne?= =?us-ascii?Q?+qp2Woyx9wJnh/sR264XMXVNvppIjWoXM1Dpk5ZaGX9ONVe+3HQGWyRAg9tx?= =?us-ascii?Q?YxBZAMVT5hyJYWoRnG+pGl3/VUhmRmzd5qr/rx6GnnfEoKBLXWhVpuJ2JUM4?= =?us-ascii?Q?LD+dJaHVpMHXBhLA26dBZT2VxMGLfptgFxp/ipHRIKam1hr29XKJ9guq7TaO?= =?us-ascii?Q?9JAzDRlweo6skKG3H8dWn6ddGqGpboBkAXM3og31FvQZyYJGgrJhqfaEMRH6?= =?us-ascii?Q?qjO5h46VpKsXUXNBxHXkNZcIrRoH+RzipSlIAb4wchvBXmR22mmE5mYIvywG?= =?us-ascii?Q?aE0GbCgl+ka6ng5II+yZjYS8BlhC4Cq7XDzZM3ut0SnjvQolo2SlnbMLot0C?= =?us-ascii?Q?XmyGvRVtH86eA+fWhl8c1PK/7IYUe9UCQ8hdbROcphI2jIk8uDQUoEZzRM21?= =?us-ascii?Q?RhwAlvR3pAjr/b5yOfO/b5T/BnXP9OsmeCbmHtKVbUTRkJyyp7JI5kBEHRb5?= =?us-ascii?Q?Gw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6418.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efca75b4-9467-4a19-71a3-08da7bced21c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 19:22:24.3800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: diRpr62gJJBIfggaQa9qXGQgJr6Igeym6uiaav28W306l7jIrRQT+TXrLJBU3kuL1HVFQxYpYvJFSEWrcqLOjZRCyxZnnMz9nwzQZNr4b+I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4200 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Harish, > -----Original Message----- > From: Naga Harish K, S V > Sent: Thursday, August 11, 2022 10:37 AM > To: Carrillo, Erik G ; jerinj@marvell.com > Cc: pbhagavatula@marvell.com; sthotton@marvell.com; dev@dpdk.org > Subject: [PATCH v3 1/4] eventdev/timer: add periodic event timer support >=20 > This patch adds support to configure and use periodic event timers in > software timer adapter. >=20 > The structure ``rte_event_timer_adapter_stats`` is extended by adding a > new field, ``evtim_drop_count``. This stat represents the number of times= an > event_timer expiry event is dropped by the event timer adapter. >=20 > Signed-off-by: Naga Harish K S V > --- <... snipped ...> =20 > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index 1dc4f966be..4a2a1178da 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -139,7 +139,11 @@ rte_event_timer_adapter_caps_get(uint8_t dev_id, > uint32_t *caps) >=20 > if (caps =3D=3D NULL) > return -EINVAL; > - *caps =3D 0; > + > + if (dev->dev_ops->timer_adapter_caps_get =3D=3D NULL) > + *caps =3D RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC; I think we should move the definition of RTE_EVENT_TIMER_ADAPTER_SW_CAP to = this patch, and use that macro here as well. With that change, this looks = good to me. Thanks, Erik > + else > + *caps =3D 0; >=20 > return dev->dev_ops->timer_adapter_caps_get ? > (*dev->dev_ops- > >timer_adapter_caps_get)(dev, > -- > 2.25.1