From: "Deng, KaiwenX" <kaiwenx.deng@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Alvin Zhang <alvinx.zhang@intel.com>
Subject: RE: [PATCH] net/igc: fix xstats name
Date: Thu, 10 Apr 2025 06:57:41 +0000 [thread overview]
Message-ID: <IA1PR11MB78530504A1D093BF6DDE341D8EB72@IA1PR11MB7853.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250408205557.6152d29b@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, April 9, 2025 11:56 AM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>;
> Alvin Zhang <alvinx.zhang@intel.com>
> Subject: Re: [PATCH] net/igc: fix xstats name
>
> On Wed, 9 Apr 2025 09:07:11 +0800
> Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> > The xstats name needs to be changed correctly
> > tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
> >
> > Fixes: e6defdfddc3b ("net/igc: enable statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > ---
> > drivers/net/intel/e1000/igc_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/intel/e1000/igc_ethdev.c
> > b/drivers/net/intel/e1000/igc_ethdev.c
> > index e712cfcf7c..68444e4fba 100644
> > --- a/drivers/net/intel/e1000/igc_ethdev.c
> > +++ b/drivers/net/intel/e1000/igc_ethdev.c
> > @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off
> rte_igc_stats_strings[] = {
> > {"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats,
> ptc511)},
> > {"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
> > ptc1023)},
> > - {"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> > + {"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
> > ptc1522)},
> > {"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
> > {"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
>
>
> Please don't send same patch twice.
Hi Stephen,
Thanks for your review.
The two patches I posted earlier were fixes for the same issue for both igb and igc drivers.
Now I merged those two patches into one patch to fix the issue.
prev parent reply other threads:[~2025-04-10 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 1:07 Kaiwen Deng
2025-04-09 3:55 ` Stephen Hemminger
2025-04-10 6:57 ` Deng, KaiwenX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR11MB78530504A1D093BF6DDE341D8EB72@IA1PR11MB7853.namprd11.prod.outlook.com \
--to=kaiwenx.deng@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).