From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9824B43B04; Tue, 13 Feb 2024 12:56:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 757404029C; Tue, 13 Feb 2024 12:56:30 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2054.outbound.protection.outlook.com [40.107.93.54]) by mails.dpdk.org (Postfix) with ESMTP id 459B94027B for ; Tue, 13 Feb 2024 12:56:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrOlzJOvWe+Qn1ePLvsM1jhchCbXtGk5L33AvVg8CPKU7/2lAGa0AtL7KZmoAkYPViZTw02S5Xxf9M1ctGXjA327kuHN9znm2Vl/dfQ6Dq4orevJg7nPjKsQB7izM2Q+l+V1uA3PHu0c7PnXS3ho+DJvN1OoXq+CjKAHmwj3fQtiGNhNnOKozjrJdWx3fWa75HTUSGGXeIunWG+xzymMoRSz7hio/yGZT/QsZ0a1vclQVjjQzNBnIpCwB7wvpqCA/NliMEi2b75MBYWH1UqHt+KuwpcbnJ06UWIVL7ajWe9JoqdVtG684oDSGWrpFl6iXNjpCgfwzadoCeEmVBBiDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CoTHKTqe/DNIbq9xipAvrx8HuIW8tRTZY6B8tS0KkdQ=; b=A8HLTvBoL+G6yVZkKZnmHIcIAHGo8MO7zUoOqrm8+wBiWkfmLaFHYAim1ZyL6Ceojqsf6wUtIu0yHsiv9if5re3RMRzax9Q2Hb6KHOyhJWQyc5AKx4WQUtCZv6vGyjW0Y8wCh64Mb//PyG/wE+EffWG9YYVY3Is9ic0A5htnQ8X6DfLcvYt5rmqKGh7a0XYpI2zas2wRBTtI8otW/twnhwr9P4xTROO78DiTsyodyTW9413OHRLRxzNsEpHPBwAPaweJgGjLhdwWcTmRtGus/eWirg6FdZ1ygk+9xRmp3DFA0hqQ3974fY4hURwqZygohEycAFCwOPMVShjhuJY6Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CoTHKTqe/DNIbq9xipAvrx8HuIW8tRTZY6B8tS0KkdQ=; b=GWCBt2/SaNH9YP6NW0nJABXeycwOpx0sRnHxgDVNvj771RzlL7/5yABNNVmM1Tzg58TdydRTmClQLIw6yhc+gt7x8wkygUWgcg9XcIIOwWQxXj+Jq8HP8TB61oPz+ahUNkEtZECtNUTobN1BBXmCAdvhcgBVxoyQe5Vvsk1PJSWc/5bi8PXHjDgYjMRWgQLf5AuzTsFKAJ3eN/a9D9MMt4xgBsqjUo61p7UA7PnsBQrronf1YYMUIYvvV368MoBxDfsidGymaAOJeW102l5pL1BW2x3s8Mrwb+usAUWHFGWjwKEp9CI8dtOptaIxE1XDLZbz0nbUfa9uYSqapy2Tng== Received: from IA1PR12MB8078.namprd12.prod.outlook.com (2603:10b6:208:3f1::14) by CYYPR12MB8961.namprd12.prod.outlook.com (2603:10b6:930:bf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.24; Tue, 13 Feb 2024 11:56:26 +0000 Received: from IA1PR12MB8078.namprd12.prod.outlook.com ([fe80::651b:be01:ace:2856]) by IA1PR12MB8078.namprd12.prod.outlook.com ([fe80::651b:be01:ace:2856%4]) with mapi id 15.20.7292.022; Tue, 13 Feb 2024 11:56:26 +0000 From: Slava Ovsiienko To: Tyler Retzlaff , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , Suanming Mou Subject: RE: [PATCH] net/mlx5: remove non constant size from type cast Thread-Topic: [PATCH] net/mlx5: remove non constant size from type cast Thread-Index: AQHaFlW7duqacitOq0GYWVhHRHISaLEHjtaAgAErZsA= Date: Tue, 13 Feb 2024 11:56:26 +0000 Message-ID: References: <1699896038-28106-1-git-send-email-roretzla@linux.microsoft.com> <20240212180317.GB1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240212180317.GB1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8078:EE_|CYYPR12MB8961:EE_ x-ms-office365-filtering-correlation-id: fa888bac-0c6d-4173-a3f7-08dc2c8aceaa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: seDkhEegTmlupmQ6q+D7N4N6aFPHe/PxBcyN4zsN5B2o5lE+DwY9thGsoJzG0s/4gQGduoqeN73rhl/qwbemNwSX9KssBmYYx4gi+HcDHR8V6xxIlREtrq7morakIB/7mpdViip2S2mZC/HAftQa7rJfoF8mnuDOReVzPX8C9UrrGMLWcuqaxin1zQvD9HO2PU0FXvHxZVqmUDXXvTfkyzo08NSnIRmUEn9auG7bc/N+CE/5dGFv6mJIcXcPXoOo75bIToYXR+CkWLhzc3w/0SgJJyQSjKHAOGgu8kkQsOsKFsiSm4KpnFglXq6QHYXdzb8vo6NZ7G2w1iXQG/8VPz5+xngYSJRBwfYx19hDDW/DV/QFgTkkplv1iFAfGgmtZtaG5QIV209HFoAMkitAEp4GpLdIhFLDFDV+0juIqjZg7rUFdH2J5kQlGbdodASXp3TgI2NxccJdysqAK2Inb6Puu6ONzylBoXtmKw7nuB3HiFt7H6UPB3NeDu51Wm6fzEBHR0RZFtMmWgQKxJ1UlXimVWI4TAxHoeRsv4JivtMvXqho4VRtCPTXn+tOLFriYW27PtQ8LSQtLXfKcH8orfIIXPyulWqXJfBbHRLDVt3YTrpLgOFbUpZ6R7W4S+hB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(53546011)(9686003)(7696005)(6506007)(55016003)(2906002)(478600001)(5660300002)(110136005)(54906003)(52536014)(316002)(41300700001)(71200400001)(8936002)(8676002)(66446008)(66476007)(66556008)(4326008)(76116006)(66946007)(64756008)(38070700009)(26005)(107886003)(83380400001)(86362001)(38100700002)(122000001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ugy4JEbMVWSX6N/4dSqpENkpktuY1+6L9/blFRtwVhhDzJW4k96gn2nCiRIw?= =?us-ascii?Q?gXIh+XKYrjP1eHLW+Cx7IcIBnIOlqAPeTi30moh+MrCe4qDKbBhvDIW8xq8j?= =?us-ascii?Q?k48wKJBIxodR6cYQ6zvOly04ULcBUhYXyNALBkaF2Rt1Ju2FCOoHVfuap8iu?= =?us-ascii?Q?/lW/BUELER1k2hZNEIFdVMIcV/WnbyVcJkN3kqChj+XFFvaX+cnR4Lz3zZ4b?= =?us-ascii?Q?WtIW4USweVdrk6unPJmcmKwE5zYO6qw9I+LwYql0z0dHfwOg8BTadNs88yu5?= =?us-ascii?Q?ZsQ+p+tRWHt+g3pRPU7LILwuI853w/EQsWzTb4B/wvSl/bNmhrLndO+5eTjq?= =?us-ascii?Q?yOD8cffvJS3w5TZN7mEPXO9he96687RuGNWY1ZRNUPnp5XYWn20faayY8OGy?= =?us-ascii?Q?8D+udayN1a7GjMH8InlH4S1s1rTb9iCgkraVl2hu9Xcz1+9BwKyX9LYot3Z8?= =?us-ascii?Q?SYyZvr9cFOQD2cFZ5LBuiliuGD5uaWnoLDvdBDNVbwrYmxMKOcBPkmZ5q/OP?= =?us-ascii?Q?O98AQG3GwLIh4hSY2xT8H2o7hvItMeD4vVdd2WvFXjjFiKUpBhToWi3Gz1KX?= =?us-ascii?Q?fcSmA3YKzg5bJehnnajlLZsWEALt4g7awZ0aCYpvCzi9tMLvppF0KUkQLraN?= =?us-ascii?Q?2DSu2CAS9qWA0IuIY3+xhDavYW42PkP1u2MdxQnNGFFUqiNmzKJSH6ida68M?= =?us-ascii?Q?o80beb4dOXFOYAz0tOH6WK80UIIh265pAQcBzGqXHxHT5PLztpp2igtQw5Lc?= =?us-ascii?Q?ApfptnlypxAS1jtB2H8rnEaqUUFzl94kzVCRwf/eeBRADgNsIjK21tXwOJF6?= =?us-ascii?Q?LkFBWurllrk/B6E7W7K2zqRIPE7N9/lu/R9TfoWVuHI9cmqNNKdvJ3rzk4h0?= =?us-ascii?Q?elGbs5kOcpxyR4ixHUD08FApqTxDHyci517iEXATqCoIfKK33ioMTRElx9Jm?= =?us-ascii?Q?fK/nDkdOZSLn46AHHdauB3XMFE51ZEJLpwFZcbIbz529PVSxLCKjp20XdPhx?= =?us-ascii?Q?gwKdvHRS30A1Oam++czGJJYmxmxj7TWtZWvLih7oF91cKflPZ/fZ++8upnjT?= =?us-ascii?Q?w3TctE5Pf+FOKiYcgMJ8YVY90tDBSqo81SugP3W8LUWIArIGWsUXa/KfjfIf?= =?us-ascii?Q?yWorsjaCskuRRQEwZpCjFFzMVuvkKQVI7wXv00i7YrEIhXEsxZowwk/QU76E?= =?us-ascii?Q?HjKQ97vzqSDmS17t10KHbr5g4kYEFXA+XEX5mMS976Op3L9fX5Jn5ezNfVow?= =?us-ascii?Q?vTKx8oxP93N7kJrmgCVnPz6C+Dqgh6+klUI6CbQHAZjfnFxjRmJRV3NczGIS?= =?us-ascii?Q?ECVIR5/wyAiJTafUNprJORYawmiDDnuFiJPcAvHQmPACn8kZ9UoBxGZBSJFR?= =?us-ascii?Q?7s2sAwn+JcETn6m1Ez2EpVEShzXXuBxUSVxRwG8gKhlimsRFMauEfCcuaLxk?= =?us-ascii?Q?waQSOygJlQ8dnQ5q50eJHW7Y4eP9XuSNLZu0gpD7B35eYk4owX3UzMZ+MeKd?= =?us-ascii?Q?6+SfpRFONQYNH21p6JMb0VluKG3Q0dHWuVNj1QOtPO6b7qnlEa4fAuQG511E?= =?us-ascii?Q?3bt+0IpY8FgneUbWTAEZTdjC9Q2wLB1/nV/BIjph?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa888bac-0c6d-4173-a3f7-08dc2c8aceaa X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2024 11:56:26.4017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jPO5rdBahHdBpS41JAq1UwojrmTHpqBxmsG0Mov4RbSGnaeM9OvO6Qic4gGvUc/7uWKISZdPktxWjAZTL2sAQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8961 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Sorry for the delay - we considered the opportunity to get rid of the point= er to array at all. Not this time. So: Acked-by: Viacheslav Ovsiienko With best regards, Slava > -----Original Message----- > From: Tyler Retzlaff > Sent: Monday, February 12, 2024 8:03 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Ori Kam ; > Suanming Mou ; Slava Ovsiienko > > Subject: Re: [PATCH] net/mlx5: remove non constant size from type cast >=20 > ping >=20 > this one seems pretty obvious, maintainers could you please take a look? >=20 > thanks >=20 > On Mon, Nov 13, 2023 at 09:20:38AM -0800, Tyler Retzlaff wrote: > > Placing a non-constant size in the subscript [size] of a type cast is > > causing unnecessary generation of a VLA. Remove size and just provide > > [] indicating the type is an array of unspecified size. > > > > Signed-off-by: Tyler Retzlaff > > --- > > drivers/net/mlx5/mlx5_rxq.c | 5 ++--- drivers/net/mlx5/mlx5_txq.c | > > 2 +- > > 2 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > > index 88b2dc5..f0ab77d 100644 > > --- a/drivers/net/mlx5/mlx5_rxq.c > > +++ b/drivers/net/mlx5/mlx5_rxq.c > > @@ -1951,9 +1951,8 @@ struct mlx5_rxq_ctrl * > > tmpl->rxq.mp =3D rx_seg[0].mp; > > tmpl->rxq.elts_n =3D log2above(desc); > > tmpl->rxq.rq_repl_thresh =3D > MLX5_VPMD_RXQ_RPLNSH_THRESH(desc_n); > > - tmpl->rxq.elts =3D (struct rte_mbuf *(*)[desc_n])(tmpl + 1); > > - tmpl->rxq.mprq_bufs =3D > > - (struct mlx5_mprq_buf *(*)[desc])(*tmpl->rxq.elts + desc_n); > > + tmpl->rxq.elts =3D (struct rte_mbuf *(*)[])(tmpl + 1); > > + tmpl->rxq.mprq_bufs =3D (struct mlx5_mprq_buf *(*)[])(*tmpl->rxq.elts > > ++ desc_n); > > tmpl->rxq.idx =3D idx; > > if (conf->share_group > 0) { > > tmpl->rxq.shared =3D 1; > > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > > index b584055..3d219c4 100644 > > --- a/drivers/net/mlx5/mlx5_txq.c > > +++ b/drivers/net/mlx5/mlx5_txq.c > > @@ -64,7 +64,7 @@ > > const uint16_t elts_m =3D elts_n - 1; > > uint16_t elts_head =3D txq_ctrl->txq.elts_head; > > uint16_t elts_tail =3D txq_ctrl->txq.elts_tail; > > - struct rte_mbuf *(*elts)[elts_n] =3D &txq_ctrl->txq.elts; > > + struct rte_mbuf *(*elts)[] =3D &txq_ctrl->txq.elts; > > > > DRV_LOG(DEBUG, "port %u Tx queue %u freeing WRs", > > PORT_ID(txq_ctrl->priv), txq_ctrl->txq.idx); > > -- > > 1.8.3.1