From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 370D943A3C; Tue, 6 Feb 2024 18:50:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C97D0402B5; Tue, 6 Feb 2024 18:50:49 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by mails.dpdk.org (Postfix) with ESMTP id 552EE40272 for ; Tue, 6 Feb 2024 18:50:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FCx5Hst8nE6cP+8YQ0QwwJJHebyjsUo/atCO404w2b1fgfLfPPf4bnEbMmvpwreVMb+zA5IPgPOnmZ+OoROHqaD1kWPvY2kae8sWxOaLwKN2bSW5ka6L20m+OyE5PveYSlxZjyoI5GBU7VxW/SxTH72fAmKbQa+d2AqXt1xLRyvPEROcBRzUQgwG/OvvkPA6cV4X2IN6byq0z/7qtEeSQirX+938xRuO31BwtamacG73AN2J+L0WabJx73fDLO8v8aDl5gvwpMuaWe5n8uzeV1FDgJ5DiWmJ4SB0VtNTYYK9epWQGKYot4ToZDIzkFaW8rxpFIWvtbr5DwN+E6YsjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7Polp0l42gc+soOvvvkcRwuoI0E0OpI6QUuGp3d/+Y=; b=AwTpVbUoenzLmG10bc6reLyDVuMEJx79xUB+eC89fxueGYr4Fc6xHRAAIvr+n904saTfTcnve4bAdSK2nJF+WEqSgCwuXa4rskV+CGeXuVlAmtAgjvUPOTNsQx52JAhykZ3Ofn9jVF5z/vxDPMNG5LqGdPPTn8wdpHmgQzX94F9Uy2hqOXCpHph1Jsw0RKXpqTtrQddjIrTNHZEvaSDeOWTn7BcnX+a6EyUYOQ42pXoR5T1Cd0ceyLLZLmvY5zzmYPLp83/fFclg6NffdalnH0y11J3PslaYyK+ApS08sXGb9pjZjoLYB6LZflslcMw7xeJwkZGLC6he+zIzzop5MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7Polp0l42gc+soOvvvkcRwuoI0E0OpI6QUuGp3d/+Y=; b=aeQ49xYN1LMopB6PRArQToft9QoYBRGKv5g+OUMY25YU0H9rStXXzGTRoEVjYDoshxl7LiDMQev6FvVFFvcujaBsy5L4XQeQ+94e88Dukrb61t8FZcML1IVCSSvGKf9Lww5uTGpIHumsAy6l0I22EFPp7iKdWdKRGwU2huo/Pbl/Xk02IMsJLa250ZRdLJvuQYmm1+DL/P+557nH4LfzZKgQV/HU5X8rJVdq5bCo0QEQJTG4ANBYwBVVlCgiKWv4sbXsHvho0GBbLrEQBmkpMt19BNkMLbweI/Cs+pF311Gj/GZGKVVeneBlEtyApNNC390xoyniaSXrWs+1euzRNg== Received: from IA1PR12MB8311.namprd12.prod.outlook.com (2603:10b6:208:3fa::12) by SA1PR12MB7319.namprd12.prod.outlook.com (2603:10b6:806:2b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Tue, 6 Feb 2024 17:50:45 +0000 Received: from IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94]) by IA1PR12MB8311.namprd12.prod.outlook.com ([fe80::708b:e498:d9c4:94%4]) with mapi id 15.20.7270.016; Tue, 6 Feb 2024 17:50:45 +0000 From: Dariusz Sosnowski To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: Slava Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH v2] ethdev: fast path async flow API Thread-Topic: [PATCH v2] ethdev: fast path async flow API Thread-Index: AQHaVCjsax4yQWgCKUeR8Y62ewfufLD7nr6AgAAf8DCAABEQAIAB0Hkw Date: Tue, 6 Feb 2024 17:50:45 +0000 Message-ID: References: <20240130181751.1425388-1-dsosnowski@nvidia.com> <2171757.irdbgypaU6@thomas> <8370937.NyiUUSuA9g@thomas> In-Reply-To: <8370937.NyiUUSuA9g@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB8311:EE_|SA1PR12MB7319:EE_ x-ms-office365-filtering-correlation-id: 5ef9981e-8d6f-4056-2018-08dc273c24f2 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ieg/2dK9pZkXi3weeKrLQgN/1RmtoxzhNqBe6ZW2IK7D3XTl3YWTSiFoXmGTQEUTvbwUpEvhWEWr45zJ5sNBJfbHIo9p8d/DZ4FR+OeeFRWovbU8zM39aUqBDfqbVfSHnS3QRhSb8MudYfRNYawt22VlN7psYmKxVk9BxGdqJ8WoIR2ep1763lhjOnQTHfCfAwx7Ii/ekPziRoxspCQc+G1emxb2A3smvVYUmezZVP/LVSvekSqhV9Ac6ELMDPz151SlW82gmvHVrZLb/V3coHALeP1lEsDaohW7r7rCCUYNocYVamZA+sirH169VqyEKkmWzH0lZqZ3NMbCctQZYFv3MO9KdqIqwnJ6/78SY95RNipGIwyV9JfgCOcIYirQ6V6vwk++K6t/8CMEHa8zrNRm331gojQV4x6tTTFEX0yXNNWpdGVBHaQBORmAczpicp4M1dGZ3xJY7RptULqu4By15avTosC8/tgL64PT1JWSW/pnbCBnKGw03944dmUQdu/ALRapWK8ZMlqFrSWNRiWoafz9EzTmrJ0R50/5YF0pXdoyOxlP7UrahC07mP+i2/ysO9mGFUinJHgT+geL36hmdwTu9xEvcKsuMd4SjzjHCOYbDcxHrraIpgh7V9Az x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB8311.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(396003)(376002)(39860400002)(230922051799003)(230273577357003)(64100799003)(186009)(1800799012)(451199024)(478600001)(33656002)(53546011)(7696005)(9686003)(38070700009)(6506007)(26005)(41300700001)(122000001)(86362001)(38100700002)(83380400001)(55236004)(71200400001)(8676002)(8936002)(4326008)(2906002)(55016003)(5660300002)(52536014)(66946007)(76116006)(66476007)(54906003)(66556008)(66446008)(64756008)(316002)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p0rQiHi7cMBZy3m8mjxtGP4Bd1syNKYd4sEhpkkLxLkLrSoR8+H+gNnsxOD3?= =?us-ascii?Q?J+UJzFg5JPGMubuFDR84fbEMZlCyCcbyuhMxfKA+GJXUrNuPE41uo6muyfGG?= =?us-ascii?Q?xEsPF4OXCT0w4qQi1yiFHX0eYG6h+OqXu++lwo0LxlAC/VNEIZ0vZHzncnay?= =?us-ascii?Q?XCP0IZsTlTu19IaHOJ0ETpzuZDLI+QFf+c7wAwvTpTkOLGIDV3KO2dhuaQ3a?= =?us-ascii?Q?+iQNbPpWSjjBubhbVL6oD6WHsM0Jsu9WfmY547J15DM7DTG1MPnKCghYZWng?= =?us-ascii?Q?aisZyqwltwPO2j04Vn5CgXOrhKGxr0YlBJZO/jlDbHhpMf+nWNF4vA6xp94a?= =?us-ascii?Q?TeJEvbRINf0n8DMnaxEfa57eM3iBCInUpFNdekBx3RYnad7YXVauaQOX64BL?= =?us-ascii?Q?GOaPmLeZqdFMfiCHr9eUQyLbhfv20CHU3XYiYks1Wkcvz8mKloWvsQ8wV6VP?= =?us-ascii?Q?S0vCzjGwuoZT5uJLRbXY9djYhgms2EwG8mVFFJ5JaIFR7EZTLSczVkOkILX0?= =?us-ascii?Q?xUM9ho/b0sqkA8gDhAFPKKv4NuioL+2O+NXd8GUkS3wrnqWgfSoIK+5Vu5zM?= =?us-ascii?Q?yaelGeFJ/8D2lnJ5PfdRDwsoC4Lr70kHqQ4GnGpNS5DcAeGzslhGK0pc3mdx?= =?us-ascii?Q?aE5Qx5H0xUjK7nmtEVMuPxClevhPkSLuh/jBJ0n9uRAB3hmHlZb+urovBl4T?= =?us-ascii?Q?bs91QtfL41QqUGcl5DVOIVanj09woz1x9jjLqxdc5qed0JqkRylqoAzodUF1?= =?us-ascii?Q?Bwy3WSQ3iYtIbQx4SrVOJm0GfBRKcJVbbPcreFZEqGFmqZzj1P2xUdYtZw0M?= =?us-ascii?Q?MXjXNivjPzAqURGM49GTKZPZAjVjyr8LKZvYXQGzJyiFy60r9zyBQs1XWxKe?= =?us-ascii?Q?9FspwchP/E1iFY0wFog+8LW3goJHj9Uu6/VHFjm7zGbXmY6RyrucVcx90XU6?= =?us-ascii?Q?btAyWj4Ljjeq6BE4HeSG1MDif7Pq7JvRC2TJ6KBVCR4Q9sUZo7MVBAZdeyuz?= =?us-ascii?Q?j57BPY0H2TTuFfCX4f+r0YYuzAnS1JazjJhWPHSCqz5eOJ9kmdDqmfEJLUzh?= =?us-ascii?Q?StvHZZa3Bh3c0A2qCuK3s4WhmJhShz1c5x07AiqTcgfl6AaypDiGx9pKJVfT?= =?us-ascii?Q?Xh20nZYrIXojvj2vVtH8I3MdCJoDqzGn1COpL7p0fePIzXsiWr7mPWWbyBZA?= =?us-ascii?Q?h4CC2FKjdUsWyz2T0c731xdmIoBJL7D7T+rPW4rlPYpcat7yucDkoYOlfjbm?= =?us-ascii?Q?ep8EkVYHUHHmBbyQoe6rnnF53JY47H8TUGl1kswUUCIdcuZOWm2jy5CI9Rrg?= =?us-ascii?Q?dIghBNIkx2yW682+TC45wFLBx+k8pGsbTBUK75OueSwgnPwZdiSgJ5+z/fs4?= =?us-ascii?Q?JsxWllbWYzzDwbdjaowhJple6xmTwWhUpdzvy0sMWTmIkUCnzgrfjfzEtVi0?= =?us-ascii?Q?81Ov4xLeJR5AHpL4dnf7Jvm9IRkacW2WWIJMOZgi4ABnGJVbnBOmfoapMETR?= =?us-ascii?Q?+/shOhBi2AtGYfWJowlV0GtJ1dj8pZDYUMZPg2A8I3jUH2f69fnLiU6uDeYt?= =?us-ascii?Q?NKwFK+2m++DdJpMKP6a3sFAsTsWSoMIVC1fI9jFe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB8311.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef9981e-8d6f-4056-2018-08dc273c24f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 17:50:45.1070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Ejz0i9Q0wxWkvbIqkHZKvDuS6VQn8Hb3lfOeBnDnnoxgNmdalthnYix5P0XV85tH95Cny4HgNIkLsceCf0K6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7319 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, February 5, 2024 15:03 > To: Dariusz Sosnowski > Cc: Slava Ovsiienko ; Ori Kam ; > Suanming Mou ; Matan Azrad > ; Ferruh Yigit ; Andrew > Rybchenko ; dev@dpdk.org > Subject: Re: [PATCH v2] ethdev: fast path async flow API >=20 > External email: Use caution opening links or attachments >=20 >=20 > 05/02/2024 14:14, Dariusz Sosnowski: > > From: Thomas Monjalon > > > 31/01/2024 10:35, Dariusz Sosnowski: > > > > As a result, no checks for availability of the implementation are > > > > needed at library level in data path. > > > > Any library-level validation checks in async flow API are compiled > > > > if and only if RTE_FLOW_DEBUG macro is defined. > > > > > > How are we supposed to enable RTE_FLOW_DEBUG? > > > > I should document it, but the idea was that it must be explicitly > > enabled during build, by adding -c_args=3D-DRTE_FLOW_DEBUG to meson > options. > > > > Do you think doc/guides/nics/build_and_test.rst is a good place to > document this option? >=20 > Yes >=20 > > It would be documented alongside RTE_ETHDEV_DEBUG_RX and > RTE_ETHDEV_DEBUG_TX. > > > > > May it be enabled automatically if other debug option is globally ena= bled? > > > > Do you mean that if buildtype is defined as debug, then RTE_FLOW_DEBUG > is defined automatically? >=20 > Yes >=20 > > I think that's a good idea. >=20 > Another way of enabling it is to check > #if RTE_LOG_DP_LEVEL >=3D RTE_LOG_DEBUG I think that defining RTE_FLOW_DEBUG based on buildtype would be more appro= priate, since the code under RTE_FLOW_DEBUG is not responsible for any additional l= ogging or tracing. It rather serves as basic checks for all async flow API functions. Best regards, Dariusz Sosnowski=20