From: Bing Zhao <bingz@nvidia.com>
To: Yang Xu <xu.yang3@zte.com.cn>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
"yao.chenghu@zte.com.cn" <yao.chenghu@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 1/1] net/mlx5/linux: set down if detect any anomaly
Date: Wed, 12 Nov 2025 09:37:02 +0000 [thread overview]
Message-ID: <IA4PR12MB9763D815B41A246BF8648C6ED0CCA@IA4PR12MB9763.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250818003223.2098419-1-xu.yang3@zte.com.cn>
Hi,
Please check how to use plain text to send the email? And this is a bug fix, please add fixline and change description of the title line and commit log.
From: Yang Xu <xu.yang3@zte.com.cn>
Sent: Monday, August 18, 2025 8:32 AM
To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; xu.yang3@zte.com.cn; yao.chenghu@zte.com.cn
Cc: dev@dpdk.org
Subject: [PATCH 1/1] net/mlx5/linux: set down if detect any anomaly
External email: Use caution opening links or attachments
MLX network interface card link detection will set the
interface to a down state upon detecting an anomaly.
Signed-off-by: Yang Xu <mailto:xu.yang3@zte.com.cn>
---
.mailmap | 1 +
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/.mailmap b/.mailmap
index 34a99f93a1..14d6ee93dd 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1891,3 +1891,4 @@ Zoltan Kiss <mailto:zoltan.kiss@schaman.hu> <mailto:zoltan.kiss@linaro.org>
Zorik Machulsky <mailto:zorik@amazon.com>
Zyta Szpak <mailto:zyta@marvell.com> <mailto:zr@semihalf.com>
Zyta Szpak <mailto:zyta@marvell.com> <mailto:zyta.szpak@semihalf.com>
+Yang Xu <mailto:xu.yang3@zte.com.cn>
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index 9daeda5435..364b024b77 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -486,6 +486,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
struct rte_eth_link dev_link;
time_t start_time = time(NULL);
int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT;
+ memset(&dev_link, 0, sizeof(dev_link));
// I think the inline initialization = {0} will be faster.
do {
ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
@@ -504,6 +505,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
return -rte_errno;
}
} else if (ret < 0) {
+ dev->data->dev_link = dev_link;
// Or just set this to 0 directly would save some cost?
return ret;
}
} while (wait_to_complete || retry-- > 0);
--
2.27.0
prev parent reply other threads:[~2025-11-12 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 0:32 Yang Xu
2025-11-12 9:37 ` Bing Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA4PR12MB9763D815B41A246BF8648C6ED0CCA@IA4PR12MB9763.namprd12.prod.outlook.com \
--to=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=xu.yang3@zte.com.cn \
--cc=yao.chenghu@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).