From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6121342B43; Fri, 19 May 2023 07:36:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52A4042D37; Fri, 19 May 2023 07:36:41 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E035741141 for ; Fri, 19 May 2023 07:36:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684474598; x=1716010598; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sk+eQOp3a/hQFcPy4iFwQtRh8Hly840n2dXz0q0DWXg=; b=fgg2I4pB0FU1iddmlqm2rlbt7UV09fYREtqy0n1Bze/h1TV1MT6VBoEM dvq8HDC8NyiFnMyFOCu7TZoah/SxEiu4GZCNI3R5GTonmergMK107eR8e GMUyGKLIAVC9DTdcYMx9NJbmfKIuG3T0AsxBdVJbwcHNE/zWqi+0vac9S AfG2BYomUYnt0j5w4ZNuAD3hfxvFzL0kN6TLM+pgK9+ZigFCV1GMutmLN z3ZWkAAT5KDnZWGZsvmRtMEpCiFdJbLxvUV22X48N/CV7mzR8uZNgkY0E QnayULNFFLEmGl4lK10pAP9upVRgqghGa1ddzkjBL07CLUTQVAzRpEbcD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="349802740" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="349802740" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 22:36:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="948987843" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="948987843" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 18 May 2023 22:36:36 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 22:36:36 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 22:36:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 18 May 2023 22:36:36 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 18 May 2023 22:36:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8A6jYPGQridUbKy+ECcPURM6OdzIxrOg1ItnbRLMUhjVULtiWQPEgqA+ZzBDgwV9Ui44VYlf/R6xLiQ8kFy9XbZORf4DigZgDSiJy2pgxvxLFv6AzkuSZm7VcE+qEguqIgEaxExiphifnK2xSwiieyBSpaFpvhQMxjJEfNVCosFiU7HCyUnkLJ6et3hgec0nOcY3SdJKQwsgBH7tjyNZobDqrBZMDrOnLK7rXpcCBnkyxk2ipWs7GrbFxQ1X8Qs6OecoxBt8eNOT00yH/rn7gj0CIuJEKRNlEJSJNcRngJFAu/RUcRchN1RiCPb9bbbMidFrQo6d4xpyZjnZ8Ri0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YY2wnO87cB0O2Fl1SKXBLF+7v7WLnP2Gx9QCanRlU9k=; b=h7u7VuYtIcmYLSFHmJyyZD6Ix4NR+IDhVRH5dMg0p77eXXp0dotMkfCJrWuup2RMuRVckDkQk62WroALclj/xyFNYptn334Vnn9cDFepTPqDS0pvn6ZcoETnltSp08GLACcgTnhJvEVGHwrHS3BXnhhNEHscvk9R+pBqAYYr8y2SClrvlydq7B4yXB/geUEGeLT6sbRsl084mOGcLc/QsoHPT0aWw3AvPaZocrjaE3FoD/oyXE2rCsRAG5peUjB6H5A9HnyLeZEXqze837baNHOH5WiHsqiITy4SEUc2uQCVSwXfcO5+8Zk8SMJlvROIcJJu5Irzg+ZWjVsbod+2Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by PH0PR11MB7562.namprd11.prod.outlook.com (2603:10b6:510:287::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Fri, 19 May 2023 05:36:29 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::a1be:2406:376c:612a]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::a1be:2406:376c:612a%7]) with mapi id 15.20.6411.017; Fri, 19 May 2023 05:36:29 +0000 From: "Xing, Beilei" To: "Liu, Mingxia" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Topic: [PATCH 03/10] common/idpf: support queue groups add/delete Thread-Index: AQHZdCDXP77gg0stkkiB7qgzeeIqLa86KzWAgCcT8VA= Date: Fri, 19 May 2023 05:36:28 +0000 Message-ID: References: <20230421065048.106899-1-beilei.xing@intel.com> <20230421065048.106899-4-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|PH0PR11MB7562:EE_ x-ms-office365-filtering-correlation-id: 553bdc45-f17a-4184-1368-08db582afeda x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ka1FzGB0kuM9FFCSvCveJx6PEXbJrDkkmy4iFx0hnSDgu20i2Ym+rAftxCSBveMAlWppFILfSaQsufLDCTunMqMzbi3P/2sCwaAo9uEuhXuFTAn7eGs8zji1b/fUTJiEowF+5VmlrmQp1q4Of0BgGeQcsBh1XNmhKX/7iIHrV4lRrFugTjjyjKwh9SQFAq+SVb2Ybno8WlB9/egWzWlll2LReEzmDsfyjGCafpk51L9zmiOFOwFwTzt9P9NgeNSz50B9XwP1mdUcKx1PFanYID/CmuS00KVNrjo0ZGIFesF4Y4rDLAgAbPPy+2jCo/H3tl9SuKStqhLKb+IDvITIg4wizhISegNosENILm5Uc5Th/cOSPfrQYf09ikUZ3QLjR91vt92+HLgLDKD6kcskHEjG0c/YQ/XAnWSubzqotAy3KSSPqPxk39nmND01u5lCXrxqMM7sSHW3/6z7E4VqHuPIB/HRz391HWERWZfguw/bfDcPxsKh544CvOclu4Tr9KQDrYIMIWB8JAeApe7NsuMTfKsXJhuekRf3TPlhvnwDuXUHAIk4i2vXpYfgksxBctCCKnJlf0qkJcV3kJxeyrq5OgzaSkLAHAOciwmCPK593GzJCG9kSLZd5hz/0GpB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199021)(2906002)(478600001)(41300700001)(4326008)(6636002)(316002)(8676002)(8936002)(110136005)(7696005)(71200400001)(66476007)(66556008)(66446008)(76116006)(66946007)(64756008)(52536014)(5660300002)(6506007)(9686003)(53546011)(26005)(82960400001)(186003)(55016003)(83380400001)(38070700005)(86362001)(33656002)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jhnx90tNWRvAbTkKBxBwxyJnWPxdMJiLyxc/OidNMvHedGOaAzkdEenfmn/n?= =?us-ascii?Q?Ox2UGetMJBVTiWKB7ZXZNpV2DaDtYLMxEMusnv3kf+aaMGLDSUicbADliDnb?= =?us-ascii?Q?L6Hnm8r2DbGw2aZ6OZW67WbEfQ9W8Otf9td+f+wmW2DGfmqLB5gnOzbDWs1U?= =?us-ascii?Q?GmUwGF357EJ+u9B/grvhC1vDzAsfKAGosg3DcKkN2pSosPZS2PV/Q6TnujDt?= =?us-ascii?Q?eFsOi1uZ6PunFyVWUBpZSHbGMQgx1RQg0vv6/zEpVsi2JL2HwhOdOhCuNTrp?= =?us-ascii?Q?HjXzB0jKZRGStAHlutk+AzIAFS6xdgxquVJfEhHRKHmkPwkdpDvLpEp5+LTQ?= =?us-ascii?Q?6QubbbT3xxcAxyKDQrWSUjbBSn7rUZPFJaw6QBmTLqvNRP5DZkWI4TIdtvu+?= =?us-ascii?Q?IAqboTwbDwjBAq+0yvWPQrGutE6kjELxolon4soNE1JbifoTtP8AYn0Z7BoQ?= =?us-ascii?Q?zYlM7OPayl25RlOnefl6alkxzNrzyBfmpg79xQBDw+IjIslUaMcddkbc1yTq?= =?us-ascii?Q?/FSYhKh3povxeuLFQbuAVKjZfwtmQ04dWa7v9UkghicqczrJbJZwqVF+hCfS?= =?us-ascii?Q?cy3eF0/PNEf4I1sl6o9q/zvSD/LiCvT9NZO9SXQKqTBGSDXVnDyxTUApVxOG?= =?us-ascii?Q?LckZ1Qs03/jFzmv7EpGYsl0uJHW/YFepr31ry+36XO9CnLlp3/Wj8csuX4AS?= =?us-ascii?Q?mAT3QDrPxFN1d1gRHnJihaRB12jfX7z+6tUsjQvk/chFJS6ARhZ1ays5Fetp?= =?us-ascii?Q?ED5F5j+AAhN87qvPO4uNACZJTI8JbikwoWDjpnAyxx8ZfanYXC0Ul39zxX1i?= =?us-ascii?Q?UhP2AuwGwiPVqQ7hf8Yt/4NI3lpdohHb0yhEPq9ufkOVo+o6wk6XNWjNyd6A?= =?us-ascii?Q?SRB08zAIAlgGoq4UTe8hjbqJCYbLt7rNMC0TQ1wFEgOVitCVGu0qIgrMSvU6?= =?us-ascii?Q?bZZy2lxF4Ix5DrJY4YBHjJou2dWdE4w3qFeh4BdIZEA5rtbcyowfN2VzPBCG?= =?us-ascii?Q?TvUs43UiryigqwOBjxBOAJZpPg8hNX4r6X5E1wfxg0T1bHa9BerwvhdGywK7?= =?us-ascii?Q?IbOgeXqynd72sv/62cGA8s4x+iH6M3H5To99tG/EHCknvtQiIW+GqwQ8Vt1M?= =?us-ascii?Q?/uvFaSl4CCO7TA9I+tP/YxqNfRIpvmPmY861XXH9kd4C7pvD21ImrJGSkvTm?= =?us-ascii?Q?stOOMOS/05ix0bi3uB8TAfjxfpw7wlvp3QmAgqjWNQQae0TuWqfaJGsTLLwU?= =?us-ascii?Q?XFB9MYjNk8E0X3uSQXWp79m0uIS0QELwNheoUPunu4ecEbvV3PQl3zb7xprQ?= =?us-ascii?Q?oN54upUnHQij/CUKUKiNK355IgSU8Ppi8zer0y2QdK3aYbMpGdrf+aj3ImGc?= =?us-ascii?Q?MCrZU/JpDAMaL14VC5QTATvVFJMCAJCs414ayWgmHRctUT3bDXyamd0pCkQc?= =?us-ascii?Q?zlCv/f4ssAfpPhSeSNySUZMHibo30olhVvIl63vK7gWc9llWzEoVvqSxlkWe?= =?us-ascii?Q?if4uEtDr1eiuMHulSMh7z4topHPtqj8GSpFoCM57rfuyp3Ai8956TmPMU6r+?= =?us-ascii?Q?KLWVNDEMubyShgqf9PHZLFAD/FhpfgXf0fzA9gam?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 553bdc45-f17a-4184-1368-08db582afeda X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 05:36:29.0098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eq4D8evAr2rIJm1a5vBMdkiD6gxHwdDNmcioMyt96bL+HNfQKuMsyB98IX1Nfj+q6/3dFzYkyeCqO6UK/PXb8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7562 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, Mingxia > Sent: Monday, April 24, 2023 4:50 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH 03/10] common/idpf: support queue groups add/delete >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Friday, April 21, 2023 2:51 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > > > > Subject: [PATCH 03/10] common/idpf: support queue groups add/delete > > > > From: Beilei Xing > > > > This patch adds queue group add/delete virtual channel support. > > > > Signed-off-by: Mingxia Liu > > Signed-off-by: Beilei Xing > > --- > > drivers/common/idpf/idpf_common_virtchnl.c | 66 > > ++++++++++++++++++++++ > > drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ > > drivers/common/idpf/version.map | 2 + > > 3 files changed, 77 insertions(+) > > > > diff --git a/drivers/common/idpf/idpf_common_virtchnl.c > > b/drivers/common/idpf/idpf_common_virtchnl.c > > index a4e129062e..76a658bb26 100644 > > --- a/drivers/common/idpf/idpf_common_virtchnl.c > > +++ b/drivers/common/idpf/idpf_common_virtchnl.c > > @@ -359,6 +359,72 @@ idpf_vc_vport_destroy(struct idpf_vport *vport) > > return err; > > } > > > > +int > > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > > + struct virtchnl2_add_queue_groups > > *ptp_queue_grps_info, > > + uint8_t *ptp_queue_grps_out) > [Liu, Mingxia] Better to unify the abbreviation of "port to port" , this = patch ptp > is used, in the next patch p2p is used. Yes, it's refined in v2 patch. > > +{ > > + struct idpf_adapter *adapter =3D vport->adapter; > > + struct idpf_cmd_info args; > > + int size, qg_info_size; > > + int err =3D -1; > > + > > + size =3D sizeof(*ptp_queue_grps_info) + > > + (ptp_queue_grps_info->qg_info.num_queue_groups - 1) * > > + sizeof(struct virtchnl2_queue_group_info); > > + > > + memset(&args, 0, sizeof(args)); > > + args.ops =3D VIRTCHNL2_OP_ADD_QUEUE_GROUPS; > > + args.in_args =3D (uint8_t *)ptp_queue_grps_info; > > + args.in_args_size =3D size; > > + args.out_buffer =3D adapter->mbx_resp; > > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > > + > > + err =3D idpf_vc_cmd_execute(adapter, &args); > > + if (err !=3D 0) { > > + DRV_LOG(ERR, > > + "Failed to execute command of > > VIRTCHNL2_OP_ADD_QUEUE_GROUPS"); > > + return err; > > + } > > + > > + rte_memcpy(ptp_queue_grps_out, args.out_buffer, > > IDPF_DFLT_MBX_BUF_SIZE); > > + return 0; > > +} > > + > > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > > + uint16_t num_q_grps, > > + struct virtchnl2_queue_group_id *qg_ids) { > > + struct idpf_adapter *adapter =3D vport->adapter; > > + struct virtchnl2_delete_queue_groups *vc_del_q_grps; > > + struct idpf_cmd_info args; > > + int size; > > + int err; > > + > > + size =3D sizeof(*vc_del_q_grps) + > > + (num_q_grps - 1) * sizeof(struct virtchnl2_queue_group_id); > > + vc_del_q_grps =3D rte_zmalloc("vc_del_q_grps", size, 0); > > + > > + vc_del_q_grps->vport_id =3D vport->vport_id; > > + vc_del_q_grps->num_queue_groups =3D num_q_grps; > > + memcpy(vc_del_q_grps->qg_ids, qg_ids, > > + num_q_grps * sizeof(struct virtchnl2_queue_group_id)); > > + > > + memset(&args, 0, sizeof(args)); > > + args.ops =3D VIRTCHNL2_OP_DEL_QUEUE_GROUPS; > > + args.in_args =3D (uint8_t *)vc_del_q_grps; > > + args.in_args_size =3D size; > > + args.out_buffer =3D adapter->mbx_resp; > > + args.out_size =3D IDPF_DFLT_MBX_BUF_SIZE; > > + > > + err =3D idpf_vc_cmd_execute(adapter, &args); > > + if (err !=3D 0) > > + DRV_LOG(ERR, "Failed to execute command of > > +VIRTCHNL2_OP_DEL_QUEUE_GROUPS"); > > + > > + rte_free(vc_del_q_grps); > > + return err; > > +} > > + > > int > > idpf_vc_rss_key_set(struct idpf_vport *vport) { diff --git > > a/drivers/common/idpf/idpf_common_virtchnl.h > > b/drivers/common/idpf/idpf_common_virtchnl.h > > index d479d93c8e..bf1d014c8d 100644 > > --- a/drivers/common/idpf/idpf_common_virtchnl.h > > +++ b/drivers/common/idpf/idpf_common_virtchnl.h > > @@ -64,4 +64,13 @@ int idpf_vc_ctlq_recv(struct idpf_ctlq_info *cq, > > u16 *num_q_msg, __rte_internal int idpf_vc_ctlq_post_rx_buffs(struct > > idpf_hw *hw, struct idpf_ctlq_info *cq, > > u16 *buff_count, struct idpf_dma_mem **buffs); > > +__rte_internal > > +int idpf_vc_queue_grps_del(struct idpf_vport *vport, > > + uint16_t num_q_grps, > > + struct virtchnl2_queue_group_id *qg_ids); > > __rte_internal int > > +idpf_vc_queue_grps_add(struct idpf_vport *vport, > > + struct virtchnl2_add_queue_groups > > *ptp_queue_grps_info, > > + uint8_t *ptp_queue_grps_out); > > #endif /* _IDPF_COMMON_VIRTCHNL_H_ */ diff --git > > a/drivers/common/idpf/version.map b/drivers/common/idpf/version.map > > index 7076759024..aa67f7ee27 > > 100644 > > --- a/drivers/common/idpf/version.map > > +++ b/drivers/common/idpf/version.map > > @@ -48,6 +48,8 @@ INTERNAL { > > idpf_vc_irq_map_unmap_config; > > idpf_vc_one_msg_read; > > idpf_vc_ptype_info_query; > > + idpf_vc_queue_grps_add; > > + idpf_vc_queue_grps_del; > > idpf_vc_queue_switch; > > idpf_vc_queues_ena_dis; > > idpf_vc_rss_hash_get; > > -- > > 2.26.2