From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AD3C4263E; Tue, 26 Sep 2023 08:00:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 369D5406FF; Tue, 26 Sep 2023 08:00:41 +0200 (CEST) Received: from mgamail.intel.com (unknown [198.175.65.61]) by mails.dpdk.org (Postfix) with ESMTP id DE37C406FF for ; Tue, 26 Sep 2023 08:00:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695708030; x=1727244030; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ROHb328LUaGqd0sKk5FcSLi11cvHSbbukpJkCQ1iOAA=; b=Nxu8L49k/bKY4nqy9MZSRZ6NNx3/QbqvylEXLk1mK0oT/d0TyFbR6Uab Pqm6wja1LAwHXWSmAMfkguG9F1ohV7yyV5NxokRAfE0yADat0VFzAMcZJ OqyxHZ5x84kENoLyTc1p43jFw3QYeEOzK0Ci2oZh9Y8L/mIYJpx/69eVh QWgOWV91QY8IbPVEmfHWf8PJaxKd/bey1FtTgOsgzfMdI0zGsuZMsnGyg NIn3wA+ESkyJbgGO/GqZyVJBXXo1+HjL03wr/rwR0LFqvaRAaVgV31JUA lCs1wB0eJBJ7vN7dOrdDGg163fE4sGjh7Fih4A2X4fnsx/fQCzckJ7h7L g==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="138849" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="138849" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 23:00:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="814349272" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="814349272" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Sep 2023 23:00:27 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 25 Sep 2023 23:00:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 25 Sep 2023 23:00:27 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 25 Sep 2023 23:00:27 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 25 Sep 2023 23:00:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvIMWSJ3pwBq21Ow7+p0wM5A/jvRqg0rvV9cQ1Y5fcaCmi0pu42dyVXFb7jlcfjKJWALm8IV6GZ4S/BRnuBlTdskriSu3irSax2dKSsFyiK5M9FkaWujNbXXWnwaeEHK2di3l3MZWNUSf7FIJwOslkw4G6+DV3c2x+OTINmeEtPgZrqRA3uUVt8xJrzAF6sfp8DWnwmUAG58sPY2XvRgXZ3wfAVUI179ch8XTlGsbSkQ1hy5GMwnl33TSclSgIpA+VyOkqIX+Pij34H8awXBWtvm0WXkqVM8Ucnw3nIK/wP8d6KWF0Cvfjdtmo/FfSpGLceDjesUHZgbigHEnNM5qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTDBjHN+3rSG+EANLIhGycAjFWFt2k6uonESF/ODhdk=; b=ie074R0ImEPD+9YKhs0mHvAZn6OqiHbTGJDARLK+lgNqc5+Myo+J5f/nMHXPmJpLSYuKGkLY4W3/zgLOyk8ytXM70TSeWnA5pNNQ6fTu4AcxIKunUbKtI9kjffo4ioFidNOSPnnpVu4jiFtjm5MdRwVA81bJ6elT2I5JmmPS2eRuMRFMi2Xwv6RbHD5pHSDrCAh6woQfIjdUp7Ta8Isa5/dPBbuTv1PuKVMPeTBsYDj8K2ayq6cJP4v6NoRpdu82NNB66EI6zBUmFrJpxbRymUAN/0RMAUTFEZ7mRDcduGHV+vEd++u0o8rhTgNSAXoydht2h49G873bV1z5SmWMlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by IA1PR11MB8176.namprd11.prod.outlook.com (2603:10b6:208:452::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Tue, 26 Sep 2023 06:00:25 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::f14c:380b:cbbf:a014%4]) with mapi id 15.20.6813.017; Tue, 26 Sep 2023 06:00:25 +0000 From: "Xing, Beilei" To: "Wu, Wenjun1" , "dev@dpdk.org" , "Zhang, Yuying" , "Zhang, Qi Z" Subject: RE: [PATCH v3] net/cpfl: fix datapath function configuration Thread-Topic: [PATCH v3] net/cpfl: fix datapath function configuration Thread-Index: AQHZ8D6KSR1QZyBinU2w+fdf9siQ6LAsnOvQ Date: Tue, 26 Sep 2023 06:00:25 +0000 Message-ID: References: <20230919083237.171374-1-wenjun1.wu@intel.com> <20230926060455.18614-1-wenjun1.wu@intel.com> In-Reply-To: <20230926060455.18614-1-wenjun1.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|IA1PR11MB8176:EE_ x-ms-office365-filtering-correlation-id: 2f433f2a-221d-407c-d5b1-08dbbe55e079 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: guTNpKXcsltyEa0m5Oek+FPeo/rATrk9L9HntRfLZ+Q0B4zCoUEokRWhlOf7aN/D06+eYaX3KAjsfKchfSnhixg7b4Wtvaz2mcdTbDoAFK8ZYvbDW32SrRKmx+HDTf1pwHlJh4j4g648tZBFLt5FGPV0X1RwCCD1bsN/7/Kvcau+6VXEV1rzJkYpnSEKysS+udSyH3X1DDuSf/gpLsxQW39oJCKtplObjoWICvxP+nPZYOKrGl3ZgKFfR8BM+qDvZgIfxU/fIMcVoJ45h8fePv2FJ0o9KlS9QWfMefQJ2ewppQgIKvMpUajdUKr3PKSsliQ92bNSu+bdpawMPOASxzbfDvACy4m4yKzZi+FipBo5N/wkusOtBLypvgy3OjdGsWUMxmdE7bvec1Ro70rnbEfuUPyYlQUbDk3qmZxTVAr31/BmiXHSNXPEyxnvJSkLQfbZehzL+wtJJSROLp3MWv2791o0hNgrWowpWPQGSmNG/g116l0VSNpLPDzgz0xJF/EsU+6AHZfEiSZJXCyS71Du0cVlfFBRcxH5Wqz+AOrx7x1cgxtno0elbSDiuO3zzOB7NALupkELTvW2cMhYZYwURLNdrVbcYVcDbedYMDAd7nWhpOX99373tkX15VjR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(39860400002)(376002)(366004)(136003)(230922051799003)(1800799009)(451199024)(186009)(2906002)(66476007)(110136005)(5660300002)(66446008)(66556008)(64756008)(52536014)(76116006)(66946007)(478600001)(71200400001)(9686003)(6506007)(7696005)(53546011)(26005)(8936002)(6636002)(41300700001)(316002)(8676002)(122000001)(83380400001)(82960400001)(38070700005)(86362001)(38100700002)(55016003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QpIalAZlCciL9P/JVbg6sHmQ6vAa1319h8/zL49SWMsNZ/iSS6qxjBxx7Op6?= =?us-ascii?Q?CH8tYNWGsLT5+q4zcHNYtyKEc10nCa+KETMCqGN5naoipdI7cTkPMSiXAwxe?= =?us-ascii?Q?3L6Emso9epBqpx3/EXmtVGOPbAJfjI+/0K6/bTUO9wv+s41Gl2JG8llimSNv?= =?us-ascii?Q?N09ChGzlSdzw/gPsBh+Z6Tlt46bFai0ohbKuBSe4gAdeP+qx5AORtrgD01qx?= =?us-ascii?Q?d+YNPco41JjmsHrAXE2Tf8+cs7SjWOqfWQFIKg+Y6Q8YkIZN3RBuYC6p977T?= =?us-ascii?Q?KpadOpkD/aVoU9I5eV1SMQr2xRs4ZfgPzsOGShHLZTpZkFJR9xjcHf/yFJLx?= =?us-ascii?Q?x96fd3m3YWpRDSuZ241QhAjo8Zaxw+UE5pnlYaRpgqbZ098GRIqE6j6KX8RL?= =?us-ascii?Q?LpamAUwhxbXV5NOWSP+rt7tLKsLEjqZXWeODxLIMkbpSqGP79ZiSSJZI0Phe?= =?us-ascii?Q?vOwaCxLexTMuUceWt7GiC7CetyLSp8WiUtLo6fy3TDiLcIg6dJq9ugql1BAq?= =?us-ascii?Q?M84pbrfbXWJOk4qyESE6zmdU8exI8DPTpw8rDESBEcmuTKPT/5MXd4k192g3?= =?us-ascii?Q?agbsLk4HQ8/llfG76ASx3jTqDQ9aD8tGwPxKf1PuWiaKfcbXY3WLr3X/2xuL?= =?us-ascii?Q?EhiHaqRBgJtxseNRap40IjCyCqTKBrjBkAUxBDmOrsUvp5ZKhYwaSy6wQz25?= =?us-ascii?Q?H0JqJobXzyyPbrsFy0u2tgptOStqwB1bmmwkBa42hXw8rdtcef5/ULIEu2l+?= =?us-ascii?Q?8oBeumBlZ/xrkyqYzMhMBRQXoeDo9kRUD8VYNySHcsKhTaAVVoRTlXe7sPEd?= =?us-ascii?Q?+FkL3vg6GvZgAJH5/7HxZ/BG8X1Gx6EZgCEcrQmu1kzjnWLlJsUdDv0MjmHg?= =?us-ascii?Q?ueIzK8OyIUdImYtRdd/JtBYIC6KzIrCA5fidshs5rgo2scE6l6nwzMfJnKgZ?= =?us-ascii?Q?t/mUz1iWsdh+gfCJ/6/j2S2bGlqFB2UE7VvH5yjpCrFz5z9gnlfuJpwEyoOJ?= =?us-ascii?Q?CWDtMwzZOlwGfb2AJaL2mIc5vvMR4ANlTM4w8akDycaygQadDd2rbhqC//hO?= =?us-ascii?Q?z47I7TkWSrYwm8ZIh4Ji076x1TuEtNYYluHDA1xMAyEwPzArECSx8W1MBHpq?= =?us-ascii?Q?HAu6v7fafBoKQNbntuYkdw1bOoOV1hGtMWJqhdKtHT1qvtAKO7V3om/VhNqO?= =?us-ascii?Q?+JJ0LPcnZlWEJNrlUaUzKnAnAHbcwYKY50J+478FOUF4vRBNVskz+p6tQ/YE?= =?us-ascii?Q?gxviKGbRne/RRXfItC3wSQq4IwMUlGTC3E6s3Yf4qKwdzVObxgDANVLEWKR8?= =?us-ascii?Q?QfIB0zYhzAqY0moCrl2wtS71l03bPOM3sUDsX5bzy1Is2rTiKVHPjP7cT4vk?= =?us-ascii?Q?Zk1nk/FaKAQGRWB5tW1tlHRIBV7l2qLn/fqRI3L7UCez0Xl92ZueL1J5YytO?= =?us-ascii?Q?pi24ifAZUNOYh89jdf9/Qgau/QW9RjwnugNc30s8jzvqDW6AHkxi4xhNSdjf?= =?us-ascii?Q?ZpTEiw+juNsIfo+YYvdvG/HRteWvq2eIYe0cZ9JxCTLEu5wdDaeoO+tsjOjO?= =?us-ascii?Q?i0Fae39A1Mr4TiE6jkJEfjPpxEsM/Wco9mhw4jTH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f433f2a-221d-407c-d5b1-08dbbe55e079 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 06:00:25.0258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BxOcs9e7/jRrmN5DyYtTqm1zBVTr8U4Cz6RWp7oFyN67i5QNt/Pv8jDT84ew/1YTrWybUPcxvr3ydj+Zqp9bQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8176 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Wenjun1 > Sent: Tuesday, September 26, 2023 2:05 PM > To: dev@dpdk.org; Zhang, Yuying ; Xing, Beilei > ; Zhang, Qi Z > Cc: Wu, Wenjun1 > Subject: [PATCH v3] net/cpfl: fix datapath function configuration >=20 > Vector datapath does not support any advanced features for now, so disabl= e > vector path if TX checksum offload or RX scatter is enabled. >=20 > Fixes: 2f39845891e6 ("net/cpfl: add AVX512 data path for single queue > model") >=20 > Signed-off-by: Wenjun Wu >=20 > --- > v3: fix log typo. > v2: disable vector path for scatter cases. > --- > drivers/net/cpfl/cpfl_rxtx_vec_common.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/cpfl/cpfl_rxtx_vec_common.h > b/drivers/net/cpfl/cpfl_rxtx_vec_common.h > index d8e9191196..479e1ddcb9 100644 > --- a/drivers/net/cpfl/cpfl_rxtx_vec_common.h > +++ b/drivers/net/cpfl/cpfl_rxtx_vec_common.h > @@ -25,7 +25,11 @@ > RTE_ETH_RX_OFFLOAD_TIMESTAMP) > #define CPFL_TX_NO_VECTOR_FLAGS ( \ > RTE_ETH_TX_OFFLOAD_TCP_TSO | \ > - RTE_ETH_TX_OFFLOAD_MULTI_SEGS) > + RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ > + RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \ > + RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \ > + RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \ > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM) >=20 > static inline int > cpfl_rx_vec_queue_default(struct idpf_rx_queue *rxq) @@ -81,6 +85,9 @@ > cpfl_rx_vec_dev_check_default(struct rte_eth_dev *dev) > struct cpfl_rx_queue *cpfl_rxq; > int i, default_ret, splitq_ret, ret =3D CPFL_SCALAR_PATH; >=20 > + if (dev->data->scattered_rx) > + return CPFL_SCALAR_PATH; > + > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > cpfl_rxq =3D dev->data->rx_queues[i]; > default_ret =3D cpfl_rx_vec_queue_default(&cpfl_rxq->base); > -- > 2.34.1 Acked-by: Beilei Xing