From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 926A441BE7; Mon, 6 Feb 2023 07:16:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77FE942686; Mon, 6 Feb 2023 07:16:52 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7A14C40A7D for ; Mon, 6 Feb 2023 07:16:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675664210; x=1707200210; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1rgbTWAk5jPWa/IZgzTadBp7OT7fKIX9Lu1Nj/YPYN4=; b=YnovKluA7tMcmm5iPP8uYFVypzAa2FU3YcEkrY0CUbR6o7uK8QmJZT91 v9zkfbK/6WKjL5gDA3B7azCD+fQpgOdd2Budl3EFgpMGiRRty8nxHWBN2 LEwn8Ik+cZt5ZPocvh7OeDJmfDxNHZcyXASY13mBuJkt6uzEp+w+mXw9N B7Gwz3MX/HH09C5MBs9JoXanDweFEDb+xF/cOiaEejiUIN+DSBgHSWi3q Eat09MR6IV8g9T5UWq6LbJu+pV40jh1ZkApiuYRu/UePM3LYuAVVfely0 7DUJhnnXiEOdCSmuYkXcvasVXk1ylWy8pDKDq4e+NkMjAkMzaWxe6sLyJ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="308781033" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="308781033" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 22:16:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="735005931" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="735005931" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 05 Feb 2023 22:16:49 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 5 Feb 2023 22:16:49 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 5 Feb 2023 22:16:48 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 5 Feb 2023 22:16:48 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 5 Feb 2023 22:16:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmOgnXi0xWH8FHp8DFTjdi9OgUr+Ukl9C9eAE15wXeiEUKfALq2XGWQD7Km5W9ReuBu//UkUdvdywBpui6xVtuUQVvNJLc5KHoSGYwB/sPl8IH5SY1KYECvJ8hfKzTvxPacNLrZSnoCUGsyJGbjOiz6m7WETUf4dE4+UFJN3MhH8AuMXhsjUqfBcIF06u+OJySHrVfb7WAl+DwS69i5+fsIv+t9KKwiapSr4ARfyq27eXshMGKsJ6wOGS7yqwzwRgg6VUu/ITIqwM9cxWQYDWvRNCWVHEkQzhzbct+bwA13NDHprjfhXgjVTfH/Ui/xs+ouRdXZBAVl7pMJKxgo+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mp467xiqORZQPQHBOcGyhfGPQe9464uxQM6qD+ptjJQ=; b=nPciZ2vIN2A4HmvfJTUuH8XNOjHcs0lCgDbv+6wYOa4dT2VzHaArFNRJrWF9oKbCDD0JclNCxV8fzLVNAbVIHEslc4LPgBwKv0mqxH0P+EZNYqy5j2yb10gTZv2KhjrNOlthCxw1O4OEictbBhR0e+9+iTyvNbPSpR2wKFxC+fVmk0gyHlmQUgK3m3cb+ih5uFByjPi7/eow7I9oCFfqvS+J6Re2vK6KYPql4OctjeUvc0aye48oQsyiNHtXsmEGdbfvJds2Wvj+pA6SAEd5iyp83O6+/630ROUSMo15t8iN8KlWQL+nS0DRarhODgE5RbjdmHBRskLaKhMN2OmMVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by SA1PR11MB5923.namprd11.prod.outlook.com (2603:10b6:806:23a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 06:16:44 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377%9]) with mapi id 15.20.6064.032; Mon, 6 Feb 2023 06:16:44 +0000 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle Thread-Topic: [PATCH v6 00/19] net/idpf: introduce idpf common modle Thread-Index: AQHZN7e7v5ESw5B5C0KH8kbLAn2Z2K7BPmcAgAA3OFA= Date: Mon, 6 Feb 2023 06:16:44 +0000 Message-ID: References: <20230202095357.37929-1-beilei.xing@intel.com> <20230203094340.8103-1-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|SA1PR11MB5923:EE_ x-ms-office365-filtering-correlation-id: 70207f52-2b32-49f6-4160-08db0809b896 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AaS5l74pUHpAwy8oxvKavrSHV0noFTAiAj/Yrs+FcSN6/GGgXngbrilPtNygBrbN2y2FHFfhxV0vzpWoZySYX8Dtk8sLT3Icx7CDOMSs5LZGhFSCF2zKe5TrlCfFA89S7lnPEUVvAIbaUm0MrR0+RgyZVWuYaepksAWsni000d1TakS9FotE+UTL7DKeuS8pKs6Q2nSdF5vV7z4WCZEbu4MTM7TX710/NyigqJyVp3tggB5jMtiuSNqHaqlvvLjqZsgo5YHvWLjuwfR5BLaLVEYLU6mcLQU8qtxG5LXQ6DGOEfEluvQ0cM9dBuyJJXDyr04xP3zUV+QYWycpAiTeqCUp12dbi6A890HctGME5dQfQWvyd6Bjdxc54ut8xQ0rJ4z6g/y3Pu/HKGurhHD0Jxc+ON7i958Oqy2VIFrgVifuh7FWlASriUISoYJBEJmn9aIX/fTWEpn8euyWqmMqWrIQ2Hz8YYxFamDJgF4vg4OPoPd0Kdbn4ZraSDOTBy09ZUMhrKG6gzs49XxINp0WLLzJAcnKUm8kQtFLDAG9DNPswYFsN2dCwsyKDRDqOQU3I3qBu3ub20xjyk8IKSyZjT56ZYd7ygrLrillGN+I+X3qf3Mhpil0CAQMq3noJKBhzJhlGjmT1g28ZP3PIIuXdyxEDtr0alabgpyZPuUiZuY1ooQ+oRO5a1y+EdDP9mh2OCNhtKqz2XfGZhvZebFpVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(376002)(346002)(136003)(39860400002)(396003)(451199018)(66476007)(8676002)(66556008)(64756008)(76116006)(66946007)(8936002)(66446008)(41300700001)(4326008)(316002)(52536014)(110136005)(6636002)(5660300002)(38070700005)(55016003)(83380400001)(2906002)(71200400001)(33656002)(82960400001)(86362001)(478600001)(9686003)(6506007)(53546011)(26005)(186003)(122000001)(7696005)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?st0BLYHXNseB0tcgJz0MmE8FXUgy77lrNrEl/V3pI7bc4Bo9sBuzXRPqz1WP?= =?us-ascii?Q?dNU+OX8nYWSWgkiaclUhXOW9b6mZIjfDAOrjhSFeGXzIzmOA9B0vDAVsZE3I?= =?us-ascii?Q?gfBiNVmuGWt+GKI8v4HjAvzyHidiA+sBJQZm3HH5dMRH69dtztTUTywLI2IY?= =?us-ascii?Q?0Pn2AIFYY7Ao4qcQ6cQMaUGtStuaaeD1VBi/6jMsNNcyTG8JY7h+bbqgo9jL?= =?us-ascii?Q?ZJzuZ3AtwUpis9vNgfMTMmTC5XDzXrmpwLH2eWaI0NKSHZk1NyusF8IB496F?= =?us-ascii?Q?EiLIuc69jPeBX0tDBIL0XgFQRYiG6z+H+4sZqC6pdU86SMqpI0jlkqU25DBr?= =?us-ascii?Q?T/okPfUghmCydwJVquTvHOVsmwvGC7jD80XqM3GVOHKA/g/xFc+OUDlhVoke?= =?us-ascii?Q?iYiqNq5mOhevVCJa/rkTpyJyDZxi6G06PA/f5ua2TJmjL3jqSwIEWhBEX2A7?= =?us-ascii?Q?EdnY0FjmcTI8rnBUNmExASV0of01md9rqwRN1An74L4dDJMrcK+jCGsv52Jy?= =?us-ascii?Q?CTl/QJZMqNjyLyDDU0PRS5sr+wFsGWMxpL8ZFaF3vzloHt+wyrSsBGnVJ3HN?= =?us-ascii?Q?3xw4tkgpa/0jl1YeO3aqTWar5plJWh/5NkWUDH8XPedghjbX63Us+n9BN8zr?= =?us-ascii?Q?ITuVEhvlNX/tkRzScV1ACGSfUM5vInVgBj7nt8GmOzSf7gEogh0Hqp89lQHk?= =?us-ascii?Q?6YK44NjYMXrS+mi94RCFUA4yuXSxBbrHi5gK02TdifAM3bB5YvJW7FDo78oD?= =?us-ascii?Q?ZcEh849BsD9wNPurmVrB3alqcSPhDvuw3GsI1WjZRZUj1YHu8ti7r9Df1zoH?= =?us-ascii?Q?yTb540C+gtJK2abzClzHBF6Y3tXtY6egEKUd+50Cx3N+ZYhR9rUwFHfhBM+V?= =?us-ascii?Q?QuPhcaSfkh1s/zB20MuYe576v4UMBwxv+/S7zeRrbGK3/6RdEUuuXA6Ak/Vq?= =?us-ascii?Q?eqYyVc/iTqu028BXH3FvRx28QkhBSbCYnxx89wloO6wjRFnrcumHAJHwZzrH?= =?us-ascii?Q?BDfcrCoKwVmIVxHMCOYn0n7U4sESuacEywTamTCZZkCvSVmdrE7u8vba8w87?= =?us-ascii?Q?OF4m1iGPNbklgGnPi6c20WHdvgsqFPuuDq6DggB/bDe+uczqtQkbBZnvJMm5?= =?us-ascii?Q?sR1PFGgZz+P9lTVWx6IybIj1LWQGPhVBd7rvynSFS1xqcsSICaJiEPWVLInR?= =?us-ascii?Q?W0qSmOcESg5nIQ0LXsuJgs+EivYqklhV6WHUxMvkJYgzVl+A6/cUBEoYQOs4?= =?us-ascii?Q?kFZmyn2l/TcB4pp32o0b2XENH5zc+rDxTwx2sYKfc6wZz0jGoPk8pGT7Dhjs?= =?us-ascii?Q?QC8ODUth5yCNxdb3oQK6rHfJ6RhjFVNe5qsd0HaLzyc5s7Y0DFqh0v3+wySV?= =?us-ascii?Q?VAnCee3ISnb9BxxIMp2KlhenEVdqbkQ7XnhX2M/thMy7tPcF9SWtRha/3FSE?= =?us-ascii?Q?Gqg1nqCp45QFtCYRSyZUzZZ2SSQpPlZ8M5Fnf6jZjGrO26/Xc5KGM9YRHfXk?= =?us-ascii?Q?XlC4rUkZSzodOjhQswnGK+W9R5/ZIOVXylMTt2Oams5mULONRQBINbbGTovy?= =?us-ascii?Q?FlPWQRr+mWScW7ErPqhrl00tdm20EuoIN25tER5r?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70207f52-2b32-49f6-4160-08db0809b896 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 06:16:44.7001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uid8o+ljXJ25GsvgiHikk62nUKie/+21NlmG/FCYuFRV2o02Ym9k8Ft8eOF4ufBvfXqimLdJ/UDNeYEIPr71YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5923 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, February 6, 2023 10:59 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Friday, February 3, 2023 5:43 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > > > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > > > From: Beilei Xing > > > > Refactor idpf pmd by introducing idpf common module, which will be > > also consumed by a new PMD - CPFL (Control Plane Function Library) PMD. > > > > v2 changes: > > - Refine irq map/unmap functions. > > - Fix cross compile issue. > > v3 changes: > > - Embed vport_info field into the vport structure. > > - Refine APIs' name and order in version.map. > > - Refine commit log. > > v4 changes: > > - Refine commit log. > > v5 changes: > > - Refine version.map. > > - Fix typo. > > - Return error log. > > v6 changes: > > - Refine API name in common module. > > > > Beilei Xing (19): > > common/idpf: add adapter structure > > common/idpf: add vport structure > > common/idpf: add virtual channel functions > > common/idpf: introduce adapter init and deinit > > common/idpf: add vport init/deinit > > common/idpf: add config RSS > > common/idpf: add irq map/unmap > > common/idpf: support get packet type > > common/idpf: add vport info initialization > > common/idpf: add vector flags in vport > > common/idpf: add rxq and txq struct > > common/idpf: add help functions for queue setup and release > > common/idpf: add Rx and Tx data path > > common/idpf: add vec queue setup > > common/idpf: add avx512 for single queue model > > common/idpf: refine API name for vport functions > > common/idpf: refine API name for queue config module > > common/idpf: refine API name for data path module > > common/idpf: refine API name for virtual channel functions > > > > drivers/common/idpf/base/idpf_controlq_api.h | 6 - > > drivers/common/idpf/base/meson.build | 2 +- > > drivers/common/idpf/idpf_common_device.c | 655 +++++ > > drivers/common/idpf/idpf_common_device.h | 195 ++ > > drivers/common/idpf/idpf_common_logs.h | 47 + > > drivers/common/idpf/idpf_common_rxtx.c | 1458 ++++++++++++ > > drivers/common/idpf/idpf_common_rxtx.h | 278 +++ > > .../idpf/idpf_common_rxtx_avx512.c} | 24 +- > > .../idpf/idpf_common_virtchnl.c} | 945 ++------ > > drivers/common/idpf/idpf_common_virtchnl.h | 52 + > > drivers/common/idpf/meson.build | 38 + > > drivers/common/idpf/version.map | 61 +- > > drivers/net/idpf/idpf_ethdev.c | 552 +---- > > drivers/net/idpf/idpf_ethdev.h | 194 +- > > drivers/net/idpf/idpf_logs.h | 24 - > > drivers/net/idpf/idpf_rxtx.c | 2107 +++-------------- > > drivers/net/idpf/idpf_rxtx.h | 253 +- > > drivers/net/idpf/meson.build | 18 - > > 18 files changed, 3442 insertions(+), 3467 deletions(-) create mode > > 100644 drivers/common/idpf/idpf_common_device.c > > create mode 100644 drivers/common/idpf/idpf_common_device.h > > create mode 100644 drivers/common/idpf/idpf_common_logs.h > > create mode 100644 drivers/common/idpf/idpf_common_rxtx.c > > create mode 100644 drivers/common/idpf/idpf_common_rxtx.h > > rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c =3D> > > common/idpf/idpf_common_rxtx_avx512.c} (97%) rename > > drivers/{net/idpf/idpf_vchnl.c =3D> common/idpf/idpf_common_virtchnl.c} > > (52%) create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h > > > > -- > > 2.26.2 >=20 > Overall looks good to me, just couple thing need to fix >=20 > 1. fix copy right date to 2023 > 2. fix some meson build , you can use devtools/check-meson.py to check th= e > warning. Yes, updated in v7. >=20 >=20 >=20