From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B870642375; Mon, 9 Jan 2023 02:34:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B481D40687; Mon, 9 Jan 2023 02:34:42 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1CA3F4067C for ; Mon, 9 Jan 2023 02:34:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673228081; x=1704764081; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oYVlpfmEGIAsS6cDivb5L1iXfgidnBVR4JtgA3izryY=; b=JCeJ8Yzd2BsYNp/QjJRAQ09b14RpYqw+wJ1Zyyn6o3BOVUQ9peaBVmHk K2WDN1YPeZoKsjng/GJ1z1nPEsWtbeEwYbjfypwYOnIaJpav6K1KEHUmN ESjr7gAbLUWEQcI4ni1CJtPiu8LF9GrzsIJC/Bl87B5dlx2Dhhvn/Kgzi Eg0xHK+p6JuFuE/xxajwD9rsYrNUtMvF2CCc2DEkt/D/fZCZ0aEN8HvV2 5t4rHtMg3jmn4mzoA3qyLCEyskcnSoRv5fMOj5ISNYtt0Sn8OwRxsdVJu TgvfDob5qu0xA251xBA0BbW6IPH+p4dJ5ERfoNIy9iMvKbNcZ+43AtAke Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="409023567" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="409023567" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2023 17:34:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="656528657" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="656528657" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 08 Jan 2023 17:34:30 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 8 Jan 2023 17:34:29 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 8 Jan 2023 17:34:29 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 8 Jan 2023 17:34:29 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 8 Jan 2023 17:34:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NX/QWiMaeAYDKgBKMzewjhgoKYVnX3SgSjlyDzoTRE5dH2ucoqmaZqy3qC3hlCo93hiFHsAL99vPJ7Tn/0YHhYd06cKEGgRAOXPYtvKYyZK5wbMVt+bQwkLp57/190wi9MJ7znKkG2IqIl+uRmaHqZPyDgB2sA+qa5Mgc+aQFqttJuYhwNkNz1OTsN5K7DV5ClmnJAjz951iYaalrQtPvXG8nCZX10osJ6YUJkVjaQ/OMs6z6/38zjQrRcvRnsxtfH4d8g9pXybi+r92lg0AhpYNf8yQc8qS2VJjKD6AMr5BTX8NDdpHdiUxrizsgoD55XfdyXN2rwM3Wcnl1KMbIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PdTCThxivB31946qnJze7EKR1rhfZSfza1EDiTbO9AI=; b=OBNreBhljvOWTz8olxrsf7zCUvqK0BOQ18Rt00j1y+QbDWcHB2IN7y39ATJ0feI/l8ZK1+Mml8wg8AMrc3J3008hdXC6M0o/1NrrTwM/LAY19b1VEa9JNq+quuiem6hWdn0GZw8nIr2xYelPuhMFkLWO9+TUMmmivEgOPRIZD47EmyYgB2slkOPHUsJBrknNjTzn60tCQQ9m43VLNAbaHprvMqUKHcOSL6fRQRosll7oD7fEOq7ayvF6h7CjbA/Sn/h4GQWRXmPXXQNhiflx3Lj6LwWobKnfEWmxR/k/AQDaU164wvK72fxLmlW0XsLcIaX/gFmCtrFH9H4LGxSwGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV2PR11MB5997.namprd11.prod.outlook.com (2603:10b6:408:17f::10) by MW5PR11MB5884.namprd11.prod.outlook.com (2603:10b6:303:1a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 01:34:27 +0000 Received: from LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377]) by LV2PR11MB5997.namprd11.prod.outlook.com ([fe80::19ed:7c4b:6f5a:5377%8]) with mapi id 15.20.5944.019; Mon, 9 Jan 2023 01:34:27 +0000 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Wu, Wenjun1" Subject: RE: [PATCH v2 05/15] common/idpf: add vport init/deinit Thread-Topic: [PATCH v2 05/15] common/idpf: add vport init/deinit Thread-Index: AQHZIbLGyER9r4zGcE2w0HZFIzZfXK6UcRWAgADfcTA= Date: Mon, 9 Jan 2023 01:34:27 +0000 Message-ID: References: <20221208075309.37852-1-beilei.xing@intel.com> <20230106091627.13530-1-beilei.xing@intel.com> <20230106091627.13530-6-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV2PR11MB5997:EE_|MW5PR11MB5884:EE_ x-ms-office365-filtering-correlation-id: 92fa5d35-5856-4949-929d-08daf1e1a560 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fqqvQeVXgZgY4VHC3RneTKkB34wemxLFLJKBm9pxb+5A+tfarcHL22YGfHUDB9lLerU1uYDL6epzfcZcQkHdP+CNN8Fd9ZcTuWBWqSJREkZDJXu4pE42txPLMxV4TEbVw2/8aEqvg6hgU+8tCkP6B/bXM7JFEwgOpMA9v9QtPPCIxirA0J2g+Sb9G8+XlzK/v9H7apgD3enR58HVypjkg5TOfaPeZS0K6RJgcomJRJFbriUvjdyc6h+ckg0JHhh/jvxkbB1klnEnew9DLv9toR6q1p5hoF22s6AD3wCJtykJj0PPy+9Pp+rL8dlCdh2L89MGmbhnBiUsQb8I4pGgXx2cWqqhsCdDE4C1vDR/Qhgk1PohZpklSg1FiZgRzWJcc3jSRdjNeCO2kMkshxnasSNWg/NNCRea1i97Qq/bP/f07gN8wMqNRzYNqaKtVMOszC3Gec1Icnf61UnVWsecKBJV1isGSxseD+UkoP5n6+w7uE8Uma7Oci5VNvLwLptWp8VEsst08yoy3cC5buE/oAyGfAQ7enVsBQol95wiEQA7sXuzOodem4VebzT2F2ViUsHoHKYFDJ6IzxjpsdtIoBmjiJX5ofuwYzXhBkeocN3i3eWsZMMgqZkaYYhTaK7LXMC4QJswWb3550P+yM7wc0DYlaMN10V6vA/2lwQ6uvFjD/VEoohGbDnAnNd4HDovQKSrDMT+E5+ZpLyP0mS9NyGnyvE6ZhBp6tilY13qx3U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV2PR11MB5997.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(52536014)(2906002)(8936002)(5660300002)(41300700001)(64756008)(8676002)(66446008)(66946007)(66476007)(76116006)(66556008)(316002)(71200400001)(7696005)(110136005)(6636002)(54906003)(4326008)(33656002)(26005)(6506007)(478600001)(53546011)(9686003)(186003)(55016003)(107886003)(86362001)(83380400001)(82960400001)(38070700005)(122000001)(38100700002)(11706005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GKVOJLpok5uzinIG7Ae4NXNHZa3HvPZhe9Tsq43zEMPKoFgktIEKr9YjsEda?= =?us-ascii?Q?98Ikl4G8ko6f1aQPMiE+YZ4ZyY75owIF7MtIb/e3aKenafnv8o+g2UT/F7Fi?= =?us-ascii?Q?pW7Ot6n1tmqYhr7Bhw4rw7hVafvTKpKAaHElwGrbJ2TWVmFLwOi5hULs+A1m?= =?us-ascii?Q?wKvvNPBH36ENoPcuplqKs0VSxy2kSrVxouDXzARJWCR3xmac2K/nvnvpPT2C?= =?us-ascii?Q?VjaKkZ9LzqeI3OiqBagjjlhCrzjJred0RojgbfspuLIOqAjnosdqBfXR3iXX?= =?us-ascii?Q?r48CpyKvPbBel98mYe9HL3EyghgxipoIlUpGnHl9OJQzb3Q1Zw6ycZ7GHLl7?= =?us-ascii?Q?LMNbaG2x8VFSLfKMdMbhGr3IXcxJT72SgRLDxTz668XYelImCadqF0EltHeh?= =?us-ascii?Q?KAIF+k9LET0zx7xhXuhyiQG8hR7PvNCesz1JTj+WW0Np1LenzUF8eiP4B1gO?= =?us-ascii?Q?Ahxwv1BA+8nJ41lX6PE/ETsa7xtHXENksGEJfSGvWZNp40XpU2SLeRbN2kul?= =?us-ascii?Q?0F4723eeauctAmqPv6qYqxecAM93oJU8dUDr7UHG6NBfNlzy/Lb3Mao76ham?= =?us-ascii?Q?gYMe/R/4035y3uEiS6bg9SeRO9/RPFHMzKClAlbWlAiFz4cpoTDo82erPcoU?= =?us-ascii?Q?zxkXKRHC1PFML9eFJoeRRYWF/Mp6oDjOnlmHzUzK+rdHmzj52QgL3S3u9yLF?= =?us-ascii?Q?fbS075ZkBnv+Jj1TzTQUfWYdq9orCMb3D2IC6+4Nm1JzmDmz/MinGWrjAnZ/?= =?us-ascii?Q?gR0yIucxFARyKPqC8GGqqNEAz5i4qtWZ6r99iMQoHgraL/Z+EHSlo/BLu3kl?= =?us-ascii?Q?pV39a/yl5bKk+5o0zaskzZIJW0nILMukl12aa9XeRTjWOsrHciO0Me1/JBT8?= =?us-ascii?Q?/X6vhMNVmEikqaTkCXDqPXQIfZkbnLQV6GX3oBaqeIuT/FuOGBo1goL6YGQA?= =?us-ascii?Q?SuXmkE1/7mQd+GopOcbiK45ItNKsT5ZP0FGznq2qIIrbOiSB2+k9+57VPYCg?= =?us-ascii?Q?ocmFM4caooi37p95iwZskmlDRdMWoBXljkqavEiVBQiniNH8o+aBzAQlAC3k?= =?us-ascii?Q?pH7RJaW/Tujafyu0IzXz3ZhMOBjStqVKzYRJ+/1RYmt3jMUmBJ1FYVayfaTr?= =?us-ascii?Q?OFCYIv5nEGI3LpiZ7bW3DPjRkKqJC4iimoOPNp0adZ/sH8PDMkBF326/2Mky?= =?us-ascii?Q?W4YG2NjLqFLe/arBTBNQDXqurdSVwd600ArhyRFcCo2MWWx5Y9nvbB7+pdh7?= =?us-ascii?Q?ULNRDre93JE7i3Th2Vo2yrrNy6stSoY+8UjpAqLVdAHor8G1QsXOo2I0EpkX?= =?us-ascii?Q?MaeCtW8HKkAUjFvKkBjp9yyaH7P396FNdrJ41o4pjoeqYe9ENb8GuNNuopfl?= =?us-ascii?Q?BEeQIJiUH11B4vIyjVDjWFhncbMGI3VPgYokTQuVM3kXNJVzZ6GOcKvsKJQx?= =?us-ascii?Q?dM5tUh5852Z1DHAacEoITKvfkdc/xgx2lKnov7AOFRkNkmP1xX240eTJyxCt?= =?us-ascii?Q?FaHiE20n7m/AA2ndRMhbkH59zgvNGUfmPkAV67PW8QJGJgHlj5QeZKORk5Wp?= =?us-ascii?Q?yLDy5BPe4mwIVnhY9AxDsE5xL7RHvnvJexvT1NTu?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV2PR11MB5997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92fa5d35-5856-4949-929d-08daf1e1a560 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 01:34:27.0539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OcNKPHvfIfXleWMZFaTQ+BAR+f+lQzeX+BHjU5voTddGeMdP9krpzGDB3G2WLXgiY/s5Cz5pToVm5OyPyhFuAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5884 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Sunday, January 8, 2023 8:11 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: RE: [PATCH v2 05/15] common/idpf: add vport init/deinit >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Friday, January 6, 2023 5:16 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > ; Wu, Wenjun1 > > Subject: [PATCH v2 05/15] common/idpf: add vport init/deinit > > > > From: Beilei Xing > > > > Add vport init/deinit in common module. > > > > Signed-off-by: Wenjun Wu > > Signed-off-by: Beilei Xing > > --- > > drivers/common/idpf/idpf_common_device.c | 128 > +++++++++++++++++++ > > drivers/common/idpf/idpf_common_device.h | 8 ++ > > drivers/common/idpf/idpf_common_virtchnl.c | 16 +-- > > drivers/common/idpf/idpf_common_virtchnl.h | 2 - > > drivers/common/idpf/version.map | 4 +- > > drivers/net/idpf/idpf_ethdev.c | 138 ++------------------- > > 6 files changed, 156 insertions(+), 140 deletions(-) > > > > diff --git a/drivers/common/idpf/idpf_common_device.c > > b/drivers/common/idpf/idpf_common_device.c > > index b2b42443e4..2aad9bcdd3 100644 > > --- a/drivers/common/idpf/idpf_common_device.c > > +++ b/drivers/common/idpf/idpf_common_device.c > > @@ -158,4 +158,132 @@ idpf_adapter_deinit(struct idpf_adapter > *adapter) > > return 0; > > } > > > > +int > > +idpf_vport_init(struct idpf_vport *vport, > > + struct virtchnl2_create_vport *create_vport_info, > > + void *dev_data) > > +{ > > + struct virtchnl2_create_vport *vport_info; > > + int i, type, ret; > > + > > + vport->vport_info =3D rte_zmalloc(NULL, IDPF_DFLT_MBX_BUF_SIZE, 0); >=20 > Can we embed vport_info structure into the vport structure? > Seems its not necessary to malloc/free the vport_info which always > associated with a vport structure? >=20 =20 Make sense, will update in the next version.