From: "Ye, MingjinX" <mingjinx.ye@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: RE: [PATCH v2 2/2] net/ice: fix updating DCF RSS hash
Date: Thu, 19 Jun 2025 09:40:35 +0000 [thread overview]
Message-ID: <LV3PR11MB8601E26E0C2ED6C7BCD95734E57DA@LV3PR11MB8601.namprd11.prod.outlook.com> (raw)
In-Reply-To: <aFLCCErZ-WYoKQOR@bricha3-mobl1.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Wednesday, June 18, 2025 9:41 PM
> To: Ye, MingjinX <mingjinx.ye@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: Re: [PATCH v2 2/2] net/ice: fix updating DCF RSS hash
>
> On Wed, Jun 18, 2025 at 07:08:44AM +0000, Mingjin Ye wrote:
> > The driver does nothing if the rss key is invalid during the rss hash
> > update.
> >
> > Extract the update rss key code from ice_dcf_dev_rss_hash_update to
> > ice_dcf_set_rss_key and make it consistent with the pf behaviour.
> >
> > Fixes: c223cadc9e5f ("net/ice: support RSS hash configuration in DCF
> > mode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > ---
>
> So just to confirm. The behaviour change here is that, if an empty (zero-
> length) or null key is provided, the function continues to clearing existing RSS,
> rather than just exiting immediately, right?
Yes, this change is referred to other PMD like i40e, iavf.
next prev parent reply other threads:[~2025-06-19 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 9:50 [PATCH] net/ice: fix DCF RSS hash update Mingjin Ye
2025-06-17 2:42 ` Jiale, SongX
2025-06-17 11:33 ` Bruce Richardson
2025-06-18 7:19 ` Ye, MingjinX
2025-06-18 7:08 ` [PATCH v2 1/2] net/ice: fix getting DCF RSS hash Mingjin Ye
2025-06-18 7:08 ` [PATCH v2 2/2] net/ice: fix updating " Mingjin Ye
2025-06-18 13:41 ` Bruce Richardson
2025-06-19 9:40 ` Ye, MingjinX [this message]
2025-06-19 10:38 ` Bruce Richardson
2025-06-18 13:34 ` [PATCH v2 1/2] net/ice: fix getting " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LV3PR11MB8601E26E0C2ED6C7BCD95734E57DA@LV3PR11MB8601.namprd11.prod.outlook.com \
--to=mingjinx.ye@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).