From: "Ye, MingjinX" <mingjinx.ye@intel.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: RE: [PATCH v2 0/3] add frequency adjustment support for PTP
Date: Mon, 23 Sep 2024 02:47:14 +0000 [thread overview]
Message-ID: <LV3PR11MB8601E8D9C2E9C06D670152E5E56F2@LV3PR11MB8601.namprd11.prod.outlook.com> (raw)
In-Reply-To: <7d2918bd-4756-4e38-84c7-300cf908d832@amd.com>
Hi Yigit,
Ok, I will describe the documentation in detail to avoid confusion. Thanks for the review.
Regards,
Mingjin
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Monday, September 23, 2024 3:06 AM
> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [PATCH v2 0/3] add frequency adjustment support for PTP
>
> On 9/10/2024 10:13 AM, Mingjin Ye wrote:
> > [1/3] ethdev: add frequency adjustment API [2/3] net/ice: add
> > frequency adjustment support for PTP [3/3] examples/ptpclient: add
> > frequency adjustment support
> > ---
> > v2: rte_eth_timesync_adjust_freq marked as experimental.
> >
> > Mingjin Ye (3):
> > ethdev: add frequency adjustment API
> > net/ice: add frequency adjustment support for PTP
> > examples/ptpclient: add frequency adjustment support
> >
>
> Hi Mingjin,
>
> Overall OK to have the API, and except from a minor documentation issue
> patch is OK.
>
> Only lets try to make describe it a little more detail, so users and driver
> developers can use is better without confusion.
next prev parent reply other threads:[~2024-09-23 2:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 1:31 [PATCH " Mingjin Ye
2024-09-05 1:31 ` [PATCH 1/3] ethdev: add frequency adjustment API Mingjin Ye
2024-09-05 1:31 ` [PATCH 2/3] net/ice: add frequency adjustment support for PTP Mingjin Ye
2024-09-05 1:31 ` [PATCH 3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye
2024-09-10 9:13 ` [PATCH v2 0/3] add frequency adjustment support for PTP Mingjin Ye
2024-09-10 9:13 ` [PATCH v2 1/3] ethdev: add frequency adjustment API Mingjin Ye
2024-09-22 18:59 ` Ferruh Yigit
2024-09-23 3:11 ` fengchengwen
2024-09-23 6:28 ` Ye, MingjinX
2024-09-10 9:13 ` [PATCH v2 2/3] net/ice: add frequency adjustment support for PTP Mingjin Ye
2024-09-10 9:13 ` [PATCH v2 3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye
2024-09-22 19:06 ` [PATCH v2 0/3] add frequency adjustment support for PTP Ferruh Yigit
2024-09-23 2:47 ` Ye, MingjinX [this message]
2024-09-05 10:26 Mingjin Ye
2024-09-06 5:19 Mingjin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LV3PR11MB8601E8D9C2E9C06D670152E5E56F2@LV3PR11MB8601.namprd11.prod.outlook.com \
--to=mingjinx.ye@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).