From: ZhangTengfei <zypscode@outlook.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, ZhangTengfei <zypscode@outlook.com>
Subject: [dpdk-dev] [PATCH] driver/net/pcap fix: pcap fd leak
Date: Sat, 27 Feb 2021 00:20:29 +0800 [thread overview]
Message-ID: <ME3P282MB166871BA48AF990B7FACBD22D19D9@ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM> (raw)
pcap fd was opend when vdev probed,
but not closed when vdev removed.
This bug appears in dpdk-pdump
Signed-off-by: ZhangTengfei <zypscode@outlook.com>
---
drivers/net/pcap/rte_eth_pcap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 90f5d75ea..fb01ea924 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1597,6 +1597,7 @@ pmd_pcap_remove(struct rte_vdev_device *dev)
if (eth_dev == NULL)
return 0; /* port already released */
+ eth_dev_stop(eth_dev);
eth_dev_close(eth_dev);
rte_eth_dev_release_port(eth_dev);
--
2.26.2
next reply other threads:[~2021-02-26 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:20 ZhangTengfei [this message]
2021-02-26 16:46 ` Ferruh Yigit
2021-02-26 17:47 ` [dpdk-dev] 回复: " 张 杨
2021-03-01 11:40 ` Ferruh Yigit
2021-03-01 15:18 ` Tengfei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ME3P282MB166871BA48AF990B7FACBD22D19D9@ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM \
--to=zypscode@outlook.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).