From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>
Subject: RE: [PATCH v1] net/ice/base: fix ddp pkg loaded failed
Date: Wed, 7 Sep 2022 12:17:10 +0000 [thread overview]
Message-ID: <MN0PR11MB598687B12155B0901EE0FD18D7419@MN0PR11MB5986.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220907091001.68216-1-stevex.yang@intel.com>
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Wednesday, September 7, 2022 5:10 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1] net/ice/base: fix ddp pkg loaded failed
>
> When DDP package state is
> 'ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED',
> it should be treated as success state, otherwise, the wrong state will be used
> within 'ice_load_pkg'.
>
> Fixes: 58e9fd55be0e ("net/ice/base: refactor DDP code")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
> drivers/net/ice/base/ice_ddp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c
> index d1cae48047..284b58a6b1 100644
> --- a/drivers/net/ice/base/ice_ddp.c
> +++ b/drivers/net/ice/base/ice_ddp.c
> @@ -1378,8 +1378,11 @@ enum ice_ddp_state ice_init_pkg(struct ice_hw
> *hw, u8 *buf, u32 len)
> */
> if (!state || state == ICE_DDP_PKG_ALREADY_LOADED) {
> state = ice_get_pkg_info(hw);
> - if (!state)
> + if (!state) {
> state = ice_get_ddp_pkg_state(hw, already_loaded);
> + if (state ==
> ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED)
We can use ice_is_init_pkg_successful to check the return value which also accept ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED and this is expected.
Btw, I didn't notice this patch has been sent before I send another one for the same purpose, this one can be superseded.
> + state = ICE_SUCCESS;
> + }
> }
>
> if (ice_is_init_pkg_successful(state)) {
> --
> 2.25.1
prev parent reply other threads:[~2022-09-07 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 9:10 Steve Yang
2022-09-07 12:17 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR11MB598687B12155B0901EE0FD18D7419@MN0PR11MB5986.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).