From: "Zhang, Helin" <helin.zhang@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Zhang, Yuying" <yuying.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
Dapeng Yu <dapengx.yu@intel.com>,
Wenxuan Wu <wenxuanx.wu@intel.com>
Subject: RE: [PATCH v2] net/i40e: don't check link status on device start
Date: Fri, 13 Jan 2023 13:50:49 +0000 [thread overview]
Message-ID: <MN0PR11MB6087A55E0EA3FABCE807C7DCFDC29@MN0PR11MB6087.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8w8BBGY_nFN8boxeqj++OBfq3yiXoQADexPM=Y77v5iwg@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, January 13, 2023 9:47 PM
> To: Zhang, Helin <helin.zhang@intel.com>
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Mcnamara, John <john.mcnamara@intel.com>;
> dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Dapeng Yu <dapengx.yu@intel.com>; Wenxuan Wu
> <wenxuanx.wu@intel.com>
> Subject: Re: [PATCH v2] net/i40e: don't check link status on device start
>
> On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin <helin.zhang@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand@redhat.com>
> > > Sent: Friday, January 13, 2023 9:33 PM
> > > To: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> > > <beilei.xing@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> > > Cc: dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>; Dapeng Yu <dapengx.yu@intel.com>; Wenxuan
> Wu
> > > <wenxuanx.wu@intel.com>
> > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device
> > > start
> > >
> > > Hello i40e maintainers, John,
> > >
> > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand
> > > <david.marchand@redhat.com> wrote:
> > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand
> > > <david.marchand@redhat.com> wrote:
> > > > > Hi i40e maintainers,
> > > > >
> > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand
> > > > > <david.marchand@redhat.com> wrote:
> > > > > >
> > > > > > The mentioned changes broke existing applications when the
> > > > > > link status of i40e ports is down at the time the port is started.
> > > > > > Revert those changes, the original issue will need a different fix.
> > Hi David
> >
> > Does it break all the application or just a specific application?
>
> I don't see how it would not affect all applications seeing how the original
> patch is dumb.
>
> > We may need to understand the issue you met, and try to fix it later.
>
> Just unplug the cable or fake a link down on your i40e port, start your
> application or port, then plug the cable back.
> The max frame size will never get applied to hw.
Got it, I will forward to a right expert to check. Thank you very much for reaching out to us!
Regards,
Helin
>
>
> --
> David Marchand
next prev parent reply other threads:[~2023-01-13 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 8:59 [PATCH] net/i40e: enable max frame size at port level dapengx.yu
[not found] ` <BYAPR11MB2711AB91F380189FB6AFCC52FE359@BYAPR11MB2711.namprd11.prod.outlook.com>
[not found] ` <BYAPR11MB27110434B9262C0E2BED3AD3FE3A9@BYAPR11MB2711.namprd11.prod.outlook.com>
2022-02-21 9:28 ` Zhang, Peng1X
2022-02-21 10:42 ` Zhang, Peng1X
2022-02-21 11:22 ` Zhang, Qi Z
2022-02-22 9:52 ` Kevin Traynor
2022-12-12 13:53 ` David Marchand
2022-12-12 13:58 ` David Marchand
2022-12-12 14:37 ` [PATCH] net/i40e: drop link check when configuring frame size David Marchand
2022-12-13 9:18 ` [PATCH v2] net/i40e: don't check link status on device start David Marchand
2023-01-03 14:02 ` David Marchand
2023-01-09 9:21 ` David Marchand
2023-01-13 13:33 ` David Marchand
2023-01-13 13:39 ` Zhang, Helin
2023-01-13 13:46 ` David Marchand
2023-01-13 13:50 ` Zhang, Helin [this message]
2023-01-13 13:53 ` David Marchand
2023-01-16 11:02 ` Su, Simei
2023-02-07 11:31 ` Thomas Monjalon
2023-02-07 14:05 ` Su, Simei
2023-03-06 6:53 ` Su, Simei
2023-03-06 11:05 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR11MB6087A55E0EA3FABCE807C7DCFDC29@MN0PR11MB6087.namprd11.prod.outlook.com \
--to=helin.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dapengx.yu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenxuanx.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).