From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4318743B94; Mon, 4 Mar 2024 02:44:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3B2D40273; Mon, 4 Mar 2024 02:44:05 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id EEE884026B for ; Mon, 4 Mar 2024 02:44:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709516644; x=1741052644; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uITuN8KTlJysHvr9NhQ0KarkeSciLzW+iPG3r0TrClU=; b=T6ej5dBRmTV0yKL/q28tJjW4ldRT2+8YQcP0DXIkJG3Qg0goArBaKd6R axmPCC1lkte5hKg5QXyYhZTb6W1fV35oXDfOZAsrLIUxEzQ5L/PIiJh6r moN5gZwlaIhL3Tb/GRdAMp3O1Xn2dIGbJByCyE1hIUYe4886kZMfruMTM 8W00Kmb/fippBDZZeiiiAcVgfcnCTng5xJVLmAWXRoHdwxJJO+Sg0ohZ+ ttsFiR+N8DC05UlJKyq8Eqm0BxhNP07G2pOTcVD5T7SemM0daDv/xK2QW gZlD1yZ9c/NvAHpWZ6kdmT89IWu/oKrDVblz1E+D020drM25HfsWnN7KY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="26456342" X-IronPort-AV: E=Sophos;i="6.06,201,1705392000"; d="scan'208";a="26456342" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2024 17:44:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,201,1705392000"; d="scan'208";a="8889716" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Mar 2024 17:43:51 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 3 Mar 2024 17:43:50 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 3 Mar 2024 17:43:49 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 3 Mar 2024 17:43:49 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 3 Mar 2024 17:43:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lN40qTu7LjUu4JXGoMQSuq+W5WqLQQgGV3wANUtaYuQ1cHYiaBcdHf/Mer9L3kFUEf+vKxRrFiuzni0S/YEq/v+xeqIfXDXHws6tHUkqyaaQB0uOMT9Dz86XZeSRpWDhZ/x91kW/J2T+zb9RN3rFTdQF9815WIGxnu4vtIOR4XmFQIIYO35eKyLBvZQOz7P78P0moGvVYGveDu4Pm2Vnj0fpVkq7lJwh2XPZhZaj9YNEEItsJ6MftJQHJ4kcRxHQqkaG0J1IPq02iJQWapNmRp/KNS5Z8qVAYcOtFE8rmCjbJjOCef2hI5VJ43nf5AVqcJWK7iXoCwOjFzVdzPRS+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNcCMlGw2Ul0eRWXTJpq7zs3ASFtXTGDXCkHOgHUTTQ=; b=cfE8Is/0B5CIbP6H47tvNpkwyv4kspnJVt/7lEw60n2dA3WX8Ktrh2NTu7GC2rpcrtnMJskG2e1OA3zyNouPeKswqocM/8mRZ+AKIxxD2QMwXro9qfc3zPyt05pbRMs6E8gNJMxkgCOggW5p97f0GDnaVHxsEdLl0CHlLrigL8hugQyJdQoTw7gwdcOTy6Xvf+j02Zb4/oKS6hsDXBS5r0OxOLHRJ9BAvClgr5LRWn+UZfgYNdXveWzGoK3XogVHbKnLuFrfaH1PQ7ILJ//vtdm96bFDGSqjNlY9zKCRfylspx/j70Q/Z7KCXaXQXbiAhcyqSMAIxhWbprDpfciUtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6110.namprd11.prod.outlook.com (2603:10b6:208:3ce::19) by MW4PR11MB5800.namprd11.prod.outlook.com (2603:10b6:303:186::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.22; Mon, 4 Mar 2024 01:43:47 +0000 Received: from MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::f74a:5253:54ae:bba]) by MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::f74a:5253:54ae:bba%2]) with mapi id 15.20.7362.019; Mon, 4 Mar 2024 01:43:47 +0000 From: "Ma, WenwuX" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Jiale, SongX" Subject: RE: [PATCH] net/ice: fix null pointer dereferences Thread-Topic: [PATCH] net/ice: fix null pointer dereferences Thread-Index: AQHaa5oOCxKRE2w4FkOGgB9KX2dPe7EisPYAgAQid5A= Date: Mon, 4 Mar 2024 01:43:47 +0000 Message-ID: References: <20240301052029.543989-1-wenwux.ma@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6110:EE_|MW4PR11MB5800:EE_ x-ms-office365-filtering-correlation-id: d0285648-92e3-43a5-11df-08dc3bec891f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fQB9j4Mw7aUEphRaJLKTQeb2BwAjuEpZna8zsk6TmtQteb7WUvieQvmsknaAtEGCAMHuLJh/4K48NO2/gW1Us/HDFoF9068jxy2DFy969UGkyh8Rw+9X6Bh/pprMtPu6ZdpJUzEvoF1ZWIqqWfmEVQt/8t9SIUM/PO/kG5dsly5vQmz+v9oXspWPX6dsagA2rSPvDK2srIG587fLDAptFFscg14RgslRiy8glIVaI4ooKCqU7vfg6Q+VhO376BAEvdGkU3cmCjHFV1LvD+A3Dz9xjuo95YJtTIU6/vjOHd3ibwiKhbq7WnAEjl9RgNuwQqljGUMN759W/XC4Jgvx2nR+fR1sHiRmyoG8T2ye2FdYUo6NNzYXNFomVLfV75eBhY1YCJx+J16hm7+r0m/ksWKWcRy0MAGIYPcZiAuWzFdIn60uIJ9dJuwNjnZ5kzwq2Ch7wuWzuG8NX8Z9x6kUpTF8kPH/nX8vYWmW8Hb8sg4SoF14eywul3ta1qC6YPaJuYTXh7thUhK3qdi1pc7SD5035J4Y82nJ4kHf533Qa7VA/dzlajMSfQ5iU8+9/54oqA1eekYbBOn6wFhVj+Ak2CAjH5tBuu9IffzFUvqq1FehyOhUeBgCYqsv/3e83KDFsdgU7D49O7xMBCOvzeRdimJnohdMUg5WsxEX3We2xRFCwQ72aKlGu91Nc6njWfbC/XGJEYRZoNgNclNnjL2yYw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB6110.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?up27bdrjZL5PNjIQvuFu19HAmj+Z/vdrCEn9yScejRc+5jcNe1+ZZVZp7VQI?= =?us-ascii?Q?Azqm57Uuq5C/h1V8uJAiA87DGRI23SC3nrRTKGYATcLlEwo6xSEzJ5NpY8wV?= =?us-ascii?Q?Rtur1G8bCdGzAuuXICdr8IEIVPHILJcwiGlvT3XXxVUmFg+j8TeUMRrTWd74?= =?us-ascii?Q?cj5JPXQdg/Wnxntwy59FfZpkvK2A8AmzGwlRdZ2A88lVYdobM8sCkDcfAxiV?= =?us-ascii?Q?X0pEHHlB9SjYP2oFGVNIPUHATSIYsYgTdvevqqezNMD8/V3xk4a5VRxh36G0?= =?us-ascii?Q?BHW7lUvzSHQoGa/aLg83QMclQH5EXoRFhGPri0Gnsu2pvmvVBUwpeyLFrv82?= =?us-ascii?Q?6SkhWLqgcHZQnzKXN7Eu8xh16f4EC9019A91WUKq0EbOiHIv8o2xmj8SaY6I?= =?us-ascii?Q?BlRynrrjMZHD9wohpSyLgy2/FyHwmsBjkXtOb1AWprYdPS/EwIm+Ahydvc0X?= =?us-ascii?Q?McrsMIxLgH6K7AcA/2QIItQggDmgHW7RoDyDtxyF+P0qyVE+Vb+2+hXSbzEQ?= =?us-ascii?Q?7HoApfGlenwp8e3GaaKUg8u8A5gnZ7O1loeyyNmnPQGpilON14q/wwBM86Gk?= =?us-ascii?Q?YsKG9qXDM1Wy/kyZJWXUdmcTpCLe/SIFuHg8GQayvx3wB8qulwqqmrZ6jN3d?= =?us-ascii?Q?8OR5EdI+MQAR2vTgXZM78CcS6VO5aHfTmTktPM5sATpHx11QOxHhpr1yCgxP?= =?us-ascii?Q?rkvl8kZz4BYFF3ElMoU9qUz7tjWSOkC2evJ9JNiII4sMZ+xGtdeo0viyAfWA?= =?us-ascii?Q?Uod1ROdPBAx4+fkw5gNuP9sropjb68vJnTwSZ06Llr3TzS8y4LJZB3FjlY1l?= =?us-ascii?Q?RDGKDJpOwbIayOyFruIi3SuvoLDF+fTOJTP9Llcu8LsFOPKqTAxl/88M6Wlt?= =?us-ascii?Q?JahZ1eA1SsNcnQhJ/vbXdVkXnL6YCFGKHzg1X1Tsju6npEL44Vjz3LzxSU1+?= =?us-ascii?Q?CReMg/JDR/eoJj71NEJkh6L/Z27Z5pFRANGMbpby2cXtF9M5LdU1wwQFvnt3?= =?us-ascii?Q?wzsaOpXBIzOO9hkyoyEhvLTIAulRLkBA6pSJ7DddlSutSOFn7fcSe1o3Mn6s?= =?us-ascii?Q?lgFTrRcD5bj6eumObCjsvfQoYLTt1zeS2KvbwbtbZZjngeTvi7JuCUp42Iwk?= =?us-ascii?Q?aFw5vBmadT9o8xExSgt4Gn1nIT7+ErreomPI0YJq9TJfe3H3gKENf/7KipVz?= =?us-ascii?Q?2q6DIAGeqwbvSz9eqIAMnWuw+lalIIu0X1426+CQsZgSVf5hP8PKRsKAhIQf?= =?us-ascii?Q?4M5nJIemwJm5RAX1bQTZ3cKPkMaLZKHJ45npo//3GOJgU7FpUuaYmHsVEYCq?= =?us-ascii?Q?yDZm2Fe9d4cfhdqr84lyw9IyMHzdbZ6wwutfK8JdYwIg+Focxk28aM0j4sQE?= =?us-ascii?Q?l8NYQUZVUxJ7hDobSkFdtDuOgU2A3aPTY/ZlPEJ+Yzce8U5l3rKWzQPZvRJu?= =?us-ascii?Q?g6WDh5GTReiOh9UQViK9bEhVhTNpblDFmHE0G8UvzplyyXq1IJiaM2p1Hb6F?= =?us-ascii?Q?+Otzi91qLyuARcxcANks8aZFmKBbdLbwRWYXQUTGt90xkeXruFiJELn25ogL?= =?us-ascii?Q?bt3Y/1SnyVYq40w10n8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6110.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0285648-92e3-43a5-11df-08dc3bec891f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2024 01:43:47.8361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x3+da3magU4/Wi9CB7Yo8r+Z6wAv+c/WgUWmYLElnlbnDV/FGD0K19gHNNVsU1N5bs/LPnS0On1VpdG1lLFbJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5800 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, March 1, 2024 6:35 PM > To: Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX > Subject: Re: [PATCH] net/ice: fix null pointer dereferences >=20 > On Fri, Mar 01, 2024 at 01:20:29PM +0800, Wenwu Ma wrote: > > This patch fixes two null pointer dereferences detected by coverity > > scan. > > > > Coverity issue: 414096 > > Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") > > > > Signed-off-by: Wenwu Ma > > --- > > drivers/net/ice/ice_tm.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index > > fbab0b8808..e10ac855f9 100644 > > --- a/drivers/net/ice/ice_tm.c > > +++ b/drivers/net/ice/ice_tm.c > > @@ -616,7 +616,10 @@ static int ice_set_node_rate(struct ice_hw *hw, > > ICE_MAX_BW, > > rate); > > if (status) { > > - PMD_DRV_LOG(ERR, "Failed to set max bandwidth for > node %u", tm_node->id); > > + if (tm_node !=3D NULL) > > + PMD_DRV_LOG(ERR, "Failed to set max bandwidth for > node %u", tm_node->id); > > + else > > + PMD_DRV_LOG(ERR, "Failed to set max bandwidth"); > > return -EINVAL; > > } > > > > @@ -630,7 +633,10 @@ static int ice_set_node_rate(struct ice_hw *hw, > > ICE_MIN_BW, > > rate); > > if (status) { > > - PMD_DRV_LOG(ERR, "Failed to set min bandwidth for > node %u", tm_node->id); > > + if (tm_node !=3D NULL) > > + PMD_DRV_LOG(ERR, "Failed to set min bandwidth for > node %u", tm_node->id); > > + else > > + PMD_DRV_LOG(ERR, "Failed to set min bandwidth"); > > return -EINVAL; > > } > > > Hi Wenwu, >=20 > I'm not sure that this is the best fix here, since the error message does= n't seem > particularly useful without the node id. Looking at the code, this is a s= tatic > function, so non-public, and only called in three places in > rte_tm.c: from ice_cfg_hw_node, ice_do_hierarchy_commit and > ice_reset_nolead_nodes. In all three cases, failure of this function is > immediately followed by a more specific error message from the calling > function. Therefore, I think we can solve the coverity problem by just de= leting > the error prints from here completely, and let the callers manage error > reporting. >=20 > What do you think? >=20 Ok, I will submit a new patch later. > /Bruce