From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0448DA00C3; Tue, 20 Sep 2022 10:48:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99F4240DFB; Tue, 20 Sep 2022 10:48:52 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2067.outbound.protection.outlook.com [40.107.100.67]) by mails.dpdk.org (Postfix) with ESMTP id 5827D4069B for ; Tue, 20 Sep 2022 10:48:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnrcyQlTeNtwiiyYxwVlmAsDFr8q62/uxWRhejnSXllg6XEc7U18bpm/CPark4vl1afqYEHREZbn+5kOiqUj0HlpqUEzHviz9ij4wcExcQ0usFdJ9EPNZv4qkoB6rSeavp7CT/amiiGmZXe2zlMRYyYXgR+xuvTsqH0NZyKRCY3roxJGBcNcI+ey/5RL9DjKpb/bAZw8o/8w3UTpVqfNfpQGuXm5MNf+EWsk+Byz1ylC/huASh0/KlZpKTR7OB/6mqfVC/ajz8+SdlkjixKcwTjpVoDFUFI76s8PRQY5BE2uMM74Il5QSfboGi0xywBsidKqgCikB+292B/Y0UmKGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xjcx9RHTywiZWEHYyodW0yYZalbpKe3O+kpZJL1Qppw=; b=AdNaOPW0iPK2uxUCqM2OTxlk3yKNzwjKi0wd5LJ4bM2jSXE2FBcjb2iEkQ6tM4j0RPZAn42r5EvvOnkYiMI5DFGgBhpj3G0+AkcVcJn8uDvK8mQmUPTX8O1A18v4giwISadmRY8qx47fNc/xI07enAM/ZHx8N3/H0vqR+F7PHMXwYJr5Amvf2p3dOhZq51ikJajwqKtn5Byndfk0ttsOtPeBGozmr+wGLlsO8fP3sbhWES5zG9QwANoSSAF1PxdgmIJRebVGgtben1U9byK83V6XTaas55ukcMm7K1aoxsUuB460UyfHiV5/X79dmX3UWZ6rCgV6oVGoeBo5ToTtKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xjcx9RHTywiZWEHYyodW0yYZalbpKe3O+kpZJL1Qppw=; b=uMM9fBdABUc+Lomnub6jxH9OVvSl2QRlh+jWsG9yw/yXnspqBWovDrRtCBnQwXSHqjGBasJEJ2adZLaPOT6duHlYosFjssTDeepwAtPqGpv1IAqFXB2cDCzmdArVHZny+xhnURqG7wHbzDyr1NjCJOioBObvpns2zhtco2brzfyLnrSX3MD57Sw1ewybVN+Celtm7akZiJJpf5Wx0TVTwYgzv/M5uHfOhOF3gpBSJjsp1BluRTxeEra1Pr8s5FD4hTGqrIr3hIdkwQhgLRaEgthdumuDRI3sTpbsAAJBdQZLEV7uF0aLuyDVXES0A0Uu4IDrDo1rn9ZgZZr/X5TpkA== Received: from MN0PR12MB6152.namprd12.prod.outlook.com (2603:10b6:208:3c4::21) by MN0PR12MB6368.namprd12.prod.outlook.com (2603:10b6:208:3d2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Tue, 20 Sep 2022 08:48:49 +0000 Received: from MN0PR12MB6152.namprd12.prod.outlook.com ([fe80::22d2:9b15:634e:bfc1]) by MN0PR12MB6152.namprd12.prod.outlook.com ([fe80::22d2:9b15:634e:bfc1%3]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 08:48:49 +0000 From: Dariusz Sosnowski To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: Michael Savisko , Slava Ovsiienko , Matan Azrad , Asaf Penso , Ori Kam , Ferruh Yigit , Andrew Rybchenko Subject: RE: [PATCH] doc: relate bifurcated driver and flow isolated mode Thread-Topic: [PATCH] doc: relate bifurcated driver and flow isolated mode Thread-Index: AQHYyIEyUAZxjQ8+xEmolmMISTGnAa3oCTdA Date: Tue, 20 Sep 2022 08:48:48 +0000 Message-ID: References: <20220914213005.225022-1-thomas@monjalon.net> In-Reply-To: <20220914213005.225022-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB6152:EE_|MN0PR12MB6368:EE_ x-ms-office365-filtering-correlation-id: 65cc4899-783a-44ee-6ce1-08da9ae4efa2 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eeBc1awbbLrXZIv/Jvw80QPZ1B/rsWBNoN8DRmYbZPhTvhvIcOWX8B8DonK5TqMIIcINAe0P72F44QDtdfVK4X3r0UvEKUtAYjhu3J7n5gmrzxDasJ3fjOYcQ4hFXgM3cTnGnVhOJGAsjSQe47SQ30MbEytYrzJbYzcVQQq1slLPjBulfRs/11qpBGuuKc7u5jrEKOksayfPeE6krhebTLMmTpa/nGdnNzlYyCMc6PWiqS8lg1E5Fj6Jk3NhWcUsW3TCYUHWzr7ezYVqYdI2oQz1VkKzN4ToYVt1WK+hpm8Pz16/G9vaCzdUWWchTzNvnhcy270+gb4W8U4sRj2SgMQSYwpwvVzqqt+LC/SOWAHEJMhXhdFqwyhL7fDcljfCeCSC5sBqcR8QvhDfxx7slhNyqDvvvz2E2UXX+Y0L1kz4qHCDYt6saib2c2UEw3EMsI2G1WLXzFHyyg4KWhGeTLbNa2qHGykdtbWGZBY+DfbAymDqrQurVWV095wURYZCQXjcW3PH8xpH5J12e5E1HRcgXeobM5CM3U+mzNgsRLllhVCe3a5jO7ysy6TK8fX+aXOPZycKRmkxnByw9fL26BvqDCwHyFbpXH1wXLAnlDUPZ1K4Fqv0KY8c44sp67wxcdM9E4G4xoSJVSzo2mnWDFBQ84inGIpqoQgStWUCBcJkwMTkXw34YsdVSJ9OisQWkZwI1OxVSxjNEb1VxhT+PWKvy2AcXu7uY+SoYqRgBAKCLDrZYbGquAdKWVm3zIYcHRgO3fEV/mm1h1cW9vh5Mw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR12MB6152.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199015)(41300700001)(5660300002)(52536014)(8936002)(122000001)(55236004)(38070700005)(8676002)(76116006)(53546011)(64756008)(66946007)(66476007)(66446008)(4326008)(66556008)(2906002)(316002)(38100700002)(33656002)(7696005)(54906003)(83380400001)(110136005)(9686003)(6506007)(71200400001)(478600001)(26005)(86362001)(55016003)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8Th8rAuvTcZWx6ICKFkY+q9rpuERLjGhFblicffZZtQM+g/srqYEtZ7h6j1k?= =?us-ascii?Q?3vqv3P4hEDNn6J/sOQpvAok6u7mBhhI8AXekra3aKoNRs/O4zN2FXNHBZ8hl?= =?us-ascii?Q?A3zZA3O8f/6P4w8kqqHNpZ1wMMz4K5omEEDXksFtywT4iddJVyClfPBi1FNk?= =?us-ascii?Q?XNEvv6Am7rWnvTdJ6pnSTffK5S0I6XiP0jXJ6gbtQmyfuNqhbuuHDCPuGrcO?= =?us-ascii?Q?+uJMBZ0BjTdQFTTsTVSxcbQ3L8HT1bZNEITGL6n9nNkGGkHM6cT5xQYMQk0S?= =?us-ascii?Q?8K1LHx/9MlmCr6+F/vrmyEt5tzoSPLl5gN9+S2fhSFPSMD9lUE5W+t6bwozn?= =?us-ascii?Q?mPA13jUb1GPIvHGIfUTBUMNYB3OqGJEVGmQj0tczQmocJGkefSVfL9gckJuR?= =?us-ascii?Q?aP4ST22SHBTL1q109Q909BPRZoQpp0pI0fSbY8id2kbZbaZPi+zuVWgseazF?= =?us-ascii?Q?XFunhTGq0OCVbj6xe8NcKSEi54YRwFPwJctImL/Bo/RzzRDPMNmY5nbP2+eq?= =?us-ascii?Q?W7uiKySQI+y8hyoDJFsfeUIWFJvOGGisH8EbvMdPUU+3niBOVWrG0d/FBtr6?= =?us-ascii?Q?t6aRWxjmhQRCzc/KCdBbAwSeABe14UM1ow5MpSPtrlgZkemywAZqvEJT9kwM?= =?us-ascii?Q?Vjh4HtTMy6RWYvM3sqLlU9B3cUpN2wrKmwLPi29w2bjDXf/+pNVRcbJDihER?= =?us-ascii?Q?UPbPqj4tTDJRrfjCdNB8EQzML3Kp4ofuhsvUj4m0cDJxChDHio5V2/2Tkauo?= =?us-ascii?Q?pxsCOOcLyAtO9nQtht3L+Qk93LV2KubKta2vqV3aTda4H2q6W+eQAvH6u3x1?= =?us-ascii?Q?6EbWNMZfoj8c25qQqOGQE6j4yepkB9zFfuG6StxCYP6AyIl0u5+yQfmQP0sC?= =?us-ascii?Q?JoOVUjb+N9BvAtPWtlTND1eBdOoOGCCZIyXT+Azcg9attj8btcvjd9cPmPxZ?= =?us-ascii?Q?ioC5fGmh9IPTmGNF38BYF5gZLVA1XRoaS7MGkCNL4Kb5/ysZ3QGwFvd4VyN0?= =?us-ascii?Q?7cP7jZCDL+ZpPyHrBG5oiSWNemU2QkIy48c9nqi7wVwn2JeMhR2wqpnTdZBn?= =?us-ascii?Q?+l8IKLaFySVrGNCoewe1rXRHemFgMlakfDvKOCP0yVJYH0mW4nrSGcWJ9FQ2?= =?us-ascii?Q?V0rWXxXlo1j3M3/nVNe0OvoGFN9MoqW6kP7kja1Zgpvg5xinN2lsd+6tjIAQ?= =?us-ascii?Q?3HlWBjgRdxPSBm2sNSKOdXgYj2y6WetLqHYMnbN8R1Os4QjxICW0V0unW1pd?= =?us-ascii?Q?Oc/i9wGthrdl4eG2YRepfdito5ERaO2poo9evEJgBQ+KSJRMWOoHWoTI5NJt?= =?us-ascii?Q?R1ZQZeTWVYy0h4c0OkVs0dDv54SZShEpPk4u3UsUVqbcc1exk2fi011IOrFE?= =?us-ascii?Q?L/Jzo2fkeCFSpVHTRmNgptyQ3zBOrs4TUWxoN4tfZtUtCfoAmyx/z0lKSQzy?= =?us-ascii?Q?eAso22obo0GRMQ0v5kJBFu6v8kTiOwrmEvneZzyWz9Qs1rhxqV6iiopnQo7T?= =?us-ascii?Q?7BaGYteOdYzCoFszRSZggEZRIziR7LKpfzYnuLMFCM/qJSk1PSFVjVJ0Q8P2?= =?us-ascii?Q?urhj1z7/ttt8Ev1LiP0fl9DM6OQgWcPHtAIHvY90?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6152.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65cc4899-783a-44ee-6ce1-08da9ae4efa2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 08:48:48.9341 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7ryuOCQuUQFxzWEQWCbyn6dAT9fLzK46xKuHyB3bDYERw0iIwh2ASu4dQG8kP02FcFR6RSB7bVGtOU+WMW2Seg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6368 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, September 14, 2022 23:30 > To: dev@dpdk.org > Cc: Michael Savisko ; Slava Ovsiienko > ; Matan Azrad ; Dariusz > Sosnowski ; Asaf Penso ; Ori > Kam ; Ferruh Yigit ; Andrew > Rybchenko > Subject: [PATCH] doc: relate bifurcated driver and flow isolated mode >=20 > External email: Use caution opening links or attachments >=20 >=20 > The relation between the isolated mode in ethdev flow API and bifurcated > driver behaviour was not clearly explained. >=20 > It is made clear in the how-to guide that isolated mode is required for f= low > bifurcation to the kernel. > On the other side, the impact of the isolated mode on a bifurcated driver= is > made more explicit. >=20 > Signed-off-by: Thomas Monjalon > --- > doc/guides/howto/flow_bifurcation.rst | 3 ++- > lib/ethdev/rte_flow.h | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/howto/flow_bifurcation.rst > b/doc/guides/howto/flow_bifurcation.rst > index 7ba66b9003..79cf4f1e64 100644 > --- a/doc/guides/howto/flow_bifurcation.rst > +++ b/doc/guides/howto/flow_bifurcation.rst > @@ -55,7 +55,8 @@ The full device is already shared with the kernel drive= r. > The DPDK application can setup some flow steering rules, and let the re= st go > to the kernel stack. > In order to define the filters strictly with flow rules, -the > :ref:`flow_isolated_mode` can be configured. > +the :ref:`flow_isolated_mode` must be configured, so there is no > +default rule routing traffic to userspace. >=20 > There is no specific instructions to follow. > The recommended reading is the :doc:`../prog_guide/rte_flow` guide. > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index > a79f1e7ef0..1bac3fd9ec 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -4254,6 +4254,10 @@ rte_flow_query(uint16_t port_id, > * > * Isolated mode guarantees that all ingress traffic comes from defined = flow > * rules only (current and future). > + * When enabled with a bifurcated driver, > + * non-matched packets are routed to the kernel driver interface. > + * When disabled (the default), > + * there may be some default rules routing traffic to the DPDK port. > * > * Besides making ingress more deterministic, it allows PMDs to safely r= euse > * resources otherwise assigned to handle the remaining traffic, such as > -- > 2.36.1 Looks good to me. Thank you. Reviewed-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski