From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7543A00C2; Thu, 6 Oct 2022 13:21:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B57D442BF0; Thu, 6 Oct 2022 13:21:53 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2054.outbound.protection.outlook.com [40.107.96.54]) by mails.dpdk.org (Postfix) with ESMTP id E941842B70 for ; Thu, 6 Oct 2022 13:21:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ck0FvHoZIcmeVcHO6wh+5XsLS1th09s8zXpVINHlq+663nC71vyVqv8pCMNFolAekRZXZgSo85PIpRp+HpANkAELxIWaC4cFhBDN93Rw/mgf+p0ZJdx8neh4WoVSyFrbS97hrWKm1qWHW306c8+I+IzCiNu0yc3Y2lE9OOjZSjkcUoxKvJ9GEbfqrRKyVP0fDAqYlNgz33aC5kCDooXo/TD8DhsrqOjKIFjKqwTlY6cmHfUMXYECKf+Qn1Wd61xoevGv3tLeKrHO/kScVvXAV2ZfgukMQBoXsp/sPl0mQLD39j8pXefeE8orU2onZuLBicFND0kv4U0SZyKZfqZ36g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tI8za3zxLA0o7PeYxbUuqR8hJD4/0nYZJSpXb3dnono=; b=KTLYH78EnXYXAiRLlJwp+X4QYcutkAacjKZEdKX+nv1PiyQpqZY10Xv4m6vchNuTOSmtNEKKZrsqsqTQPj4VGkTXJebsWeIEvvpETOkfuT9IBhboS0Z4m3S6snBOH/A4UpLIfeB9JIcBT6t7JY+XywdXRbmsrnPN3B8lESV8SN069I/mle1/5QfUVRm9c8cazhO+cm2PvM9VUYRddgURNDNq0tqCEn0LNnNk2yuUdNcKs4Q3ZqARHAMWIXBXCpLt5QFGiFMKt7oSzCOYuWEFkFpEed3udB7RHX2iAfv/6Gmhd/8J+qsPb0w0O3GsLPL8v8BNU+yaPz0WL73seAMnqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tI8za3zxLA0o7PeYxbUuqR8hJD4/0nYZJSpXb3dnono=; b=qSwvGtLA7mbNmufmOweQC8e/FxOeoGN+O5b1BmEeHwIR6raHtorowh+mrWb65RCAcYa0XyLCkfqnjJPHio5L13r6ayf49HJzHSFBmRwp37fZxnsQPaYClxAVipkom6hQtAs6NdEpBIdTm5jckzgZd0WXuJ5DK3ctw2pCWV4EfC8nxxab2BZTo0IF7W4WgfaZLUjdWw4cHbi/lzDzM37awbodc/5H+0VlML+ZGQe/d6ifmikAUhMLAz0nHjyprfGN3lEM6hTmc1Kyf47msKEizA0w02zj1kPhHsbbL5GlHAYADpGIMM6HF9JUuZjClz6SvGTe+Q8F+iKh3zxtquHSyQ== Received: from MN0PR12MB6152.namprd12.prod.outlook.com (2603:10b6:208:3c4::21) by PH7PR12MB6693.namprd12.prod.outlook.com (2603:10b6:510:1b0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct 2022 11:21:51 +0000 Received: from MN0PR12MB6152.namprd12.prod.outlook.com ([fe80::22d2:9b15:634e:bfc1]) by MN0PR12MB6152.namprd12.prod.outlook.com ([fe80::22d2:9b15:634e:bfc1%4]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022 11:21:51 +0000 From: Dariusz Sosnowski To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH 1/7] ethdev: introduce hairpin memory capabilities Thread-Topic: [PATCH 1/7] ethdev: introduce hairpin memory capabilities Thread-Index: AQHYzEZW7YkB7jklt0Si1YeRHcXH9q3+ij4AgALFFAA= Date: Thu, 6 Oct 2022 11:21:51 +0000 Message-ID: References: <20220919163731.1540454-1-dsosnowski@nvidia.com> <20220919163731.1540454-2-dsosnowski@nvidia.com> <1781971.b8e9qBsS6s@thomas> In-Reply-To: <1781971.b8e9qBsS6s@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB6152:EE_|PH7PR12MB6693:EE_ x-ms-office365-filtering-correlation-id: c3ee42ba-5616-470a-c7af-08daa78cf730 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7my2BA00/alQVmMgF+SU8grnepZOUkByeJZ3X3sqU3AACkTAEPb7MYwKNbLevl/c6Q8uQA886TJIzJEAp5jFQakJvczyET3eSDY3YLN7I14IuXS8FNtbnUe9I+wxQ7jZ95mJ1XsBJFqqDQqRWmCYwc9LYW6CiR5SxGmUKKeMeFy2YVGtVqXiQrKXexwGIWbmUMhpkuzS2TzVKoi+Mh99lkioXUWg1+r8VfJquFbQadD01nM9zOA0qJp0nGHQPFnj+LQ8JxJTrACzsXvsB2tcsdEViWfdhOaLTLQaMSrcwUsjeuphyhq8XK/VKMQTLYqM9J6iTiYyRLmmiYe23aHDC4v0Px533yOU7vQbIuLsafqXJZVMGQD3kbk1NExnxAk+Bntui6xjAUFmiGiyAdNt6vViJkOE/Pu8yytBSEK0gC9MaHHw/ZS3QXTvaW3BNHvUkuNeyCXxmIx1jgaorEVWcHyLIWlkjuIb+BUxd1mU7noVg/H/JoEMz8at9lumn2AEKDYd85oGLgML8HeSLr/krWMXO1GUppG01B69WVQ07xSWA+wDOghjWPTvD1clkHZC1StPBW1mbKUJs8tcqzPdBJKDSszQJnjCsmw4ayASHD5POm8crO/VsC8HCt0kipGVFUjDLEPGmki6560b1sv35+fa69jaQlS+lu2LFg2meurGG3py+9acX+/W048ahPo09hSPahRTlehEqWKvtF6bqCwywjJwHpwb5sMJ3GsnnbU9BsCC5kxJDKou3s6n9rtSHQZXyBQP0kPWwbCTbHCRvQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR12MB6152.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(83380400001)(186003)(38070700005)(122000001)(38100700002)(41300700001)(2906002)(5660300002)(8936002)(52536014)(55016003)(478600001)(55236004)(26005)(9686003)(71200400001)(6506007)(7696005)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(316002)(54906003)(6916009)(33656002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oYrPacxwHD7g00a+DRld6JPKzfO36/OtaAYfIvoQdwNKGsrnXOc4ml7URHP0?= =?us-ascii?Q?stvnyVdfQPgy6UhKrFD+NAbMP/cVyvklOxYqrFCL8zIrLdX/0JcKV6YjD3g5?= =?us-ascii?Q?6zJkSKS0LZQgv7C6cSUhle2H8Iz/3TfvYDUosY7izC3HLuYZgEriYqITVCHM?= =?us-ascii?Q?HK65KCiSOdXPqjM7vJIUoDi/FWg1UxArO1PjqRqhVeTXsfN25ywgSjnUK2yv?= =?us-ascii?Q?W4gaPnTBz83VmhVnDkEVI3YkVCgrBDo9j8yVbXhN+TqgIYlDQWUPPAqcusnI?= =?us-ascii?Q?GRnK8DxsdYPqFYhlyACNciEfg5W9uaRiaKTU914V6bu6G6w5l196tWXD99FI?= =?us-ascii?Q?fqzfnOn2gfodGmC7kOGd3Qj9ldYeAfB45a7DWrFys4TmbhErFWM4IHgDjq8s?= =?us-ascii?Q?4JiqsG07DQvfA4c4ZokTv6oEZnLYQHAHTM53oPozYiYLIUSs1EmTeNb3q/UA?= =?us-ascii?Q?BbVqFBLOkKB14WGejXIWXRxkX8mct6rT4VQPdBz9/wgb+ymGacS3HCxBpe0u?= =?us-ascii?Q?mR7195noyrqT5UBFIMpQCyhXjJNOj0DT4KIV7nXblZ7uJxOMys8H1CJQZJ80?= =?us-ascii?Q?XZ9BrvvZmJL53mKEXBFSAG6Vh5UtZRGwefOItTiv8n1smyZC+rAaEmqImGQN?= =?us-ascii?Q?I/Az2Uc/hnVJzHTGZJrue43sQMqy2qzCwQO+6fAZncpXOfr6iQBMViXeR1+B?= =?us-ascii?Q?yVSryzvN9vdqltigqtGLjNg0PYTQsRbwEYRsCVMz8pLJXudeh1wVnp53YciE?= =?us-ascii?Q?lthmXt3x6x9RZkB3W/ib0Q+uiFWSB8YVHqZGOwj6ac8A+XRqkwakQ0im5fhh?= =?us-ascii?Q?nx8TdqjW5MM4JRP6f3ZX8LNyFkghJIgz0nuUiIX+lu7gxpNqnaiZBHpbf5mx?= =?us-ascii?Q?PUNxeiT7eEMg0+yXHNQc+Eyn2/g9jBr9QdAPU/ZW3xCaZvKFkqCk7ToMGeGg?= =?us-ascii?Q?pfHAqcdknunZcu29Coq8TEMMgVsc9jXmHfPFs/t78TP5jvB42ITTxiFc684b?= =?us-ascii?Q?HsjCbbxapiW/OoK3FinRQ5OWqOGuW5jbeCIRx9xU5w+mazdXlQE0vRNQO/lX?= =?us-ascii?Q?3+XOTHcGXPpCCJ0kq6e+muLsO2h8+T5gj360JAqi9JoWvxQ9PbsjauEckQPh?= =?us-ascii?Q?fHarZ8hh6fQ9z01UuhLdt7iB29FfhoOBHoqYXKEZ2DYpceiN9iLphcw9AWag?= =?us-ascii?Q?OEr9H+MZn7C9G9wqMk3MDU3YkHOtqCzCByI04QhTiePBZYjpsgGTO7XNIMcy?= =?us-ascii?Q?59AKJ3CQAYr1M5zhiXm72e9E9MqMoSfVk42S8zFHx1DV4LcW5k1Cbtnus+mK?= =?us-ascii?Q?9PygFHMyIXjRinp8TSHr0R/XhWWMYZPZSnQ/KNblMMaXR/MuEENF6CrZ5JxI?= =?us-ascii?Q?KwWX5mYDidsbMxRN4r743qc7svzmEB6nbCqW1tqV5wSzD7gPb96ZoGjoQkvz?= =?us-ascii?Q?uKVCYrasNrtFqm7O3Zw1IsXGsEX6M1zyLMVQuIUeCLSjnj/kjD7CiwNRxMKE?= =?us-ascii?Q?2UnptkOgvUGlf1/ELP8aFB+5YOXB+/z75kngCTNJgMTX/nOs0TrHHO+LGXX9?= =?us-ascii?Q?7L/DUgwXRNgTv4Sn6Mk6xmvUL9b1z3WXiQwg4F1Z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6152.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3ee42ba-5616-470a-c7af-08daa78cf730 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 11:21:51.0307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oXlq89ApPzJeymZVpPDqmUIthngccgnCDWxSdo1LcOoVD6Em45VOkmvRlujXd+hMDLij/8ZGI/KhvB7sLeSXnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6693 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > What is the benefit? Goal of this patchset is to present application developers with more option= s to fine tune hairpin configuration to their use case. I added more details regarding the possible benefits and motivation to the = cover letter of v2. > How the user knows what to use? > Why it is not automatic in the driver? Basic assumption is that the default behavior of the PMD (mlx5 in that spec= ific case) is a baseline for hairpin performance. If that default performance is enough for a user, he will not have to chang= e anything in the hairpin queue configuration. If performance is not satisfying, user will have to experiment with differe= nt configurations e.g., if decreasing traffic latency is a priority for the= user, user can check how his specific application works when `use_locked_device_m= emory` is used. Specific performance gains of each of the hairpin options is not a given, since hairpin performance will be a function of hairpin configuration and f= low configuration (number of flows, types of flows, etc.). > Isn't it too much low level for a user? In my opinion, it's not too low level since purpose of these new options is= fine tuning the hairpin performance to the specific use case of the applic= ation. > > + * - When set, PMD will use detault memory type as a backing > > + storage. Please refer to PMD >=20 > You probably mean "clear". > Please make lines shorter. > You should split lines logically, after a dot or at the end of a part. Fixed in v2. > > + > > + uint32_t reserved:11; /**< Reserved bits. */ >=20 > You can insert a blank line here. >=20 > > struct rte_eth_hairpin_peer peers[RTE_ETH_MAX_HAIRPIN_PEERS]; > > }; Added in v2. Best regards, Dariusz Sosnowski