From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0C4B4233F; Mon, 9 Oct 2023 18:41:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A354440A7F; Mon, 9 Oct 2023 18:41:42 +0200 (CEST) Received: from DM6FTOPR00CU001.outbound.protection.outlook.com (mail-centralusazon11020016.outbound.protection.outlook.com [52.101.61.16]) by mails.dpdk.org (Postfix) with ESMTP id 20693402B1 for ; Mon, 9 Oct 2023 18:41:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZtWgDO2u776oogJEsBSmMJYJRIBxLpUWeMa/HO9mvxdpJMD4JBccPIduQe/LvKwOFJy491ob0E+SCMSq58hX1iZwYowE9+HkFWVhO7WAB2V+Kt4kdXPLsprnwj552uf0t1ZXyHonh476At8KUFbwIFKoLYTy6bLCLwLhY/SzMbDF1oVaiQqLnwV6QLpnP0kynNp5XMW38TcU4nesH0FYhOMzrSXijA9IOGoGOm1YUJNw2EAaceJmyQJx1ns0jswOiR3J8E6pOpuYcpJCV9kQqAuDtRjDFeqM33pAKuvD7Br3OgjTxKVsc810f/99B5QwawfPx6Cbpckrlr0vbIQ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E4Xufcv2kQbfwFR+d8rvz3l3uWbQnrIJbVKWACeVfCo=; b=nK+2QzISYaOMOmC2c543jPLV10z8gNXCLFtIg2sWKoA+tfy9CmRU+9R9Q77W6o2IDIh5Y62psSqdei/f7DZhtnygNBzojRrBfdNowXZPQM+Lm0aCNQBgFbg3Ln4Yn7q24XLlLTZGV7qXyFyXPCrwMPtbeSZ6KxQnEBq5evrBavseVfe6onXDl7v/CsQI/NYNnnJLFhBMDvObcdz5SuJfN3vMfAlf8+dniBvuGGXIYLjVCN7M5f2T393CE9dVUcP760JZAtgDKvVQxvar8z2lbA0rsdd75b4T5spw3CA7On7VfhYAX8cIE3V9DhWnSUvQULajW+o4tiKu2ZJAdqgXcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E4Xufcv2kQbfwFR+d8rvz3l3uWbQnrIJbVKWACeVfCo=; b=Fk1r9widTia2hDy/BRnnrprJFoOqU9buCMwUi9CckbejXoHZ0JurMCepdmnVTLYxy5T+Oy/vja0A4g7uu0LnkSYa+5N2QvFhUlT7z+0a7gPa3vkxw7/8uQu3MyM+gsw0sFOYPSvum3KOozZsLEFe+smq0tnVaQrDvu67ebSC4Tw= Received: from MN0PR21MB3120.namprd21.prod.outlook.com (2603:10b6:208:374::18) by MN0PR21MB3509.namprd21.prod.outlook.com (2603:10b6:208:3d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.2; Mon, 9 Oct 2023 16:41:38 +0000 Received: from MN0PR21MB3120.namprd21.prod.outlook.com ([fe80::5e3d:e9ea:72b1:393b]) by MN0PR21MB3120.namprd21.prod.outlook.com ([fe80::5e3d:e9ea:72b1:393b%6]) with mapi id 15.20.6886.016; Mon, 9 Oct 2023 16:41:38 +0000 From: Sam Andrew To: Stephen Hemminger CC: "dev@dpdk.org" , Long Li Subject: RE: [EXTERNAL] Re: [PATCH] net/netvsc: add support for mtu_set Thread-Topic: [EXTERNAL] Re: [PATCH] net/netvsc: add support for mtu_set Thread-Index: Adn34ejvYolderxPQNqpdP6DbvVZdAC4dNuAAAKUuaA= Date: Mon, 9 Oct 2023 16:41:38 +0000 Message-ID: References: <20231009081737.3b64131e@hermes.local> In-Reply-To: <20231009081737.3b64131e@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=10365321-ff4f-401b-a87b-0b9d7adadfb4; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-10-09T16:31:31Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR21MB3120:EE_|MN0PR21MB3509:EE_ x-ms-office365-filtering-correlation-id: 34f0de85-fefc-4996-c078-08dbc8e69bcf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BsoMs4MCuIH6x9zaZeudErfc17Pey7NV3xg4oTp8QjquTUJ2quux2JLPX6SClMx2iEcG71jzUEA6ejkC6iPEXCCr6QXSXRHBCWPYkjWzFUBPoJaUPuqtHagUNztiW5qQ30poGWqCd+SPjrgNNyiWEuM3Nv1fJ85F8cUmZN3w6ND0MqFBJZu6XMl4dp1O/Cka82Lj8UOkF7Fj9SjTte/6X/rsMpzDy1HH01i2QRDt7+Jtc6NbnyjpKMZqenT2kueczq0XdHRo9ncl3mdzmRqOYbVvicuJGM8pcOFM6dtdDDPH7IZ3mdEbol9S0KwdRw4NBi5vQZmo5kr0+MeJFFsiSe6Daenr8h8rVVc39kllQRyfl9sI/slPqDe6Z20JQ4D330Oa6hP2tHPsRSyQuWZD0BURsMZJr5sVO5r2Yryx+ZrX83a6hA+Y6mgIbB4exdcYd8n2DRBZbTuuDVflzBgOEVOaLOiFPtD9Vwd0ANpbtp7YcS30WUftj0Am9eGrHuPuw6cX7/VQEgmlyQF/1EFCwUSf6uh3BZirbQynxavk0p8dJUaSsoUeyCduK+yMrDGbUsGPII/OPa2IyMR6QKph3KpbJMUvD+ikbM1PZWmCOYx/LZPXv25Q73KbTc8j1z8+N3ViP0CuPNERmmJJ3GyfutiAfBAxeF29uQS7l0kCWtM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR21MB3120.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(346002)(376002)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(71200400001)(6506007)(10290500003)(8676002)(478600001)(8936002)(107886003)(83380400001)(4326008)(2906002)(66556008)(66446008)(8990500004)(76116006)(54906003)(66476007)(66946007)(64756008)(41300700001)(52536014)(316002)(6916009)(5660300002)(82960400001)(55016003)(82950400001)(122000001)(38100700002)(86362001)(38070700005)(33656002)(7696005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RUoNfgHdVuvBrQ9MDcP5jhTGIbtIpm0YVvAHXU4QJkTJu/9Y2aHcLmspoe7Q?= =?us-ascii?Q?AqgFEVFI1j5YVfV162m7nbJBnKIS/Q6leN+eORtiUpuIrE7vBn8Yni9eKGvO?= =?us-ascii?Q?162BwCg5ZkOlgWmPwGYlujM7u8Ovn+Weo3WlkXRiVemAOnAVYTGYOv9WCEdr?= =?us-ascii?Q?JE4ZIIc2UrI4OGC8O5x57seHwqKaw9rBzXuSxdF49oCcrHbqoNuXRcDo7h14?= =?us-ascii?Q?JpAPcEdLBzlSTXUacJtDqZj8lSDrDpzoz022USzDf6R3XjrHkQ67QFbvY/ke?= =?us-ascii?Q?kqD/lJNRTXsWMdzJ362MRbGVc3+YzRPnKBKMQjhgc8XfmQz9eAkqX3cA2o0K?= =?us-ascii?Q?7m4AEyikMBELUZzRdzxppQnpvzVLLEsw3Nch6XQHRpBpF+u+Fbm0Qq0cVk+u?= =?us-ascii?Q?2PjAeq75dbkJ6+DTxBag2ezCzo0WvzkTu+lnWkau/GWyYKDh/EnQ3d5wE+Yw?= =?us-ascii?Q?FDVyihIWULD5Bf8NZY6Zhp0zkSBgttRbqXmlmaJJZtPO+1PteLuIzh0B9CYv?= =?us-ascii?Q?MXtc39ajO9mIPBo3u+O9QZAq5nv5j63ChVdcu+f1pvRDvGbYNlSOtqRqyEma?= =?us-ascii?Q?y88xGqIZSxMOCFZogM4dVvsM5WMBo56EK570CSozXxPYPrpdCL/QFe58HQh8?= =?us-ascii?Q?TkG520LWi+LAerSik5lDoolR5L0X8IGCjTgun2fNNmtEuKkmwdDx0Rk3XgK2?= =?us-ascii?Q?kIQ05eBBHHtgNX27MrChivM/RN7u7j9DyIvfadH85mKv56mim4S6EXZy1Z7H?= =?us-ascii?Q?8y3EdMocfSVQ6+CKVYLrWE9Qcu80EKpzF/NyynOCLf1Op2qP17tePH+hSj5d?= =?us-ascii?Q?f60RXL/vYKP4fyqHL5XhWJM10IghVxR0OfEFIX+KjFlMJ8tP6rnK5l3R5KoR?= =?us-ascii?Q?qD8/MPXoFQxh7U/zYeeJKMHfV3ULsxU13lnKWkQ26ios6DFRS6T4SeI5AntJ?= =?us-ascii?Q?xQEDowOXS5/wpgN1J3I+XShikvETsJ7QRkN44yRWq/7lA9ZHK//uYM2RuYoQ?= =?us-ascii?Q?N42bopr/l1gqf6QFeDW7WafKEhOX5m8wzsZqwfFIyW3PlXPAYyZEAUXvzQYT?= =?us-ascii?Q?25886Tc2XkEWhdT6GD7MupgYA6Fbgbdynyvg00PW8gs9g/SyMBcbUvHDgsXv?= =?us-ascii?Q?XTuKH7uDkGmG40r5DJJns52vtsaD1QM9eoDirtC8+p4/8Bok9721S2ixJ/qW?= =?us-ascii?Q?g0soGIFRaWqu7AXhX7EK6qUWsQjtT865KF6YwXRaeLS1UzYm9Upy3Km16P/v?= =?us-ascii?Q?A4wiepn3vcbF/K7uNUu6eB13+r8rxv9cUHcek6rsiiB4CSK7BtEbaKxDekE4?= =?us-ascii?Q?nFTMAbPSYP94FZbwkWr24xHH/P3BubQ0h0k8EzCJXGAy6fYBGI25Y6x9i8RB?= =?us-ascii?Q?h+UvBKf6310zhtWmlz/g1JuSHv4etthShyT6jXtniJS2XR4Fw0bBPd5SExCw?= =?us-ascii?Q?XHLb/ryHUvhkWBuXRUFQ7HJ/oCexo+qdGqI/u8xMIjyTm4XJ8F5JgfjGm2rz?= =?us-ascii?Q?k24PUynUKPdKcPZIIskPSYPtr06V2Nu7euWThX4TfOHBRhyJUfEB3HMksKkY?= =?us-ascii?Q?QD05Hbu4Y1PBd8ss+gc71nFBkBnj8fhLFBaf7jG9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR21MB3120.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34f0de85-fefc-4996-c078-08dbc8e69bcf X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 16:41:38.4876 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5oXi7GlAXRCIfsR8JTpShLles2ANB6pNi3D3hUFAOvzQMq8fnlJoZRZSiu+CycKVf0Ad4RxA65/VDObICTHOWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR21MB3509 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, From: Stephen Hemminger =20 Sent: Monday, October 9, 2023 8:18 AM > On Thu, 5 Oct 2023 23:17:28 +0000 > Sam Andrew wrote: > > + > > +static int > > +hn_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > + struct hn_data *hv =3D dev->data->dev_private; > > + unsigned int orig_mtu =3D dev->data->mtu; > > + uint32_t rndis_mtu; > > + int ret =3D 0; > > + int i; > > + > > + if (dev->data->dev_started) { > > + PMD_DRV_LOG(ERR, "Device must be stopped before changing MTU"); > > + return -EIO; > > + } > > + > It looks like this proposed patch does not have the accelerated networkin= g > virtual device case. The driver needs to first update the MTU of the und= erlying > VF device (and handle errors), then reinit the vmbus device. The following line should handle the AN virtual device case: + /* Change MTU of underlying VF dev first, if it exists */ + ret =3D hn_vf_mtu_set(dev, mtu); + if (ret) + return ret; This is the new method added in hn_vf.c: --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -778,3 +784,18 @@ int hn_vf_reta_hash_update(struct rte_eth_dev *dev, =20 return ret; } + +int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { + struct hn_data *hv =3D dev->data->dev_private; + struct rte_eth_dev *vf_dev; + int ret =3D 0; + + rte_rwlock_read_lock(&hv->vf_lock); + vf_dev =3D hn_get_vf_dev(hv); + if (hv->vf_ctx.vf_vsc_switched && vf_dev) + ret =3D vf_dev->dev_ops->mtu_set(vf_dev, mtu); + rte_rwlock_read_unlock(&hv->vf_lock); + + return ret; +}