From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB3E3A0540; Mon, 20 Jul 2020 14:59:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C02B1023; Mon, 20 Jul 2020 14:59:14 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E745BA69 for ; Mon, 20 Jul 2020 14:59:11 +0200 (CEST) IronPort-SDR: WZUFy0XgCXNigtAbvRByXk510ETO9M2UXMUof/LCDd7Zp5l4fvqx3n7xtIFm/4RhL5umi3TpXh GWHdt0oWvQBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="151243357" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="151243357" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 05:59:10 -0700 IronPort-SDR: lxNt+1gGFoVooH/VA4tLrC1QQEkNI61hqS3Z2g2p9s0g9hNMqjxToGinvvvNdG236L5Ae5x48u 0X2POLIIll1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="487233152" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2020 05:59:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 05:59:10 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 05:59:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:59:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwkqSXartrhMt+g4gwTGPWvQOT+ERnDEw4tyaWk13ISDuW76Rt0xu3CGVQdYwGZa6SUj9gTnIxSyrx3nRBNH02OfE6vcgd6Owb/EPEF2n7Z6tI+ZVJICUtSkRFgQOADJVTgm8lY66phB6jw6+MKIZibfv6bP1JOzYUmsyTSx8CnkYXOZVjgOkRRQn0ffsBLv59MxU7cms3Qeo/FLQSZVxpGF4R7y6uuJz4ytAiPkDUvKoUtCZm/bqVPa14TDzRCxSDBS39R48X35CHlta4dFp7nn7nU+livZnwsJq0IBTtoYVvOx1d1ShHtIdujNzcN+wqKTD9KpRFvCHRndyLrigw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KSU9Vmg27pkJWoLMxEvuRl0fHipB3WRlJ9npuQGelDQ=; b=ggMVNxqjhISgw4LTAx7Bch8kvMS9iLiV7rVbSWuek6X6nPr3HFdislmtsjikyr/uZa1Ku81W2Vj5wjtvicF0JO1bHP0GhDDGhXkUEzwdq7BxhfTciJX7VtpxDXuOgqJdFoJLZrLn6t4oLmcTf0HFRud3eOdrTQbAcveW3Hm9lOzP0LTs95uWJ3HyX+MTn8sF1e3X5+6yjPzJSwWwApiawQcsswGpOsHn7Nn/D1R5864qxsq9JSeMj0BUA5xXPEQn56ax8mGz75gGZDlS+JawBozII3HULIUkVlA2pxRUXyMxIYzUVT6iEOasi4zeB41wR+1PjV55nrf6VhognDUoKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KSU9Vmg27pkJWoLMxEvuRl0fHipB3WRlJ9npuQGelDQ=; b=ceqn59lhK+rQ0WvRrzwOrMmgjs3BN7rX2mbjagQB+pWgnSiT3p4a9zA0LRX7vujUjLkPWzjQY4A4rxV/z8FPDu4vUTfFn5gEKakULoExPGK2zzHIRGU+IpJzCAjmn5dSE5eSqQszU/hhOIUfVCy+Q7kWTU4mCKasvKabdTvan1s= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4000.namprd11.prod.outlook.com (2603:10b6:208:13a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Mon, 20 Jul 2020 12:59:04 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f%4]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 12:59:04 +0000 From: "Coyle, David" To: "De Lara Guarch, Pablo" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests Thread-Index: AQHWW4mJa4pIe98VdkmFNJ7CzxGQeakMIugAgARMX+A= Date: Mon, 20 Jul 2020 12:59:03 +0000 Message-ID: References: <20200716153111.65308-1-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.53.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 301ddbb8-962f-4137-3fc1-08d82cacae50 x-ms-traffictypediagnostic: MN2PR11MB4000: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sBEXz3jfKo+DJ7YVIGoqAVNYWnqxrZAOfKRai4XAbYetAscyJtlx8916lsZncb/KgfyPeBj2GfyKyjJB8rBWuNkDuaFBeh2961OymA5s+9QXyxUR+Nmg8qwUMfB2RZv0HQ7Xg7qyWk8jlk5nXNvweinUeKHiG/0CAp72Ozqb4zpW27mMQtC0bFVyKQ8zCV2BgqwqOeHvPqgP6njtyx2Ayoxn1XJ0WaWQNLtxrwMHM1TO67CdYVq8JNgX6E4y86guDcSotJbujpRblZUaVEAPDCBLqeqlGF5+YqD9sx9Vv95/S1qkWh5eSD3ghmvhtyT97ks7h1XcAecMl8zzUaax8g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(55016002)(9686003)(7696005)(52536014)(83380400001)(6636002)(2906002)(107886003)(71200400001)(33656002)(54906003)(110136005)(8676002)(316002)(5660300002)(86362001)(26005)(8936002)(66946007)(66476007)(186003)(66446008)(6506007)(4326008)(64756008)(66556008)(478600001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: U+7NqVf3PvMizCW/eom7FvF0D4loHdjaq2nZxpV9jYQUrKbBW91dBV17MyicJYzE4EgXgtVu0O3Ye1tI8H1iw3WVwt+EU2jIEgvmp4DVHUFMD0wW1JM0XG4Y4Uijnkj4xwVynyj3E35etFEvSJhuQM8UIVS+ZFop8oPnSucTLHfByShCuEKRuDL8qcvaLTzlE9HSozBW5usns5kFbXTPkfsyYxpMx0IFEwgNW59Fy/a0Zqm45qa4VCkvpGYwu+uufSZ5wPKiEjNXDGhwA/qyoxu3NfUvL/X1pbcqqDAXp2HM/d8KZQPrnHxZodl+GDoba8y5EelWchbE+EMoq8nfaTjnMjF1Rb0iLPUFrIBeZU3/QEFPxplP4y+EJncal6Wt+PKB8mbwa1Fz6ZbvTw7b23rL338WwXFpjC0Ymj0KRfEgtBcr+5HIAJJQxoP4S0/BmdbLfWld1QXGUb56xZJRWtC0l8Xx7HGY9BWR1/lrpOg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 301ddbb8-962f-4137-3fc1-08d82cacae50 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 12:59:03.7260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZM8blgNCzDTF0ZBuDbY52g2HOWbwEyJoK9htLLvA3b8BFSBBoAOx5uCK1wYs4KQBfLd2jvbZMO6I3HEwyowgYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4000 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, July 17, 2020 8:04 PM > > @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op **ops, > > } else > > buf_sz =3D options->test_buffer_size; > > > > + sym_op->m_src->buf_len =3D options->segment_sz; > > + sym_op->m_src->data_len =3D buf_sz; > > + sym_op->m_src->pkt_len =3D buf_sz; > > + >=20 > Actually, I am wondering why this is needed at all (for DOCSIS and PDCP).= This > is already set in " fill_multi_seg_mbuf" or " fill_single_seg_mbuf" (and = this > was already working without this patch, right?). [DC] I have found that if a number of buffer sizes are specified like this = on the cmd line "--buffer-sz 64,256,1024", then the pkt_len and data_len filled in "fill_multi_seg_mbuf" or " fill_single_seg_mbuf" is always the largest of t= he sizes specified. The cipher/auth lengths are then set based on the --buffer= -sz option. For DOCSIS, I tried to be more accurate and set the correct pkt_len and dat= a_len in the mbuf. This followed what PDCP did too, even though I'm not sure of t= he background why PDCP did it - possibly spotted the same issue. I have also f= ound that DOCSIS performance figures can be better if the correct pkt_len and da= ta_len are set in the mbuf - I don't have any proper explanation for this though a= s the cipher/ auth lengths are always the same. I've dug around a bit more on this now though and this is actually a proble= m across the perf tool. Some of the crypto PMDs have logic based on the mbuf pkt_len and data_len, but because the perf tool isn't always setting these fields c= orrectly, that logic may not work as expected. >=20