From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D86AA04BB; Tue, 6 Oct 2020 13:43:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1300F2952; Tue, 6 Oct 2020 13:43:39 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9ED24F64 for ; Tue, 6 Oct 2020 13:43:35 +0200 (CEST) IronPort-SDR: NZ6/VsmA8IJ0sobcb4vceox+xgEtguYm4R7lTLzmfWst7tE/iqjnk+Is0KTdTkBY2xbconEl9G qnKCzKn9hSMA== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="249160875" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="249160875" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:43:34 -0700 IronPort-SDR: wEmmo4jiL17mFelajJKVz5V3Sk/2IQicID8gEYe/Dyd6HSdg4LQZgxVhAnJ0PA5VA+/l19vOw1 2D0lv/UdPhdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="517176438" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 06 Oct 2020 04:43:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 04:43:34 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 04:43:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 04:43:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 04:43:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCdBmE6ywEfGwGZYzOEnrBCKLQsjWDozX9HQg5dXkPAD2kWup1PNpKEf/ArU5IiCxG1YHnpeZEGqkV29vAt+ASInEb2PeYKyj5eTgGj2Smt3il//YzxQkjRrrXfgaUJ3DchtxBSEb9WKHYXgO17cz1+nQ42yhgLLErxQEcoBx4INhU6NyOhAPUn6DZ/ky0ldlIT2KME85zsSYLMykA4qioizh5zB3R70v952reenAuJseZDqq7RdyyjwbMrwKY8hKngzSF1d+HrEATqybJ0k+6rIkRu+Vmk+5jLTGkY5tisf6xMsk3aFRL8XfByvWICmibpmuDvzYznbPSYfV9XU8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tct0KKnwf+rrIJxHc/KgaUanFd11h0uAZlgDG5ezEDM=; b=eumo0DUsZvMtDh/rEGEToT2sbR2uMDX1xXqkE1rXpsvz8T2cGlEJMhVaRBRXIeZ/3suf68EjlTjdBNVsBzFdNwJ/1wj+9HsabVDlookos09t4or2eGKuQTCSdX7mlRoQ6LzrOLZXpFDSaQBcCNTy7t7h8Jwt1bevLTEzLB3fOBqc6ZtgQgAPREzmaWy6CKJ0FskObDH3s36YLri7n9Cypavwa9HEfT77wbiZ0dXAL/TVrDxFE86vJeVntyiESapg2S71MkQuAAKmoY+wJGDlzISDu7uL1D3lKSHsVL9BRbEhQjpqgIemUlCKMUbyn18TsV7msHhOMgjFPVH6s5jTSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tct0KKnwf+rrIJxHc/KgaUanFd11h0uAZlgDG5ezEDM=; b=MlRW81xGvIWqnfn59aLJYrZwDb77qcz4nPZemjBeCQBtU9VV+IzHhOukvm9jsXQQVaMXOVhRNU9nnDNPxA77++azIdFmZ1axHbHVH8aExjWMaH/K0jWvzVSZH1EV0j+ryqkNj8d5Hzf0ahqjps588GOT0UYMwixQgYzBPdycCig= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB3999.namprd11.prod.outlook.com (2603:10b6:208:154::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.42; Tue, 6 Oct 2020 11:43:29 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::850f:c50e:27f4:a517]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::850f:c50e:27f4:a517%7]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 11:43:29 +0000 From: "Coyle, David" To: "De Lara Guarch, Pablo" , "Doherty, Declan" CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session Thread-Index: AQHWm8UE6zXcY54FTEevvKUAJ8vGwqmKao6AgAAJXIA= Date: Tue, 6 Oct 2020 11:43:29 +0000 Message-ID: References: <20201006094215.49882-1-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.50.9] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 916743e7-c91e-4965-b425-08d869ed0b8c x-ms-traffictypediagnostic: MN2PR11MB3999: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QNR1vgsyK9PR4W/vKd7dbyWx0fWZ6B1Hkp6b2YqQ7ms2kK8Z90DXh+LwmbdKaGn+odfT2L5DxNAOsjt3UKsM7Xl/1N6EkXNmkixy/8QA1GEJ/61dFwyd0ANggh7CLXyYOlwHTB/mx4R+NrxmKsPcFzi8l19Fl02eNWTUCJiaKJALSPX65h20MbeZSA3kWBh0T934jfMrOSqlmxwA7sHnKzkO2q/0tZRCliBSPxFNi7NhxJ8Wp9eZrE4KdIs9+G/fSsp1bTSlEe2DFTnUUTlJHXLWt/nNfBFKIHQwvLYk/ufUZj+v0dVpWgA1uXllASlsPZgMxjdyVT7zI3qqHqe2Ug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(2906002)(4326008)(52536014)(478600001)(110136005)(26005)(6506007)(186003)(86362001)(66946007)(54906003)(55016002)(83380400001)(76116006)(9686003)(8936002)(6636002)(71200400001)(33656002)(4744005)(15650500001)(66476007)(64756008)(66556008)(66446008)(316002)(7696005)(5660300002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: MfrVYpMNyn2KrHBFcUQn+r2dsuJsB52mu3C5DS/rPY9bOXC6qhcpDFpXkPL4mgliHqMe0ZV8tGS1jqkTIvQ/KGW+yI73CNWrkyYYQ/XhKory7u9RuMaWVagnifKtUodIlNllqoxdbUSeFEOEI3/Yq9pvOGGj7vuJ0Ezm81f0cGcO7WLvPtCQv7ju+AdvLgFvnpmwvd0dtEeEDedsVqrPbpBNSiejCCO9sxNZMzc7RvWZ3sLVWyshPrSa8SzsQFlHbENotlZfC5Z4/Dz1jVP00qiEQEYw5x5pkAOeZopIqcDFtuHBqUb2YxlyRC/QCONqBOBZBilC3FTvKFHlKuuR0moPcbXB2t/lXKICc3VaSPKPO6Brl6unW1qrJx1pZWFTkbDXqWKvWlhCRzYFsdKdunHai2G48AMYVbbLIiV3GClA9O19L2UOQAR7ab8BTaz/VNNU/VTguik8XhhqplGgbKnFAtruK2qVFtNafOQk2Bksgalw3hJTb7WoG6s8E/PEsVwHDP2t9Fb7DdXvZJtvuDfmH7qNyZH599R0b0Vn/a8x9pY4eyWxFPe0SBZhoGF4KErVP7cY6bf6omJbZiTjS/Kao6qpuaP4dB5mND6ja4lBShoARgFAZbM657PYv/3ruy6vVXzVn/mqQ6Hv3y5uDg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 916743e7-c91e-4965-b425-08d869ed0b8c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 11:43:29.1473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JNqboW1q5pjzbrZoIEJrjXm98TxqJqocy9cppqOg6iFbIc3wrcyuNtHbAu9/gtS7DeSW0bvXQp8qbc8u8eIX9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3999 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo > > > > When destroying a security session, the AESNI-MB PMD attempted to > > clear the private aesni_mb session object to remove any key material. > > However, the function aesni_mb_pmd_sec_sess_destroy() cleared the > > security session object instead of the private session object. > > > > This patch fixes this issue by now clearing the private session object. > > > > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") > > > > Signed-off-by: David Coyle >=20 > Patch looks good, but you need to CC stable, as this should be backported > since the issue was introduced in the previous release. > So, add Cc: stable@dpdk.org after Fixes: fda... and send a v2. > Apart from that, you can keep my ack: [DC] Done, thanks for pointing that out >=20 > Acked-by: Pablo de Lara