From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8DCFA0540; Mon, 20 Jul 2020 14:38:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 154A71DBB; Mon, 20 Jul 2020 14:38:50 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C3C09A69 for ; Mon, 20 Jul 2020 14:38:48 +0200 (CEST) IronPort-SDR: 6OJyXieW+kwzePxXBSx8ZGFLf7SpqbVXMs1qnB3ixoTPNiDr/3br/JJ8MNeC7uDndEJEylVs+/ 7aGwnhRq7kXw== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="211443250" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="211443250" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 05:38:47 -0700 IronPort-SDR: GcphgMsV9fwJOs1YMNZS0V0omFYeqatPGfLLfQQKglTGzD4EBA9WgjXMZkyKSd7mbbO1Em/jHe 9lTR85SHRVlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="487228506" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2020 05:38:46 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:38:46 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:38:46 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:38:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TldtJQJGBOBq+9lmkgjAVGUdGguQv7CxryhAO1LlM5Chdp6RLT+YT7+DrZgbNOi8y/gQaA7ewaFI1JbJMWUyny1hHeEeZ6QWAAYfgt2iQYF8RvHoEDx+Ahg5d0xQH60j2kyXaKxdlfxasmYMu3Ma92hTzOwGrFAK4hSuDK+xi974ZPSlnMSF4UVIfAfTaYPdZxFyMazH1e3/ALY4q3/AYSQUSBpQh7uXpDbtXG2lmP40HWG0p4QJH386Ocs+JFfXTOuzHEmUfSNHCAQmzXWfZanfSZgRYHbsQOBVN9jOcbWst7+KWqcbMdlJST7mowZQAI7GT0T7TWruVZqJKmztbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXgsrU9FvlOxEFMmQTukYa7bBcHMbfy2/MHmNxPp2xM=; b=Mzy58c2cQk9VAIsueY3UbQqnLj51ablM08iyIIcex1sb8GNOXR8wSQVG1OzmeSmQ727D1Hw4+GEmYUJlbx/7xd6/RzTAVzYKhpfA/lFKiMZ3i5iuIU5ISTU1eZCmW7aNhamTBjjIOBU4nTwiQEK/0JXYSQHkNik5w3+tHZ5kK8q+DN4aFDFKsppaeJsefpH+sYewQcMDKv/W3pP+0I+VomLhsPCBwmZER0Hcrysa0mJzhT5QABViS1yrWpWEyprxjOKf98BFqQS1/3yLCCpT+1BiVMfbdbP4RjCulgeyCo+h+F86BpXe9Oqp4sBzU6Cejz19IGE6ApbvcrFPV6rTBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXgsrU9FvlOxEFMmQTukYa7bBcHMbfy2/MHmNxPp2xM=; b=C/3zn/Cp/4CAr2E1v3LkogG5MaXPqEReTA3H7KUU9yrLQq3C66pqHaN8Ib81QwwUqrWgX2s5WbqCSmHREauEhHJZTfSx+V8jo1Sf+zrXo0hUtH6IXnsxIgo6ZGC5rktZjEfMl4yOkvHZd1rWDcVAO0srwb0e92V1nFUfkihQoQo= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Mon, 20 Jul 2020 12:38:43 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f%4]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 12:38:42 +0000 From: "Coyle, David" To: "De Lara Guarch, Pablo" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup Thread-Index: AQHWW4pKgrB6aOP5GE+pc0t5DvL+P6kMKhcAgAQ/xAA= Date: Mon, 20 Jul 2020 12:38:42 +0000 Message-ID: References: <20200716153600.66071-1-david.coyle@intel.com> <20200716153600.66071-3-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.53.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f277b825-ea08-4d1b-dac4-08d82ca9d64c x-ms-traffictypediagnostic: MN2PR11MB4046: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1MdTLkVbh3XZfgKcXPbF/P4xGQ+g8EsQMVWaV67kJLhDiS/XPZtS4yXXWzJaGjLQPgzEPox3ZNSvCW0Fs/OhgR3QYBZbW8hkrAiyVui4N3RlNoIIje7Au2fLJ6CAaKGHU9ddPjF4Mqlrj3cBGaVYtj/Yk2dpjlcmUH2hMCsAPlQj8sSUibyspGdSddqolWcbnU6PQzgcsWn1G44mVhUnQE3DKkGZXIA3wum8iXy4q/bKkEhvZu99Zmd1Vh9ASBB+xWpxa3xys53X+hxVCFVzjmHYAtSWSPNpDpc1gnaG3/ZHyz6gerct+u963DxNWDeQTUoFpHNeCpFzodixgoazhw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(5660300002)(4744005)(55016002)(52536014)(110136005)(86362001)(54906003)(6636002)(83380400001)(316002)(66946007)(478600001)(9686003)(76116006)(15650500001)(66476007)(6506007)(66556008)(8676002)(64756008)(66446008)(33656002)(71200400001)(26005)(7696005)(8936002)(2906002)(4326008)(186003)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8qiVc7VAgGz2czjEH4OgRBensXslE9/JPcZthEyv0fO3VPeY+I56pcxJKdjCisXFg1hfUXBYF4GfanCcwfI547SgwTXpTYZZ7bIZAQq87zJp/RiFWMKpXiXbXtPyLc8GQY6KtOCLLc9K0F0v5/JoOt4olVOotf0Z5evCs/tGkHk6g3gy5Z1uf54l+7OOe3/9PXA0V3e73eDR/8DdOq455K+E9O2kFZj88wDZSf5lo60kfFnZ+Lqde58ETN6Uq7zEnEp/QFYwECgp7bPbb6U4Tk6ZvyiHgEuyM12HQEVDZ+QBhROyLY07DIwUymSRgUvIDd35XPXUC6VsQOftR9p0WbdWGHaXfER2A2d/C7QJ+B9vgu/sMW2SuH3LWwIYeNdDKbgPqbkGU3+We/W/eGfF5SDVh0crrCVC8881vQi5U7qGHkeZ14yzKHQGGoW77Z+QFrVkYoUxBf+zP/Pg3pSzazYLYlA2h33miwK/+9vQBW8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f277b825-ea08-4d1b-dac4-08d82ca9d64c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 12:38:42.7432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N+dfZA9TiX4G5eZNyMApAm0sAuBrGkRFUHm2AON2+7mhfTo2c4OrPHUWa1bXG5TLODdnlSiQyU9D+UPrgmBpbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, July 17, 2020 8:29 PM > > > > #ifdef AESNI_MB_DOCSIS_SEC_ENABLED > > + struct rte_security_ctx *security_instance; > > security_instance =3D rte_malloc("aesni_mb_sec", > > sizeof(struct rte_security_ctx), > > RTE_CACHE_LINE_SIZE); >=20 > I see that there could be a potential memory leak here. > Assuming this malloc works, if alloc_init_mb_mgr() fails, this memory wil= l not > be freed. > So I suggest two options: > 1 - Free security_instance if alloc_init_mb_mgr() fails > 2 - Move this piece of code after alloc_init_mb_mgr and free mb_mgr if th= is > malloc fails. [DC] Good catch, disappointed I didn't spot that myself :( This is fixed in v2 coming very shortly - used option 1 above >=20