From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13E00A0A02; Wed, 24 Mar 2021 11:41:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1554067B; Wed, 24 Mar 2021 11:40:59 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 0A9714014F for ; Wed, 24 Mar 2021 11:40:58 +0100 (CET) IronPort-SDR: Pqmn6zFkZSozZcaDYHi1lmVgbt8+RRQsIcJwRJdCip3ibLbNNsjfdCRAuTgXaR38MdHvpxOMWt c8rc5chOXHWA== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="210780660" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="210780660" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:40:58 -0700 IronPort-SDR: L9cuUQSTxUjfMVlLFO6daGg74OPDP+VUOavLSCy5axofHIJO42UwOeeIiB8tz1ZopDUA3deAfQ gT5mworlbfpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="413734158" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 24 Mar 2021 03:40:57 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 03:40:57 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Mar 2021 03:40:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 24 Mar 2021 03:40:57 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 24 Mar 2021 03:40:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8gDQSt1kUZJizAOAPCxZUpJN+OeXPArIfJkoesJeaChYt4AWFYyEpV+iCs7TtBPcU0JTUp2flmYaA41slqU4lpjV/xnWGBLkHHLYCW6VGmwyO8AztHHJ0+8+9mlrytlMIefR+Gvm1jv7uobV62n2Jw3LNi3L3ZOyqkS9HetDWrOXGyCRuLjUYgZcO4dNLb8KW56HpQqBrzo8qf96zU7dGSK4AC5Wd3lkCrWJz2Zg3pIHQbeF1EG38Spe79e1vATqHEozJBU9ifTZSs+4Q97ZzsBtdTR45lRt0qgBLJ1wEkXCMtqErW9BGdm2X1MRDZbj3AI7rnfmPlsMyj65aFTKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slysi5FsbOdvpMKhiojlX5zVhaHsPj8+jHaH/fbK3qU=; b=Q4HeOOj03KV75TB8XuNQDx1tZCp6Uuhq36zfekUowZs4Ugzg2WewOBSDXierBHTAxSBHYbJrdCEtpvyX6qAy5RmM3j+jD/kGNEax6bVXk9DwaDU8KaWnKZWJBWAuNePb8Z+WolYfn1SjohjpZwrrzt43Z+WyXdQHyPOoAYLpXrRJp2x39KULN/UJn/JiRSgQ1trZIpM8eitNnbDur3qaunn5nUfFZqlWSsFC/6v1rb4vzVjDXFzGT0CP7wjd7L/lMMD6SW58Sk5LL3qh5nBZUOz/ytQuYZt6myDn4+05VVj6H47FMewzO7r486jxEvyRmISSGUk0vwASN9BqBS1TCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slysi5FsbOdvpMKhiojlX5zVhaHsPj8+jHaH/fbK3qU=; b=F8/t7W4bWZq0PzFk1ryvOIH4RYEuMmcnH3GNMQ4AnCm7eShdN2UkHzyb06EkqnKoNY/dEEAbWLGIxw+SFD669NdkCnPhpqyWIgS6QPCRluBL+muSOgwZ6kt6l0wpV1r6eaxMIO859gip7uBmLeaSWREIvtP0Z+PD0gXeHvgiZaI= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB3886.namprd11.prod.outlook.com (2603:10b6:208:137::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Wed, 24 Mar 2021 10:40:54 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8824:3385:f40b:a60d]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8824:3385:f40b:a60d%4]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 10:40:54 +0000 From: "Coyle, David" To: "Rong, Leyi" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Xing, Beilei" CC: "dev@dpdk.org" , "Rong, Leyi" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 Thread-Index: AQHXGxGkDOPJ3I8uNkycI/YPIbJ2lKqS/Waw Date: Wed, 24 Mar 2021 10:40:54 +0000 Message-ID: References: <20210317091756.11878-1-leyi.rong@intel.com> In-Reply-To: <20210317091756.11878-1-leyi.rong@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.45.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1395bea-c763-4210-a3ed-08d8eeb14d37 x-ms-traffictypediagnostic: MN2PR11MB3886: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EPD+PChoxDIIH+v17is35CMWKlDEm1hVOmi8miWLhbh3ec8IidPcBqCOVyMehAU63g7DrbselW8+YTfbNbt9vWAg4RD8UIwE3uAE/CmW17n/cAeskS2k/XAcT+zdWn7lUGbHQ1emUyaSmhPomFL3RBfCaSfoPIAYwnnaURWJvokIwk/BMfpUu7ZGQCO1ehVi7fuM/ZpZN8Pq0wLvDU/bnXHJ5h4mKSArmSRUUVNKCITnn2j7+BXG/e+cu+YTYr33uX3n7MI3y9o3/iAzMvFl7wFRbzOLT4BCSK7S7SRa2dB6MS4qQjRlPVwryo5qyLQRWCr7kGJGTab8Lo6A01x8bYU8weTEgg2yif60cth/9/o0nE94NfuWheERNQAXA6X8gzXBECPBUzWtlmn6CZhwuFKF9g3FeybTEk/h1ryfsaCbvtVRBX2+iyS2MNm18z/+lV+OHTfS2EGPb8ZJgPq0zOXHtcWVFOmnpv2yRXmrJAM5rZ+df4tIz3lTuo4TaSl3SW8LrxBKXUo9dPPzyEsW5gXJOxIJ6ZoiDJTFHkvzEnI/m0siwWV8sO+04Ll2jNdUKKajMmgPy93GfBMfhkG6Hkqf2hnuar/7/WVpF0HPPfXPIZtMN3nfTsNOZvqJpVHS80xymlSqyJp5JMLTVj5irPVNytAO7rC5n142wVio7ro= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(39860400002)(366004)(186003)(8676002)(107886003)(6636002)(54906003)(5660300002)(9686003)(52536014)(26005)(38100700001)(7696005)(55016002)(8936002)(53546011)(64756008)(478600001)(83380400001)(6506007)(71200400001)(66476007)(4326008)(66446008)(66556008)(110136005)(66946007)(33656002)(76116006)(316002)(2906002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8dyhWfTtsnAdooP3whTnWZG2l/5DmJAIcyfaVAbDbcORlu1Pr/lfKKl+KLcY?= =?us-ascii?Q?TNHtFymY377lZja+Mc7IRZyXRORzsb0p9TpCG2lQly22APA0Cvn922liBHe/?= =?us-ascii?Q?vCqJzguU6dNMVnDeb0f6EM1YVqpaxiBVf8pakYcRc0FyxWmJnDGYhi6MbMo4?= =?us-ascii?Q?8T17dvKnxLf8u7M7Zut5Exj3pzOPtYL70G9R0758JMvSXvS2G2NeeB3i8ME9?= =?us-ascii?Q?eawhyj0vlpv2NYqjrYymkpBjQTbVhsp1oKJ7zStwjlF+COUbKlAupDSl6Jj/?= =?us-ascii?Q?jaDekScwv6BnQRkP7mk+fNHXAsF0j5/OdEQQx3rYRTM3xsc5z3ghuEaNyh8H?= =?us-ascii?Q?TEX8U4PAe/diAg2FIwQrkiSj4VTzYwluBzVaraIEKABdETGmJXmF4DBp72+T?= =?us-ascii?Q?xGqgzK1u+5mSoB5re4srv4+MTbzf/9unZh72vScpu8xeffNkjcFvWuRC/IMo?= =?us-ascii?Q?A6ciaKcRJuwGhcWjYQlmPf5j4rmWUqszjrofCmoTiN63rN2pu2sH8CWl1cnp?= =?us-ascii?Q?Qkgeqm1+5vp+bDE7MV9otXcM+dOejb13DX4HcbB8aDMufKsYdAba1oGVQpP8?= =?us-ascii?Q?n0Fs0Dh7FVSichNz+rR3gMNtTxTJLdLyM35bH7C4HQ/4Y8FxDuA6KN7cxsVb?= =?us-ascii?Q?8jW98FslqxmPxVsvuuQeYyJIbFyjrysH0WhNUvzc8nEjTaR18+cvHds6L8lT?= =?us-ascii?Q?QWiD4UkOi33EqXZ0e4zdjrsKsd6MP+WIgIOEU6VqTjdiTueHzbo/ATps8SAd?= =?us-ascii?Q?RloPSenJOWDOOlYZDPnqX1oyFeyBmp5id2T1sZaoykb+jib8L+CALmrTHxv5?= =?us-ascii?Q?h/X7KKIwfCd4/3FiiieGZ6FYDl3B11m8YXn8rLWDDIim7sB44E93KFTVb1Ms?= =?us-ascii?Q?XrgPCEbfJD9HnY2QVvyeQO7GJklk7HvmHDSqHG3GPW+Z7+5opnZyEda0sNaV?= =?us-ascii?Q?GsK0DLBfUaC3UHpyOIWJ5NYLax+tzHburrv0zesxFhjVJyM8DCj1MQlbpTlc?= =?us-ascii?Q?zlbNfcWQG9btLs9Qmw+06UeJIFb0HHPneoh9+B3suJWKnIyriulWNn53pC34?= =?us-ascii?Q?h2yRFLO7lfl9+DyLmjg889skc8vZRLxGvqgDAyxmry7qNYSE36O/AL7jI75Y?= =?us-ascii?Q?xjAbJ3zIBj5U17EweVYbJ38QchdF71fe8X130l5iS4blEMxNmplU7G1WxCGZ?= =?us-ascii?Q?RVwm5sQ1hO86m4XevvCjVjf0uW6I036+wb1dliO7qPOdkeLEjfAvwcXSSdGt?= =?us-ascii?Q?zVfbLke/9G1YuCeEjjRWfz8MumJxnVUuQzfhtgfg7bCHlN2ZaEWztNdVPH0k?= =?us-ascii?Q?I28=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1395bea-c763-4210-a3ed-08d8eeb14d37 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 10:40:54.3070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s7MTYlj3kyuNn6FKBxcsHGG2oKSMuVJdOLqvgGy5Fey6q/GKmwAD6sSwO0nOU/5Yk3LW5jzFUPgc4itDTpDm5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3886 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Leyi > -----Original Message----- > From: dev On Behalf Of Leyi Rong > Sent: Wednesday, March 17, 2021 9:18 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Xing, Beilei > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH] net/iavf: fix pkt len parsing in AVX512 >=20 > Fix pkt_len parsing when DEV_RX_OFFLOAD_KEEP_CRC is set in AVX512 > path. >=20 > Fixes: 31737f2b66fb ("net/iavf: enable AVX512 for legacy Rx") > Fixes: 6df587028e57 ("net/iavf: enable AVX512 for flexible Rx") >=20 > Signed-off-by: Leyi Rong > --- > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > index 5cb4c7cda6..67184ae3f4 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c > +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c > @@ -380,7 +380,7 @@ _iavf_recv_raw_pkts_vec_avx512(struct > iavf_rx_queue *rxq, > len4_7); > __m512i mb4_7 =3D _mm512_shuffle_epi8(desc4_7, > shuf_msk); >=20 > - mb4_7 =3D _mm512_add_epi16(mb4_7, crc_adjust); > + mb4_7 =3D _mm512_add_epi32(mb4_7, crc_adjust); > /** > * to get packet types, shift 64-bit values down 30 bits > * and so ptype is in lower 8-bits in each @@ -411,7 +411,7 > @@ _iavf_recv_raw_pkts_vec_avx512(struct iavf_rx_queue *rxq, > len0_3); > __m512i mb0_3 =3D _mm512_shuffle_epi8(desc0_3, > shuf_msk); >=20 > - mb0_3 =3D _mm512_add_epi16(mb0_3, crc_adjust); > + mb0_3 =3D _mm512_add_epi32(mb0_3, crc_adjust); > /* get the packet types */ > const __m512i ptypes0_3 =3D _mm512_srli_epi64(desc0_3, 30); > const __m256i ptypes2_3 =3D > _mm512_extracti64x4_epi64(ptypes0_3, 1); @@ -869,7 +869,7 @@ > _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct iavf_rx_queue *rxq, > */ > __m512i mb4_7 =3D _mm512_shuffle_epi8(raw_desc4_7, > shuf_msk); >=20 > - mb4_7 =3D _mm512_add_epi16(mb4_7, crc_adjust); > + mb4_7 =3D _mm512_add_epi32(mb4_7, crc_adjust); > /** > * to get packet types, ptype is located in bit16-25 > * of each 128bits > @@ -898,7 +898,7 @@ _iavf_recv_raw_pkts_vec_avx512_flex_rxd(struct > iavf_rx_queue *rxq, > */ > __m512i mb0_3 =3D _mm512_shuffle_epi8(raw_desc0_3, > shuf_msk); >=20 > - mb0_3 =3D _mm512_add_epi16(mb0_3, crc_adjust); > + mb0_3 =3D _mm512_add_epi32(mb0_3, crc_adjust); > /** > * to get packet types, ptype is located in bit16-25 > * of each 128bits > -- > 2.25.1 This patch fixes the issue Tested-by: David Coyle