From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC09BA0540; Mon, 20 Jul 2020 14:40:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C53E71DBB; Mon, 20 Jul 2020 14:40:03 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DC328A69 for ; Mon, 20 Jul 2020 14:40:01 +0200 (CEST) IronPort-SDR: vhXlSuJfbs5P2l6XRLSQbfZ3S6VBxiTDJFwMagEuzQj0CqH8wH8ZJqbcasoyPl8MkGUiw6DEzk +NCP3ZK6v4RQ== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="149884127" X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="149884127" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 05:40:00 -0700 IronPort-SDR: J95LoU64fEhPVPBID2leLkTxKxSktCW1SYj9n3C8ZZAb7znbIre8/6FI8cIyrz+mqaWEpuIW/i 623ds8L4WZ8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="326048872" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2020 05:40:00 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:39:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 05:39:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bxbe7bsNoiiszF7iUN0+5dJHFxAm8Fnid0XM2vn0xzQY9NYDlj22BzkhYpbwleZ/cwp/Q0kQKkBDZmSspDOhV0GmQES3aLlYhafUQjLOs0C6+Bcx1VRtYpgjogpwD9hRY/vUbx0BagePBhLcc9j1BXxmzCYhbYS9cZ6JaMTi+Ar9X6ro2tjdIKaMqiqh0rx+NSfKXGIeAmbL0Jy9ziq0n1r1DEANL7O39CXhHjQBwfzkU17bZp7fYqOpCDNP5rcbwqjzH/WnD1257pAZPK0XYTl53gvrz7mvGoUx6Xqg3MrdNmJz1O5wmbmprhcZ3aPMTZubszIjv7g+OwF6TmbSvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qo1FMireVju5IXRUFgxUcusifXheWk94+jzAuY46VAA=; b=bOXb4UVVKcdAf2HmVpSk4K2YYIArzTarb1/ZXWI+4VS4Z7NA8S1/aPG8O+wSwuJ9QaOwCZVeYZ2WEDk4YmnFRvZO22qTQrJrVhorAJx0/q5fLdhMdgaE9tW606FGI72wpaFAAkkXUOA7NMyFdBwNvRdqfJ39UhSNcCl8ZNIyG7Ouk7Q+GuYup0/e0dRYEX+ykf5VoCTnI/SpXLW+6u6P/+8js4BcFhd9s92bLogi14NV55dhV7QJPmnREf5Jtc5LhaRuK0B47AEzlP/Zqy2wO3swBOb/1D/0ykNrpOhTLFQGLPG97ll2PkixO/od6VmcZYZTabFNSAa4g2J9X/jCpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qo1FMireVju5IXRUFgxUcusifXheWk94+jzAuY46VAA=; b=WMJtiVIRGbpPeFZWrTRU5SMBiyLybB4+fzta8nEuXaDnaTqOdNVCQ02ApfcFMlINfB39229mSNZ2NRQN+BDvhCtoA+ycJ+iFkrU7zbnGra9NSfMQ5Tz76W5fwT7AOSZYeHoh9sYb3Ig+iejqT514PJVKs1Quq5cOQzaT2JiTnto= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Mon, 20 Jul 2020 12:39:58 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8de8:edef:28d5:758f%4]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 12:39:58 +0000 From: "Coyle, David" To: Akhil Goyal , "Trahe, Fiona" , "Doherty, Declan" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1 1/2] crypto/qat: improve security instance setup Thread-Index: AQHWW4pE1u08yFbNh0aNWk7bpeaJ9KkMFrEAgAHJNwCAAAEygIACjUsQ Date: Mon, 20 Jul 2020 12:39:58 +0000 Message-ID: References: <20200716153600.66071-1-david.coyle@intel.com> <20200716153600.66071-2-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.53.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20696282-0eeb-40b5-400e-08d82caa0331 x-ms-traffictypediagnostic: MN2PR11MB4046: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BJp4t58TaFD9zdOaMl/syrqKcyX15iBhfMWJO5BcOwwD6bFeX+Cap7OgLgwfpigauqxibwFr50aa1AG+MNUobZpvuaPhk0JZRwn9UVYM474fixSpYlvrD9JMbpwQHq0BL/plVPKt9ZEKBden5f/9G5PzU2LV/RIGVldE4CRnHKiIhagJQQy/XOSCjD07PDKdk7kfPpIcHWrIzsatHF49wQdExXB2usyqceS/1YR2qpIk5Xev+TQU+b0K6yN0JAnzVampjKJEdidsfbLKzJcyn2wVgPyNyd5B3DeCC5tJLkD740O9g/FMd4uBDa7a7t1t x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(5660300002)(4744005)(55016002)(52536014)(110136005)(86362001)(54906003)(6636002)(83380400001)(316002)(66946007)(478600001)(9686003)(76116006)(15650500001)(66476007)(6506007)(66556008)(8676002)(64756008)(66446008)(33656002)(71200400001)(26005)(7696005)(8936002)(2906002)(4326008)(186003)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: UxggSSPlRa8Vq93rhOTjebkkvu5+QyxlmPaq6zGfSoDfOFeSkw5luXBAinczyRd4HJ7gIHcvOyNmOl3m9oE7+fQs71Y69cYuXzCvAYEHMCIzu60Wdmfbydv8rhtlWpGyMdosEy8J6EEkO35LtMD8KQ7IbXqlrxX0f3Bnul9PmzjvgPwhB+Z6I0adKh9Ynm3HcfeBpwSUo/G2CkcdKAb5AKxqaoIZLUydVdhgNJAHF85D4nA8O15E0ZHDGpJ1TjG8rrm9KLzrWfqqlq3q/a82FpxotdUFuYfBQKLYfSmxC3k9HnLqsLDyW/DmruzdBFHdwcNS4vs11l6Esnn+O1GzwTm7hiktyl+e8PqWN7xUKgELWtcfc/S11a7pcmO3DPMLyNTy/y02NVTTuy8r+DzKzfe8hYJA9kF/fi8TnwST5J6xbSnEqb+D/s9Zm+5KLXqvMSV3x/nUBoUIE79RBSUgIt3EYWKZ5jFeHWymdktQLoA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20696282-0eeb-40b5-400e-08d82caa0331 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 12:39:58.0698 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N6sgE5e5gD2uXrf/qQmDk1o5puwI8atGTWVwkj4AT0AEqheEGgAEEp/MwPy37VWlOYX1uMo5T6z5q80YvmCEwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/2] crypto/qat: improve security instance setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Saturday, July 18, 2020 10:41 PM > > > > This patch makes some minor improvements to the security instance > > > > setup for the QAT SYM PMD. All of this setup code is now in one > > > > '#ifdef RTE_LIBRTE_SECURITY' block. Enabling the > > > > RTE_CRYPTODEV_FF_SECURITY feature for the device is also moved to > this block. > > > > > > > > Fixes: 6f0ef237404b ("crypto/qat: support DOCSIS protocol") > > > > > > > > Signed-off-by: David Coyle > > > Acked-by: Fiona Trahe > > > > This patch is applied to dpdk-next-crypto > > > > Please send next version for 2/2 of this series. >=20 > No this patch is pulled back. I suppose the memory leak is there in this = patch > also. [DC] Yes, memory leak is here too and is fixed in v2