From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1CDF3A0577;
	Tue,  7 Apr 2020 07:13:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C32BA2B86;
	Tue,  7 Apr 2020 07:13:24 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 1ACC1FFA;
 Tue,  7 Apr 2020 07:13:22 +0200 (CEST)
IronPort-SDR: ZCs6A1k+9FzHD1Tsd+TpDdNdzpeIJ68sX8kBMwHfbUoCSqNPiVuAVsrPYR8asXIbQDtmQ/EnM/
 tjXdehGXBEIQ==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Apr 2020 22:13:21 -0700
IronPort-SDR: fbz4/uV0v6t3DbqB2Poc9J1gZrb9zhvS9uXAW6Slk5thOIXZJU0OgF8IkXUBvOTsvuN7rHYWNB
 cpkMascmw82w==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,353,1580803200"; d="scan'208";a="361436348"
Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129])
 by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2020 22:13:21 -0700
Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by
 ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 6 Apr 2020 22:13:21 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 6 Apr 2020 22:13:21 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dt9PJpOdlGVgFCKgnc7ph7fczeNBZfAoyC0Axtbc0d8ZYHHDs6dVOlmkNbWbdvHI3E/2UJ0RJR07WKM7rHeFPJKJPh/YWmXUoHDj9+4x4WuBWNN7t2gAhdT0VHXWFVIRtDaqb8bxXfq2E8B6fWf8YBvcuGwM/wjbOOZL/D8xetX+jOWvqG+b379xXXOEfdZj/DauXfcmKRH4W+InZAnRdK+SkyoRj3bCLYTI2HoYkUF78srmJ1aG7cgttckB8U52M5IhhlI5ZoC+y41h5tnvYWfzjSuHMrmy2uNPs/FAhRJpmYXSYAkbsJ/FUKMotmgHdYjzz7gygggTDP0QhHWyaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ChzFv6xjnOwLS11/TExyvYWf619W6xHIoSJhbynJ9mc=;
 b=KtYsQ5Zfx3VA7Cfa9x+As63kqh0sETHbNi4Caq+pE7zTVuJ1nOc+WI4bWM33WxJ4UWHF0nYgjf6ghQJRRZoxkZ4ZyWzhMYbUzn0Mlx8IyjKSxEok6bMzdebJCTLCnzbUeru4oadUU0O2V1ry9z9uPCWUzeZYG7A48KnEQl2tU3U9eSCrAvk4dsyes0Rb2HxLzXo2CV5Qio5bSFB48QixsOYg+yVwf1jMLiZWpi1cPbLKbBVOHPMbtpPTxGVl8ZQrqyHJBMa2PcAdX+wdxQt8LCzb8+D5zPTHW+YMnGUBkd12qE9N+5fTc2tE5mKaUL4kAMN8xAttH+Y9uywBVHCsGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ChzFv6xjnOwLS11/TExyvYWf619W6xHIoSJhbynJ9mc=;
 b=GT6BMC5l+tknk3fWJHy2paANriUHPm1W+4B2yUziGvpseDLatdIKXkyF3Fp5fed87/gj/0piK88MHnpbqL86g09Lw7ms5+T/BGBTFPJoCbRDRQTKYL6ZRWHDZoTTOGh94DZoqfi0uzP5jNcNcch6TpeHJViJcTvf/1aoIeJ+iIM=
Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28)
 by MN2PR11MB4694.namprd11.prod.outlook.com (2603:10b6:208:266::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Tue, 7 Apr
 2020 05:13:19 +0000
Received: from MN2PR11MB3582.namprd11.prod.outlook.com
 ([fe80::f091:55f5:2e58:8b26]) by MN2PR11MB3582.namprd11.prod.outlook.com
 ([fe80::f091:55f5:2e58:8b26%6]) with mapi id 15.20.2878.018; Tue, 7 Apr 2020
 05:13:19 +0000
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v5] net/ice: fix RSS advanced rule invalid issue
Thread-Index: AQHWDIFeC13fkDMx6UqmkWXeqHBb2qhtHU0A
Date: Tue, 7 Apr 2020 05:13:19 +0000
Message-ID: <MN2PR11MB358267939DFD4CEDB51804D4E5C30@MN2PR11MB3582.namprd11.prod.outlook.com>
References: <20200319074825.16035-1-junyux.jiang@intel.com>
 <20200407014817.25163-1-junyux.jiang@intel.com>
In-Reply-To: <20200407014817.25163-1-junyux.jiang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGM1ZmM3NmYtY2M3Ni00ODY3LTg4MmMtNzVhNzk0NGM2MTQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC8wdVFKQW4wNWNpV0JuQTV4djI5SkduTnk3RlwvVmxYdlRhbHIwSnRlYitVdEFMQlF6VU5mczBES21HSFRSK2U3In0=
dlp-reaction: no-action
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=qiming.yang@intel.com; 
x-originating-ip: [192.55.52.201]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 06d8c1f1-a45e-4551-507d-08d7dab262df
x-ms-traffictypediagnostic: MN2PR11MB4694:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR11MB4694FEE74C8A55ED69CBD306E5C30@MN2PR11MB4694.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 036614DD9C
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFTY:;
 SFS:(10019020)(376002)(366004)(136003)(396003)(346002)(39860400002)(450100002)(53546011)(4326008)(8676002)(7696005)(54906003)(478600001)(71200400001)(110136005)(6506007)(81166006)(81156014)(316002)(64756008)(55016002)(66946007)(8936002)(66446008)(9686003)(186003)(26005)(2906002)(52536014)(5660300002)(66556008)(76116006)(33656002)(86362001)(66476007);
 DIR:OUT; SFP:1102; 
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2LlmfIu/H2YGIEh71koqsvlmC0IjuQXLpnSKE0aTTuTEmip90A1mggmGzZMjAU0J5FGp9W2/eXdiZW0cwj2rQrlK8+4t/4fzAgfYDShDpBK5OImEXxD7hgtj5MO8efEiXW2lvFVoy5IEMaxfMXARWrlIpSb8S3YHf9WBZ7XPQb3YHBtw1kxx2msEDkRbIiDhU9UpJmf25g8JjdcfS6mOU2zQ4jD8wpL3N9TPIzDCn7SaMPasG7DwpdyNFUdXR6p1F8cLNQxqXRl5o3o/D/7aNuojxjCPkH3H7u1cSaNutyf4pD0nM69SxG3lv6tCadRNoGy5OrBRH9+HFwxdyVqxZ2ipcso0Fr+PTXkkdjCa05p7WHa1EsJ5pWGrR66oN8G5oggh3gGKkU5mabZ3IV7lBu6jt/cW0738LosrUGw7u7K2NNfvd3VUZzxC5a61PaRd
x-ms-exchange-antispam-messagedata: emg1OL/wNdxmrDz6Ynt8f5+M9MnvghMEoIeAja4UCSEXBBAHPReSIIWSviYBsnvrTog8YWHBGQ/lC/w7oGMiv8N3HQl2FAy+ts/dpUGn0f/Hy3UgPbVv/17I1IWB9qB12+HMlhKPMHF2R6Ek1vtfKA==
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 06d8c1f1-a45e-4551-507d-08d7dab262df
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 05:13:19.2941 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0KruK98RpiZ+4JWPM/PB7NDuo3Le9XgE9dVapxwlEr3npOLJQwzIT8AZATOg+3sLFkH8PmZIj/WzWAUAPKnmvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4694
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v5] net/ice: fix RSS advanced rule invalid
	issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Acked-by: Qiming Yang <qiming.yang@intel.com>

> -----Original Message-----
> From: Jiang, JunyuX <junyux.jiang@intel.com>
> Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B7=1B$BF|=1B(B 9:48
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v5] net/ice: fix RSS advanced rule invalid issue
>=20
> This patch moved the RSS initialization from dev start to dev configure t=
o fix
> RSS advanced rule invalid after running port stop and port start.
>=20
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 50 +++++++++++++++++++-----------------
>  1 file changed, 26 insertions(+), 24 deletions(-)
>=20
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c =
index
> 85ef83e92..90a91c9c1 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -2446,24 +2446,6 @@ ice_dev_uninit(struct rte_eth_dev *dev)
>  	return 0;
>  }
>=20
> -static int
> -ice_dev_configure(struct rte_eth_dev *dev) -{
> -	struct ice_adapter *ad =3D
> -		ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> -
> -	/* Initialize to TRUE. If any of Rx queues doesn't meet the
> -	 * bulk allocation or vector Rx preconditions we will reset it.
> -	 */
> -	ad->rx_bulk_alloc_allowed =3D true;
> -	ad->tx_simple_allowed =3D true;
> -
> -	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> -		dev->data->dev_conf.rxmode.offloads |=3D
> DEV_RX_OFFLOAD_RSS_HASH;
> -
> -	return 0;
> -}
> -
>  static int ice_init_rss(struct ice_pf *pf)  {
>  	struct ice_hw *hw =3D ICE_PF_TO_HW(pf);
> @@ -2594,6 +2576,32 @@ static int ice_init_rss(struct ice_pf *pf)
>  	return 0;
>  }
>=20
> +static int
> +ice_dev_configure(struct rte_eth_dev *dev) {
> +	struct ice_adapter *ad =3D
> +		ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> +	struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data-
> >dev_private);
> +	int ret;
> +
> +	/* Initialize to TRUE. If any of Rx queues doesn't meet the
> +	 * bulk allocation or vector Rx preconditions we will reset it.
> +	 */
> +	ad->rx_bulk_alloc_allowed =3D true;
> +	ad->tx_simple_allowed =3D true;
> +
> +	if (dev->data->dev_conf.rxmode.mq_mode &
> ETH_MQ_RX_RSS_FLAG)
> +		dev->data->dev_conf.rxmode.offloads |=3D
> DEV_RX_OFFLOAD_RSS_HASH;
> +
> +	ret =3D ice_init_rss(pf);
> +	if (ret) {
> +		PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
>  static void
>  __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect,
>  		       int base_queue, int nb_queue)
> @@ -2797,12 +2805,6 @@ ice_dev_start(struct rte_eth_dev *dev)
>  		}
>  	}
>=20
> -	ret =3D ice_init_rss(pf);
> -	if (ret) {
> -		PMD_DRV_LOG(ERR, "Failed to enable rss for PF");
> -		goto rx_err;
> -	}
> -
>  	ice_set_rx_function(dev);
>  	ice_set_tx_function(dev);
>=20
> --
> 2.17.1