From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "Di, ChenxuX" <chenxux.di@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue
Date: Fri, 8 May 2020 02:54:28 +0000 [thread overview]
Message-ID: <MN2PR11MB3582D135179DE35A98A64B47E5A20@MN2PR11MB3582.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200508023617.GC75514@intel.com>
Hi, Xiaolong
I reviewed that function, it need rework, not only this coverity issue, the logical was wrong.
Qiming
> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye@intel.com>
> Sent: Friday, May 8, 2020 10:36
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue
>
> Hi, Qiming
>
> On 05/08, Yang, Qiming wrote:
> >Nacked by: Qiming Yang <Qiming.yang@intel.com>
>
> Could you post the reason why you nack this patch?
>
> Thanks,
> Xiaolong
>
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenxu Di
> >> Sent: Thursday, May 7, 2020 17:50
> >> To: dev@dpdk.org
> >> Cc: Di, ChenxuX <chenxux.di@intel.com>
> >> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue
> >>
> >> This patch fixes (out-of-bounds read) coverity issue.
> >>
> >> Coverity issue: 357699
> >> Coverity issue: 357694
> >> Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS
> >> flow")
> >>
> >> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> >> ---
> >> drivers/net/i40e/i40e_ethdev.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/drivers/net/i40e/i40e_ethdev.c
> >> b/drivers/net/i40e/i40e_ethdev.c index 749d85f54..c2d5c6835 100644
> >> --- a/drivers/net/i40e/i40e_ethdev.c
> >> +++ b/drivers/net/i40e/i40e_ethdev.c
> >> @@ -13179,6 +13179,9 @@ i40e_rss_config_hash_function(struct i40e_pf
> >> *pf,
> >> break;
> >> }
> >>
> >> + if (i == UINT64_BIT)
> >> + return 0;
> >> +
> >
> >
> >
> >> for (j = I40E_FILTER_PCTYPE_INVALID + 1;
> >> j < I40E_FILTER_PCTYPE_MAX; j++) {
> >> if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) @@ -
> >> 13311,6 +13314,9 @@ i40e_rss_clear_hash_function(struct i40e_pf *pf,
> >> break;
> >> }
> >>
> >> + if (i == UINT64_BIT)
> >> + return 0;
> >> +
> >> for (j = I40E_FILTER_PCTYPE_INVALID + 1;
> >> j < I40E_FILTER_PCTYPE_MAX; j++) {
> >> if (pf->adapter->pctypes_tbl[i] & (1ULL << j))
> >> --
> >> 2.17.1
> >
next prev parent reply other threads:[~2020-05-08 2:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 3:09 [dpdk-dev] [PATCH] " Chenxu Di
2020-05-07 5:15 ` Ye Xiaolong
2020-05-07 5:55 ` Di, ChenxuX
2020-05-07 6:30 ` Ye Xiaolong
2020-05-07 9:49 ` [dpdk-dev] [PATCH v2] " Chenxu Di
2020-05-08 2:26 ` Yang, Qiming
2020-05-08 2:36 ` Ye Xiaolong
2020-05-08 2:54 ` Yang, Qiming [this message]
2020-05-13 2:26 ` [dpdk-dev] [PATCH v3] " Chenxu Di
2020-05-13 6:51 ` Jeff Guo
2020-05-14 1:16 ` Di, ChenxuX
2020-05-14 6:17 ` Jeff Guo
2020-05-14 6:41 ` Di, ChenxuX
2020-05-14 7:07 ` [dpdk-dev] [PATCH v4] " Chenxu Di
2020-05-14 9:07 ` Jeff Guo
2020-05-15 3:22 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB3582D135179DE35A98A64B47E5A20@MN2PR11MB3582.namprd11.prod.outlook.com \
--to=qiming.yang@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).