From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 935DBA056A; Wed, 18 Mar 2020 04:15:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 033F41C06B; Wed, 18 Mar 2020 04:15:08 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8941C1C027 for ; Wed, 18 Mar 2020 04:15:05 +0100 (CET) IronPort-SDR: b9RZsFXD3B5BXRgd6m4BJFYJMyJsE3o76xLBmT+LU/np4tZit9G3qgTp6QBb9OFgjlIvIvWZJa tfRbTp84KzMQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 20:15:04 -0700 IronPort-SDR: Al15Uvk6AexcQ9Te34vf9rMTVZI3b62Kzw56T/i+wwKfauRdb3BPRaqoHPcF2nd3qqfsecEba5 3iYpOpJ31jHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="238079671" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga008.fm.intel.com with ESMTP; 17 Mar 2020 20:15:04 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Mar 2020 20:15:03 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Mar 2020 20:15:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Mar 2020 20:15:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxNq0xfPddFtwLTVAinNd++TLxO8yWEOLLV1SP3reYIEUCTAdJiquRq5zQdcrw64gmAnBsmgB34+b2DQhz6hR+t8uwN2qxmI0BvSCIpbN2WmTM3VAf02FrAH5p8GOHA3ptSBY7K6VrWA2RFB93dltO1DXjZYMAimwhv2LqJDdTUUZDeE9tztefetBCo7Gh+XEfbFhgUADnt8Ny7GFA4Va5FKU+ebRSMLr8OERSWihm5qL06CuN3JzxFC9I18y/agZZ5llnXupvaKMZ6tmVqBULTUqEGxxFlDznB2XUT7pAU8NJsYFd3w/65XPi8rFrwyP0N0HOYwh7v3347ooSpHdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jlu9WZkTL2HFd0gqPUAEfy7qpgUX8mtkni7/15pel8Y=; b=EJl0BbgYuOE4DZhl3tI59Vj6876tphoyxRr18SQVCs5uZzxFGhuf+uLzcQQiMlUj6kCBDYQEmmFZtl/G5r6UWg3RhoFbeTL5Yka21plfNcW21QQQBxgcnTWZ+cwAXvXtzudbE3nvYnsxn/nQNJjzrFSpEC7otrSTGTdJ2NaxNq7AXDS093EzlYKXvPcw3/0UJmfnF9pNUXY79y51rnOoXHDkIiNlFKRyiF38ax9O3a71Tdc7BCB/+qMV4lWhPjIysI6S9mtBGHUa8yk9Hr2wj4vYvtshiOACNQ24ZPHSj7lQRYANbyhQ7EC0eu1BdhsPFxk64TQK/AUaFmwRZ0uWVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jlu9WZkTL2HFd0gqPUAEfy7qpgUX8mtkni7/15pel8Y=; b=bE+ARQizpvoABl0a75KKOHdY19/41WB4f3FS3do/enVGaCpBHYSIFjjfKfOrwScO+1Ghb1HF5LBGbUiVK3pbogN3Op+Z0XIOFWTWnaqAz4/XCEA+9xabxbTk8vVDzOrkjGbT8fW5/OvodlxGAc3adWEHjFs+h91/yesJsyp5Yg8= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB3790.namprd11.prod.outlook.com (2603:10b6:208:f6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.14; Wed, 18 Mar 2020 03:15:02 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26%6]) with mapi id 15.20.2793.029; Wed, 18 Mar 2020 03:15:02 +0000 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" Thread-Topic: [PATCH 1/4] net/e1000: remove the legacy filter functions Thread-Index: AQHV/MhICu1AV8FG30yuhExRvmQ91ahNrJDA Date: Wed, 18 Mar 2020 03:15:02 +0000 Message-ID: References: <20200318014710.13577-1-chenxux.di@intel.com> <20200318014710.13577-2-chenxux.di@intel.com> In-Reply-To: <20200318014710.13577-2-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiming.yang@intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0bbc939-2280-40b0-d4a3-08d7caea8c7e x-ms-traffictypediagnostic: MN2PR11MB3790: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(396003)(39860400002)(376002)(136003)(199004)(8676002)(81166006)(81156014)(8936002)(66946007)(66476007)(66446008)(66556008)(64756008)(186003)(5660300002)(86362001)(26005)(7696005)(316002)(33656002)(6506007)(110136005)(53546011)(2906002)(52536014)(478600001)(71200400001)(55016002)(76116006)(9686003); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3790; H:MN2PR11MB3582.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QdHdA3X8IDnog5bHHwXZ5DyRR3YdqUCi8UNBZVPC474QIDNamgdiuCs5irBFXOf6BMg4PG3ocOq0pOoWr7+jNeemXh1mzr5y7akciaYrd3XT2PpzgEWR55uQExW0X/awyFpmd0n3WE3+dGt8GS5t8DJKdt9MbUJMBGGeMkB0+DvDvVfVvrM3KVoDAQZf8TMnM2l8X+RFWI3pVlAqZLhmZy6soQmX3A9pdpi+YWHWmvVcZMbYiF0oEhNes9ubR2+LJWo5lfGpvZ32CFhM5C/9vofdB1eIVtIJUs6vtWsGWoZ8AlQM5TBNjJolz/8juJlq1q4ty2J0rpw++0XugGN2tu5400WNFE1HZFwnUMESqjUvaOdFi9MUlzI88TEtE8kWjMJWY3T5mQ770C5fETvNe21ijMmmH+jUViR4YnX5F/21wUGv8fYPU5ys5c0ZynVz x-ms-exchange-antispam-messagedata: I02p3ErW/7qamNSnO15aVmcnM4PopBfJrnKIrrkPx1APoBm2dqsqHaLigJhywxd7pNx9s1Vqi8UFJxN55iEgriaYXDNVRqooTrNIvRGjgADllqnkkXTYWnYj3s5HBXvq9khPbWBwIaycYA8A2jMn0A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d0bbc939-2280-40b0-d4a3-08d7caea8c7e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2020 03:15:02.3635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hqoZlbmdbQX3Z3ewS6qz8AM7KGr9OmundP4E0pnNT2f66H2lqCxAeRN04NzgjTpJlVz3p3pT9VBS3r+ffrnHPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3790 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/4] net/e1000: remove the legacy filter functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Di, ChenxuX > Sent: Wednesday, March 18, 2020 09:47 > To: dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > > Subject: [PATCH 1/4] net/e1000: remove the legacy filter functions >=20 > remove the legacy filter functions in Intel igb driver. >=20 > Signed-off-by: Chenxu Di > --- > doc/guides/rel_notes/release_20_05.rst | 9 +++++++ > drivers/net/e1000/igb_ethdev.c | 36 -------------------------- > 2 files changed, 9 insertions(+), 36 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_20_05.rst > b/doc/guides/rel_notes/release_20_05.rst > index 2190eaf85..e79f8d841 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -56,6 +56,15 @@ New Features > Also, make sure to start the actual text at the margin. >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* **remove legacy filter API and switch to rte flow** > + > + remove legacy filter API functions and switch to rte_flow in drivers, > including: > + > + * remove legacy filter API functions in the Intel igb driver. > + * remove legacy filter API functions in the Intel ixgbe driver. > + * remove legacy filter API functions in the Intel i40 driver. You only delete parts of the legacy function. > + * Added support set hash function and set hash input set in rte flow A= PI. > + >=20 > Removed Items > ------------- > diff --git a/drivers/net/e1000/igb_ethdev.c > b/drivers/net/e1000/igb_ethdev.c index 520fba8fa..2d660eb7e 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -3716,16 +3716,6 @@ eth_igb_syn_filter_handle(struct rte_eth_dev > *dev, > } >=20 > switch (filter_op) { > - case RTE_ETH_FILTER_ADD: > - ret =3D eth_igb_syn_filter_set(dev, > - (struct rte_eth_syn_filter *)arg, > - TRUE); > - break; > - case RTE_ETH_FILTER_DELETE: > - ret =3D eth_igb_syn_filter_set(dev, > - (struct rte_eth_syn_filter *)arg, > - FALSE); > - break; > case RTE_ETH_FILTER_GET: > ret =3D eth_igb_syn_filter_get(dev, > (struct rte_eth_syn_filter *)arg); > @@ -4207,12 +4197,6 @@ eth_igb_flex_filter_handle(struct rte_eth_dev > *dev, > } >=20 > switch (filter_op) { > - case RTE_ETH_FILTER_ADD: > - ret =3D eth_igb_add_del_flex_filter(dev, filter, TRUE); > - break; > - case RTE_ETH_FILTER_DELETE: > - ret =3D eth_igb_add_del_flex_filter(dev, filter, FALSE); > - break; > case RTE_ETH_FILTER_GET: > ret =3D eth_igb_get_flex_filter(dev, filter); > break; > @@ -4713,16 +4697,6 @@ igb_ntuple_filter_handle(struct rte_eth_dev *dev, > } >=20 > switch (filter_op) { > - case RTE_ETH_FILTER_ADD: > - ret =3D igb_add_del_ntuple_filter(dev, > - (struct rte_eth_ntuple_filter *)arg, > - TRUE); > - break; > - case RTE_ETH_FILTER_DELETE: > - ret =3D igb_add_del_ntuple_filter(dev, > - (struct rte_eth_ntuple_filter *)arg, > - FALSE); > - break; > case RTE_ETH_FILTER_GET: > ret =3D igb_get_ntuple_filter(dev, > (struct rte_eth_ntuple_filter *)arg); @@ -4894,16 > +4868,6 @@ igb_ethertype_filter_handle(struct rte_eth_dev *dev, > } >=20 > switch (filter_op) { > - case RTE_ETH_FILTER_ADD: > - ret =3D igb_add_del_ethertype_filter(dev, > - (struct rte_eth_ethertype_filter *)arg, > - TRUE); > - break; > - case RTE_ETH_FILTER_DELETE: > - ret =3D igb_add_del_ethertype_filter(dev, > - (struct rte_eth_ethertype_filter *)arg, > - FALSE); > - break; > case RTE_ETH_FILTER_GET: > ret =3D igb_get_ethertype_filter(dev, > (struct rte_eth_ethertype_filter *)arg); > -- > 2.17.1