From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D233A04FA; Tue, 7 Jan 2020 16:25:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 138201D9D0; Tue, 7 Jan 2020 16:25:45 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 863851D9C8 for ; Tue, 7 Jan 2020 16:25:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 07:25:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; d="scan'208";a="271546914" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2020 07:25:42 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 07:25:42 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 7 Jan 2020 07:25:41 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 7 Jan 2020 07:25:41 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 07:25:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpoZnh1gC7T5l4/IJv+EDmCiosiAAM8+ddGzbC/2af4LY3s7ZeNszBCimQ8Y6mTc6fwpJLaC0LkARhJwylY9/vq0Q1ZMW3cfyblt8hVQKdsrjwex7V6UI8RvuSLDrysX267NyZlGdAibIWuD5aezJ8oALT9/0j18xcfs3qIXlNbk71DwwWthz0XJLptG4GWNWh8Z4MTIloTkcTlch2FzwanR+1FFVUUGnb0EPohvYUR2m11O/NREbhHoXaMqpYGXaNvS7C8caTbkDhev509tG41kldysKi34VHvWy3WA33SnNvUfUMrsEHQ1ntYfdJii1UWhciw0sfbmVz3aT1B5EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1oWJC/307kpbZxhBXuSosUfwNRUBJfKVD3Gz9sH4UI=; b=CpQ/ynZ9gFCDn6ZqGsRUFLkHVxxa4QNorW3IOsSclViE5rYOTZGWqPCHzaphD5VMNnMN05gisfzkqWhburP3w8awTYqYY0JT1sB8TO0jSx3zIJYUs5jb658YaJz6blgDNJWV7kVLC14b35e1iBb4Ij3yHQ5EiW4564JYCeuu2IHaGoIgmoAOQOQxZjZyplhfNTNpVY38Jx2JE8zbB8bXXYbhxedmE1I1YVzazFvvk7KSkL20nd68XRUVtVcM3SIRxd+SQTn7EM9QqksuuDI/4yTa2VPC5I/LK3eFr0STLyBzRCFliftI0hd622y+SIFnZ0uWHfiIoi72tzILTEqqaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1oWJC/307kpbZxhBXuSosUfwNRUBJfKVD3Gz9sH4UI=; b=BRZsEveUJv9TzCi1+D4pY/AIcRtA8UjSvxBnI96wB2XWkLoAGKYS7961Og7CsQWxRh0jzFzpWiiJh+xiq6PxR1cvIUjUzWSaMFE9zeZFACOEvRzvQCi+ADTLaqGBQHYhtVxSpG00bFPucZd9WfaDOg/q3hWR8iR+cFPRb6aXe5A= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB4335.namprd11.prod.outlook.com (52.135.38.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.13; Tue, 7 Jan 2020 15:25:39 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2623.008; Tue, 7 Jan 2020 15:25:39 +0000 From: "Sexton, Rory" To: "Xing, Beilei" , "dev@dpdk.org" , "orika@mellanox.com" , "adrien.mazarguil@6wind.com" , "Zhang, Qi Z" CC: "Jagus, DariuszX" Thread-Topic: [PATCH v2 2/2] net/i40e: support FDIR for L2TPv3 over IP Thread-Index: AQHVs/puHnoAOI0Zx0iCHm7vRxkk4qfKOj2AgBU5/NA= Date: Tue, 7 Jan 2020 15:25:38 +0000 Message-ID: References: <20191216101518.15666-1-rory.sexton@intel.com> <20191216101518.15666-2-rory.sexton@intel.com> <94479800C636CB44BD422CB454846E013CEB187A@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CEB187A@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2MwZTI0NjktMTkzMy00MDc3LTgxZTAtYWMxM2Q0YjYzMjYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY2ZLVFpiWnE5U3FTQjJ0cXFveEErZjIrR012NkUrS3JEVnVxcWtqWUhsMTN2WFVuZVM1UmFWT0U4Z01RSzFOUyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51c6dc51-3d14-45a3-ee50-08d79385d9db x-ms-traffictypediagnostic: MN2PR11MB4335: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 027578BB13 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(396003)(346002)(366004)(376002)(199004)(189003)(66946007)(478600001)(64756008)(66556008)(66476007)(86362001)(110136005)(33656002)(7696005)(66446008)(71200400001)(5660300002)(4326008)(107886003)(76116006)(26005)(316002)(81156014)(8936002)(8676002)(186003)(2906002)(55016002)(9686003)(52536014)(6636002)(6506007)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB4335; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P7S7dfR4e5isVyx/+f1AmqmKnCVBRiaakl9qmdjxr5AGg/vrN5qRWtR+SNsjg4ieKZAv2P8zxOIG7GsCjmcoyOC3wnpxujQDW78QRiX5IICGMzkGjuoWIJI992n3LpubDgfAb0LCnV4OdR09El44py+H7vaanwTtime9uObiuuf8v2oUlnWRvYTICdq2Dt1bMHGKrSMZwziKqRoOPty4aZZwNbdlT4Fh0+5KG6NMVBRm+BAqxFyylFyt8FPN9o255Mbiq9UGvB2UZBxEZN0k/WW9XkbsANJ+hfdq+J5DiJGvXs31FrWrwA+yx29f/3mX8wpNxQDnXjFXZeqKB9ayWykddxqgzg8on/L5z+OLt3+Kz4qQB8SFFnrs2wE2haYFl+tEdJdJds2v0I4TwVQ4FHpc3jxemXmNzzInozF3CRtdmddGokV4BzDcx53bw467 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 51c6dc51-3d14-45a3-ee50-08d79385d9db X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2020 15:25:38.9917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oIZRalfxafWwV/AgtNhFWRdZ1ktDGZc1ZoAb7WXuNfu2eXY9S3V/PwzD4qALofc4LpkFX4avgg0/UcrCh9bI9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4335 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: support FDIR for L2TPv3 over IP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei, I have resolved all comments below in v3 of patch. Rory =20 > > Adding FDIR support for L2TPv3 over IP header matching and adding a=20 > > new customized pctype for l2tpv3 over IP. > >=20 > > Signed-off-by: Rory Sexton > > Signed-off-by: Dariusz Jagus > > --- > > Version change is needed here. > Thanks for noting, will fix this. Just getting familiar with the mailing li= st process. > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index 73ef0b41d..5e6935829 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > @@ -3954,6 +3954,10 @@ This section lists supported pattern items and=20 > > their attributes, if any. > >=20 > > - ``proto_id {unsigned}``: PPP protocol identifier. > >=20 > > +- ``l2tpv3oip``: match L2TPv3 over IP header. > > + > > + - ``session_id {unsigned}``: L2TPv3 over IP session identifier. > > + > > It should not be a part of this patch, which is focus on i40e PMD. > Good point. Moving this change to separate patch where testpmd changes are applied. > > diff --git a/drivers/net/i40e/i40e_ethdev.h=20 > > b/drivers/net/i40e/i40e_ethdev.h index 295ad593b..5b6d43556 100644 > > --- a/drivers/net/i40e/i40e_ethdev.h > > +++ b/drivers/net/i40e/i40e_ethdev.h > > @@ -508,24 +508,43 @@ struct i40e_raw_flow { > > uint32_t length; > > }; > >=20 > > +/* A structure used to define the input for L2TPv3 over IP flow */=20 > > +struct i40e_l2tpv3oip_flow { > > + uint32_t session_id; /* Session ID in big endian. */ }; > > Is this structure needed? > This is unused so will remove it.