DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sexton, Rory" <rory.sexton@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge
Date: Tue, 21 Jan 2020 16:42:54 +0000
Message-ID: <MN2PR11MB3678A28E5AE04DB0B646478DEC0D0@MN2PR11MB3678.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB39146BA2116AC6283E1D3C19EF0D0@DM6PR11MB3914.namprd11.prod.outlook.com>

Nack - if statement should look like this:
	else if (pctype == I40E_FILTER_PCTYPE_NONF_IPV4_TCP ||
		 pctype == I40E_FILTER_PCTYPE_NONF_IPV4_UDP ||
		 pctype == I40E_FILTER_PCTYPE_NONF_IPV4_SCTP ||
		 pctype == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ||
		 pctype == I40E_FILTER_PCTYPE_FRAG_IPV4 ||
		 ((is_customized_pctype) &&
		  ((cus_pctype->index == I40E_CUSTOMIZED_GTPC) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV4) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV6) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_ESP_IPV4) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_ESP_IPV4_UDP) ||
		   (cus_pctype->index == I40E_CUSTOMIZED_IPV4_L2TPV3)))) {

-----Original Message-----
From: Iremonger, Bernard <bernard.iremonger@intel.com> 
Sent: Tuesday, January 21, 2020 4:29 PM
To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Sexton, Rory <rory.sexton@intel.com>
Subject: RE: [PATCH] net/i40e: fix i40e flow director merge



> -----Original Message-----
> From: Iremonger, Bernard <bernard.iremonger@intel.com>
> Sent: Tuesday, January 21, 2020 4:02 PM
> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z 
> <qi.z.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; 
> Sexton, Rory <rory.sexton@intel.com>
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] net/i40e: fix i40e flow director merge
> 
> Merge of i40e_fdir.c added checks on cus_pctype->index which are not 
> necessary and caused flow creation for ESP to fail.
> Removed the added lines to fix the issue.
> 
> Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over 
> IP")
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  drivers/net/i40e/i40e_fdir.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_fdir.c 
> b/drivers/net/i40e/i40e_fdir.c index
> c346073..1d7c392 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -1063,12 +1063,7 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf 
> *pf,
>  		 pctype == I40E_FILTER_PCTYPE_NONF_IPV4_SCTP ||
>  		 pctype == I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ||
>  		 pctype == I40E_FILTER_PCTYPE_FRAG_IPV4 ||
> -		 ((is_customized_pctype) &&
> -		  ((cus_pctype->index == I40E_CUSTOMIZED_GTPC) ||
> -		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV4) ||
> -		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU_IPV6) ||
> -		   (cus_pctype->index == I40E_CUSTOMIZED_GTPU) ||
> -		   (cus_pctype->index ==
> I40E_CUSTOMIZED_IPV4_L2TPV3)))) {
> +		 is_customized_pctype) {
>  		ip = (struct rte_ipv4_hdr *)raw_pkt;
> 
>  		*ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4);
> --
> 2.7.4

NAK, causes problems for L2TPV3


  reply	other threads:[~2020-01-21 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 16:02 Bernard Iremonger
2020-01-21 16:28 ` Iremonger, Bernard
2020-01-21 16:42   ` Sexton, Rory [this message]
2020-01-22 15:20 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2020-01-22 15:48   ` Sexton, Rory
2020-01-28 13:48   ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2020-01-29 10:10     ` Sexton, Rory
2020-02-10  9:19       ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB3678A28E5AE04DB0B646478DEC0D0@MN2PR11MB3678.namprd11.prod.outlook.com \
    --to=rory.sexton@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git