From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91AF2A04E4; Wed, 12 Aug 2020 04:07:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAED11C0B4; Wed, 12 Aug 2020 04:07:58 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6B8531C002 for ; Wed, 12 Aug 2020 04:07:57 +0200 (CEST) IronPort-SDR: ERJx22yfJ9Ds6OInjTSa+rvWwRD8PoKGKafD+QfaL/jO4p+fVSPg6KAfG/atFktZM1EUtf/m2V C2p7W2QU+dOA== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="133922936" X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="133922936" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 19:07:55 -0700 IronPort-SDR: 1oBu74FJfbzhignwjzjdC7+sJ602zrNtUoO3ZZuu20YLKmmYi7fUgmMLYnouQLLAOh1oSKCwdV 6xpJUOzgzEpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="317933746" Received: from orsmsx602-2.jf.intel.com (HELO ORSMSX602.amr.corp.intel.com) ([10.22.229.82]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2020 19:07:55 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 19:07:55 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 19:07:55 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 19:07:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HyUgQIjhHNCyoWAgq2NW+azBB3JQEmGAcaqp0ma016bViytYvFEpoJaGnaM4bHQmhFojGsb8swtHbR6Hr1uBl0rpHWKiEzPHfuP0uVhPvtNWUuUAskBXCznPRYg1QZsuEWrXKhkxxQPQCH+h05pAF0h6oxf3PH4qI26H8dCdu+o1X+oc2ADJvKqbGsqaNeB6ZVSHGeupwwDIFgQxWOPUF+QUyjeIi00xxMYkdpu2YYXQRLUIpCFWZGNpvbxaak5Zxcrm+wZd8rVoq7yBlM962WUntR0/0iCY/JmApihJXDhYRuln6kV9lriaJaKYB6PlMEpwlx6VTIcnZHOVwhY19w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IP2ALUH/NrRTUZNm5LAJct9+QdWj82jsV+UGt9BUDKc=; b=MWYDvcTICSTJuLLQFR2s1QE9xVHMTtFRaWJACaEfipbTLvM7ipHT8mjaNtgODrCIGyw1JkMn7pLUJM4y+aXII8x6yUQOHxogNrKsTAWUO8IfJoqSrI2BjuZ/2j+untAgfwSpr49eTU+x0v4uA8VE3ec+cXJ7rIo1EdbieVK0dDd67L6UoQTpZ1tQdmrJgvw0F/WjrUIm78xOrUybqRHd1ealLCI2SNZm+tKBojHO7jdIhAxtYVEAQSr4UfUsSTQwhNOIPaRn2wVo7HdMvryh8XxG7NQw7pyVjLi/eR+j+IDbKrXVuJBrpNkTjwh0jkMaX572+bXVZ+4DGv1IRSCj5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IP2ALUH/NrRTUZNm5LAJct9+QdWj82jsV+UGt9BUDKc=; b=ys/byc55TsXaL1HFYe61b5FeEINeryuQBTGCozmVWjfl1LQ3GozFx1DKAdvg7HRtzBlC9TK3r+idJO5QqFOMuxBZkNhHnMkZmRHGtzUBJIUhTh0K1brCItpSd7XGB8DIsw0wkZKOP9/8g3YzlyRkrS+uqx/0lVEgrB4fJVOKkgQ= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3983.namprd11.prod.outlook.com (2603:10b6:208:137::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Wed, 12 Aug 2020 02:07:52 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3261.025; Wed, 12 Aug 2020 02:07:51 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH 1/7] net/iavf: fix scattered Rx enabling Thread-Index: AQHWb6uTVKpmFfBfcEeq5ddK1HW6Dqkzuf9Q Date: Wed, 12 Aug 2020 02:07:51 +0000 Message-ID: References: <20200811062917.7007-1-stevex.yang@intel.com> <20200811062917.7007-2-stevex.yang@intel.com> In-Reply-To: <20200811062917.7007-2-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cba02015-7a36-4ea3-30af-08d83e6484da x-ms-traffictypediagnostic: MN2PR11MB3983: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TDm8L70bKtulmW7B1O7l0nLJ/impGzONb7tVywDAodXcwZohlm5K5QrRXOa9I8pFK1TEqUYAYRtsdgW45cQnpZeXw8Fdb/1322daJpn/AEMmHQPP5YQXTJEyWgPVW2Bo3D6kpV616qERe94dfywh1I4DETxqOYUQ0W4aP+niflAuCDz4wVHwS4d8wC1Gsi0Umpv6e3f+tTFpHt9exR+esJmo0gymSRk0DxYe4ztri1PFzshL4RpI5cjlzy5gznOGX8RnwFFojzbxFw4RfSSb4j58eIa6ZGnIsQ7XKvlTSZv5WauqRRAwuFD0rElHpM8f x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(8676002)(52536014)(66556008)(64756008)(66446008)(66946007)(66476007)(33656002)(8936002)(110136005)(478600001)(7696005)(71200400001)(5660300002)(86362001)(26005)(76116006)(316002)(9686003)(53546011)(2906002)(83380400001)(186003)(6506007)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: pz+YNSMpqbtpuVwbH9lNUFPLQb7YEwpqSTknHndZLWElhbPnosgU745PhCojaCEwmFrWf8/W975VfSEstrNzZ3thUnR+lr9g18yOdA7uDRrAuMo/KTUxFXUtHjxEEqMNsiT2tNY4Y++hmPX9zHLVj6nrlydh3DC99xqTVR6daWO+i/m5zNPVc0Z0Mrhi3q78Nrig9MJ7h1zmqHc6jrqFj1VIGAr5jI7JUmuTeqiKXpudGhqIfYRbO1AMxkOy1Ys7cWwhsx1Vn1Inlx5eJScANOyXhcbsysm6Q8c9w6oapDH2cKNzxwz3Qttbx7Z0pC8OSDr/Ffy0e9Mvhlrsmg+BwIKGFi8ysHc2l2/qpyol0slcyRJraA5JxLg+eFqrq9Kkb1HbgECO3tFzHkXh1WTBT3arXUjU+cH2xRUWCav1WeenRVN4Mglk6elCdJbjiHLSPd9ii4q1mYr6oHCPwuOxQbDwg3bnJ9kEjFEEiRvIHW+ZLuurn7DrpxRhA8gg9cCdmi94bRFxWXXCLkFlnjD4tru9xfTMfj0w07uIqSzmqbbbv2c9AYvjBD4GRsJtNmh0v7J7OQMa3llBaSy1SVsPbItMVCslIaiaYBjQlVtx2eU3jjiPur7RxMcxyixd1XJ4bfFOEhH//uZAmb6kki3Y/Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cba02015-7a36-4ea3-30af-08d83e6484da X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 02:07:51.7889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +PHdcwamPXnRBhEFp3PU3qZP7/xLwMzjOOR4yGEB8AAtd8lqEWAK7f4WxygoK7FGp2douaHTICDF4LS+7NFsAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3983 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/7] net/iavf: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, SteveX > Sent: Tuesday, August 11, 2020 2:29 PM > To: Wu, Jingjing ; Xing, Beilei ; > dev@dpdk.org > Cc: Yang, SteveX > Subject: [PATCH 1/7] net/iavf: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, the AVF is for all intel NICs(i40e, ice now), so please also check ice driver. BTW, please check with the original owner if the fix is for DPDK PF or kern= el PF. > queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vlan > header size. >=20 > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") >=20 > Signed-off-by: SteveX Yang > --- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index c3aa4cd72..f9dd5710c 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -253,7 +253,7 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct > iavf_rx_queue *rxq) >=20 > rxq->max_pkt_len =3D max_pkt_len; > if ((dev_data->dev_conf.rxmode.offloads & > DEV_RX_OFFLOAD_SCATTER) || > - (rxq->max_pkt_len + 2 * IAVF_VLAN_TAG_SIZE) > buf_size) { > + rxq->max_pkt_len > buf_size) { > dev_data->scattered_rx =3D 1; > } > IAVF_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); > -- > 2.17.1