From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F22A2A0A03; Mon, 18 Jan 2021 09:27:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D53CD140D24; Mon, 18 Jan 2021 09:27:18 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E4E17140D22 for ; Mon, 18 Jan 2021 09:27:16 +0100 (CET) IronPort-SDR: A1dWJqXrBoXGwUXr/6hTI6EknVlC2zUCw3X3ddVYOeq//DcfUL0W4dwpIjV9OFJYdlnWaiCw7x KiQOZAiIvV4A== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="166441726" X-IronPort-AV: E=Sophos;i="5.79,355,1602572400"; d="scan'208";a="166441726" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 00:27:07 -0800 IronPort-SDR: KqCvasnmu+7tQQ18VJbvmMiRbKPYaSyBo9mEj+8tmM4/gTTBEiVLrxrjQCf7YSZIjT+/BJ5zAa /+aGAHalMMdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,355,1602572400"; d="scan'208";a="466293546" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 18 Jan 2021 00:27:06 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 00:27:06 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 00:27:06 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 18 Jan 2021 00:27:06 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 18 Jan 2021 00:27:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWEiMatfNI9Kn+4vByJP9joyjlJqrwrjhrETGLrNI2u0ruNCl89ZFAh8Qp7G9lHdR4t8RnLJzecmhfMvUDdTt8eVLpXYDjqL15UjaQkeeM6MhHGtAoxkW86FpmxOFQJLXSXyfu+ML5CkFK6q0FjVCYNxEL6V5ebRthe9LKyLk7WHJTMRGb23V7/2zNb9xpJhZUZOR99rWklQuWflMqtMNgG5bfzLBSmjM9P/ZNZmxPoA6crdbEoAqtjLdQboT0f0bXQ6DYmDH57Wa3ELndv7cabCisxCdkBKLMHe/JZZPbgaKXpUVQ8JJrsN3jrZT0kK+Q0GEuBwAF68g4C4sQyreg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rCZE9DF73TQyFGOKVpqF9QvRwmulz6DSB8gsXnQr7T4=; b=TQpDWv+HdzZMDbPZw6av/aAtpwl/rqJKkmgdgstZop4NkoROHW5783lgzrxL6n7G68iVkVwoNpIO36xoSTIjdlZzjJj85YFYWAfsEKySahZUdStSsPmJMTqhZ8Orq3ZnB6qhYNatmr28b0n+UTUe/3JP0PRvIP5Zcj0C/OiligmWIxFvFryMbDHctXgZAP2Vx2mnEnVsnVHkwZCIFvaVl0lP7jTpLPGl3ScWOmBhWM488Cs5naeOfFsyZCZ/W4OyCyZReelRW0Ke0vDiZAEkGyz7b1YBmNTmrJTIESQUeoJ1WX1etpQgvVx0N8SGGonL6/GzZ1ny2lJ2gAUaSg+2pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rCZE9DF73TQyFGOKVpqF9QvRwmulz6DSB8gsXnQr7T4=; b=ESmbvyHG3dxm++phSxTs+iFwXNRKP50r3Ps+y6c48WPxm3ZPG6jI/mRoYHNg3RMmXsWMdjdUtPVabK+mUg+cXZjg1w6Ew2BOBW1PAzMHQjUGXqFkvKk9Yz3MbsVrObUFNSy9tKZEE2/ywP4EuQjZa/FXPsdg2dhrA7tJKW85ev4= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3629.namprd11.prod.outlook.com (2603:10b6:208:f0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.14; Mon, 18 Jan 2021 08:27:00 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4d7f:d51:79bc:e596]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4d7f:d51:79bc:e596%4]) with mapi id 15.20.3742.013; Mon, 18 Jan 2021 08:27:00 +0000 From: "Xing, Beilei" To: "Zhang, AlvinX" , "Guo, Jia" , "Xie, WeiX" CC: "dev@dpdk.org" , "Zhang, AlvinX" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable Thread-Index: AQHW6xlUbPgxtujVQUiYvchk7J5pQKotER3Q Date: Mon, 18 Jan 2021 08:27:00 +0000 Message-ID: References: <20210114065248.17160-1-alvinx.zhang@intel.com> <20210115083411.9324-1-alvinx.zhang@intel.com> In-Reply-To: <20210115083411.9324-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 658fdcb1-3d8c-4fcc-1b66-08d8bb8ad3e5 x-ms-traffictypediagnostic: MN2PR11MB3629: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:109; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5xl19wZ+HfkgekhKdAqOcWB7Bn1h9761iSKAlIcPdjRX1oPmvt+hhBryiB6+95YbGHUcsHEJXXER5IJge48cUKFmtRRNPsIqv54qN4JXvY/AtccsNCXYg/eGS3B7ajHFE3SIc5QByC0WIb+kk0ktT5iIAkm0/WKFzTG9y79ucIHLxBzqttI1f2ILtcxhyTF2twkmfO+QiP6SBgV1HE3t91Jtk2XR3MSp4qQKHdPN9sqPFQOVsyR3g4Q0BW5B2dGSeMYXyZv4BlAUxi7jNa7vbL2uNW2ouhxT/gHeL8h9DSQOy7rNPEaUhQTtqHIUStw+LPZAdz4Mvq33+AqbYykGgVIDueotQkmY/9B2ZMi/SQpCFoTMU9Avs+GQwG+Efxo73PjRCAZYj6JR2prdqaXS0JD9Y4dKDghL0SOeiwNRTa468NgU8nPUg1jHQJej0vLlFX44oooL10Qg2y8kE8sIXXGB9FO06TSnfMmb6vLsIthsL5vmPatYPMzwJSzSJm2gRyU+FRDht0L257XvqKJS2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(136003)(376002)(396003)(9686003)(5660300002)(8936002)(107886003)(4326008)(316002)(76116006)(83380400001)(66946007)(52536014)(55016002)(66556008)(66476007)(64756008)(66446008)(71200400001)(6636002)(8676002)(478600001)(86362001)(6506007)(2906002)(26005)(186003)(33656002)(53546011)(7696005)(54906003)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?mea/T6ZMn9YLahRurp56GxYnVC2Mon8a0FF6Vf4dvi+Yd0kkSeE/clYZWQpF?= =?us-ascii?Q?eBXRWmoly1Z9iSuRQeCH5YfREDUv7q5BIPo1A1SYwFqEEBojjy2fpZOQIci6?= =?us-ascii?Q?z9x9fd/5lK1KBxWeX8nQNE3houURnZARdnhRHiVX90GyAtZhoRZtyZwOFnQv?= =?us-ascii?Q?Es1cL6qa3VD9cCe/ERelYcV1WaOcOH5HF6vhIzf4RyIGGVTVx4egQSZLqkya?= =?us-ascii?Q?U1zRqjgrngZaG7d/LCOn4SwqZgnR/3OrKpUob5ohLUJbFd0j32wRqGBWK+Fk?= =?us-ascii?Q?4ZJAeZh06Tw7Jpf9kStkOSLw+ndKDwEI3DOKpbK/S1JlyO+nAW1A3oxzfCbB?= =?us-ascii?Q?0aWOQgpn/sHaiHnSwX0paLXUi/FBYLhOK0CsBJRX9rxxai6Zy15Q1dSvgNdE?= =?us-ascii?Q?Ruk4gG3e3XCTGrxzg8k26tK72GFB7chCI93lL130mNXDEp6xqLZ8cmLmFzLd?= =?us-ascii?Q?Xh+b3rv7RDD22U5Bdd2g1sn63oEk2ZWzOxBe5xr5W/usgCCnCfAI/k1KVMYM?= =?us-ascii?Q?MZLOf58w875bL2d1qsbLonk8f6F7iMq2arDYwJHQR9svLDCvBeLGj2VOE0zw?= =?us-ascii?Q?6zhcT04BTJX5HyY8pz5J0dv8c9sD93SoX029jsC3yT5f4wwIyCXhtc0Bq9Ov?= =?us-ascii?Q?7n+bkU1dWDsp3RMTMgFA6v5wuFzuz9e7/ME70BEJRQ1VPq6MWHQwXwyzkzrX?= =?us-ascii?Q?CLm3SCXc+IgGoeGXk36d1EWAuqafuaR5Xm8AwV7L+acb3aBTQJ0gk6ZmHA4y?= =?us-ascii?Q?CuxpTChswlZ2/ygQdtTm4bVBs5TmsbIFuI0UFIRiBZu6ayxniSSr7pPw4t5K?= =?us-ascii?Q?uIm20KQwQTZCx7d0vetcyUvHtHELLptJRcJgMH8D+WkCG4CvtnC8A8stXd2A?= =?us-ascii?Q?cjjh7YT49UswpjmLaAF9OKmuymYPaBw4lbfBsYZHp3Fn7lSmWJLwHvA3npUs?= =?us-ascii?Q?5dr4VIqQQoEHXbeh2O+n3AOnrOLTwf1cUtJZoeL1VAw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 658fdcb1-3d8c-4fcc-1b66-08d8bb8ad3e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2021 08:27:00.6314 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s5ayYrOrMPoCq88eiqXH6Mzm68yaX3moRkAfZU21oIhlziaKo3ZWhOHLZOctFUcN74W/DwiE3Sj+Tl9sy1M/bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3629 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Zhang,Alvin > Sent: Friday, January 15, 2021 4:34 PM > To: Guo, Jia ; Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable >=20 > From: Alvin Zhang >=20 > Using "key", which points to an out-of-scope variable "rss_key_default". >=20 > Coverity issue: 365293 > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") >=20 > Signed-off-by: Alvin Zhang > --- >=20 > V2: Update the commit log. > --- > drivers/net/i40e/i40e_hash.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c = index > e07f806..83a9af5 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -901,10 +901,12 @@ struct i40e_hash_match_pattern { > PMD_DRV_LOG(WARNING, > "RSS key length invalid, must be %u bytes, > now set key to default", > (uint32_t)sizeof(rss_conf->key)); > - key =3D (const uint8_t *)rss_key_default; > + > + memcpy(rss_conf->key, rss_key_default, sizeof(rss_conf->key)); > + } else { > + memcpy(rss_conf->key, key, sizeof(rss_conf->key)); > } >=20 > - memcpy(rss_conf->key, key, sizeof(rss_conf->key)); > rss_conf->conf.key =3D rss_conf->key; > rss_conf->conf.key_len =3D sizeof(rss_conf->key); } > -- > 1.8.3.1 Acked-by: Beilei Xing