Re: [dpdk-dev] [PATCH v3] net/i40e: support cloud filter with L4 port

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Sun, GuinanX <guinanx.sun@intel.com>
> Sent: Tuesday, July 7, 2020 2:34 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Sun,
> GuinanX <guinanx.sun@intel.com>
> Subject: [PATCH v3] net/i40e: support cloud filter with L4 port
> 
> This patch enables the filter that supports to create following two rules for
> the same packet type:
> One is to select source port only as input set and the other is for destination
> port only.
> And the supported packet types are UDP/TCP/SCTP.
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> v3:
> * Add limitation to i40e.rst
> * Rename variables.
> * Fixed the variable assignment.
> v2:
> * Fixed code style and variable naming
> ---
>  doc/guides/nics/i40e.rst               |   9 +
>  doc/guides/rel_notes/release_20_08.rst |   8 +
>  drivers/net/i40e/i40e_ethdev.c         | 200 +++++++++++++++++++++-
>  drivers/net/i40e/i40e_ethdev.h         |  18 ++
>  drivers/net/i40e/i40e_flow.c           | 223 +++++++++++++++++++++++++
>  5 files changed, 457 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
> 00c3042d5..98a5537d7 100644
> --- a/doc/guides/nics/i40e.rst
> +++ b/doc/guides/nics/i40e.rst
> @@ -736,6 +736,15 @@ with DPDK, then the configuration will also impact
> port B in the NIC with  kernel driver, which don't want to use the TPID.
>  So PMD reports warning to clarify what is changed by writing global register.
> 
> +L4 port filter

Please don't use 'L4 port filter', there's no such filter type in i40e pipeline.

> +~~~~~~~~~~~~~~
> +
> +L4 port filter is a new type of cloud filter.
> +It is possible to generate two filters - one to select L4 DST port and
> +second to select L4 SRC port.
> +If the L4 port filter is used, the cloud filter using inner Vlan and
> +Tunnel Key will be invalid.
> +
>  High Performance of Small Packets on 40GbE NIC
>  ----------------------------------------------
> 
> diff --git a/doc/guides/rel_notes/release_20_08.rst
> b/doc/guides/rel_notes/release_20_08.rst
> index f4b858727..d7d4c4e3b 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -108,6 +108,14 @@ New Features
>    * Dump ``rte_flow`` memory consumption.
>    * Measure packet per second forwarding.
> 
> +* **Updated Intel i40e driver.**
> +
> +  Updated i40e PMD with new features and improvements, including:
> +
> +  * Added a new type of cloud filter to support the coexistence of the
> +    following two rules. One selects L4 destination port as input set and
> +    the other one selects L4 source port. We call it L4 port filter.
We didn't call it L4 port filter.

> +    But there are limitations on using the L4 port filter.
I think no need to mention the limitation here, since you have added in i40e.rst

<snip>