From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86FA4A0C47; Fri, 11 Jun 2021 03:45:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06A244067C; Fri, 11 Jun 2021 03:45:19 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E91D14014F for ; Fri, 11 Jun 2021 03:45:16 +0200 (CEST) IronPort-SDR: awz519N0l1bMLn9BdN+tC9oPrlAymuz8hY+XmDlkOTWeeqLtZXCJCL91jEK6qx8jfhf0gqlhBI eZjJ26Uyt4vQ== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="202415278" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="202415278" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 18:45:15 -0700 IronPort-SDR: pU/wPEu8p2W0ey2jpY3MLx8E0k8vgk5VQdFn77/dwPP5trhAipl3leqFol7adhMvIaNv2kMi7o Qrr8l3xBymrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="448946727" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 10 Jun 2021 18:45:13 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 18:45:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 18:45:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 10 Jun 2021 18:45:12 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 10 Jun 2021 18:45:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mAaSV63Q13le/eruIDGfJA6blN+WrBy1rY4NhktUS8e1TdTm8gxVSeuJjC6Cdd5R3DaHjFnhjiguo1zZGjYK9ZOysQKdENf0Ii1/eC+9pi2HZZgpoEJYLL8wFXkBL+zeXFrU2g2FJvs7HID/jC3OtuZIUix4gpdwRV7wpa3bf7XsS1ndB5M20Bqn2UQnpRrsK/MuKfHv/ngvnP4W2FIFS7vtJ8m0lPdHfs8YlGkvxUpAkTLrWe/2FDmrkjnwZHDFHyXKHqPBlab9bI7RX1aSxrY5sTbBJE3sBuKALlHD7D2tuetlTw7mwcOzJXzvCtDrvJJm/Ncs2D+nFmJoeZ2zuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+4A6S7d2d8VkE4qvmV2VzDDPCfFH0Pi/O3HL/VnRODk=; b=HpeMqKokIqo0H2wOzl6DHDHL8VkBmTZas/ygQKXebwXPgaJtnpWN2ztUPPoQDeI6G33UxWi2yiIF4Ho/UyLfLQTEVPKzWRdNGx3Ynpj4OWoZSbUHKvnhqUZRWty3++KV1OSEr5BSm2PM97sG3vTsRn2HqNP5ynIZxvdoq5+Uf6Mnrp6VzqBsufPm4Tpf+U0Dgg4n/BWCP/s3b/XHKfMotIrus1HjwJ6UkB9lnHxYc4U0BemIV4Wp5nrXBMB7gST2KkZ2IPtItij3GFfmYKGfxIR7WLXATrQPKstJ/PZzphsGnC8/S8YMKe4vnO9nI14B+bI7UyOCJjywgrynqCtypg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+4A6S7d2d8VkE4qvmV2VzDDPCfFH0Pi/O3HL/VnRODk=; b=A4+qIyOgx+1umMnwHjfl61wNQrAc70YQte+YoJMiBEMH8fuHs9jGETZNvVWRaVH6QW9U1P86ODQtrbG6L2BIfk6VX6EZ6PS9a3RmjaFiU6ZZpaeC2wOlq6T4LMn7L5Uy5YoVln88DLipi3MO4ehdrs6uNyQuEh/+wxE7d/cpl6A= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4142.namprd11.prod.outlook.com (2603:10b6:208:135::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Fri, 11 Jun 2021 01:45:11 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4219.023; Fri, 11 Jun 2021 01:45:11 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" Thread-Topic: [PATCH v1] net/i40e: fix set rss hash function invalid Thread-Index: AQHXXmJFvWFcQWUDn0eHd47O8c91TasOCPYg Date: Fri, 11 Jun 2021 01:45:10 +0000 Message-ID: References: <20210611013511.977843-1-stevex.yang@intel.com> In-Reply-To: <20210611013511.977843-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.224.224.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b543d34-6eb2-448a-238c-08d92c7a8d08 x-ms-traffictypediagnostic: MN2PR11MB4142: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:494; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0qaWinytukUhl7rP98yTkDqHKq2LXMn7qU6UM7Qu/s5sdkpfBnZWAJWh6Tjui8S7liq5U1Brm2PvJfYYHxv+2OteacYKMq6ruCLGB8CAtwSZ5hQ0j8sebjCoimjDlG8WC9pwukgst39e13Xupfm3aw/d8Lh2BTXNlxltZCNM30/Beu2Jepr0X/jWe1meQyhRCQPnUYTkBnmyk7GP9oCYbzBp7e2ajZ32qY6i2U1PpvTaOWb4QiAyvtTosTaSfTf9H+pS2NJD31Fgi0FVd9/u2HD5C7NKEDC5jCHNHOvBX8W/4LbKZ9CGDAht9obyW4zguIud83TFu2yhiBe5P5u8WTZADDeGHePUmbZbKPRmarEPsu6zyFVgPBPlpDRxRJo4OUUtxE94431CcBE53G1MATN0A9qpLODa8lgHlbvvGaCuPcygTkj8yxuSjrF2HCYv8uU2Eyvx7ciWCYptCiSNTTUbs2L/JFH59QLITYt4px1B5/K2ehYZ5DQ2AKcB2piNCYAjBO3o1C4qPtpp/jG20Hc6FXFmoRLkfNMIva0nh9MgsDblu6xP5k6uwpt7qpOZj+RArJUR5HoJWsOTtF9BGVYfYHFu1cEbXgJwpexqN8g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(396003)(376002)(136003)(39860400002)(316002)(26005)(186003)(53546011)(66556008)(66446008)(6506007)(478600001)(83380400001)(8936002)(9686003)(76116006)(122000001)(7696005)(66476007)(66946007)(33656002)(55016002)(38100700002)(5660300002)(2906002)(52536014)(110136005)(86362001)(64756008)(8676002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G6jId0pr9kZHvYNUyPPwvZ2Y+N3JLl64Q0krgLeImjyueiDTZP1QZikF32v8?= =?us-ascii?Q?oZ8mQB25Urx7pepJwTX+2nqux4Ba8EbX4jBoLIpa+NxVwxktgtyhmsJl0sX6?= =?us-ascii?Q?0rDZv2y2qYVOLSXd1GlFCYvQycTUNNzgdLxRk2EkdnCuj1CO1fU9KOnllMpc?= =?us-ascii?Q?LnUxAAD5HhIfsochKPySk0lLOy7YOzFmFjRNIZeKXeDyzQb+2VVmN7bFV5Hx?= =?us-ascii?Q?qqVAduSPYFwZz9vioGIoNl5q6sv9OsIy0dfi/hlMDKARmIjwiJUjCTewo6IA?= =?us-ascii?Q?Q8L7DRxjm95qZ/4zseHJAXOYGs809zxwURw6w5+Y+dBbOWOKyWq7iZFycbE4?= =?us-ascii?Q?wAXvxmEprOpfq04U7NhIbc93pfpIfvCgOfkaonLKvjX9uSsCTsub1T7N6BU+?= =?us-ascii?Q?bcPlDDGSPC5EheWuYVqAYkv5TCE4wZ5rxQ5D0RAkK1idQN4nHJAlBl/QQ9/K?= =?us-ascii?Q?FCxGYeGt85F4H3j+UEdE4bFumKq6CvIMoh3DgjIUkNBgSwzxcQZL/ooL0lUv?= =?us-ascii?Q?srhNEmH9Dh7poPIqEMtqAUii5y7x+Y+oZPo34qCD3Dev4DtoVnWjm2tZxCOu?= =?us-ascii?Q?DnXIMLA4guKrf+Hn9CrbQihcKzWgfOqpWCaf6wWNlu2Eh8wmXpFV14hBX959?= =?us-ascii?Q?3/oLlACmIqfddmQXJuuDENUJ78hW926kHAwRFDR/WSbplZEeTk8/kX9KRw/s?= =?us-ascii?Q?BQL2zw3kjWe/tj3hU0Nr5xe0Eky+epYxj+i/xAWSIpdksy3h+SYbYsLHdeJA?= =?us-ascii?Q?X4Ba+RwFiFXC6oWNhYZ/zap0hojiP0qmI7iEpRbt/n3dcfmSeqzAF5S8gtp1?= =?us-ascii?Q?cmhOJbrdhr5Zt0Dyi6knIEbPQ721gcVw2XQFLB2qF8+nvMc7YbiMLsCw2Y8F?= =?us-ascii?Q?9l4y8aP/MMlJLBoCZunPkRt53ao7lbMUk9/z+DoIRgp4pOI4rFWK1iT/11uL?= =?us-ascii?Q?7Z3nVkYvRIHWTifwJAXEPk7Go5fSIfOwT+eOXeo98idnYbhOVHRvFHCs6ah+?= =?us-ascii?Q?/f/qiS/nnV0fBxsUqWeaLn1ZtQp5bmCeNK18zWfzLh7oznlNSy52fDfqDrts?= =?us-ascii?Q?yAymJ0G52IR5RL7fOzDpwKytM/LzlQtGyKpKFGW4uqgBlXFf+Y5nk7Oir8vd?= =?us-ascii?Q?3rZZ1jHIxaSXSD0Me2TWrAQ8+IbHRjBbCuEXj4ZA/bAXd5BkIm82M8rQB/n/?= =?us-ascii?Q?tZuNaLdzpkdVfU7UqXlSKK4ome8Clma/ZURo3xdpj3Mc6InC/MaDyn3oKNxY?= =?us-ascii?Q?MfBhsPAvL8vkwd4zsxG+VYwUgqTR//3UEV+qVaW5Nbr0ljO1/sjugwlBo4v1?= =?us-ascii?Q?D9ZTIv8l04YqD5awiXe2NBej?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b543d34-6eb2-448a-238c-08d92c7a8d08 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 01:45:10.9611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sh/g52JioP/Cjzq980pLd+wk5cHbtO0e71xMCKH0X9RG/AM7/KSgGqn/jVOg03VDeglP4mABNR9IjYj3AUa/TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4142 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, SteveX > Sent: Friday, June 11, 2021 9:35 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, SteveX > > Subject: [PATCH v1] net/i40e: fix set rss hash function invalid >=20 > i40e can support following rss hash function types: default (toeplitz), > symmetric toeplitz, and simple_xor. However, when filter engine parses > pattern action, it only supports symmetric toeplitz & default (toeplitz). >=20 > Delete the hash function limitation when parsing pattern action. Missed fix line. >=20 > Signed-off-by: Steve Yang > --- > drivers/net/i40e/i40e_hash.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c > index b1cb24f437..bd734722d9 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct > rte_eth_dev *dev, >=20 > if (rss_act->func =3D=3D > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) > rss_conf->symmetric_enable =3D true; > - else if (rss_act->func !=3D RTE_ETH_HASH_FUNCTION_DEFAULT) > - return rte_flow_error_set(error, -EINVAL, > - > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > - NULL, > - "Only symmetric TOEPLITZ > supported when pattern specified"); Do we any other error info if rss_act->func !=3D default or rss_act->func = !=3D simple_xor? >=20 > if (!i40e_hash_validate_rss_types(rss_act->types)) > return rte_flow_error_set(error, EINVAL, > -- > 2.27.0