From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3877FA04AA; Tue, 8 Sep 2020 13:35:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 129F41DB8; Tue, 8 Sep 2020 13:35:16 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EE132255 for ; Tue, 8 Sep 2020 13:35:14 +0200 (CEST) IronPort-SDR: +SNvPhCDNnObyx7Pf04mT5GAvjrsiy8UhIUNl/9nJGvh1JbbTUUbmmf34Z/w8uvPEgWjI74cEu NJQS/pjLaDDA== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="222322237" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="222322237" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 04:35:13 -0700 IronPort-SDR: 0hcP4kSG0MWEsQ+JzSf+8QTv2/tXEElgEzES96K08H8lt/RVRS3GTRr/s1TDdGXsyo4jlCOHll M+bZKr9tWWfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="328447516" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 08 Sep 2020 04:35:13 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 04:35:13 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 04:35:13 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 8 Sep 2020 04:35:13 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 04:35:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLGKm2K5gkRS1PGptXcwOf0mdj8vZmBKS+4jntXlCVyr15ttWzUks9Cbw9GbBiBpwgDZ85WiuAoE+gTG/z3kCiotSbA9Pg7fniveneVZT+yLhXp69lrC5aZxr772Ak7pKNRBaKwv6gQP5k7uKXtOHSvLigUSc42Tq0QrXj6oVgsGEi5ryVd0RXUCJM+xlI+GM8nM+99UFtOKeczu1ZCbJIw8025qR3f2K6d8Cx/GTFZUfisd4+rAKkJYjm04GVZZhI/9OhupdMfyd7YgutQbz7TKbsFbWdN927rcdqr6UjqZaQL8MAiExfhi+cCqR/GWMyFFXVQes3LE5VMgTXzAtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7TxUa4VFZ4vJVAPLh0HSMbP8lm+UhApNoNNdMdM1Jdo=; b=dwKx5w37o3TS9UT/OM2Fb8wn2gRL8sHswRxGsv8Z8V11lQpHMZTIT72dN0RMf55prDfUBmJT9vUJgseSCfaxvL9h1gUbkXtQZMKnQBi19IPKcMdHIG4AOb2Y64ZRdmStuXKQnulBtTpf7CKNtj7NAzbay9VH6386Rs3lnb1GtGOjQqas9ItwCUbJSWsolBThypqdYcLyrf6tMgwDreDvEsx5foyKr2wjincIjbrI7psfaBg7KKWLeTxFIzpz2/Bs8rM6yrv7NW7REtzC1C4DYEhvCrObF/s8dK0Uxv7HsRE6/dD4pn38SOv7bAgMIU2iZgubyZUrreLmNXRDsT9BYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7TxUa4VFZ4vJVAPLh0HSMbP8lm+UhApNoNNdMdM1Jdo=; b=zhZLSKTagIsVtBmsZsmSrWkurMAexkbxIu6fLuXHgo4BNZKfwJyJBPWoEghving0q5ybMVv6MuPTjiIXnxRInR+eziUtqXkq+/pk5EDw1QuS/tkoXyc6pn/0YL5ULaFjTMF/x7k1vz0x3bQyDX56FaH5kdRyOsMjUeOwxebX/yA= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4696.namprd11.prod.outlook.com (2603:10b6:208:26d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Tue, 8 Sep 2020 11:35:03 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3370.016; Tue, 8 Sep 2020 11:35:03 +0000 From: "Xing, Beilei" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure Thread-Index: AQHWgPbdOks28PC170mpXiQTGDovDKlepL8Q Date: Tue, 8 Sep 2020 11:35:03 +0000 Message-ID: References: <20200902063802.102428-1-qiming.yang@intel.com> <20200902063802.102428-2-qiming.yang@intel.com> In-Reply-To: <20200902063802.102428-2-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f21bc13e-6c8d-410f-3274-08d853eb3a72 x-ms-traffictypediagnostic: MN2PR11MB4696: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2AYYY7Pp+8y8KNnzOdKH4tM3H+T/y6SzqvnGsG+E/1OY3tJ3PMOwFAjqgvUBfMJlXAdTowSjKMo2Cf7xzYo2TYuMMrvvvn8ZtL/5lDnMjIPcND6Zz7J+h+m5Tb8g+a4QqIKRenViKbqP5JCZkIHNkluFF6G2B1AW/CqmWq7PX5ItzQtBfd9xUiUJrwQsPtrUbNuAppNmaNnKqKb89rKJtQ50QiJAOHl5MyX3DdFHLA3tZq2j6xUzqbvbgnOzfvjCuGDQnyyEj8lOQ6Lf6i1PiD89bmHbzfqJrQq9uoGme0srwQFzlskya3YEQi7oD/Sy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(366004)(346002)(396003)(6506007)(53546011)(54906003)(55016002)(2906002)(8936002)(9686003)(33656002)(86362001)(26005)(4326008)(107886003)(83380400001)(7696005)(186003)(52536014)(478600001)(5660300002)(316002)(66946007)(110136005)(66446008)(76116006)(66556008)(71200400001)(66476007)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: nfs+REmvQ8NIRNDaxjvSWmfFts2jwfzKICBl9UJOHfE638MM/0ysl/QykyUshRAB1S8MOLUR1T+o7TkZhwT/I3qdBqJfFO+xZ49E/4hsjhQGuqhwEQLW5TbociMBCA6HQEgFTX4ysGYrUiR7lL+fndEIW63z+BXzAJVVV2wjhOBvfaZAvHoWlCU7os5SUhriErNsSYx65/VRZOYGhSsXlY+b3Zz3IYl2bns4MTNLqJIb+T7oLolMmrNo3O+XOF5F2x1C0ceyvTfes4GdT/ZlQ6ZS6XQn+2J7MT1UVQgkJUCPIRKILTJtQEtlRpOy+rO95D7JiVpnJST1Z67UEiAiz0Z5mNgcpI49yjS9M424fMUvwWORCpfgQbum0gJhzIqMfZMQeTZpa1Dd9vrBJnuQbv1adBS9dg1VQ7n2dhOhL2yhw6LlyF4dwS+63wFfL07p1klfBEBQvmjw/604j0J8MhY7UlQ5CrTQ0puSkwxiocg6BJP3kRHXLUDzOK6jTxQyTTojARBOd+mndkccEy5Wgnxo7fWARDY1Niqx6mFh0kUN9GX194DYcxDj6qruP3H7m7gMbtK7uJXyY1c+STdsO0T1URpLNOr2qir5cRoyhu0AGNsspYZ00450W3aax3E1QodBKiu9vztdwvvWthctkw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f21bc13e-6c8d-410f-3274-08d853eb3a72 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 11:35:03.3808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: btUf+9kPlevmTzYqVP6TXbIMZs0sXqlIE5X9lgmKJe6QZah+M5l097SS09H4xhuTHXS8R8sSfCQcgWixRXaEUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4696 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Qiming Yang > Sent: Wednesday, September 2, 2020 2:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor > infrastructure >=20 > Defines data structures and code to init/uninit VF representors during > pci_probe and pci_remove respectively. > Most of the dev_ops for the VF representor are just stubs for now and wil= l be > will be filled out in next patch >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ice/Makefile | 1 + > drivers/net/ice/ice_dcf_ethdev.c | 66 +++++- > drivers/net/ice/ice_dcf_ethdev.h | 11 + > drivers/net/ice/ice_dcf_vf_representor.c | 245 +++++++++++++++++++++++ > 4 files changed, 321 insertions(+), 2 deletions(-) create mode 100644 > drivers/net/ice/ice_dcf_vf_representor.c >=20 > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index > 34cd4024b..f9eb34a87 100644 > --- a/drivers/net/ice/Makefile > +++ b/drivers/net/ice/Makefile > @@ -88,6 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D > ice_generic_flow.c >=20 > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf.c > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_ethdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_vf_representor.c > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_parent.c >=20 <...> > + > +static int > +ice_dcf_representor_tx_queue_setup(__rte_unused struct rte_eth_dev *dev, > + __rte_unused uint16_t rx_queue_id, Should be tx_queue_id which is more readable? > + __rte_unused uint16_t nb_rx_desc, Should be nb_tx_desc? > + __rte_unused unsigned int socket_id, > + __rte_unused const struct rte_eth_txconf *tx_conf) { > + return 0; > +} > + <...> > + > + /* No data-path, but need stub Rx/Tx functions to avoid crash > + * when testing with the likes of testpmd. > + */ > + ethdev->rx_pkt_burst =3D ice_dcf_representor_rx_burst; > + ethdev->tx_pkt_burst =3D ice_dcf_representor_tx_burst; > + > + ethdev->data->dev_flags |=3D RTE_ETH_DEV_REPRESENTOR; > + ethdev->data->representor_id =3D representor->vf_id; > + > + struct rte_ether_addr mac_addr; Why not move this to the beginning of the function? > + > + memset(&mac_addr, 0, sizeof(mac_addr)); > + ethdev->data->mac_addrs =3D &mac_addr; > + > + return 0; > +} > + > +int > +ice_dcf_vf_representor_uninit(struct rte_eth_dev *ethdev) { > + ethdev->data->mac_addrs =3D NULL; > + > + return 0; > +} > + > -- > 2.17.1