DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Guo, Jia" <jia.guo@intel.com>,
	 "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask
Date: Mon, 1 Feb 2021 03:26:22 +0000
Message-ID: <MN2PR11MB38075025E133A27667ED8255F7B69@MN2PR11MB3807.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210201024046.16244-1-alvinx.zhang@intel.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> Sent: Monday, February 1, 2021 10:41 AM
> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask
> 
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> The absolute field offsets of IPv4 or IPv6 header are related to hardware
> configuration. The X710 and X722 have different hardware configurations,
> and users can even modify the hardware configuration.
> Therefore, The default values cannot be used when calculating mask offset.
> 
> The following flows can be created on X722 NIC, but the packet will not enter
> the queue 3:
>   flow create 0 ingress pattern eth / ipv4 proto is 255  / end
>   actions queue index 3 / end
>   pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
> 
>   flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
>   actions queue index 3 / end
>   pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
> 
>   flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
>   actions queue index 3 / end
>   pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
> 
>   flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
>   queue index 3 / end
>   pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
> 
> This patch read the field offsets from the NIC and return the mask register
> value.
> 
> Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director")
> Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
> 
> v2: Update commit log
> ---
> 
> +static int
> +i40e_fd_get_field_offset(struct i40e_hw *hw, uint32_t pit_reg_start,
It's not only for fdir, but also for RSS, so better to remove '_fd' in the function name. 

> +			 uint32_t pit_reg_count, uint32_t hdr_off) {

Besides, since this patch is too HW specific and large, I suggest we need:
1) regression test first. 
2) verify RSS with private API.
But RC3 is coming, we may have no much time for all tests, so can you submit the patch after 21.02 release?

BR,
Beilei

  reply	other threads:[~2021-02-01  3:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  2:09 [dpdk-dev] [PATCH] net/i40e: fix X722 FDIR " Zhang,Alvin
2021-01-29  3:34 ` Xing, Beilei
2021-01-29  3:46   ` Zhang, AlvinX
2021-01-29  5:11   ` Zhang, AlvinX
2021-01-29  3:54 ` Zhou, JunX W
2021-02-01  2:40 ` [dpdk-dev] [PATCH v2] net/i40e: fix inputset " Zhang,Alvin
2021-02-01  3:26   ` Xing, Beilei [this message]
2021-03-01  7:06   ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-03-09  2:56     ` Chen, LingliX
2021-03-24 11:38       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB38075025E133A27667ED8255F7B69@MN2PR11MB3807.namprd11.prod.outlook.com \
    --to=beilei.xing@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git