From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E165A0A0D; Mon, 1 Feb 2021 04:26:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C2F216066D; Mon, 1 Feb 2021 04:26:30 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B54B940693 for ; Mon, 1 Feb 2021 04:26:27 +0100 (CET) IronPort-SDR: uhcOhID1Yxpnq3pblGIDScrW09Q4BYOntqhF+RqCNtQKxNz6ZbRPWxO/DxA0CKDZxwXZjPCnG4 hrdF6/nEpLmA== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="180773982" X-IronPort-AV: E=Sophos;i="5.79,391,1602572400"; d="scan'208";a="180773982" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2021 19:26:26 -0800 IronPort-SDR: yy/jpuHhYl2/qkgLL9EQzi2RjgGHk5IfpzvkOP6Abk6kxTzTmxEPwIKIk2jZDuoJm2Oz6IG6We t86vZAnDk31g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,391,1602572400"; d="scan'208";a="412114696" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 31 Jan 2021 19:26:25 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 31 Jan 2021 19:26:25 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 31 Jan 2021 19:26:25 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 31 Jan 2021 19:26:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGeu2B9UVDCxvqzmK30435u3+scrmfAUh2P3smXheW6PXZq0itCfyMqfAWIYuCRWG/9XZFjZi1eT61ovOwA8EqSlJZWMpiPqOxpXSwWdKxrNqLllkCjHZiJmWuIAeJVp5ZZgD78zIhtDQbDvzhj/dvAZFzH/n2HRo3U2ZJF5vpS3qOtqSNmEyHj0N7xpKaffcAG5ZEIY7PZIA7jkgsQ5YXuWW6cqsjOXKXqDsWQhPshIQxcBfM3ChKOl0xNh2+bL2AQ+WrM9D5ymMZTbg/oTq7DCsGjk2NdVO4AD2YStNbXHarI8tJC1GMogoljOFpJ+TQwHBuEdr6AO5mQ6cySDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkqKMEoOqHswJSofOtN4azh+fusYnzCtIHuFgc5n/VI=; b=jUpVu2j1oTWNcGAtK3wXfaGuHIm/kp7jhsunph83OeXyu7YLCGDwEOfPmdTGb4d9DSEx8t/zCITvWYDvdY3KMv62+y2OqGvYj7ODLZ3bmMRvAVGyoKaZWeLgTOy4XSwu8pGf88vPeYLfqq1H9Su6nZ7NGDP9xPNMwU1p47FhMzLjYhReWpmAtfIDf5GIn9J8dUhUN1FNV49R/kpG8h5PXSkT6RgHzF9toP+5P/UHbFU3tWHPjh1ye3P5VkC05ktqTUuq6XvvAk/WYgf4eX6t+QeWMezwZQYTKa/lWIz6qFNV5Dvl/O5RHHjh4hFpD4X5PzsoXw0V34dJr+Dnq/T58A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkqKMEoOqHswJSofOtN4azh+fusYnzCtIHuFgc5n/VI=; b=oOePYfNOg8GtkW0NtFWgfq2RNdxFArRB55RCrdzNBgB4ZwG/LqTdc36FF9W6kYQMXeC4t+3QD5bwbkGKJtplSyObwI6qldQrkAz97voJQxqKpY1vZPjIZad7XtE5omn0BqZ7n/TVAaaunaoQT0Koa42+1S+NtT0lh/WJJJkx8kY= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3759.namprd11.prod.outlook.com (2603:10b6:208:f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.26; Mon, 1 Feb 2021 03:26:22 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::b92d:3d89:1894:8f18]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::b92d:3d89:1894:8f18%6]) with mapi id 15.20.3805.024; Mon, 1 Feb 2021 03:26:22 +0000 From: "Xing, Beilei" To: "Zhang, AlvinX" , "Guo, Jia" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask Thread-Index: AQHW+EO/ECTXao9EUkiPZaew5yqm26pCoVaw Date: Mon, 1 Feb 2021 03:26:22 +0000 Message-ID: References: <20210129020921.25104-1-alvinx.zhang@intel.com> <20210201024046.16244-1-alvinx.zhang@intel.com> In-Reply-To: <20210201024046.16244-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aecfbedd-f254-4318-3a7d-08d8c6612634 x-ms-traffictypediagnostic: MN2PR11MB3759: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:608; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3YgVfTzaMhWTOdJD3SjsY6FIcOyKs5WPVHlll3ChwOai4LrS4bVII/+vfPGMKYsRjY5dRPZFTNQsK8FZg3GxQFFNYdn3rQqukbDnN6cmUtDq0HQK1RR7boD90EZOdfGYcahVoOnnR40ixHHTwKb5b9ptTSiURZKKeUTH6hIAmcEytMhhxNt3YufiHNq/Ca++Op+Mi8y9e2sSL33c6u/uOA0p17HyTXanILB+ap5VSc0lPfNsriAAK8Wpbs3txEIN0yaMn15y4m81j2q5c+Q4OGzMqIZH3p3t+QPZeI+NzuV6yBM/ylqeVyj6thv30KeaIi2pESj6WcngXaHHmHDjFbIMXuxNbDeizkOvQId3poTp3vpvVxxr40dDj/G807daxMyumRkOmNYDIJ/Dzy4N08ETDXI3tAFHfjNV0n0WvISqaqFhC8M+jgnUFnvz6MT85p2wZrrX4G5gj74L5hcMu49Bo+zgtcKWls+f4S1jryamvmBFMH9MJm2rVYYM3EnVKSS4l23K0AdwpQ2gLNj8eQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(53546011)(8936002)(6636002)(33656002)(64756008)(186003)(316002)(52536014)(66446008)(66476007)(66556008)(71200400001)(66946007)(8676002)(26005)(83380400001)(6506007)(76116006)(5660300002)(7696005)(86362001)(2906002)(9686003)(55016002)(4326008)(110136005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?a9dOxoL7/jdQLxYDd8k3lPdGBDXhc9MdWC1PuSKA4I0YQBy5rwhS7QRvB75o?= =?us-ascii?Q?nmZ+Kbq+SKx/b2w1VZmlSY5Clhbu5ULrn5FGFKw0sMLmo5LSLtlxOHv/WGPu?= =?us-ascii?Q?tULze28Rd74sbf1Vmt7bn8Bd0uXgwL/fiUwg9tSDlweC1yV5eewoSooIRLEb?= =?us-ascii?Q?oMALYAT/e17JSdwY/BsmJ8moD2pcPS+BpUf54nJnwUhPJ/atvyqW7fSzWEnC?= =?us-ascii?Q?y1XXgBH93NGPRUHSftu8jlEpzhwoiXuI5+Lo51eoZLZ8Y3CR5NEmbz3jXiwR?= =?us-ascii?Q?3lRfEbK7vSeOLGcKVl4qUY/owyYOktJwudzcDmxDy9r3o4eHpaOeszLOhLDN?= =?us-ascii?Q?nbAte+S0ujQwqV2U7hbrC6twy3BT5nxsW1/Y4epstp1MQLAvXZM0Rr87s1Yh?= =?us-ascii?Q?4+zx/EXmr+zSyfB7zFULoEE7BdsaFw2dMJp+Yv7L/KuuBAin7qMzuWpFAdwS?= =?us-ascii?Q?PzQE5QyTNuqP8BE1mZSXdRQXuO1Bi0KdWPYjnPMAgd2sJAqC7rZcecJHuQnE?= =?us-ascii?Q?FkoNH3OalNmUB27VZNUwfhhk+LpFDq71WnuuFERI6v6cGIkV4wrjxIX4g9Vq?= =?us-ascii?Q?beDlr5hHsiJYDuuggXXb9oMM0/7KQoKq87ck8oroGnchkjdUFUgJl+um0OtN?= =?us-ascii?Q?eSNQxTFIG9nuDUWbipAdMcr08/V2zOZN3XiE74P1Iz+vRwhqPttU43NIbJ3o?= =?us-ascii?Q?4d4A/Bae17u0YWJ1ersrVdlrch0EH5+kTo7TWzml84PWpWBL99/ZJo9iKm7X?= =?us-ascii?Q?3Ptg083J3MsTcx4bLrNj+4HsbOaLcvlUqe6hBekulUS4F6bBxX721GNvvH7y?= =?us-ascii?Q?8Qhb1xsXJrPesDAZsjD+tOWLDJgi/J2f+5xksi6sSyWo5PL15FkRQKVdNRdC?= =?us-ascii?Q?vzY5Sdg9LHuNfKiyE6kvYOdYyo8oK6SzHaSaJLj87ukgZBMm7iQPfdmRiWiL?= =?us-ascii?Q?ajofqHAr4n0r6kO02WYpPQf8LMD/EjziF3gWQ8bOJMmuo1C2YOkHb99C3v8A?= =?us-ascii?Q?XLdBFAhVQ3PexhJW22SSLWpxR0HDlo6ps62aG4XFXxvYNe+CJtdaL8IClt7k?= =?us-ascii?Q?gNRAVWZd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aecfbedd-f254-4318-3a7d-08d8c6612634 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2021 03:26:22.5041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1hRahZYhPos+mhIEEuYERhPDOoV+b2HVn6Ba3YeB0NB9g804JguC14RCRGo0vB9H1HPqINKhY2DMErn+zSdwew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3759 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Zhang,Alvin > Sent: Monday, February 1, 2021 10:41 AM > To: Guo, Jia ; Xing, Beilei ; Z= hang, > Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask >=20 > From: Alvin Zhang >=20 > The absolute field offsets of IPv4 or IPv6 header are related to hardware > configuration. The X710 and X722 have different hardware configurations, > and users can even modify the hardware configuration. > Therefore, The default values cannot be used when calculating mask offset= . >=20 > The following flows can be created on X722 NIC, but the packet will not e= nter > the queue 3: > flow create 0 ingress pattern eth / ipv4 proto is 255 / end > actions queue index 3 / end > pkt =3D Ether()/IP(ttl=3D63, proto=3D255)/Raw('X'*40) >=20 > flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end > actions queue index 3 / end > pkt =3D Ether()/IP(tos=3D50)/UDP()/Raw('X'*40) >=20 > flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end > actions queue index 3 / end > pkt =3D Ether()/IPv6(tc=3D12,hlim=3D34,fl=3D0x98765)/UDP()/Raw('X'*40) >=20 > flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions > queue index 3 / end > pkt =3D Ether()/IPv6(tc=3D12,hlim=3D34,fl=3D0x98765)/Raw('X'*40) >=20 > This patch read the field offsets from the NIC and return the mask regist= er > value. >=20 > Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow direct= or") > Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- >=20 > v2: Update commit log > --- >=20 > +static int > +i40e_fd_get_field_offset(struct i40e_hw *hw, uint32_t pit_reg_start, It's not only for fdir, but also for RSS, so better to remove '_fd' in the = function name.=20 > + uint32_t pit_reg_count, uint32_t hdr_off) { Besides, since this patch is too HW specific and large, I suggest we need: 1) regression test first.=20 2) verify RSS with private API. But RC3 is coming, we may have no much time for all tests, so can you submi= t the patch after 21.02 release? BR, Beilei