From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23B57A04B5; Tue, 12 Jan 2021 07:10:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A7FF140E3D; Tue, 12 Jan 2021 07:10:56 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1D471140E3B for ; Tue, 12 Jan 2021 07:10:54 +0100 (CET) IronPort-SDR: 6f/w3Cd0NlK2iMBayrgdN7GpPklEQTtQJGvGp+F+Jx7V95sVOuhjcDnGFaZaCr1gr/9zmfBBdk 7QnLwPq27XBg== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="242060574" X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="242060574" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 22:10:53 -0800 IronPort-SDR: uxBXw0Iu6ZpaMj/itPYlfZ9Wwau8GIcXJ4KXYoIL3bwxgxUkVkUyNruL0OOKd78RM0xGHXomhz rVw7ZODSZcPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="352893904" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 11 Jan 2021 22:10:53 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 Jan 2021 22:10:53 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 Jan 2021 22:10:53 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 11 Jan 2021 22:10:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQhFXFv+2G8Jy2PFlZ2hZEPdSlJ6rtKak5lh1CDffAar+CiCbRnB4ueBDaVqAJFvFOA6DdE0w8/RW1A1r0g4ZmgUnunFhY1+fTTUsOOLTFr2t9f/tzn6F/aS7inQsYdEBAy7yh2hykrBYl6S/dzCrkbbw5Liat96kehq2/Yn7AaLZnO+886fbA1zEhicYrn0LbeeTjpS5Z3iTx5x3DhiJl/US0GA9rOl2wmIzcUQINOWpHrN/wSOOAEfZMAaole760MlpX9oXpxSqivFjGockKz3HJ6MFaHQSNhnt+g4cIke9dNl/DBOx6oAAd57fxKILsM4Ye7sbXGM6njUIehOJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lZkzS0wcb7fIAZQSIhk9y3GChGJminVh1vG9/UH5yAc=; b=aMgbPoruiwe+Zxfx/cqqKLHuhsic1y9IDvV5rGrqeehA2p6KevgQHog8NP3PRZR/TMOV4Rv6vqW4PyZDhhs7Q3FX8VEnSUFLz2OBoZbaewkbOqAxsKuREreSD62W4QP4toMZGoZRSg2Gil/VrAMwdqC7VjmzdILWczfQVMXtPXc4jYlJ1+zuKBDEyPfhvvikch36feW81v4hyFKTZ8shsX+q6TpWFM/dtja4MeRG0DMfiyS+gXnOQCvJHXcz+3o4cz+6XaRwELIqXmI1o8LnbjjpqY3G2qw6cMFMNdk5aWMPP9ZpqsNbiSgArRV0geT8on9hOdej1XsiMUWIwRGCXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lZkzS0wcb7fIAZQSIhk9y3GChGJminVh1vG9/UH5yAc=; b=U+tzDpcno8E/OJ3ItDjtlfxfTL3GJtvXswYiQRCodqVZA3jynWVNwy6pV7kAscqGtK5Zg4Li9d0LhP5xXwp9Yx56tEOLasAgn3HY/Zi8pg4hlNIKfTxp/34ZoZ8AfKMo7PjewbJ2Pz0CNG/pQ8/bi22AZnygjmiajUtfLBPAvhw= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Tue, 12 Jan 2021 06:10:52 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4d7f:d51:79bc:e596]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4d7f:d51:79bc:e596%4]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 06:10:52 +0000 From: "Xing, Beilei" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Xia, Chenbo" , "Lu, Xiuchun" Thread-Topic: [PATCH v3 5/5] net/iavf: fix vector mapping with queue Thread-Index: AQHW5NDkzz0ZNdIudUqFWwPwjDGR+qojiVOQ Date: Tue, 12 Jan 2021 06:10:50 +0000 Message-ID: References: <20210107074533.15465-1-jingjing.wu@intel.com> <20210107082718.33748-1-jingjing.wu@intel.com> <20210107082718.33748-6-jingjing.wu@intel.com> In-Reply-To: <20210107082718.33748-6-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38100311-3629-4692-f7fd-08d8b6c0d088 x-ms-traffictypediagnostic: MN2PR11MB4046: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 75wq9xqOl+l4G9f5n2C01p1HhRhSvzZT6KlQUSRkFG3X4KRUoTnxZj/0TDPzL0ebKltO4JNGSdGKNB1a41PPQfASDQTzcDVjgkYH36dSamZl8v324bGgL1MwGle4W32DZwORZbx56FZAfukFyn25dKguGLtP7TFxES+QnDRPJ8eAKgE7wV3OfpUY5KBD9yq+z/fPbXNCPlIjIccdJ96sSZf+sFDagHO6qc3p3Fchhz+YBj8L+fcKE6GbPP5hFH58mzB5NtFUG392Bd6kNVf7IJMChp5oFlyoaoGgo+08G+RA9/bOxSjo6C94uX2ARSn/TLpbpzHQ4VPaBibMPUQRzrIG1Q6pP9xi0O8yiyvzqyhLKt2QxAaeDEZTQdAwq4MPVF9lvdfVZR2swiPo/Zcx2E0J52wujNjA0kOGdr7C89mSfhrxL8WnWPYFlITqB41uqYxJiAaKLs806tTmJzkHqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(83380400001)(316002)(966005)(186003)(86362001)(5660300002)(8936002)(26005)(52536014)(76116006)(66476007)(4326008)(66556008)(55016002)(107886003)(2906002)(8676002)(53546011)(478600001)(64756008)(7696005)(66946007)(6506007)(110136005)(66446008)(9686003)(54906003)(71200400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kvZe5wNEba6SHw3m5K8Tz6dpz8qO2tpgtRA42LxJ6Hw1fp58hevLRrpwh3YA?= =?us-ascii?Q?1qB3tL3VjTrwmtrgVy9Vqh/gGip/h5Xuf17e0Sm46emy99TRUM5Lce8gk+A4?= =?us-ascii?Q?RzXFgdIMglhsBu0o9PmHaE4x1Gu86Uu7J8syzrAV4KEPqwow9UqYhxG4GFa0?= =?us-ascii?Q?80m/Glrs7TXIkg1h1FUqlyCSc6z09qfzPJ7su8QJ/hE0xZBNdPJjVAMspzJ2?= =?us-ascii?Q?TyeXVzXrZa3wATcpmQOf0LAVgE6lYcpetCmIxzWo4M7xhck0ibAV0daajXaZ?= =?us-ascii?Q?yS9NZ1PI9GeEHaEAugXkq8CUowIofPnBxyMndGEJeJGQShHGcQTX7gcRD2wf?= =?us-ascii?Q?UQgK/V+E3BTPu1qhJIpqjTMtJK0anEDendjmNiWPPwqZsZ41LH+kuK4PhkV6?= =?us-ascii?Q?qG19anvwPq/n9iO4uEqI0SwGo9cn8ekXsljqtnMUopYDO4deRSo+o3Yoo+9D?= =?us-ascii?Q?zYI6zg1OMhtYq4AMpDLfL8UmwMcCjr7g+Qf6jpHqkE+tHSxDGRX830/1qyLR?= =?us-ascii?Q?AHSYAJoYHf9RoG3ENQ7JO5I6zmTIUN9sjHPpAH22xWjkJdMNNITavKFnR8qv?= =?us-ascii?Q?RmEbjH3vFr/1Ya7H9NwE8/Fi415bXgCT8VqfrpYlc5CAIey+/R9aztFUwvxi?= =?us-ascii?Q?KXqgYWmEqHIqFAuQaLDt1rql0amv2w5F8B7YIARPHfWQuz8NFCFsSToBFGgx?= =?us-ascii?Q?SS13erBrkNR9EEzePpp31Eot0j2vDsNOQczByLvfdnouK+x0et3rL+UUkXHv?= =?us-ascii?Q?qX7TP3gBO1VCbPtoh8xRyVuadDFDt2vVAErPMGGEcUKsweoCWOj+m2TwKy6q?= =?us-ascii?Q?p01TEVuGJKiscN33ywT4C9jvcqrIoqtEfA92CLuSdOzUOQXu4KpU+qPwyV7A?= =?us-ascii?Q?fYQBcWj21YF/hjIsp1cUbp6fBv6ZT3b3V4zPux7Ni8TCBRJ2BXju0J9EqJ74?= =?us-ascii?Q?Lqwjo1Js3ftE/dqnzRRV9kmPs7t21NN/Sn1XNg7dcVE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38100311-3629-4692-f7fd-08d8b6c0d088 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2021 06:10:52.0818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yEqVljBAwJZbMIdiTLlOYnK/00cLxJRtDZXzyMdFMha3JkQk/qeSD6E7Mvl2Trj/GL+smWMN/Efm98fytjKLQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/iavf: fix vector mapping with queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Seems the patch is conflict with patch https://patches.dpdk.org/patch/86202= /, please help to review. > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, January 7, 2021 4:27 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Xia, Chenbo ; Lu, Xiuchun > Subject: [PATCH v3 5/5] net/iavf: fix vector mapping with queue >=20 > Fix the vector mapping with queue by changing the recircle when exceeds > RX_VEC_START + nb_msix; >=20 > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") >=20 > Signed-off-by: Jingjing Wu > --- > drivers/net/iavf/iavf_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 06395f852b..b169b19975 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -570,7 +570,7 @@ static int iavf_config_rx_queues_irqs(struct > rte_eth_dev *dev, > /* If Rx interrupt is reuquired, and we can use > * multi interrupts, then the vec is from 1 > */ > - vf->nb_msix =3D RTE_MIN(vf->vf_res->max_vectors, > + vf->nb_msix =3D RTE_MIN(vf->vf_res->max_vectors - 1, > intr_handle->nb_efd); > vf->msix_base =3D IAVF_RX_VEC_START; > vec =3D IAVF_RX_VEC_START; > @@ -578,7 +578,7 @@ static int iavf_config_rx_queues_irqs(struct > rte_eth_dev *dev, > qv_map[i].queue_id =3D i; > qv_map[i].vector_id =3D vec; > intr_handle->intr_vec[i] =3D vec++; > - if (vec >=3D vf->nb_msix) > + if (vec >=3D vf->nb_msix + IAVF_RX_VEC_START) > vec =3D IAVF_RX_VEC_START; > } > vf->qv_map =3D qv_map; > -- > 2.21.1