From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1660BA0C42; Wed, 12 May 2021 08:16:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85F1C4003F; Wed, 12 May 2021 08:16:40 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 08AFE4003E; Wed, 12 May 2021 08:16:38 +0200 (CEST) IronPort-SDR: GuQ9jmf7u4pcRRcjW43rEYwON1r3yqyScj2xN1BLmnKCuAk1qIFDh/925Vyy32koTAoVeaE8RO 6cICE+ey7laQ== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="260881877" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="260881877" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 23:16:37 -0700 IronPort-SDR: aD5K/pAJUFM/iGZuyygHBJGYjQ5x+x0jb7/OrbC+Ib5GzdhvgPwZH1e9F8FlzhsZFg9nFI8eNe t67R+wcaB+0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="391702739" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 11 May 2021 23:16:35 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 23:16:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 11 May 2021 23:16:31 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 11 May 2021 23:16:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kf4MIlLz793PHkyLBajfKVYgKH9tDe2qxgbouK75mxoof2YzBwQ5wK1fiegYdK5wn8Y1xed9O2bYUn+qUUywSRIOLAdFoQLmw1PsQ7slu7muTRnR5SgZnVp4WDzBNrXrE6niIctKuJHJr7TBbJEwbqMKqWxph6NGLUyEC7No/TNKIU4bqkusBO1OgnNAf5hZ9+Utj9HYZD794Xpydl6qLzndCfdq8UTn+Pe3uXPndorPYEVpM2FkYKu7qK4giJwJ1I3sy3G9vhkHs/QO+CoIdZmeewpR5lt38OGFadCwerW1z39Nd89fRAMAg7pHmyxgwJLz9NtqsN4ImMgmyu6KhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HULqkwKTSwZA61QvXxaQLV8ZH3MTFpfFIxWHeheaRE8=; b=U/hNxzi9uNTMxn+1pH7tb523mFtZXdjtadoR1QeP9zCuasUMaRF6PQqCL7WGM77RuAvr7YBszxhySx0L3fkClU6IcWUMtsydLeCsSA+DYwylybZsa598C886us7eqIQCbRFxH5oxhuxUiNrwq1M5sgO0rSlZoQ93A9ZhEg7/C+Lc/uBieQIWpnbJhGcz8P4BOcvmCaQYpg92/VVJv7O3cOihEKQzT51uCnW1F7wuNxaTe+Fz70Yawf/BhppfvA5BBGVm7rRR5JTH5hjdz0BomYvPrYAUTwvMizZQV8BTy2OyzZo1lwbEw6d7jQa1IFToAYCwR4NglZKe+EaTcN8SHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HULqkwKTSwZA61QvXxaQLV8ZH3MTFpfFIxWHeheaRE8=; b=C9WfoBvCdN0dPJTdTgtyxcl1ieigafkeY/qmAxFHXSM2QAaNtoqH14zljZ0PAUerFJ5TsGOg74pzx+IhQwV6iDTirvIazoyKjyn+/rWcxBU+3ZiOsVAuf6qKCITddrNxE7kD5OR7VKkOGZZSKrdXDHZ9UjziGnEfZ8ZZFM/JeW4= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by BL1PR11MB5398.namprd11.prod.outlook.com (2603:10b6:208:31c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Wed, 12 May 2021 06:16:30 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4108.031; Wed, 12 May 2021 06:16:30 +0000 From: "Xing, Beilei" To: "Zhang, AlvinX" , "Xu, Ting" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix VF RSS configuration Thread-Index: AQHXRvJuAca5UyermkucFMvZcA4YlarfXk2A Date: Wed, 12 May 2021 06:16:30 +0000 Message-ID: References: <20210510122050.32668-2-alvinx.zhang@intel.com> <20210512054818.36076-1-alvinx.zhang@intel.com> In-Reply-To: <20210512054818.36076-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c86216e3-a161-492d-f27d-08d9150d7be3 x-ms-traffictypediagnostic: BL1PR11MB5398: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PKjAy7GOPtATe7uTZlRecsMIP1ZnGISowgGkLyTi1jWORxz42n5Ct0Bf02bPEIHTVplXjeCms/00L/zB6XVwiTVwhO5jffjSvStzn85O+byUIq7eG+x8OPFntpBfG51FDfl+jQYKO/f6teLRILG60jsApeTpy5JpvV8sx9HDl2/GKzkCE+Sf+tyNcJKcfEZoYpurPtUDze/UeG7lu0Y91gmWS00XiqSvefLzCWbgAdHCuIOUUTsfnUMAj2+sZ04Wm9n4xmRBs0YfonA1l+WMpD4BETxJDehe5ETrc8o6Zw/puuwEpTpCXYbXjpYtE3muinZzRkNMFm6zyGO8/ZJNjRZQ14F/0kPX559nG0qQlI1iH3x4qGfY8y2pahUbz7VNx31JjZgc4tYvdeVJSTYSHfYKRaalGEu1Vf+LcteUkNBoXB5YdeHa/UlnlbmJWeE7oXFcKA+QwCwzroAtEIE4eYkToXwZeAMFugcYhDyp8w5Vkvfgd2te/GW7uW1BsF5UJ3RvojXj/G9xb1rYDqli+q3JpGm2l/jdGArbRWpcoma72N+bviLbAED75Hc4UMqj59p68B3q/tiIdDyqwSFCx2YikP+VuZPGc7XaI9rT1kU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(366004)(376002)(396003)(39860400002)(5660300002)(8676002)(33656002)(110136005)(316002)(54906003)(9686003)(6506007)(53546011)(8936002)(7696005)(38100700002)(26005)(2906002)(6636002)(83380400001)(186003)(71200400001)(76116006)(66946007)(478600001)(66446008)(66476007)(64756008)(55016002)(66556008)(52536014)(450100002)(4326008)(122000001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: sh96V/npnF2zXvpGSXIetFFpUdlMVyON6wJLTj9okUZPBueoh0H85S3eoOXYufWFuP4SQDQH4Sip6oBFaXm/heY8OG99MZBtnnYRpmSaQrJrXgQeLjA6ngYnJs5Ot4eUzEH4Xi4eW7joLt9jy/1PRGp8QaVZXXkEZXDeQ4ZZD5AiTiePsfqmG5x23pHHXPaT+7fJ2petjrlFzAa3JWPv0tnevaFXMbmrvUzTDfbFHM9CtNQtsiaCnica/z9M+KADwB+TX8+yoIY7bvBhvTlHx8eiF0HyJoGCE/O68r7Y8a4Jhc/LvxbdDi9AYLBsTgtQcVSnXpMasfO9btcLbYh4Ft1X0zYoaZ0gKS91fsOh3AfZwDLChDVneRnkl2au9SnvV3ba3CgjJ7+R312XtJ16kAU0+OXEwZtKGZlJqx0eGAov4PI+QMPSB9V2puL3RfaDEnppn/G0ZsnyG+12Dbj1QBy0swABNMsw57lIKYD2DvKV40gYLUXNOQlOTmWwGFT3oq9XUXC5jArmBuPWCVyWf0YNCY8djQdkjcpDnRnUePV/GKTGAZR2n/JwbeEuhR40PvMqsi3kwUgwb4QX+4tRDzhUphAqhJyIFbzOPWJsFwoaWWHaDXdmyPnRwGXyhHqHEgvko4sks1xksvpJNnq0XxlqSpC+2pDWiGiBMhkbJdtVp99akOA+S0Cz8WkkG67ZcUEMVmG6cyIShiPeBqwuxlJ28BJJjJIR8PC5eEXR2Tw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c86216e3-a161-492d-f27d-08d9150d7be3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 06:16:30.6200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g2mfYoPJaz/AMAJKDanpBio5AmjCMZRdfSFEg/ghYscb7yXXSovT3/aqD7FYV8Mtxfl52S/ZVyrvT22pXAydmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5398 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VF RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, AlvinX > Sent: Wednesday, May 12, 2021 1:48 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; > stable@dpdk.org > Subject: [PATCH] net/i40e: fix VF RSS configuration >=20 > The kernel driver supports VF RSS configuration message > "VIRTCHNL_OP_GET_RSS_HENA_CAPS and VIRTCHNL_OP_SET_RSS_HENA", > this patch adds PMD support for these messages. >=20 > Fixes: b81295c474b0 ("net/i40e: add user callback for VF to PF message") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/i40e/i40e_pf.c | 58 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c inde= x > 9804ed4..b18dc84 100644 > --- a/drivers/net/i40e/i40e_pf.c > +++ b/drivers/net/i40e/i40e_pf.c > @@ -29,6 +29,28 @@ >=20 > #define I40E_CFG_CRCSTRIP_DEFAULT 1 >=20 > +/* Supported RSS offloads */ > +#define I40E_DEFAULT_RSS_HENA ( \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV4) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_FRAG_IPV6) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_L2_PAYLOAD)) > + > +#define I40E_DEFAULT_RSS_HENA_EXPANDED (I40E_DEFAULT_RSS_HENA | > \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP) | \ > + BIT_ULL(I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP)) > + > static int > i40e_pf_host_switch_queues(struct i40e_pf_vf *vf, > struct virtchnl_queue_select *qsel, @@ -1288,6 > +1310,36 @@ > (u8 *)vfres, sizeof(*vfres)); > } >=20 > +static int > +i40e_pf_host_process_cmd_get_rss_hena(struct i40e_pf_vf *vf) { > + struct virtchnl_rss_hena vrh =3D {0}; > + struct i40e_pf *pf =3D vf->pf; > + > + if (pf->adapter->hw.mac.type =3D=3D I40E_MAC_X722) > + vrh.hena =3D I40E_DEFAULT_RSS_HENA_EXPANDED; > + else > + vrh.hena =3D I40E_DEFAULT_RSS_HENA; > + > + return i40e_pf_host_send_msg_to_vf(vf, > VIRTCHNL_OP_GET_RSS_HENA_CAPS, > + 0, (u8 *)&vrh, sizeof(vrh)); Use uint8_t in PMD. > +} > + > +static int > +i40e_pf_host_process_cmd_set_rss_hena(struct i40e_pf_vf *vf, u8 *msg) { Same above. And please check below. > + struct virtchnl_rss_hena *vrh =3D > + (struct virtchnl_rss_hena *)msg; > + struct i40e_hw *hw =3D &vf->pf->adapter->hw; > + > + i40e_write_rx_ctl(hw, I40E_VFQF_HENA1(0, vf->vf_idx), (u32)vrh- > >hena); > + i40e_write_rx_ctl(hw, I40E_VFQF_HENA1(1, vf->vf_idx), > + (u32)(vrh->hena >> 32)); > + > + return i40e_pf_host_send_msg_to_vf(vf, > VIRTCHNL_OP_SET_RSS_HENA, > + 0, NULL, 0); > +} > + > void > i40e_pf_host_handle_vf_msg(struct rte_eth_dev *dev, > uint16_t abs_vf_id, uint32_t opcode, @@ -1458,6 > +1510,12 @@ > PMD_DRV_LOG(INFO, "OP_REQUEST_QUEUES received"); > i40e_pf_host_process_cmd_request_queues(vf, msg); > break; > + case VIRTCHNL_OP_GET_RSS_HENA_CAPS: > + ret =3D i40e_pf_host_process_cmd_get_rss_hena(vf); > + break; > + case VIRTCHNL_OP_SET_RSS_HENA: > + ret =3D i40e_pf_host_process_cmd_set_rss_hena(vf, msg); > + break; >=20 > /* Don't add command supported below, which will > * return an error code. > -- > 1.8.3.1