From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01ECBA0548; Wed, 21 Apr 2021 07:11:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D29E6418AA; Wed, 21 Apr 2021 07:11:06 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 6DE364181F for ; Wed, 21 Apr 2021 07:11:04 +0200 (CEST) IronPort-SDR: H83Hattde17mlpuIpUrpKjH+6ggLF83p/WfclY38W+cqjwI9QJ1fMrWvmQuwiQ04F1nNYNAuhC xXlQBqpKcnQA== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="175747335" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="175747335" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 22:11:03 -0700 IronPort-SDR: SAdHKZzpBvhkDAfPsTp33J2an8XtxXWbPgwmS86of4WTr2nY2Tnilpeh/jonsnjkQJTWbad9mC grecCXteqWEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="463454169" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 20 Apr 2021 22:11:02 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 22:11:02 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 22:11:02 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 22:11:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 22:11:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fqlYDlmK6L0mxglwT8h3HmgoK80lSkgLoo6Qg6G5S85xezjJhsCLmsC4iED2Ig2lvDeWJ9kkboeCDl06Mn0EtvvHt3fOuh4QZFoq7F5mpCYIKpRriIfyUXfQlkuPmzsOqe8nhnFv/iPEUWBuSRJdBbFDZcfoNmTjxMmdMO0g3omW7aJacIg6KATtNHQixX/DZaI1nHfTkkV92VlCW67hQd+VVu+j0pDRxuQcu8CsC87m1YVJ0pxgEe00n2HWjIaXehvtzlKR8LpSiD9rDT0ScBUEoNTxpVf3lGXzUJu7i/69owin0ObrReUCfRuI1tO7jIOlfG91ux5eTNHM/1WcHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvwIUIvQFTzNZ2AWNl/guoyOF/5WMBrMM0XU9vYSBVY=; b=MGC/DdyplWcoR0eUquol09chnkMA5zkWwLkZDceDsTfLs4ZVFgg9AQg/JTsvJxOB5nN3T2tyOfOn7s+Ry2CaO7//HGsni6+jf0Jom5jDTqr8FLciXyicqMRjS2v7FbF3BqDQYt1h0jDs3sMWvrnU6haec/YtZwko+kjbGKnhaoTRsoRheuNMrafvTqZkIZeZKvdW7gJ8NvuLsqNoMzMQxHHGKP/z6TdYFEK25JvJwgzgouV7CWT+YaWrFvDxc9TJswTZcO18s3fkvIeqevoO6vEfDz0jk3aL7arT8tF1jQYxM+fzCyVfuMr+YfABa3oaFtSt1DKwp0oqXORXfFvQ7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvwIUIvQFTzNZ2AWNl/guoyOF/5WMBrMM0XU9vYSBVY=; b=hypx/rXEn5zLjTgtX9+hXJNOjHHlbLMVch8k2TposhIxMq7okzGpA1/ZweBKNRuew8Yo2px1+/ZDzF0Q2+VjvTXxyl1uJUnZHED/mtc9nXJ0oV958wYLF+Fo+2TviJ6fopRhnPovIgzcUFqnYPQho51F3P5DJ0ZcabfN2SeSO38= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3679.namprd11.prod.outlook.com (2603:10b6:208:f1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Wed, 21 Apr 2021 05:10:57 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7%6]) with mapi id 15.20.4065.020; Wed, 21 Apr 2021 05:10:57 +0000 From: "Xing, Beilei" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Guo, Jia" , "Yang, SteveX" , "Zhang, RobinX" Thread-Topic: [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs Thread-Index: AQHXNmHZewhH/Qb8Kk2/iSbMWHlYt6q+bKAQ Date: Wed, 21 Apr 2021 05:10:57 +0000 Message-ID: References: <20210421020830.4989-1-murphyx.yang@intel.com> <20210421034403.8894-1-murphyx.yang@intel.com> In-Reply-To: <20210421034403.8894-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c06cb151-fc20-499d-54e4-08d90483d8e5 x-ms-traffictypediagnostic: MN2PR11MB3679: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ocmb1l7Urpbvpe6A+JMVS70L5g/afFGQQ4fMnJW79oaKBBB1h31BpwsBNlq1xHFsX3F4mH09ejIwKrxwyUN52QSK5okEqdvRxY7QD4mlhSsBdnFFZ6j7itST5qqFTDCxwLttolJWFFqkxJHfez+K+jCyxtrJASgNy7cbEWbox8ML26uVvP+eZIFTfM/I9rhy0RdvSj7JEi+1ltHvwakQThKv0iVV5UZJHEU9VnD24qw6amCUWMAqPRGU2rxAUqDdqSMArmzuGWExOAxrj0AvO375jJoIAk3yMP1yyjd9rT4T+r3PBIDEc0em8EIJqDI2B9Gbma6cdT3GVhVOi2qufms5IbEUb80T3/C2TuS4hniGC08Ny1vuEx4MjNaqjZ07vEF0Di2gaO8m+42NCHVHtna1gnkhz7C9WlQD7qlBO4fkaHc7dtm1SWndz72xggbCNzkqIOjcH99R59q6uM8Vr7ospYuLI8eJI7DTr7IfMnXHxA6y1BSHENfLQ2qPq7dpkaBLIjmXqKpdwPZgySrAoVFFTgkNqwIQMk0iKRc0TaV067vUg+Xoru3eiF79DNXl0o2qCyK/P2DcvtyGr8owFmwW/YKiJTxBAZU0J2aG01g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(396003)(39860400002)(136003)(376002)(9686003)(86362001)(2906002)(5660300002)(107886003)(316002)(66556008)(38100700002)(55016002)(53546011)(7696005)(52536014)(122000001)(6506007)(64756008)(66476007)(8676002)(66946007)(76116006)(110136005)(8936002)(83380400001)(4326008)(26005)(478600001)(66446008)(186003)(71200400001)(54906003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?F7LFz/ZbATvqYrNsHMZqvROOWRCOFtqhHsvMf+xTNNPzUhVskb49l7yPd6wD?= =?us-ascii?Q?ah5pvneMQ+ucNhMpfGzr07RXlviHyI7N99B+EjdkCcwlyhd3JMqviqhQUJNF?= =?us-ascii?Q?qBoxt+NwrO/K8yfsv/QNEH1Cb0KKOgWLWsfxmDTcM2XkiE1BJRib9ibpQJrl?= =?us-ascii?Q?iXpkwfuCfw0qfh1HBduY4/vpIFRNiwE8JNYQ6lhlTOABj+fIAGBWcqFRJFhy?= =?us-ascii?Q?Cqr/0bPJaHKXUO1ru5DRWBJozI8bRLdFJcZdXsX0fn4krmtoeSzYBTax7t/i?= =?us-ascii?Q?DepxU6XmuTWrcDStsQFYwmpZH24rxFWJV9F/LcxXsIjKbQN3crwj0r0sU+XH?= =?us-ascii?Q?DRTF5y3jjqeqHd+NZRg8xf+Z7PX3/7jw5Lt59WPwbIByx5SjkJC/wGOF5cLH?= =?us-ascii?Q?nM1dajQWlU9J92+1mlLn2Gz/E33zL2dnLNKND4M/jqWqpGnGP0p4oXQtUrVQ?= =?us-ascii?Q?MYrFmz1vXT1Wsuu70Y9vOJ6wEVkqUhLP4c4EbTSgaOnWuYAOPThZoJv62BDF?= =?us-ascii?Q?79ztyIQeMcrNjlsF3FDvjMNiacv4h01htY52EkxbypTqwaW1KHELC5UA6sKf?= =?us-ascii?Q?JhlyuwvfzFkIjlXWuPFAPoGXQMJIdNO1WIdOo/eMARw1l11xpGF/BIl5aVxb?= =?us-ascii?Q?TE3vB0aYRnRTXfuy2gYOGlmRVybyMDh31hFYrgKX4iJvu1tq8fgSFb5UTaGb?= =?us-ascii?Q?7qPWSZszo+YiZSO/PLbTuY/9wH2EeIQrW9LBV74lGn3FDI5XklA+rXcNGJpL?= =?us-ascii?Q?g7zB6hmRLu7vzV2LG4Oc3kO3HuEZ50Wf0IDino6hOrj2r1027fsJ4Toi50fP?= =?us-ascii?Q?r6HT/umyQjJp6IcIyqmmuRb/KtHMi4MoTuINjMZGjzCyaI21r6HhE3PEyuhg?= =?us-ascii?Q?EQIYQDGqb3DNRyc7GBsaCmDeKhAGdA0cs6pFS+BHwNsbTKXciCda3O2d2rTc?= =?us-ascii?Q?NQsLj2MKdDSferdpKUL40nI/xnqO0czkdXgF5/RonttbcZlAdNtiDV4HRk0V?= =?us-ascii?Q?87GIUeSSglOxMP/iCD/HSyNXFfkm6qX39aKgH4iC3jec/alUN/CdkC37aeF7?= =?us-ascii?Q?KM2IA7IauK3VXbLOdGQwFNRtxpBCp1G+NaP6glT6c/A/aukmP7zT70W7Om2t?= =?us-ascii?Q?CUVNwkBejiOuAXcDgkrptgi0x26x6U9i9tmeO5Ib93HDs8Q1ThGf0gZO7VD6?= =?us-ascii?Q?IID1GO+9ulFXxgIwSf7lYj+3Hj0vEmHesdnMaVnjkgUqTlgqwyjRg1C8KjIY?= =?us-ascii?Q?3dYm/kTb+/uDbgZ6qj5uxKTfxTQK6r/CqT/vQeSqG/r4ru8vZphNyzx+Z18w?= =?us-ascii?Q?gyE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c06cb151-fc20-499d-54e4-08d90483d8e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 05:10:57.3831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x2t6iX1g/kFAcP/ZAdklFOBP+snYcJWj4lJSOJuduosDQ7Eb6IyaSRCxHANKgkxHyOUeBlkc2j2d/j9f4Xyqbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3679 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, MurphyX > Sent: Wednesday, April 21, 2021 11:44 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs >=20 > Currently, FDIR doesn't work for all common PCTYPEs, the root cause is th= at > input set is not configured. >=20 > Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow valid= ate") > Signed-off-by: Murphy Yang > --- > drivers/net/i40e/i40e_fdir.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > da089baa4d..ed1c60af99 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1607,8 +1607,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf, >=20 > /* Check if the configuration is conflicted */ > if (pf->fdir.inset_flag[pctype] && > - memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > - return -1; > + memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > { > + PMD_DRV_LOG(ERR, "Conflict with the first rule's input set."); > + return -EINVAL; > + } >=20 > if (pf->fdir.inset_flag[pctype] && > !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > @@ -1616,8 +1618,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf, >=20 > num =3D i40e_generate_inset_mask_reg(hw, input_set, mask_reg, >=20 > I40E_INSET_MASK_NUM_REG); > - if (num < 0) > + if (num < 0) { > + PMD_DRV_LOG(ERR, "Invalid pattern mask."); > return -EINVAL; > + } >=20 > if (pf->support_multi_driver) { > for (i =3D 0; i < num; i++) > @@ -1762,18 +1766,15 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, > i40e_fdir_filter_convert(filter, &check_filter); >=20 > if (add) { > - if (filter->input.flow_ext.is_flex_flow) { > + /* configure the input set for common PCTYPEs*/ > + if (!filter->input.flow_ext.customized_pctype) { > ret =3D i40e_flow_set_fdir_inset(pf, pctype, > filter->input.flow_ext.input_set); > - if (ret =3D=3D -1) { > - PMD_DRV_LOG(ERR, "Conflict with the" > - " first rule's input set."); > - return -EINVAL; > - } else if (ret =3D=3D -EINVAL) { > - PMD_DRV_LOG(ERR, "Invalid pattern mask."); > - return -EINVAL; > - } > + if (ret < 0) > + return ret; > + } >=20 > + if (filter->input.flow_ext.is_flex_flow) { > for (i =3D 0; i < filter->input.flow_ext.raw_id; i++) { > layer_idx =3D filter->input.flow_ext.layer_idx; > field_idx =3D layer_idx * I40E_MAX_FLXPLD_FIED > + i; > -- > 2.17.1 Acked-by: Beilei Xing