From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C052FA052A; Wed, 27 Jan 2021 02:44:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46022140D57; Wed, 27 Jan 2021 02:44:32 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B79FC140D24; Wed, 27 Jan 2021 02:44:29 +0100 (CET) IronPort-SDR: Wi1DOfuvDT1ge9vaXVfvmDOmCFVp5XUdtgRlYFQWuwmV7PG8E+lQti8+vl3mFOcmJV9Mm8um7d mfDy51gemWhw== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="159777681" X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="159777681" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 17:44:28 -0800 IronPort-SDR: T//m8sWSCq8FC5wIlw4ddT0gTtnxq4eBbO/TQbinEzAu7I6q2A7S7pAkOpcXtFRy9uQQzzwalN e/a6ON+JqPdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,378,1602572400"; d="scan'208";a="574226408" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 26 Jan 2021 17:44:28 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 26 Jan 2021 17:44:28 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 26 Jan 2021 17:44:28 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 26 Jan 2021 17:44:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ck6e6wthKSzqz6b7YGAHWgqjP0p5IdBZSjOeLlIqw+sfHolS000o+yCpQQtg6z3If+urJCzQrgoaUiZEsoYXXtEPzKMmUdhAfiKOLvpeTKE2CO6Ifav1E7G3hzzWllyb0PXB1plrRlguhrufUDUknYqebTUhR866zNkgP9H+KfSp/TVOTCDWswZXouV1sLkp1uX81D0F/vQtIRaReEphEUQqVTa3Mkdu4Kltp172kvLqK+5qpy3+FfRxcTCCTESxKkzQtjrjLZRvu2mlG2Z8fqj44xv3bR9zNr7ATw8roJ8rNcw0ky5Qfl4Jylsj88CUzfQqGOPktY9bKqXgkrjqug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUptsTlXXuh0bwbVtFO4d6GJN9LvXKdqd1W9q+OnSzo=; b=OAJLQg6wvwZBCgHs5GUrRLhBoW32N3vGwWUwsU33V/H+MRpq2BKGNtZJ9WkW0IQsuYx++iB9jBFQVbNQb0DGgYXBcf6gMg3qyMCUXgMlQuYU+fNyH+hLgzCL5LU0KIn0+Yelt7TGfjhFciOYgs+Ee27Sf/ct+W5KIpP7RuPCBMoWgq2aDKdXOubSHPfi1fcnHHpkKxau5LPud4rCZLCAexcfXNWCugR8dTvjhsSVWRUWiUYz73HB6UdEI8Excwllm5N7BzrfO2Yu24BNQRoplFPaAo4ssOIY4HAxGwzdl8hQneWmzRuf8ajNU5BN5TYmXI60JHE2bpXiPyI/13/Yow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUptsTlXXuh0bwbVtFO4d6GJN9LvXKdqd1W9q+OnSzo=; b=En6nU4ucxds56hNc/rycWmQrDTds43f2bZMogtdhuVlJQFxKxMfJIDRU0/mL+q759VyYUP3noTTe76o6KYNQg/64Xs4l44O0TeJQNf8m1YoPSP/N3tnKTcPfP+r7sdU7Rw0Pw+wEUcxnx94Lz/o7xI6OwyMIQTUiSaK69cAhk+w= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4517.namprd11.prod.outlook.com (2603:10b6:208:24e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.16; Wed, 27 Jan 2021 01:44:21 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::b92d:3d89:1894:8f18]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::b92d:3d89:1894:8f18%6]) with mapi id 15.20.3784.017; Wed, 27 Jan 2021 01:44:21 +0000 From: "Xing, Beilei" To: "Yu, DapengX" , "Guo, Jia" CC: "dev@dpdk.org" , "Yu, DapengX" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix register setting for hash enable Thread-Index: AQHW88j36+X4ahV5hUKGXh2mZOga/6o6r6ow Date: Wed, 27 Jan 2021 01:44:21 +0000 Message-ID: References: <20210126095211.628354-1-dapengx.yu@intel.com> In-Reply-To: <20210126095211.628354-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a387f46e-9824-4961-8a4d-08d8c265117e x-ms-traffictypediagnostic: MN2PR11MB4517: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9F59O3twQAQiq+3ZufbtU2LZ/LaHXKwhT0OGmsWewRPFFNYISQX6VtKvePVuP3n55C0tJZ3EOAk6FQzZvy1lI1pk7jAWoo/6yBKQV0DUIo5hEhE3hvbkziA9JqoCZPtxyx2R6RZVvNAbQstOXJp0HKwfC6MoFXBMooDA24twmpflGFOxoOTRPo3hv3tlcxFPLzSUC4VsyHUyon7XHhplkv7K96/ky24QvdMZvTq8CFDSAAOXA4Obmze2x8g4Hq03NRVn9SSHHBCQTtAzmIdJar/n7/uBXhVx7azM0tk4o3pUtO8MflAomXlCNKGnSmvsKZqC3HQQ9qofpre789hb3aIu8qhOh5zLTykyYEUwPrIhqGNeReZMUCM+CxyMEfmshDuKvV1meRo+Plh1bFvJ4M6oauyhlQBbaM+MFu2ZOdOvBw3u0YoWLI1ON9HDH01gmCIgRaoICGoG0JzTeh1Naj4X+wdG89ik6ji/BfsbOhZ9xDq7lHtcB10pAiNqhuqcRTDDQDXR4RQModjRaDZQiw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(136003)(366004)(346002)(7696005)(26005)(83380400001)(6506007)(53546011)(4326008)(450100002)(86362001)(6636002)(2906002)(71200400001)(55016002)(8936002)(186003)(66556008)(66476007)(64756008)(76116006)(54906003)(33656002)(66446008)(9686003)(110136005)(316002)(66946007)(478600001)(5660300002)(8676002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ez12FNHUa805ZxYWyuqS0t+m7SvsXos4F+LzvhhYc2/f82XWn0rVZFbBamsd?= =?us-ascii?Q?tTUxu7NF/gWvEXQnEWJcK9b7MpcTMF5ps5Ic9LxeCA70mwknVHDR45CgXGDD?= =?us-ascii?Q?8Q1AhwP8yJ8mKufuma/xT/D/MugCXuXHHLQhNdsE4k2BaB34U9SBeu88z+To?= =?us-ascii?Q?EpB10VCvHmKXO/xL8Mfvx+ymBuaZe0XR8sy2+MnNO/S5+9wiIO0LqpxTcKg+?= =?us-ascii?Q?xmQjbdW9ma91vyRZRCxSz7nyGc/U3ntzDT5f4LhUTTw90Eikg8dyt6orB8nw?= =?us-ascii?Q?naBkMR5M71QjRm4IeEY9RXSGzG7paNo56f2OEBYFFbdRlF3LeuyvpOOmBUdZ?= =?us-ascii?Q?OjNXQg/tb9x5Sz+SEegtbINYgPQ3vgQS6AUuHvfal/lyrplsGxp/7kU+vYZj?= =?us-ascii?Q?iJevsS+vQ1I5ygkVkzTNKEYZI+4DaL1pHBHOMiN579MMT41UT/nnFDMIKO1O?= =?us-ascii?Q?wpl4XjymzoOU8XtuM3oOCtyoNU+2zR+d5ZD1WsN6NhZWmKgKkzXpkzoSRGVO?= =?us-ascii?Q?xs18n9VpLf138RYunqtjRQkmQ9nIFSRjnm2ZanfpqwGmXa2VKRPyUIlDIclg?= =?us-ascii?Q?Rv5ePo58vsSFfrwPbmwyv88mjLAg42Zlsp3hUIBDw54kFdZgAtkdsG9Xyz0L?= =?us-ascii?Q?DGbZP+T2LjTVX2tRrfCrcD5fVh76Sas+pKPBTeAgJfvbLFZ45FHAVNVgPigP?= =?us-ascii?Q?72Xo07WP+c5jDLx9FuMFeH7/hPpMR53fbf3tiB5hejf9njKCa3APbMSLvqda?= =?us-ascii?Q?J5IvW69O3HOeug0JeqIiSzwMrKxxJYoenMKFrOV3OijFjvSagLdEwCSbJqv0?= =?us-ascii?Q?PcMZfmP44N7vZ4SMMW3K8eSUcSxNoC4UU2RhM5aRwMdJt7W3AXUfX1xfjlGd?= =?us-ascii?Q?8CgEvWhzSR3/IuXp+H371Fg22KhK/QnZYc6q1dBmsM7F84F7mYavKFTVmHvD?= =?us-ascii?Q?oRSTef9v1N/xcPyqBXdY2TR2JwLkCNdEjJFnjyJ7thyLpWOZbRlxbKxaqr8H?= =?us-ascii?Q?bTvwbPvqERRoriqFf97NYULYPALAoLrxJ6v7+Hos1SMjoEz0GTw3NvDRcB44?= =?us-ascii?Q?ujH/3lLx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a387f46e-9824-4961-8a4d-08d8c265117e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 01:44:21.2736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PJMY0RbnWSq6PQIzbGC1Hsz2kokjtGOAl8W3rFaBp/+8CJEY9BHTnWdAdGRtXddJav6zRHJAhxKXd/eA4onGIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4517 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dapengx.yu@intel.com > Sent: Tuesday, January 26, 2021 5:52 PM > To: Xing, Beilei ; Guo, Jia > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] net/i40e: fix register setting for hash enable >=20 > From: Dapeng Yu >=20 > The original code causes wrong value to be set into PFQF_HENA register > because unnecessary calling to get translated pctype value for X722 NIC. = The > result is RSS cannot work. >=20 > So remove the unnecessary translation. >=20 > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > drivers/net/i40e/i40e_hash.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c = index > 9271797a7..b1cb24f43 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw, { > uint32_t reg, reg_val, mask; >=20 > - /* For X722, get translated pctype in fd pctype register */ > - if (hw->mac.type =3D=3D I40E_MAC_X722) > - pctype =3D i40e_read_rx_ctl(hw, > I40E_GLQF_FD_PCTYPES(pctype)); > - Did you check the latest X722 datasheet to confirm the behavior? > if (pctype < 32) { > mask =3D BIT(pctype); > reg =3D I40E_PFQF_HENA(0); > -- > 2.27.0