From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90E74A034D; Mon, 17 Aug 2020 05:08:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 986271C114; Mon, 17 Aug 2020 05:08:18 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0E9071C0BC for ; Mon, 17 Aug 2020 05:08:16 +0200 (CEST) IronPort-SDR: iPPY6s1BC/+6atsL/kifrG49Tn6mAyf2iGmp7ZLpSx1knUzsiRRSeAKBW3P+a8Utpl2MEUq2Sp 3A3ENISQkl+A== X-IronPort-AV: E=McAfee;i="6000,8403,9715"; a="152274106" X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="152274106" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2020 20:08:15 -0700 IronPort-SDR: 0aQrx/N0j2h8VgNdLrSMfrKIWS7hgvnzsRgxt8S3vSvDVnDgiAJF8GukQAGN86dY97Ryfuzm4T Jca/qc1CcD5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="292303325" Received: from orsmsx606-2.jf.intel.com (HELO ORSMSX606.amr.corp.intel.com) ([10.22.229.86]) by orsmga003.jf.intel.com with ESMTP; 16 Aug 2020 20:08:15 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 16 Aug 2020 20:08:14 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 16 Aug 2020 20:08:14 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 16 Aug 2020 20:08:14 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Aug 2020 20:08:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QamQJ8VzXm19m6LXGh3Gta7paKiARUqNqQyAyhnb5rxFfPVy3Ra36KX6MJfzOJFd7Fhgjr8+8HCnpByxakpftzIllYrlf8QXCDarRxUy9TATAgQFUS7GVuiUEHQox1tZUxI6RASrDfFwy7lEvcYVvl5tS5BS/J/MGLPAXiSdYYoWZL8CnENBwobgmzHIg5o0y0Ux7slMLOWiKMQC896jA35eqmA4aufyB1iYg87LUC1dNCL/lInt2avQxiAgoThkUX6m3O6Vb56dwZRbg6fQsbjh6TTRZ7Yd4jPsNlkCWoVbtWKlQxMTEq40pgaUGx6/FZdo3q6srpDYfkUHNt7gwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Et2c1jRI5niijUffts/ymVMw4k6LEZjJuQH7ixneXHA=; b=Li5C46QWSL9SJrkpRg1V8JxL3JFmD8zXyS0DFa2PkHqzLHcYzNH6fpEnAj1+TNSPItXmL45EABVDYwyYfs/ZQ2R7a2lhPu4LuXh7e/HhOqGCLXzwbn4c7dt8S41IDw126hr+ImsOR5c22MAcH7ibEmagy0rPQY2LqeTsXpyVwqE6HYOUyDa8HfPyC0xThG7sfMQ553iOOXkP1ZZMa+/dp+aukIdUjSG6urlh0N874c6BgzCjL8LE848ZRQ4d+FDOymNyBlNvCwPa53O1MvVAackpvTKjEFQy40+rXbFfyfW0H9E93vy5fkwZzYiRWYQWRbcwAYHfGkbCI4To/x1XYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Et2c1jRI5niijUffts/ymVMw4k6LEZjJuQH7ixneXHA=; b=IwvfI03q0iHKYbB94ow4kM4rtQZ4vRP2b/RBb44qfG8YV5xJ4pRXCFkhHw3XKyj2UTDuybL/gAboJwPu7oDmybQfh8yeDz0HmXpElJxCdTbIuqJxptrLhQk9uFVGXGxhUKjmiDsW1i1OA+5jsqK1xfa7BtCavuIDV1Hre2vrrIg= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4159.namprd11.prod.outlook.com (2603:10b6:208:13a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Mon, 17 Aug 2020 03:08:12 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3283.027; Mon, 17 Aug 2020 03:08:12 +0000 From: "Xing, Beilei" To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" , "Wu, Jingjing" , Ray Kinsella , Neil Horman Thread-Topic: [PATCH v2] common/iavf: mark internal symbols Thread-Index: AQHWclm0X7DTcraF7UaC775ZMBjGdqk7ooiw Date: Mon, 17 Aug 2020 03:08:11 +0000 Message-ID: References: <20200814162318.325906-1-haiyue.wang@intel.com> <20200814163055.326072-1-haiyue.wang@intel.com> In-Reply-To: <20200814163055.326072-1-haiyue.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85d1a689-8cca-49c1-c3ed-08d8425ac6b3 x-ms-traffictypediagnostic: MN2PR11MB4159: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:41; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oV941LcQoQunkR+tZTr6COZiV6Du8iNS9SF/hnvS505UTnZYqbTDHBh2zH4o1jrvkNkBXFNyyIeDm5jZdwSM/HrACtOBGkUA4K05vDeQqhNXFM50CesoIeBPYelX+lYuiEBL5cZzgLenYoqk39PB8ISiVb1UbHYUNDFLeHaV7u1hJ05NdcZIjiE5QuyCAArg+p19Pen6x53hqkbH2p19sfOe//HFO9qlgWwisHVBbPIOvI2qN8GyS8+vpBwNc7o2/QvYGB4ZVhBpgzBTnnf59xQGDL/mt8tB+A0RfjiRjPYmzz7wM/Cl3Hn8BD3FRAW7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(6506007)(7696005)(53546011)(478600001)(9686003)(26005)(4326008)(2906002)(186003)(8936002)(54906003)(55016002)(66556008)(110136005)(52536014)(64756008)(5660300002)(66476007)(66946007)(76116006)(66446008)(83380400001)(86362001)(33656002)(71200400001)(316002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +EQrDaAA2gneEV9TblNjqx7hQZ6y3Ih8mioKYJTmUIDePJveAccTsfzvFKpgoj8QdUMz0q4norDQpVePdSyJzvFIE86DW7V+3nzsJGysm0vSEKvZMYOSaktR9m7oRSoG27g7XXVaF0vSIXnFOw4MFd01kqYYF5IqMNlxmnBku0EiUbhDErwjPMn7AaImuBxK823Ey5hOwXJPv2n1xa4YDg2zdmx/97e0OXkPgFnG9OSCWL873FAVcwzCjoPbuxrgODjZBIFD2SumHOmo2R9Dj9IAyauT/l/PKjCVeXA8+CO0sw80C4Cq4EOy+XXm27+KqugsUxW4Gy3Brr/tYcsMc2I9TdEIqhniGiGQzcVMBmX/K2tygDE6VXaQOirvO1jfJiMWvXno1BSVHYGC6qe+W2DtNDRVSBGwS79l3vw8MNk964WfgYEkOG3s6vZb5S+Iyar13qqa+vzGkAo5bYqZTSdjojAa7/InvDMEQ+WbJlQUAEMhoSZ56ggzfBiMJoXIJN0n7EbbJf9umVtLwJSyInU7KVpcKhB9VimFl8IEmJ8GXh2GAo6+HYkP7xzx3bMRD1pYIgGFBTva/cnkA4yIYtFPi7szr9xoURi41B+oRdfWx6Ys0okHnstKqfffZKX0YBldDaXUFs9Kns7TWCKacg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85d1a689-8cca-49c1-c3ed-08d8425ac6b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2020 03:08:12.0175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Pnd4DMWjc9AN7ezFdFJjIBvJbKXMNy8wU6ULotSmLhlhDsH4F5NiLYodkbT11gj/gRzJ55pFPokfzztmrD2Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4159 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Saturday, August 15, 2020 12:31 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Wang, Haiyue ; Wu, > Jingjing ; Xing, Beilei ; R= ay > Kinsella ; Neil Horman > Subject: [PATCH v2] common/iavf: mark internal symbols >=20 > According to ABI policy, the internal functions should have the new tag > __rte_internal and linked into INTERNAL sessions. >=20 > Signed-off-by: Haiyue Wang > --- > v2: update the commit title > --- > drivers/common/iavf/iavf_prototype.h | 6 ++++++ > drivers/common/iavf/rte_common_iavf_version.map | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/common/iavf/iavf_prototype.h > b/drivers/common/iavf/iavf_prototype.h > index 31ce2af49..f34e77db0 100644 > --- a/drivers/common/iavf/iavf_prototype.h > +++ b/drivers/common/iavf/iavf_prototype.h > @@ -17,7 +17,9 @@ > */ >=20 > /* adminq functions */ > +__rte_internal > enum iavf_status iavf_init_adminq(struct iavf_hw *hw); > +__rte_internal > enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw); enum > iavf_status iavf_init_asq(struct iavf_hw *hw); enum iavf_status > iavf_init_arq(struct iavf_hw *hw); @@ -30,6 +32,7 @@ void > iavf_free_adminq_asq(struct iavf_hw *hw); void iavf_free_adminq_arq(stru= ct > iavf_hw *hw); enum iavf_status iavf_validate_mac_addr(u8 *mac_addr); > void iavf_adminq_init_ring_data(struct iavf_hw *hw); > +__rte_internal > enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw, > struct iavf_arq_event_info *e, > u16 *events_pending); > @@ -61,6 +64,7 @@ enum iavf_status iavf_aq_set_rss_key(struct iavf_hw *hw= , > const char *iavf_aq_str(struct iavf_hw *hw, enum iavf_admin_queue_err > aq_err); const char *iavf_stat_str(struct iavf_hw *hw, enum iavf_status > stat_err); >=20 > +__rte_internal > enum iavf_status iavf_set_mac_type(struct iavf_hw *hw); >=20 > extern struct iavf_rx_ptype_decoded iavf_ptype_lookup[]; @@ -76,9 +80,11 > @@ void iavf_acquire_spinlock(struct iavf_spinlock *sp); void > iavf_release_spinlock(struct iavf_spinlock *sp); void > iavf_destroy_spinlock(struct iavf_spinlock *sp); >=20 > +__rte_internal > void iavf_vf_parse_hw_config(struct iavf_hw *hw, > struct virtchnl_vf_resource *msg); enum iavf_status > iavf_vf_reset(struct iavf_hw *hw); > +__rte_internal > enum iavf_status iavf_aq_send_msg_to_pf(struct iavf_hw *hw, > enum virtchnl_ops v_opcode, > enum iavf_status v_retval, > diff --git a/drivers/common/iavf/rte_common_iavf_version.map > b/drivers/common/iavf/rte_common_iavf_version.map > index 44142499e..e0f117197 100644 > --- a/drivers/common/iavf/rte_common_iavf_version.map > +++ b/drivers/common/iavf/rte_common_iavf_version.map > @@ -1,4 +1,4 @@ > -DPDK_21 { > +INTERNAL { > global: >=20 > iavf_aq_send_msg_to_pf; > -- > 2.28.0 Acked-by: Beilei Xing