From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E3B1A054F; Tue, 2 Mar 2021 07:53:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 737CC4068C; Tue, 2 Mar 2021 07:53:42 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id CEB0340142; Tue, 2 Mar 2021 07:53:39 +0100 (CET) IronPort-SDR: 00Fp73r1Yiy2U2Ew9s+5qS3cJu7uzWvzPmezhwzmuy0J2jyaapFBg1ROOKpA+ejRo7I2mh46c5 HCO2861xOkgg== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="183312737" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="183312737" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 22:53:38 -0800 IronPort-SDR: KdiQ2Dd8u1qPZ3sr3EGCUOepW0zjFpiDEWu8yOLIXrnbVPlrBjtPfnswhixqzuQwKJi/C+WYTg W8bSE92O4p+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="398181711" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 01 Mar 2021 22:53:38 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Mar 2021 22:53:37 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Mar 2021 22:53:37 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Mar 2021 22:53:37 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 1 Mar 2021 22:53:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJlSJfsICxlG489+/PgK2do/wYaPdV+vktYJjE4eviGd3SwuK5F+4weaHFi9366PWwnRQz+FwQjbiqdpWdEY/u3gxb5+E5eDl0Vq1JMrWPSpnV9mlQf4rH+fRe1bxh+QW4KzIbPfC6j5Adgn+K8IzB4S6u3YPN3u765Sftxg8nduSrfkuL94itgA5/xnCPSxLeu0Spg39C9xd0HgrmJ3zm4ufX5km9YkubTgCDqJ5CBXv5EzEWZAFBWAswHsfDvOaAgT8ikIOiocy/Bbw47HFylh6ryS02vV0zn1TKTmXAYgcJWK/apptaShZLbE1nlFkXuT9M/gPd31zXjbtwsewQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RmChEF6+aS6MV3dMilPq+ecsxrW7XF59ohUXeIyoeys=; b=ZNe7dQ/8+jnvRKvxiBk4Ueld0GN1H0UmZbLwZWc/CG8ansFxbxCLW9gCKSa7OgT9rw+yGlW11xn+u4/sv0sT1p/NkG8V5SL2d8gqjg0CXe166ccQEmDqofRG0A4H03vpq2giIAyjdjwq8Dsxz9vZo9bwtZUB4yl5aDc55sZTQNQub8XDvMT5Iq+/zX2+HwS2RJj10Lrz3DrZZqiD7VK50SAB4knpQ+ue6ehVhQ/f/TIjn44lUQ0twV2+VIMnd5oRCUL1Cc5jLqH/MFrzaGTwX2TiasXXEakchY3COyDxP0LT/2GB0uuStqcjewaRD/608+ZJYu8QNFJG+vBIF1wuoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RmChEF6+aS6MV3dMilPq+ecsxrW7XF59ohUXeIyoeys=; b=P6YWjAxq6bLe09lv1daOOhFtG2nHa4aPDJVt/et7xO90y0YIOtGLPbwE+GKu+fWeTKsZxDJd+RoroICd2voD3k7j7A+oh0YIes5NWE9hzRO3YVitaSyFZAZ9NfYglpHnMcx3o0Q5phKiOMXng+USDr+ZxDXQhphp73wVFBIF90U= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3663.namprd11.prod.outlook.com (2603:10b6:208:f5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Tue, 2 Mar 2021 06:53:33 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7%6]) with mapi id 15.20.3890.028; Tue, 2 Mar 2021 06:53:33 +0000 From: "Xing, Beilei" To: "Li, Xiaoyun" , "dev@dpdk.org" , "Guo, Jia" , "Finn, Emma" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix IPv4 fragment offload issue Thread-Index: AQHXDBfSkzARmPt2ck6YXVFlg9sGC6pwRrwg Date: Tue, 2 Mar 2021 06:53:32 +0000 Message-ID: References: <20210226081438.1693788-1-xiaoyun.li@intel.com> In-Reply-To: <20210226081438.1693788-1-xiaoyun.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a87d1e51-c22f-4b5e-7aa3-08d8dd47e52c x-ms-traffictypediagnostic: MN2PR11MB3663: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QWg3AvVsoqhj454kUYw5Py5baLUscRgl3n469idNClgWOWMq0ukbC7fn0cP6i6QnEjrL64lYHWAoFFIk+fK2Jr3OLsbNtfbmLE1winXw9226+UyNSlzFGaPRqDuVRjqs1Lejo91b96vi39y51esvnGllq2TjXCoi9Gt+rPppQ2jZDSW8byeI7QDAtNHWBcgWpyFkayOeIxTVCbYgcA2ViEmCvyUdtG0v0T0eZ3LXTH2yKBg/NR2eVEumgfkJwyqDfedMX6OztWVGiuDkq82uCRgnewcr9HHoGumLMyfjcBha3UWXv63nke9Yb/Jd7qyjqgG9Na8Ify1Spg5w4tBmOZKexqawpBnlBlGX41Vr97nDrTSPydRcQVKu7uD95BkN3AyQ5bKuyqHEHn2fO5Enja/uF4vZkeVIDfgMM2Y90JnNStERj9PWFQ8tgmotHr1UogIHUjsdFD3+NXa/nDOV2d4VtHbaQAV49HMY35ZmMIFXe8lOLK4t8kZr1PaaBSh9XzA4hBHTwBQt0X5R3ci9IQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39860400002)(366004)(376002)(346002)(396003)(6636002)(4326008)(71200400001)(478600001)(6506007)(450100002)(2906002)(53546011)(316002)(86362001)(9686003)(33656002)(83380400001)(76116006)(26005)(66446008)(186003)(110136005)(66476007)(55016002)(5660300002)(52536014)(64756008)(8936002)(7696005)(66946007)(66556008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?cy2qVSLJRWvZ8fO3d5dwWtYUkmUlb64sL2CjP5Do/8iFTQbrLfY2g9GEzUIa?= =?us-ascii?Q?JsXdF2WgYDS2Yz9weRw3mxh+XdyExtxcEv0yjZjGyqkTxUIj/3jglcvaf5V6?= =?us-ascii?Q?aGY3UxV6WY67g8ISRgGZciXX66PZaDAMznikSao97JKMO93+6IyoF+/10Ubx?= =?us-ascii?Q?aqtDqJao0DU5M7ybXxezOGioHy5A713f5REKhybPxXK5xeXFvxjF+fNFgrUj?= =?us-ascii?Q?+eEDUR3VkVNeHWxD1axAfU8VnTBvP3I3dSHVnKO/ueo/InCwASTuGnnTeZDU?= =?us-ascii?Q?Pb5Q3KlDtL5tv63dVGxc2/Vy02yMzJN79XdOpYaZOXmO3jabqBoMvIvNhIWO?= =?us-ascii?Q?BTJJnKnavnjTXRdhdTc7GTa05encKbq62U4TlhNZWDDeopYDan0IKvAW5h8G?= =?us-ascii?Q?Od/Z2RgVwPpdkds8k+mjtrDbMGWmEYRNKiludm1476fNS9hFlCoWQX8UD6Ht?= =?us-ascii?Q?3UigjIe1IG75tPnu6FqR0VL+wDaq2DqMk527dky9EDLYgn9Mc7BxPJGO5li9?= =?us-ascii?Q?1JzirIX7cb3ZbfG/RkVyzqM4EUdg7j2zNeNAYNSpQpBMAarv1K7l3Ia4zYjw?= =?us-ascii?Q?Vm0Kx8P3UtW6Ybh+0sFNkdraXP6odoxP12NZXX72xPEkd8+A8vTn23qjArR6?= =?us-ascii?Q?rKVBaBwmyoxILqxLzbE2SJ4jYHDOggCGrOZeSyVistDFx8vZnzHI6arGRRIF?= =?us-ascii?Q?nW85iXByjyuPLoh8iEM5EQk+Rm58J+myJlD5WTum7AM5EIcxBSU3ntbTruYi?= =?us-ascii?Q?IYcyvEYoPXAObKl2+IB4BvSCNRv7RWX052P2A7+khwZIy0KRdFV9SATJtjJz?= =?us-ascii?Q?nnW4I3xd5ODZcJ0Kl2NfQpV9paeDkP7/tUDxynfrMU54h1qXOo2G00rn2QCY?= =?us-ascii?Q?bM89TVaDQ8v9QsBrgRD+4ukcA6TrXdt90NfBMyzHpBlPHgXFHv1JYD70azF3?= =?us-ascii?Q?JQhSaQTPE48xLRAt/YDwuFVwtMQjPz3TKpbl7bj2M25cYJQbHKW6e0o0vRgH?= =?us-ascii?Q?63uCEbfVezVIgbNCJ+MfyiZlSJ18JvQNDt/AUFRSMB4Ht91HYvAHf9HhHcUU?= =?us-ascii?Q?KH8paMe9eKrghuG4jVsRthgdHrUXGZhC/5kjqRcny64utLAJeC7I3neIBKta?= =?us-ascii?Q?4dx5IfRP4FdSi9/d10pZffMxy+etPchRBZXlY44jbt41KNo5to+NvgDsFagG?= =?us-ascii?Q?vYt8lzr6N9UpqCk+uckrl5dvbBZjQU3YZAEhrhY4kXanlkjwD0R8ss/SExvJ?= =?us-ascii?Q?gWvdZLtLuK288rX+fs7YTN9sEd9FUpDOVeydtAyDcY8yPvQyDXxJGVNI4uM7?= =?us-ascii?Q?/7JaMcFFCIkfWsGJ4Haamjep?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a87d1e51-c22f-4b5e-7aa3-08d8dd47e52c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 06:53:32.8899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HCMehUqroZIVHX2gSRcwUYct85urXkx4v5pLiaXYm5afibTE8WDl4hBriycEQZZJjMyZY0Qo8btsTrm3WNPU9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3663 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix IPv4 fragment offload issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Li, Xiaoyun > Sent: Friday, February 26, 2021 4:15 PM > To: dev@dpdk.org; Xing, Beilei ; Guo, Jia > ; Finn, Emma > Cc: Li, Xiaoyun ; stable@dpdk.org > Subject: [PATCH] net/i40e: fix IPv4 fragment offload issue >=20 > IPv4 fragment_offset mask was required to be 0 no matter what the spec va= lue > was. But zero mask means not caring about fragment_offset field then both > non-frag and frag packets should hit the rule. >=20 > But the actual fragment rules should be like the following: > Only non-fragment packets can hit Rule 1: > Rule 1: mask=3D0x3fff, spec=3D0 > Only fragment packets can hit rule 2: > Rule 2: mask=3D0x3fff, spec=3D0x8, last=3D0x2000 >=20 > This patch allows the above rules. >=20 > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyun Li > --- > drivers/net/i40e/i40e_flow.c | 89 ++++++++++++++++++++++++++++++++---- > 1 file changed, 80 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 4d44282312..86d96d9a11 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > + "Invalid IPv4 " > + "fragment_offset mask"); Needn't split the comments line. > + return -rte_errno; > + } > + /* > + * non-frag rule: > + * mask=3D0x3fff,sepc=3D0 Typo: sepc->spec > + * frag rule: > + * mask=3D0x3fff,spec=3D0x8,last=3D0x2000 > + */ > + if (frag_spec =3D=3D > + (1 << RTE_IPV4_HDR_FO_SHIFT) && > + frag_last =3D=3D > RTE_IPV4_HDR_MF_FLAG) { > + pctype =3D > + > I40E_FILTER_PCTYPE_FRAG_IPV4; > + } else if (frag_spec || frag_last) { > + rte_flow_error_set(error, > + EINVAL, > + > RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid IPv4 " > + "fragment_offset rule"); Same as above. > + return -rte_errno; > + } > + } else if (frag_spec || frag_last) { > + rte_flow_error_set(error, > + EINVAL, > + > RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "Invalid fragment_offset"); > + return -rte_errno; > + } >=20 > if (input_set & (I40E_INSET_DMAC | > I40E_INSET_SMAC)) { > if (input_set & (I40E_INSET_IPV4_SRC > | > -- > 2.25.1