From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6D0EA09F0; Thu, 17 Dec 2020 04:20:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DD19C9D0; Thu, 17 Dec 2020 04:20:26 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1D40DC9CC for ; Thu, 17 Dec 2020 04:20:23 +0100 (CET) IronPort-SDR: jMYROK0BYfKxEmgdO0Ts06F8+lYR2eRaaqBnUyKWGDPrY8PvDxl6yQJFYaPUl5iTxpi9B/Uenx U1goD1ZyEPog== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="193570954" X-IronPort-AV: E=Sophos;i="5.78,425,1599548400"; d="scan'208";a="193570954" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 19:20:22 -0800 IronPort-SDR: Nh7jDvZbv/AjY8LvSMd+MqDE2LmiWqhDd2JvJTv+bPJyVswT+MudWp+1aycb1kNm0R0cKr9/y5 4QkEtN5jF/0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,425,1599548400"; d="scan'208";a="385150257" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 16 Dec 2020 19:20:21 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Dec 2020 19:20:21 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Dec 2020 19:20:21 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Dec 2020 19:20:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGgmhP3zK7wkE87nILwSJCAJq9mlfAOXavsnqUlgsEtUpPexXrMThYchGboQwih38Vj9FBvv6EvX02l+luYCYRO5erYrWg1puApEKaVGS8tv2gccL6kkwjbsY2VDCdod/QPzzWa/gKUJI+p/QOs2BwlGInfZWAgip7klpEI4Uw9SS6g+HBMUdSiHdGj84PNlI1YA6R7VOfNhJqUgmuGxDR3Rwyhpc3e9vHzMWqOIA8+4UH8BIwZf9rFPlHFyLz8f4gjiLxEOLo0tIulTtMoY1MT9UepbYKILZ/BYxqOF5Fv2FDMr0+LLDkrJHUT/7JM68+ErbUui7pIGhwVx9EPuCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LvKxBTHCojYYzzzHMsXVLCyk2j+woNjCpgy8bngX62s=; b=E47gqvP7CH5LMO1kWPOXTuiEMfFljqV7WuF7GCaiAICxI9ViYgeC2de/36UKfolo5djQwS69ShHmP8b58lZHccLC20ZuZFL0DAd9Q4a6Kj7ccfaPeFrInBLhBFCBbdf9xBZRtfUGpPhYWfbDmfCBbrowo68yVchEgsmZVFb4wTYyqZ3EXadV0ol3QbJqKITb79xyrC0N26NmHDptbKk8hQNbXJzlvGc1phoZt9TIEvjHrnpX++a+A2nuQiHChl/8V6F0znti/s8QGAHW74ZKXo9ZlOrddQovg60ziXeMFXdeo6Du1Mc4cXKusFxIo9e9wBoSWC3SOBiOa04QD5EQvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LvKxBTHCojYYzzzHMsXVLCyk2j+woNjCpgy8bngX62s=; b=sE17J6tk19HB6pUCfJ5WjCUk1IqmMYIMSEz5ouuW8w3Cq+3+2/PB3pZwn/OgNci+KGbCby4La2U26QUzTFckLTIDGI2NBjg7DP/efRTHLNdtW4zsE2mSRBWOj/5ensLV7f707Ati8AOvtNuleP3vB4ouNEbKRrefQZKSYafMw90= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3838.namprd11.prod.outlook.com (2603:10b6:208:f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.19; Thu, 17 Dec 2020 03:20:19 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4dc9:358a:cd2e:45d6]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::4dc9:358a:cd2e:45d6%6]) with mapi id 15.20.3654.025; Thu, 17 Dec 2020 03:20:19 +0000 From: "Xing, Beilei" To: "Amber, Kumar" , "dev@dpdk.org" , "Chen, BoX C" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action Thread-Index: AQHWuBPdPsnuNQJr4U6skaYtuxmuHan61gnA Date: Thu, 17 Dec 2020 03:20:19 +0000 Message-ID: References: <20201110180409.42133-1-kumar.amber@intel.com> <20201111101031.52758-1-kumar.amber@intel.com> In-Reply-To: <20201111101031.52758-1-kumar.amber@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06ffb974-9bbe-4b6d-719d-08d8a23aae8a x-ms-traffictypediagnostic: MN2PR11MB3838: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gg48gtvHo3I7GbenhNkYybDRrgOj5vRC7M3HbFajM67VahcROhN6YfH+VrhFgVezFMYAUcl9q6tzW685B3H2CdrTqlBrPuc1t2W/ESiDGHxS4o6JRTDLfrT/MyBLT5qadjOJDX7h7RnwP77yLWcXmiIh9OHd1KZJzWN0GPTL+0i+flCpJlREiQjLupDCg/7QWB8kuC1evVJ3xCyyglG54HDpOGM1KYQ6jhvbt/XITHrJicOgC4RMdsNOcvlAF0VV9OElP+tvTFUiIUK0VvUWZW90OWEnUNjSkeEAfaWS0NCe9TGbyge/uV5VxvQ7Wyo4o/BMjiHMcS3ZKZ4jdMV4Ww== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(76116006)(26005)(2906002)(6636002)(71200400001)(316002)(83380400001)(64756008)(5660300002)(8936002)(86362001)(6506007)(110136005)(107886003)(478600001)(53546011)(9686003)(66476007)(66556008)(66946007)(55016002)(52536014)(4326008)(7696005)(8676002)(33656002)(66446008)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?evGtwIyxeCCTlcZtvzfH4uzepF9JZAdEfAp1l1oja9FsExl6DlQBEGG26sh/?= =?us-ascii?Q?l94UcHIhNjbBQNBvnTi5zxFlkHz+xtkeh9cEgJnS0Z/sxNWkbU2t9rZOOS4q?= =?us-ascii?Q?G798wir4fPOw8V54hlVaMblKI3am5ePMoLiqM9GXLAqE0y3LRJ17K3xpxZlV?= =?us-ascii?Q?UzELaghyu65yOrIJuHdYevVghETbC4z4w+4YJyQnh42lSWz0fIEnfQPQoUA3?= =?us-ascii?Q?2tAMef1EdlRTluxNlhfWhCfkemDEgoDwZ9c1DnXRFBMjCbDij93ucq79ggN1?= =?us-ascii?Q?zXX80lk+zRlt6MZV7ByZN0EAC0Bt0Hfzr0Q+K1GOftaIO1BxfQBVYDsv+Dom?= =?us-ascii?Q?qCr28vCY+fhbcG3cijCK3BKnGPRUCpnzIHR4XxyWrx9+JimWYcUC0YB0li96?= =?us-ascii?Q?42ICM2MZV3EsowXr8Kb5NIva971jxxkLH57Mm4CirM+jXL3JAfVvFHbx8981?= =?us-ascii?Q?BOGdVEQVpBq5IbjKz0mtyzm4gBnFJ+49Yeddq8LmjhSVj9hGIHg9MiNoz8F3?= =?us-ascii?Q?Px6jILtisjZRitXwHiNiFIAWBXsh9QfhlNh9tZiUjURVEzKoxvuGKSN28pal?= =?us-ascii?Q?tE2q28zp2Z/IIbFNtqvc/5Ou5prGyW3wMs85LPxcfO5y5GvTZULC4sFIyUyn?= =?us-ascii?Q?/LrCa5tSHQKecXgSFx+xZe4/ha3Y3JFI02NzhqvVbHUkegUWgP6sRURDiEca?= =?us-ascii?Q?Bqw1Uce/4hJHJaDUsuxPowZvHp98GIB2+ZlB2oY78sWaViTRu+n1vLtFWumt?= =?us-ascii?Q?m4jBZxb4TXpNYFJ+SJ4krc56/j1oimNoF4XPMCNvIf5g1YjbHvY7c+74mO3I?= =?us-ascii?Q?OzvV+D7vU15SngkKc/io5wR6FfDVly20udhV0bK+pnNlsU4PyjkqLA/vqjZg?= =?us-ascii?Q?jdfbFdH/grABoCEI5gNS6aB8tVU/w4O0iiZzR//ZCeMes3byeoYUfZhi0Mbx?= =?us-ascii?Q?VM3tZhvuIw6reHGriE6u0Aym15Do8IihD1CzJGVVDQE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06ffb974-9bbe-4b6d-719d-08d8a23aae8a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2020 03:20:19.1947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZQJP0LEhHqGRCkjUf9uABmrMgqeZaT3RHZs3Ngkqb4AbjRVn51HuTPAtfOpzKyCxo/er+w6Zqsn9V0PJuaD5SQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=20 According to Bo's test, this fix patch will cause other cases fail, so NACK= . @Bo, could you please detail which cases will FAIL, thanks. BR, Beilei > -----Original Message----- > From: dev On Behalf Of Kumar Amber > Sent: Wednesday, November 11, 2020 6:11 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action >=20 > The driver must check for the queue number in the RSS action list and if = not > should return with a proper error message to user. >=20 > Bugzilla ID: 573 > Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") > Cc: wei.zhao1@intel.com >=20 > Signed-off-by: Kumar Amber > --- > drivers/net/i40e/i40e_flow.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 5bec0c7a84..975340cb1a 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4917,6 +4917,17 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > NEXT_ITEM_OF_ACTION(act, actions, index); > rss =3D act->conf; >=20 > + /** > + * Check if Queue number is specified > + * in argument else throw an error. > + */ > + if (rss->queue =3D=3D NULL) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, "Queue numbers not given."); > + return -rte_errno; > + } > + > /** > * RSS only supports forwarding, > * check if the first not void action is RSS. > -- > 2.17.1