From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9627BA04B1; Thu, 27 Aug 2020 04:49:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 670B51BC24; Thu, 27 Aug 2020 04:49:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 65A691B951 for ; Thu, 27 Aug 2020 04:49:23 +0200 (CEST) IronPort-SDR: RTr7122yYOfiCySJevG4z+2SSBsIMI53WY2RJdVStCT4eKFAOpytHQsDhwYmbCWmMUpV8lekWx NTuMqgmyBIBA== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="153833896" X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="153833896" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 19:49:22 -0700 IronPort-SDR: xIeUL7YEEB9tG5C5vxvkCJjRgPKLbR0z0eHDUbELHurhqwfhJXC1j6q9+Ur9oaoADin0Mcfp1w eBuI45cUJOFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="339369046" Received: from orsmsx601-2.jf.intel.com (HELO ORSMSX601.amr.corp.intel.com) ([10.22.229.81]) by orsmga007.jf.intel.com with ESMTP; 26 Aug 2020 19:49:21 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 26 Aug 2020 19:49:20 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 26 Aug 2020 19:49:20 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 26 Aug 2020 19:49:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFeUU0ybr3+8Fqh3Hlrbws3/CBV1iBaIml74xGl7OYw+aBoRD2O1mmCRxk6nCcZBdmAsdaoTCCm3J1I+Nfh7w4ECIEZeinIAasW9pcxEo4i9gJ9isw/TQ6/36erPzF5r/Ji1PaFzlypsZNiTNT2l85R4mrFqYo7FzJ/WIPMuL3gJnqO7vOCaElcMbpiUCm/lRYLHVJii23lUNgriXixJBEW8d7Dv7jZOXd0zj1xSaDEOoViTSbaIYSASVw4CsAThnFEyf5eFCOpAhDiPpCjN8zJbPhsFlN4ixsZ0fvcadCJhPG1Fl5R8em4DHPl8j27JG7zSx4Vyiqya8ATgKY9L5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eu8X66efwtganJbM9LhrIxFd5jgRi73J85qk2zIZ4e4=; b=P8YI8pcsFE0GVX5rTjkZqhUy0K8OlH8sOsY0zIpUM0H7L5QYOMHAAy3RES2VsO1XVibkCpuz2UJXe9cYW90hIPT8Dr7q6C6LZVINU8u0Umkme9lpG9H/AVcxLbpo+Zy641URkh6rJ4nugod6HV4eeL2BAPoq1AmcUrF6MO2STzRb66OBvPo6mXiOE3SVFxV4ukCn82unHsPblGff9xcyvJ5SeKUNBydmilk1ymoDRiwETib3ngwU/fHxbQuOgOTCaeNtMHAVNA6tu/k+1exKFomjTJZ1C0vGvcJQq8UoZ6PrHFg9xFMLJcO6R6xIZIe0/MBVD5FxeekxAQDqGt82aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eu8X66efwtganJbM9LhrIxFd5jgRi73J85qk2zIZ4e4=; b=makldMyIiDdxSbSpRMBQpz2bz48nFkeSooagF0Ig0j8Y2iw70CMlKbZGqRkB7NO8x6KCm4CCVAiOKnA83GwW/4PE+cBq312aonfsPb4INd15YO1QgrrcqxIza3Wnt2tlbFUyUuNg41B3YfZpJuoKzsOP6BQlmbitcC4/RSej1Ek= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4629.namprd11.prod.outlook.com (2603:10b6:208:264::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Thu, 27 Aug 2020 02:49:18 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3326.019; Thu, 27 Aug 2020 02:49:18 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Wu, Jingjing" Thread-Topic: [PATCH v2 1/6] net/iavf: fix scattered Rx enabling Thread-Index: AQHWfA96YvpZvP87SUmKzApcqN+yMKlLQHbQ Date: Thu, 27 Aug 2020 02:49:18 +0000 Message-ID: References: <20200811075910.20954-1-stevex.yang@intel.com> <20200827011410.18401-1-stevex.yang@intel.com> <20200827011410.18401-2-stevex.yang@intel.com> In-Reply-To: <20200827011410.18401-2-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b5e1021-8f48-4596-3b4f-08d84a33cb1e x-ms-traffictypediagnostic: MN2PR11MB4629: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E/OgRZEBhFLZlGX96Vv83ksp7vsZps+LayiEDpWXGHdJMh/mqk3NzAdUGsjTxuTEJdaMCsj3I7zyIacOLa0lkcPV4cPXjjO1StgT2JWHqaQBJjDCj4Ub9/0xdYTLVJCU8JJFlmEpaVJ+2H0ya+Wa0aImZcB/4pYlApX1PopcFaosCwCqPMZmCqjeraHk0OuN0aXNvqN2igLk7AXemBC5ZsPfPrmUm8HqTCXbpKn2Z1VfUYoLCRV1C/kb4P0g8BCMCLR01WcX5yfcYC1aNBLD2+HLonesf/WdjtT/Zmto7H3JSiIVERRKCwPpZWKHiYb4rj1TwjIyklrMeyU5Z4bYYQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(55016002)(8936002)(9686003)(110136005)(478600001)(316002)(83380400001)(107886003)(33656002)(6506007)(186003)(26005)(53546011)(8676002)(54906003)(4326008)(66446008)(66476007)(64756008)(66556008)(71200400001)(52536014)(66946007)(76116006)(2906002)(7696005)(86362001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 5qx/lehxBN8pmX9D/vF+WMgtW9WZYLsVuzg7NEs1Eu/VobBEoHj0OjxZEjEN9QJB8974xv+WWq7uogLNJN/Vr4wJGSdf3jYNnVCpJg9jj2iKlParDYEf9aPXrNcZDmX8vZSIds9iKUHsr+aYnffYKbH3IaJHqFV4/l/+2h2KilFYptKOX9aKJ4zlmJ1r2ViocCOnw8lXs5DZAxLybJ/Ir+y3/pLFRJXvXdFzdY2gicKgmfqODc/ErruoryjAFs0qsUrU+fLA35O2JV+wfmBMwkqlRinpsb6zrxPDVfQZ5fg0SwWC2nLUB3pkLClxs+ENV5TPzv5CNCZkAkKy6W9xzlh8DWdaAywztHmHGQkh6ZOqe681dcCTRMeiaHoVZ0cGp4M6yiCXSQsvLM+P4MTE2xppvDGUMcP4bArxaQrp9bIJ07wh0yyvLVgMbNmnjgdi965LUwP3vkXNXmP22kGzNeJMmDMUhRNey0rIncOaUaPWdjWMIGNsttAjj4l9GOHRrAh2i5HpMtUs8T0HOINtBbD1G9uQ2uM+LOBNsLahht30jyqlIQFbW8xL755Xab3yHX+fxARWhF5zXvgJ5B+BNQrka1wInddLTIssOVyP+iovPpYBT5UZgJA7CvwsahCzS08Vockg8OwMcBzZRgBh/A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b5e1021-8f48-4596-3b4f-08d84a33cb1e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2020 02:49:18.2310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gz2049fDrGLzvE6UNZeiZszmKEw9PRNVvj1ntY4o7qdiAuu2sGWazBQSgyqmbV4e0uTz4jh+7buCgrnqv1ximQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4629 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/iavf: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Yang, SteveX > Sent: Thursday, August 27, 2020 9:14 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Jingjing > ; Xing, Beilei ; Yang, Stev= eX > > Subject: [PATCH v2 1/6] net/iavf: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, the Seems my comment in v1 patch is not addressed. > queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vlan > header size. >=20 > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") >=20 > Signed-off-by: SteveX Yang > --- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index c3aa4cd72..f9dd5710c 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -253,7 +253,7 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct > iavf_rx_queue *rxq) >=20 > rxq->max_pkt_len =3D max_pkt_len; > if ((dev_data->dev_conf.rxmode.offloads & > DEV_RX_OFFLOAD_SCATTER) || > - (rxq->max_pkt_len + 2 * IAVF_VLAN_TAG_SIZE) > buf_size) { > + rxq->max_pkt_len > buf_size) { > dev_data->scattered_rx =3D 1; > } > IAVF_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); > -- > 2.17.1