From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure
Date: Tue, 20 Oct 2020 08:18:09 +0000 [thread overview]
Message-ID: <MN2PR11MB3807CC0CFCFE11C1E9931D0AF71F0@MN2PR11MB3807.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200902063802.102428-2-qiming.yang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qiming Yang
> Sent: Wednesday, September 2, 2020 2:38 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor
> infrastructure
>
> Defines data structures and code to init/uninit VF representors during
> pci_probe and pci_remove respectively.
> Most of the dev_ops for the VF representor are just stubs for now and will be
> will be filled out in next patch
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/ice/Makefile | 1 +
> drivers/net/ice/ice_dcf_ethdev.c | 66 +++++-
> drivers/net/ice/ice_dcf_ethdev.h | 11 +
> drivers/net/ice/ice_dcf_vf_representor.c | 245 +++++++++++++++++++++++
> 4 files changed, 321 insertions(+), 2 deletions(-) create mode 100644
> drivers/net/ice/ice_dcf_vf_representor.c
>
> diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index
> 34cd4024b..f9eb34a87 100644
> --- a/drivers/net/ice/Makefile
> +++ b/drivers/net/ice/Makefile
> @@ -88,6 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=
> ice_generic_flow.c
>
> SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_dcf.c
> SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_dcf_ethdev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_dcf_vf_representor.c
> SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) += ice_dcf_parent.c
Need to change in meson.build.
>
> # install this header file
> diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
> index 2faed3cc7..73af87785 100644
> --- a/drivers/net/ice/ice_dcf_ethdev.c
> +++ b/drivers/net/ice/ice_dcf_ethdev.c
> @@ -973,17 +973,79 @@ ice_dcf_cap_selected(struct rte_devargs *devargs)
> static int eth_ice_dcf_pci_probe(__rte_unused struct rte_pci_driver *pci_drv,
> struct rte_pci_device *pci_dev) {
<snip>
>
> static int eth_ice_dcf_pci_remove(struct rte_pci_device *pci_dev) {
> - return rte_eth_dev_pci_generic_remove(pci_dev, ice_dcf_dev_uninit);
> + struct rte_eth_dev *ethdev;
> +
> + ethdev = rte_eth_dev_allocated(pci_dev->device.name);
> + if (!ethdev)
> + return 0;
> +
> + if (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)
> + return rte_eth_dev_pci_generic_remove(pci_dev,
> + ice_dcf_dev_uninit);
Should be ice_dcf_vf_representor_uninit here and
ice_dcf_dev_uninit below ?
> + else
> + return rte_eth_dev_pci_generic_remove(pci_dev,
> +
> ice_dcf_vf_representor_uninit);
> }
>
<snip>
next prev parent reply other threads:[~2020-10-20 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 6:38 [dpdk-dev] [PATCH 0/2] enable VLAN offload in DCF Qiming Yang
2020-09-02 6:38 ` [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure Qiming Yang
2020-09-08 11:35 ` Xing, Beilei
2020-09-09 7:18 ` Yang, Qiming
2020-10-20 8:18 ` Xing, Beilei [this message]
2020-09-02 6:38 ` [dpdk-dev] [PATCH 2/2] net/ice: add VLAN config for DCF Qiming Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB3807CC0CFCFE11C1E9931D0AF71F0@MN2PR11MB3807.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).