From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4753BA0547; Wed, 21 Apr 2021 03:46:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3195041385; Wed, 21 Apr 2021 03:46:29 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1183540A4B for ; Wed, 21 Apr 2021 03:46:26 +0200 (CEST) IronPort-SDR: tVLXAjxQ1ex83YvY7OIZdZbEPtiIhyaF/bJ8RALtsyzKFOmbCWPEG/z1hfK2LiZ3bK7vC0/qh8 sRKZt2Q6cu6w== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="256937092" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="256937092" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 18:46:25 -0700 IronPort-SDR: Ccb85OCw1jRWxBTCBfSg3mkeykFAveQH4m+iCuKdOCAX/iUz83QVGmNT176RGjFe7+301JTcHu bMo+mDCXIgUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="455141625" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2021 18:46:25 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 18:46:25 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 18:46:25 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 18:46:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z+V6p3gmcEp5oTsNiCgbXpY6ckLrT8lK1uFJeMo7rzUTTdNlGTDRFS03z0H2lEJJp6AQXDcqdm2hna7oKCij8DqkbQZksACS2hlUVVSa19tZff8QaqkE8oq1B+x5M0O4D9k4iVTslCAyJkBQuwPokPm+S08dxCKsyfttWgS40YnDC4M7iDQd7HIejW+7x3CnUDTB++hT9OmIEjJdPlzejxhcSN6MbPSX8Br+/lgzwpMLmmLXcQyJYMwFbC7P3GvdQD9ZOSuww2nifZKmEmxRLfYP6n3Hr+BlXj/5PGWJFdIcJ2CxVJRh0q9gGIo9RFMMbXTXlidL3UelYRWcbi8NBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jcD29NAIVrHvwmYyv8+TkuSVFVKEsYS7BxEQA7+2M9M=; b=BpOkorDBs2c9utz5mNjRoKy2MUBjaa/+AwwZBb7j9E61DhP/+NYQNtMYVbZlme67SmQrJQdvH5JkLSFHIIvX3hcMGU1KUOPcbDnLYHY5Q8fHK8xyfBCNFoYblr+vEZU9O6l8sgUb5hNJx0EL1puuMr2wsX51CuAAOG3q4aH5lb4ZIJyjgeFXI5tS0VN30GKV71VVq33FHqJp21fMCet7DL268SpOH5ktSBcfaTJT8xaYXpvtpf+T4FVdY1sxL/lHT2Yk7kjN2iogMOK4v/JWGJbUl+QIRvJo5UAB94K/Z8nvoVxsTCts+M32e0vwvSjeCXgkfTT+mVGxihDfHj0clw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jcD29NAIVrHvwmYyv8+TkuSVFVKEsYS7BxEQA7+2M9M=; b=rz7O5ozJxchNqIkzbTb7l6m6WrL4bn1Cge0XrWWr+zeMp8jzqMKJpTO3PCv3Ntoi/eAFcK0ftMBneClegBf8iBVjAtH1PJ1olwFwqfOu7JQFM3Vvz1oN1PGUtx5pn3FLz+1r27zVvpCrCxoOfJwfGagUAiEhs3wMxcyuL9UigY0= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 21 Apr 2021 01:46:22 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7%6]) with mapi id 15.20.4065.020; Wed, 21 Apr 2021 01:46:22 +0000 From: "Xing, Beilei" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Guo, Jia" , "Yang, SteveX" , "Zhang, RobinX" Thread-Topic: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype Thread-Index: AQHXMmhFu7rij7ymhkWr2iRC6C8rRKq+OlPw Date: Wed, 21 Apr 2021 01:46:21 +0000 Message-ID: References: <20210416021955.9790-1-murphyx.yang@intel.com> In-Reply-To: <20210416021955.9790-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad29a6c9-c415-49ac-f810-08d904674422 x-ms-traffictypediagnostic: MN2PR11MB3807: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k2x4LmhvqmKAkJILxel5/gAoSgrvrcRmQ3zbQ+efhO0RRQ91Vx3erBhguWC19yXhqMGGrDkFYoYXyrmrqkGrEgPuFtOPzi18jXaa1yyQ4wq9DER1QDvKcc9sVkZuBGiMAdT49mGTXDcHiVfJvSPv+282XjXjP1qNT+89BtGWd4dIrET/1Tr7Sx1V/DmsuByAhrI1v4FMzqKaFZy+GMPnzzTZgv7O05UZKubsCF6+yDcZp8HH3n54Ao8vlSdTiDwtMt/GX3k2hqjxlLBEFvodCYxJCdhd7/WErD17DEOEFQ6KMPAPZX9PS4CWUKUCJTxOKo04OaivKkQbRnvJHJmBKcne+fbANcruFFDGKNRf5/6WQEhq5SZxyGti2BRLITIHsIUGPqcUs0rtUg7EvuoMeboSA8RyPVI3QI/AIAKcgmjPOczdtyIUt6ktTfJNbA+iFJbaFIGGL2fkt2H7fbPRjHaVWNwJJmEPK0ALjwGfHn/HjRddqD+2HrQ9ySsZyEKSJvcUfkJKjKH1Xg9G77a1J2dCi+49UPLax/2/kkVBf7vtsCIdwE6OUHGCONwV1T1Fw9dxZLhTnroiEauJZCcpA6peK1Oc+vBZpX7W+WCQh4E= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(366004)(346002)(136003)(396003)(2906002)(26005)(316002)(110136005)(55016002)(186003)(54906003)(7696005)(8936002)(5660300002)(6506007)(53546011)(122000001)(107886003)(66946007)(38100700002)(66446008)(66556008)(64756008)(66476007)(9686003)(4326008)(76116006)(52536014)(8676002)(33656002)(86362001)(71200400001)(83380400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ydtYWbBHkABg4mhbGE78W2OGGdC/48E9/sVw3oD3rPsyA9cUErGAQiutqVOS?= =?us-ascii?Q?aXl9nRbrn494dP09YgY+4RyqyMjVT61ZrsB3Y/u/uL7NEmAW9stzPHzHqdoJ?= =?us-ascii?Q?Q0CVg/sm3gU2Z3XDB68R1wc3QEvFZqy5RtYbcb5bOUGB1uVicUWJnYsM50y3?= =?us-ascii?Q?WDwFcjQG1lOTc60Rh9n3m2Rza9XY0oldGzn7qb/yKsr30LCYzRNR/GomOST/?= =?us-ascii?Q?QbY5py+XarzT9qDPHD82vWXyB41ZYBQgCBO7AtLA6zBoaQBRD86WXssCg333?= =?us-ascii?Q?yRp4OaXz7A7rH12GBSHoi0x3t/6GsTPdM84rRFlfSz29JApULv3FEFttsQkn?= =?us-ascii?Q?jdFR42Uucbp4MBjawNZMdhiA+UEAH7k3OLPNCjEVKHghyunJRFN34P4LezdM?= =?us-ascii?Q?LJkt83yD5Zlzbu7Bvq6gPVBpipaikTZe2JlCSV5HivAcJY3rtgeYBZPdVT0T?= =?us-ascii?Q?KqWQbR0wuMNpQ0adBQqRX7iHfmxJ9TALE+uTWDCVE3yCnITjMZ8pSGjfsJfj?= =?us-ascii?Q?Z4Z/BEP42pXHehkvkL7MasMF5beAp+TMVr9PSKN+rWrbLmf5G2WItuvPmJ7k?= =?us-ascii?Q?00S5ygaWc7XbO21La8bRY3AgCZCXa8i9wCmyhJHtSulwjdFQV3PB8/uqkWZr?= =?us-ascii?Q?7MchEQSBa1TnkyrfcOlLMfpMijB/r+ZRkFqKw9A2eMPuHTcRdwB9ZNRWsuXf?= =?us-ascii?Q?9/UhbAL9b7c+s9eoJrA+Ys+uGPTclrjSOitZGTLmGw6bj5o700s6NJ92QNul?= =?us-ascii?Q?CojXKye2y5nng5MQMdw1Wj6g3iSpmIatOX7OeZPiFo9w2NwZemsQNtDmiNzl?= =?us-ascii?Q?Gnz1VyYtm902l88TTuJHaAX/l57VqZt+6BAl5k407s6YhFPoNWf9PFGLbOkx?= =?us-ascii?Q?B8Z6WBqsF5wD7U0JFyjJLsd7o8dhan0uh78Ipnj0XzpBryi+AdJ1g1IY25Id?= =?us-ascii?Q?v/GnZy0howhLchm+zSF7IcVY9jlWpG7LGtFilsxKxIl5rLKGrmz92KtYMPFr?= =?us-ascii?Q?X1tgouBgZ7xOhPTFkCeRw9iD0s04CzeIfjnU0I6NMHCoS1pyOtFVVzcxjopR?= =?us-ascii?Q?KZPBD45HNL88svAd7vAIw+ylj6Izf0qawLAc3baeq1bqZZQUWL8zIzQuxkaT?= =?us-ascii?Q?JhvytFymdwHOgVeGeZGRL1WgQ7V0L7PToP0BiPM6oZAXMQcv9mDgdriRBcjd?= =?us-ascii?Q?iDEKOThzMObSBPsvcZfex/O8IRPvb+GVqPBqwxAXRu5t45eYVCQ/1Mwz60rK?= =?us-ascii?Q?AcweZI/jHnF/mKfp3MKVDatVF6xaQwXQGU2zKui6sec0285VHSqcsyOQVBvf?= =?us-ascii?Q?rCPczwSueY/N4nFhTrw28Yje?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad29a6c9-c415-49ac-f810-08d904674422 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 01:46:21.8841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eWfxn23lVneN61XDFH5X2KANIgKUWLqB8ExynVd7tBirLL6D4FGq7k60EiJvdSIFVNnb5a5LroxA/BQ/1WxDtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3807 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow does not effect on uncustomed pctype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, MurphyX > Sent: Friday, April 16, 2021 10:20 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype >=20 > Uncustomed flow rule does not effect, the root cause is not write the con= figure > in register. >=20 > Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow valid= ate") > Signed-off-by: Murphy Yang > --- > drivers/net/i40e/i40e_fdir.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > da089baa4d..77375b059a 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1607,8 +1607,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf, >=20 > /* Check if the configuration is conflicted */ > if (pf->fdir.inset_flag[pctype] && > - memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > - return -1; > + memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > { > + PMD_DRV_LOG(ERR, "Conflict with the first rule's input set."); > + return -EINVAL; > + } >=20 > if (pf->fdir.inset_flag[pctype] && > !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > @@ -1762,18 +1764,14 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, > i40e_fdir_filter_convert(filter, &check_filter); >=20 > if (add) { > - if (filter->input.flow_ext.is_flex_flow) { > + if (!filter->input.flow_ext.customized_pctype) { > ret =3D i40e_flow_set_fdir_inset(pf, pctype, i40e_flow_set_fdir_inset should not be called here, but outside the if stat= ement. Since all following configuration is for flexible FDIR. > filter->input.flow_ext.input_set); > - if (ret =3D=3D -1) { > - PMD_DRV_LOG(ERR, "Conflict with the" > - " first rule's input set."); > - return -EINVAL; > - } else if (ret =3D=3D -EINVAL) { > - PMD_DRV_LOG(ERR, "Invalid pattern mask."); Remove the log here, then you should add the log in i40e_flow_set_fdir_inse= t, Right? > - return -EINVAL; > - } > + if (ret) > + return ret; > + } >=20 > + if (filter->input.flow_ext.is_flex_flow) { > for (i =3D 0; i < filter->input.flow_ext.raw_id; i++) { > layer_idx =3D filter->input.flow_ext.layer_idx; > field_idx =3D layer_idx * I40E_MAX_FLXPLD_FIED > + i; > -- > 2.17.1