From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3C24DA04B1;
Fri, 28 Aug 2020 08:39:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0CF4D1C0B4;
Fri, 28 Aug 2020 08:39:16 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 7158E1C0AE;
Fri, 28 Aug 2020 08:39:14 +0200 (CEST)
IronPort-SDR: BSAWCCNWraT8n0B7ON4vTM8xXxhfL7yqpjE+9tMIhoNwQ+ujJiFIi029U5ZbIWcAT2JBlkAQtY
aUqy5MEW4fbA==
X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="241432891"
X-IronPort-AV: E=Sophos;i="5.76,362,1592895600"; d="scan'208";a="241432891"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Aug 2020 23:39:09 -0700
IronPort-SDR: 4et56TG0d112E3tXuAxxnY4QCguVfPsBC9zQQk4IcCUy8WW4z6duluhhWLxckI/zSeCkowd5pe
wG95mrLAmfaQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.76,362,1592895600"; d="scan'208";a="332451104"
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
by fmsmga002.fm.intel.com with ESMTP; 27 Aug 2020 23:39:08 -0700
Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by
ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Thu, 27 Aug 2020 23:38:48 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Thu, 27 Aug 2020 23:38:48 -0700
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Thu, 27 Aug 2020 23:38:47 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=DU0bB78lM7d7C9/NVf2DZacWi97mGAhRsdYlS156ob5FP9VPZQ//o7X/wB2TRxy5cEpzwGonDbvoNUuPdUOwe/VyHqMgtTfCxw0EcR9qlyGB4W2YtcgRLN/aAwjd11UE/9uEwHDtjoa9BVNpUhSdeD9ltZDwt5EMLeKzCHmAieVP7PX6RrtfIAQZEgCpxAeoo/lhNqRd9+K8l6EP5J5l+jQRMtPzsYBCDJI1y+emaEedt8vWCjBEfPa31bhKmpmPDG0fKt/En9w2/2Mcg4bLQeY2KG2U79KnRm4yYBT0TcEMjBPo4Ys4zhJ9X8hdQrvuyB1SRsqM+Nl+z4GbnW1IZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=wHHHRegBubnvN9TH1ECEQtPBKVqjtMc0N7jBIaQGeqY=;
b=WocCOm8Kq9JzBa/hQ8FrFX7lZ4dRtMWlKkTvdxZDXUIubQc09aDx7Pb2+nlc5yrf7BYrXcoz8Lj5VCuw9TCBW2SnSfz6f6Wo3zmr8b9dhWg/ZBrTNTPvUVlHhr3UVLZmkyXhOGu7/hDZWVc/6/ghqOpAyBcAzuCqULqP85/4m60GO1ce+2QH5I/6SMTC4HQsh08FmDgEFRtuOCv2XL2P65aTTwFB2ILv6OecxgO72sp5HAOR8BqWRCaqcUUBqrp0qWu8FMjvfEEh5hHnX/4TXaUlBiMP3P9+PRAFk99zriOKFEedL7V61+AJ2E97HJ9RjeA/EG7gGuUt7bC0YRlEVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=wHHHRegBubnvN9TH1ECEQtPBKVqjtMc0N7jBIaQGeqY=;
b=KW/EJ9DiOsn3E6YA7yUNkn56z6FvyO3UGNggWe3MlcMmoYZqSGaNE+sAKl/FRcmLoGm1Hcs7Vfofn5OMczYsksNwarH1N8BbP1+R5C8uXmwCUDh+FVbtY9j6jMNPhCQfObtTiZTzqA7F/5kk0Kf4vwgZwaNHoW+QvQqCnIMX0D8=
Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24)
by MN2PR11MB3584.namprd11.prod.outlook.com (2603:10b6:208:ef::14)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Fri, 28 Aug
2020 06:38:45 +0000
Received: from MN2PR11MB3807.namprd11.prod.outlook.com
([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com
([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3326.019; Fri, 28 Aug 2020
06:38:45 +0000
From: "Xing, Beilei" <beilei.xing@intel.com>
To: Elena Carasec <xcaras00@stud.fit.vutbr.cz>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>, Andrew Rybchenko
<arybchenko@solarflare.com>, Luca Boccassi <bluca@debian.org>, Jan Viktorin
<viktorin@cesnet.cz>, "Di, ChenxuX" <chenxux.di@intel.com>, "Wang, ShougangX"
<shougangx.wang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] i40e: fix segfault when using custom RSS key
Thread-Index: AQHWe5waRDcRo8zNuUyGRzBKAMUa/6lNE03w
Date: Fri, 28 Aug 2020 06:38:45 +0000
Message-ID: <MN2PR11MB3807D401C156788A4212C860F7520@MN2PR11MB3807.namprd11.prod.outlook.com>
References: <1598441281-11209-1-git-send-email-xcaras00@stud.fit.vutbr.cz>
In-Reply-To: <1598441281-11209-1-git-send-email-xcaras00@stud.fit.vutbr.cz>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: stud.fit.vutbr.cz; dkim=none (message not signed)
header.d=none;stud.fit.vutbr.cz; dmarc=none action=none
header.from=intel.com;
x-originating-ip: [192.55.46.36]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 88cb89a9-14b0-446f-1655-08d84b1d0353
x-ms-traffictypediagnostic: MN2PR11MB3584:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR11MB3584F7D4E4A7F458AD0B7540F7520@MN2PR11MB3584.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hUVbYylMzMoxH2aPdEjbT49mljwUT4nWlRPTT5VJjcWypSVtDKFfHD64tPcz35XDKMOmDxK6zFjkUvmf2y+oXMUfzlly31KxfoooZzxe0RNtQeWPlL2sDqBwYFegrmV96tRIA14EDDrXhLKMdFUQ8u48hUISfD5pztDcxPulHLQbx2cSjqBX2Lj140RNL0kHOpU5Paxltqt0mSx4CTv9qSpyywzDCIIDDgwJV+ngPSuPXcKfuaIHPdzeAOLTf/PWjUdPV78rG/IzWxIUetiYa7PV3GQ8BCes+eDaTqfklPO/ThZ4KlwhKMZVENoSrG/M
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(5660300002)(4326008)(71200400001)(66446008)(66556008)(66476007)(64756008)(54906003)(33656002)(478600001)(9686003)(55016002)(83380400001)(107886003)(52536014)(86362001)(110136005)(53546011)(6506007)(7696005)(8936002)(2906002)(316002)(8676002)(186003)(66946007)(76116006)(26005);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: Xv2vfPt5Gia/+hifhgjZzYrnKgmYQiDQ8cOXiBGOTMSg38hrs+0xindNNutEacp1HdWDKQ8/Bl+v1gApzowT0NpUcQL31g1NaBjWUjDnH8uqSME4Vw98c6umigNoBIrqdWHxfZOvE4DN+uWTz7WL/VScRFxOyFpdfE0/e8NINiHG/Ax/apf5p7PLMzEJ9CCYkBqOw2zAF6B5+izoahDi8uLomzQOwT6yS5LLYVPFWrigK2jR+sV1y0chJcQerCpcYyfaHzJOkZhLWlb1po3oDGVC1T0vwq1fqnZ8nc3OAGUOmX1pRdqWi4hKNP4OP6ybSc1+W7+ofoljnO6Ut09j1Zay0ygsvdxddrqX6LrGNfZnv8002Of0Dl0+qThIog1vC7DchtepGKU6fzKxMoWl61HHP2eGRRknc090nyT1EKOWr8eOgSDcemAMI9z5VM5bMi9kXTmNbsMicG1OeNpuTv9o8diI27EhcDNruBNVRekMHloj9NiOIe/3wiLpvs11BNj0WkJaItwg29gemqg6pIVeOJvZhVSObzc3pt8C868c+LDgonoxFa8W8NXBtJdbrCZS+xyHwgyFshq+bB7kTVlSpKNFiWlhSLF2J9MkViRDc1Pyzqc/GVGhCSgMtKU2bY51yconoyEvasgyfPpIuw==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88cb89a9-14b0-446f-1655-08d84b1d0353
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2020 06:38:45.3467 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mdry5/r4ks3PVSwEKvy0dlsKNzy2jmViA+WsqF+5Q06B3QQFqcL9LF3GOtHVB+zIpw0WOCBW3iRp4NRe5JkM0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3584
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] i40e: fix segfault when using custom RSS key
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Elena Carasec
> Sent: Wednesday, August 26, 2020 7:28 PM
> To: dev@dpdk.org
> Cc: Elena Carasec <xcaras00@stud.fit.vutbr.cz>; stable@dpdk.org; Xing, Be=
ilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Adrien
> Mazarguil <adrien.mazarguil@6wind.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Luca Boccassi <bluca@debian.org>; Jan
> Viktorin <viktorin@cesnet.cz>
> Subject: [dpdk-dev] [PATCH] i40e: fix segfault when using custom RSS key
>=20
> &out->conf and in can point to the same memory area. Reinitialization of
> out->conf leads to setting in->key to NULL, but leaves key_len 40. This
> leads to segfault on destruction of the RSS flow action. The segfault hap=
pens
> inside i40e_action_rss_same(), when comparing comp->key and
> with->key, because both comp->key_len and with->key_len are 40 (should
> be 0).
>=20
> Reproduction steps (testpmd):
>=20
> port stop 0
> flow create 0 ingress pattern end actions rss func default level 0\
> key
> 6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5
> a6d5a6d5a6d5a6d5a\
> key_len 40 queues 0 end / end
> port start 0
> set link-up port 0
> start
> stop
> set link-down port 0
> port stop 0
> flow destroy 0 rule 0
> (Segmentation fault)
Hi,
Thanks for the fix.
But according to Chenxu and Shougang's test, this issue doesn't exist after=
DPDK 20.05,
where RSS configuration has been refactored.
Could you please retry with the latest DPDK?
BR,
Beilei
>=20
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
>=20
> Signed-off-by: Elena Carasec <xcaras00@stud.fit.vutbr.cz>
> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde=
v.c
> index 11c02b1..a5fe130 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -13211,6 +13211,8 @@ struct i40e_customized_pctype*
> return -EINVAL;
> if (!in->key && in->key_len)
> return -EINVAL;
> + if (&out->conf =3D=3D in)
> + return 0;
> out->conf =3D (struct rte_flow_action_rss){
> .func =3D in->func,
> .level =3D in->level,
> --
> 1.8.3.1